Homestyx hydra
Diffusion hydra 4da88848bed8

Fix exception accessing a non-existing EditEngine

Description

Fix exception accessing a non-existing EditEngine

Summary:
Trying to access a non-existing edit engine "foo" via the URI /transactions/editengine/foo/ throws an unhandled exception.
PhabricatorEditEngine::getByKey($viewer, $engine_key) is null as $engine_key is non-existing foo.
Thus avoid calling setViewer() on null by splitting into a separate step after a null check.
When null, show a proper 404 error instead.

EXCEPTION: (Error) Call to a member function setViewer() on null at [<phorge>/src/applications/transactions/controller/PhabricatorEditEngineConfigurationListController.php:17]

Closes T15793

Test Plan:
While logged in and with sufficient permissions,

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15793

Differential Revision: https://we.phorge.it/D25597

Details

Provenance
Andre KlapperAuthored on Apr 19 2024, 6:57 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:93c7444d5c7a: Fix PHP 8.1 "strlen(null)" exception mass-editing tasks when custom Date field…
Branches
Unknown
Tags
Unknown

Event Timeline