Homestyx hydra
Diffusion hydra 488960ae7a80

Fix PHP 8.1 "strlen(null)" exception in PhabricatorStandardCustomFieldLink.php

Description

Fix PHP 8.1 "strlen(null)" exception in PhabricatorStandardCustomFieldLink.php

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15807

Test Plan: Unknown. Given that $value is later used to construct a phutil_tag I assume that it should be a string and not a scalar.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15807

Differential Revision: https://we.phorge.it/D25610

Details

Provenance
Andre KlapperAuthored on May 1 2024, 11:39 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:fbe07fbeefca: Convert "Page Size" field in Maniphest Advanced Search to…
Branches
Unknown
Tags
Unknown

Event Timeline