Homestyx hydra
Diffusion hydra 4139305f73f0

Mark `renderActionDescription` as abstract

Description

Mark renderActionDescription as abstract

Summary:
I got caught by this... my custom Herald action doesn't implement this method and now I am hitting this exception:

Call to undefined method HeraldHipChatNotificationAction::renderActionDescription()

/usr/src/phabricator/src/applications/herald/adapter/HeraldAdapter.php:896

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13779

Details

Provenance
Joshua SpenceAuthored on Aug 3 2015, 6:26 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:5f76c71d781c: Share target filtering code in HeraldAction
Branches
Unknown
Tags
Unknown

Event Timeline