Homestyx hydra
Diffusion hydra 412c01ffa6fb

Fix PHP 8.1 "strlen(null)" exception for "/bin/auth cache-pkcs8" without…

Description

Fix PHP 8.1 "strlen(null)" exception for "/bin/auth cache-pkcs8" without parameter

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

This patch also fixes another similar strlen() occurrence in the same source file.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/auth/management/PhabricatorAuthManagementCachePKCS8Workflow.php:35]

Test Plan: Run ../phorge/bin/auth cache-pkcs8: Get no strlen() error anymore but only expected output Usage Exception: You must specify the path to a public keyfile with --public.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25587

Details

Provenance
Andre KlapperAuthored on Apr 17 2024, 7:08 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:0e53f91c9701: Fix PHP 8.1 "strlen(null)" exception for "/bin/herald test" without parameter
Branches
Unknown
Tags
Unknown

Event Timeline