Homestyx hydra
Diffusion hydra 3f8846d80c53

Fix PHP 8.1 "strlen(null)" exception on Diffusion repository History page after…

Description

Fix PHP 8.1 "strlen(null)" exception on Diffusion repository History page after setting Callsign

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=97e163187418), phorge(head=diffusionCallsignHistory, ref.master=9b99123ff931, ref.diffusionCallsignHistory=9b99123ff931)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php:28]

Closes T15465

Test Plan: After applying this change, /diffusion/XYZ/manage/history/ renders correctly and shows user set the callsign for this repository to XYZ.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15465

Differential Revision: https://we.phorge.it/D25289

Details

Provenance
Andre KlapperAuthored on Jun 12 2023, 3:47 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:1060736e895b: Fix some icons not displayed on UIExamples' "Icons and Images"…
Branches
Unknown
Tags
Unknown

Event Timeline