Homestyx hydra
Diffusion hydra 3544620209cf

Parse unusual Subversion protocol frames which contain extra whitespace

Description

Parse unusual Subversion protocol frames which contain extra whitespace

Summary:
Fixes T13140. See PHI660.

Recent versions of Subversion can send a (get-file true false false ) protocol frame with extra space between "false" and "false". This is allowed by the protocol spec, but never normally happens, and we do not parse it correctly.

Instead, parse it correctly.

Test Plan:

  • Added unit tests.
  • Ran svn proplist svn+ssh://.../diffusion/X/file.c under SVN 1.10 before and after the change.
    • Before: indefinite hang.
    • After: completed in finite time.

Reviewers: amckinley, asherkin

Reviewed By: amckinley, asherkin

Maniphest Tasks: T13140

Differential Revision: https://secure.phabricator.com/D19451

Details

Provenance
epriestleyAuthored on May 15 2018, 6:37 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:7aa12f192a6b: Add PhabricatorQueryIterator, for buffered iteration over a…
Branches
Unknown
Tags
Unknown

Event Timeline