Homestyx hydra
Diffusion hydra 313d3b7bf2ea

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Maniphest task…

Description

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Maniphest task creation page

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15302

Test Plan:
Applied these five changes (on top of D25144, D25145, D25146, D25147, D25151)
and /maniphest/task/edit/form/default/ finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15302

Differential Revision: https://we.phorge.it/D25152

Details

Provenance
Andre KlapperAuthored on May 1 2023, 9:51 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:bccd4f5981a7: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Dashboard page
Branches
Unknown
Tags
Unknown

Event Timeline