Homestyx hydra
Diffusion hydra 2d635fb76e9b

Dashboard Panel: fix first tab sometime not opened anymore

Description

Dashboard Panel: fix first tab sometime not opened anymore

Summary:
After this change the first Tab ID is always selected, so we don't risk
to have no tabs opened by default under some corner cases.

This is vaguely better than the original logic that relied on the fact that
(0=="0") is true. Besides being a vaguely weird emoticon as well, now that
I look at it better.

Original logic:

https://we.phorge.it/source/phorge/browse/master/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php;c43618a3a8bb021936fad687f04cb1a95faa23e4$289

This fixes a regression that appeared in the cute Wikimedia Phabricator
(that now is really Wikimedia Phorge). Their homepage should be gorgeous again,
without blank space due to unopened silly tabs.

Closes T15651

Test Plan:

  • Have a Tab Panel (/dashboard/panel/).
  • Be sure that the first Tab is automatically selected (again?)

Reviewers: aklapper, O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15651

Differential Revision: https://we.phorge.it/D25447

Details

Provenance
Valerio BozzolanAuthored on Oct 16 2023, 2:40 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:94aefaa31d4c: Replacing the deprecated -moz-outline-style with outline-style
Branches
Unknown
Tags
Unknown

Event Timeline