Homestyx hydra
Diffusion hydra 2abf292821a2

Fix an issue where editing paths in Owners packages could raise an error…

Description

Fix an issue where editing paths in Owners packages could raise an error: undefined index "display"

Summary:
Fixes T13464. Fully-realized paths have a "path" (normalized, effective path) and a "display" path (user-facing, un-normalized path).

During transaction validation we build ref keys for paths before we normalize the "display" values. A few different approaches could be taken to resolve this, but just default the "display" path to the raw "path" if it isn't present since that seems simplest.

Test Plan: Edited paths in an Owners package, no longer saw a warning in the logs.

Maniphest Tasks: T13464

Differential Revision: https://secure.phabricator.com/D20923

Details

Provenance
epriestleyAuthored on Nov 21 2019, 2:22 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:374f8b10b3cf: Add a "--dry-run" flag to "bin/repository rebuild-identities"
Branches
Unknown
Tags
Unknown

Event Timeline