Homestyx hydra
Diffusion hydra 29948eaa5bd2

Use phutil_hashes_are_identical() when comparing hashes in Phabricator

Description

Use phutil_hashes_are_identical() when comparing hashes in Phabricator

Summary: See D14025. In all cases where we compare hashes, use strict, constant-time comparisons.

Test Plan: Logged in, logged out, added TOTP, ran Conduit, terminated sessions, submitted forms, changed password. Tweaked CSRF token, got rejected.

Reviewers: chad

Reviewed By: chad

Subscribers: chenxiruanhai

Differential Revision: https://secure.phabricator.com/D14026

Details

Provenance
epriestleyAuthored on Sep 1 2015, 6:52 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:13516cf35f03: Fix an issue with "packages(...)" in typeaheads
Branches
Unknown
Tags
Unknown

Event Timeline