Homestyx hydra
Diffusion hydra 255325bd046b

Fix PHP 8.1 "strlen(null)" exception which blocks rendering user's Edit Profile…

Description

Fix PHP 8.1 "strlen(null)" exception which blocks rendering user's Edit Profile page

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15319

Test Plan:
Applied this change (on top of D25147, D25153, D25167) and
/people/editprofile/userid/ finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15319

Differential Revision: https://we.phorge.it/D25168

Details

Provenance
Andre KlapperAuthored on May 1 2023, 4:05 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:9aa8d09d3138: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page of…
Branches
Unknown
Tags
Unknown

Event Timeline