Don't leave temporary files around when trying to use credentials with…
241cfc2e8312
Actions

Description

Don't leave temporary files around when trying to use credentials with destroyed secrets

Summary: Ref T4284. This fixes at least one problem which can cause the observed behavior.

Test Plan:

Before applying patch, used PHABRICATOR_CREDENTIAL=PHID-CDTL-... bin/ssh-connect + debugging prints to verify the keyfile was written and cleaned up normally.
Destroyed the credental, verified the temporary file was not cleand up correctly.
Applied patch, verified temporary file was not written and command exited with sensible error.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4284

Provenance

epriestley	Authored on Aug 21 2014, 2:26 PM
sirocyl	Pushed on Oct 16 2024, 5:49 AM

Parents

R1:7d31ea7c55ea: Minor tweaks to `bin/mail send-test`

Branches

Unknown

Tags

Unknown

Path

Size

src/

applications/

passphrase/

keys/