Homestyx hydra
Diffusion hydra 222a6fea0a1d

Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo…

Description

Fix PHP 8.1 "strlen(null)" exception on Diffusion repo URIs page after repo creation

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/repository/storage/PhabricatorRepository.php:348]

Closes T15658

Test Plan: Create an empty new Git repository, go to its URIs management page.

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15658

Differential Revision: https://we.phorge.it/D25454

Details

Provenance
Andre KlapperAuthored on Nov 4 2023, 2:34 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:d4b110af260c: Remove unused variable $info in DiffusionCloneController.php
Branches
Unknown
Tags
Unknown

Event Timeline