Homestyx hydra
Diffusion hydra 2188473fa772

Fix an issue where we may "min()" an empty array when viewing a revision with…

Description

Fix an issue where we may "min()" an empty array when viewing a revision with no changesets

Summary:
Ref T13667. When a revision's diff has no changesets (usually because Diffusion performed an automatic update with an empty commit), the UI currently tries to "min()" an empty array and fatals.

Handle this case properly.

Test Plan:

  • Created a revision with a diff with no changesets ("git commit --allow-empty" + copy-paste into web UI).
  • Viewed revision.
    • Before: "min()" fatal.
    • After: UI isn't perfect, but works without fataling.

Subscribers: cspeckmim

Maniphest Tasks: T13667

Differential Revision: https://secure.phabricator.com/D21760

Details

Provenance
epriestleyAuthored on Apr 20 2022, 12:34 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:52df4ff515b7: Fix an issue where "git" may be unable to read a temporary file in Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline