Homestyx hydra
Diffusion hydra 19e0abcb27b4

Fix an issue where raw diffs that are not attached to revisions could skip…

Description

Fix an issue where raw diffs that are not attached to revisions could skip repository policy checks

Summary:
See PHI1697. If a diff is not attached to a revision (for example, if it was created with "arc diff --only"), but is attached to a repository, it is supposed to be visible only to users who can see that repository.

It currently skips this extended policy check and may incorrectly be visible to too many users.

(Once a diff is attached to a revision, this rule is enforced properly via the revision policy.)

Test Plan:

  • Set repository R to be visible only to Alice.
  • As Alice, created a diff from a working copy of repository R with "arc diff --only".
  • As Bailey, viewed the diff.
    • Before: visible diff.
    • After: policy exception (as expected).

Differential Revision: https://secure.phabricator.com/D21103

Details

Provenance
epriestleyAuthored on Apr 13 2020, 2:58 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:5597f4e6f229: Add "uri" to the fields returned by "differential.revision.search"
Branches
Unknown
Tags
Unknown

Event Timeline