Homestyx hydra
Diffusion hydra 186768ccfd88

Fix PHP 8.1 "strlen(null)" exception when received email lacks From header

Description

Fix PHP 8.1 "strlen(null)" exception when received email lacks From header

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php:527]

Closes T15767

Test Plan: See T15767

Reviewers: O1 Blessed Committers, avivey

Reviewed By: O1 Blessed Committers, avivey

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15767

Differential Revision: https://we.phorge.it/D25564

Details

Provenance
Andre KlapperAuthored on Mar 31 2024, 7:54 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:5263d5d59030: Custom integer fields: fix search by array of possible values
Branches
Unknown
Tags
Unknown

Event Timeline