Homestyx hydra
Diffusion hydra 0d5379ee1778

Fix an export bug where queries specified in the URI ("?param=value") were…

Description

Fix an export bug where queries specified in the URI ("?param=value") were ignored when filtering the result set

Summary:
Depends on D18968. Ref T13049. Currently, if you visit /query/?param=value, there is no queryKey for the page but we build a query later on.

Right now, we incorrectly link to /query/all/export/ in this case (and export too many results), but we should actually link to /query/<constructed query key>/export/ to export only the desired/previewed results.

Swap the logic around a little bit so we look at the query we're actually executing, not the original URI, to figure out the query key we should use when building the link.

Test Plan: Visited a /?param=value page, exported data, got a subset of the full data instead of everything.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13049

Differential Revision: https://secure.phabricator.com/D18969

Details

Provenance
epriestleyAuthored on Jan 30 2018, 11:03 AM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:5b22412f246e: Support data export on push logs
Branches
Unknown
Tags
Unknown

Event Timeline