Homestyx hydra
Diffusion hydra 0b93685cc999

Fix undefined variable in HeraldAction

Description

Fix undefined variable in HeraldAction

Summary: $no_permission is only defined within if ($object instanceof PhabricatorPolicyInterface), thus move the check for if ($no_permission) into that clause.

Test Plan: Read the code.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25741

Details

Provenance
Andre KlapperAuthored on Jul 24 2024, 11:47 AM
sirocylPushed on Wed, Oct 16, 5:49 AM
Parents
R1:a039c4952f6b: Remove call to undefined method DoorkeeperDAO::getObjectKey()
Branches
Unknown
Tags
Unknown

Event Timeline