Homestyx hydra
Diffusion hydra 064424c1b755

Add getQueryApplicationClass() to *TransactionQuery.php classes

Description

Add getQueryApplicationClass() to *TransactionQuery.php classes

Summary:
Add getQueryApplicationClass() to all *TransactionQuery.php classes similar to other *Query.php classes having the same function, and make the parent function in PhabricatorApplicationTransactionQuery.php abstract.

In the future, this will enable excluding transaction query results based on their underlying application (for example if an application has been uninstalled) to mitigate the problem of overheated search results. See https://we.phorge.it/T15642 for context.

The only callers of getQueryApplicationClass() are in src/infrastructure/query/policy/PhabricatorPolicyAwareQuery.php and src/applications/policy/__tests__/PhabricatorPolicyTestCase.php.

See T15642

Test Plan:
Patch changes only one existing code place, thus check if related pages still work as expected:

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15642

Differential Revision: https://we.phorge.it/D25500

Details

Provenance
Andre KlapperAuthored on Dec 25 2023, 3:28 PM
sirocylPushed on Oct 16 2024, 5:49 AM
Parents
R1:87db48289705: Adds "Locate File" input to every browse directory view in Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline