No OneTemporary
Actions

Size

6 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/search/engine/PhabricatorJumpNavHandler.php b/src/applications/search/engine/PhabricatorJumpNavHandler.php
	index e965620d1c..53e92b6e58 100644
	--- a/src/applications/search/engine/PhabricatorJumpNavHandler.php
	+++ b/src/applications/search/engine/PhabricatorJumpNavHandler.php
	@@ -1,128 +1,122 @@
	<?php

	final class PhabricatorJumpNavHandler {

	public static function getJumpResponse(PhabricatorUser $viewer, $jump) {
	$jump = trim($jump);
	- $help_href = PhabricatorEnv::getDocLink('Jump Nav User Guide');

	$patterns = array(
	- '/^help/i' => 'exturi:'.$help_href,
	- '/^a$/i' => 'uri:/audit/',
	- '/^f$/i' => 'uri:/feed/',
	- '/^d$/i' => 'uri:/differential/',
	- '/^r$/i' => 'uri:/diffusion/',
	- '/^t$/i' => 'uri:/maniphest/',
	- '/^p$/i' => 'uri:/project/',
	- '/^u$/i' => 'uri:/people/',
	- '/^p\s+(.+)$/i' => 'project',
	- '/^u\s+(\S+)$/i' => 'user',
	- '/^task:\s*(.+)/i' => 'create-task',
	- '/^(?:s\|symbol)\s+(\S+)/i' => 'find-symbol',
	- '/^r\s+(.+)$/i' => 'find-repository',
	+ '/^a$/i' => 'uri:/audit/',
	+ '/^f$/i' => 'uri:/feed/',
	+ '/^d$/i' => 'uri:/differential/',
	+ '/^r$/i' => 'uri:/diffusion/',
	+ '/^t$/i' => 'uri:/maniphest/',
	+ '/^p$/i' => 'uri:/project/',
	+ '/^u$/i' => 'uri:/people/',
	+ '/^p\s+(.+)$/i' => 'project',
	+ '/^u\s+(\S+)$/i' => 'user',
	+ '/^task:\s*(.+)/i' => 'create-task',
	+ '/^(?:s)\s+(\S+)/i' => 'find-symbol',
	+ '/^r\s+(.+)$/i' => 'find-repository',
	);

	foreach ($patterns as $pattern => $effect) {
	$matches = null;
	if (preg_match($pattern, $jump, $matches)) {
	if (!strncmp($effect, 'uri:', 4)) {
	return id(new AphrontRedirectResponse())
	->setURI(substr($effect, 4));
	- } else if (!strncmp($effect, 'exturi:', 7)) {
	- return id(new AphrontRedirectResponse())
	- ->setURI(substr($effect, 7))
	- ->setIsExternal(true);
	} else {
	switch ($effect) {
	case 'user':
	return id(new AphrontRedirectResponse())
	->setURI('/p/'.$matches[1].'/');
	case 'project':
	$project = self::findCloselyNamedProject($matches[1]);
	if ($project) {
	return id(new AphrontRedirectResponse())
	->setURI('/project/view/'.$project->getID().'/');
	} else {
	$jump = $matches[1];
	}
	break;
	case 'find-symbol':
	$context = '';
	$symbol = $matches[1];
	$parts = array();
	if (preg_match('/(.)(?:\\.\|::\|->)(.)/', $symbol, $parts)) {
	$context = '&context='.phutil_escape_uri($parts[1]);
	$symbol = $parts[2];
	}
	return id(new AphrontRedirectResponse())
	->setURI("/diffusion/symbol/$symbol/?jump=true$context");
	case 'find-repository':
	$name = $matches[1];
	$repositories = id(new PhabricatorRepositoryQuery())
	->setViewer($viewer)
	->withNameContains($name)
	->execute();
	if (count($repositories) == 1) {
	// Just one match, jump to repository.
	$uri = '/diffusion/'.head($repositories)->getCallsign().'/';
	} else {
	// More than one match, jump to search.
	$uri = urisprintf('/diffusion/?order=name&name=%s', $name);
	}
	return id(new AphrontRedirectResponse())->setURI($uri);
	case 'create-task':
	return id(new AphrontRedirectResponse())
	->setURI('/maniphest/task/create/?title='
	.phutil_escape_uri($matches[1]));
	default:
	throw new Exception("Unknown jump effect '{$effect}'!");
	}
	}
	}
	}

	// If none of the patterns matched, look for an object by name.
	$objects = id(new PhabricatorObjectQuery())
	->setViewer($viewer)
	->withNames(array($jump))
	->execute();

	if (count($objects) == 1) {
	$handle = id(new PhabricatorHandleQuery())
	->setViewer($viewer)
	->withPHIDs(mpull($objects, 'getPHID'))
	->executeOne();

	return id(new AphrontRedirectResponse())->setURI($handle->getURI());
	}

	return null;
	}

	private static function findCloselyNamedProject($name) {
	$project = id(new PhabricatorProject())->loadOneWhere(
	'name = %s',
	$name);
	if ($project) {
	return $project;
	} else { // no exact match, try a fuzzy match
	$projects = id(new PhabricatorProject())->loadAllWhere(
	'name LIKE %~',
	$name);
	if ($projects) {
	$min_name_length = PHP_INT_MAX;
	$best_project = null;
	foreach ($projects as $project) {
	$name_length = strlen($project->getName());
	if ($name_length <= $min_name_length) {
	$min_name_length = $name_length;
	$best_project = $project;
	}
	}
	return $best_project;
	} else {
	return null;
	}
	}
	}
	}
	diff --git a/src/docs/user/userguide/jump.diviner b/src/docs/user/userguide/jump.diviner
	index f4ae81ecdf..705aa3a457 100644
	--- a/src/docs/user/userguide/jump.diviner
	+++ b/src/docs/user/userguide/jump.diviner
	@@ -1,28 +1,27 @@
	@title Jump Nav User Guide
	@group userguide

	Command reference for the jump nav.

	= Overview =

	The jump nav provides a quick way to navigate to tools and objects: just type
	a navigational command into the box and press return.

	= Supported Commands =

	- - help - Jump to this document.
	- T - Jump to Maniphest.
	- T123 - Jump to Maniphest Task 123.
	- D - Jump to Differential.
	- D123 - Jump to Differential Revision 123.
	- r - Jump to Diffusion.
	- rXYZ - Jump to Diffusion Repository XYZ.
	- rXYZabcdef - Jump to Diffusion Commit rXYZabcdef.
	- r <name> - Search for repositories by name.
	- u - Jump to People
	- u username - Jump to username's Profile
	- p - Jump to Project
	- p Some Project - Jump to Project: Some Project
	- s SymbolName - Jump to Symbol SymbolName
	- task: (new title) - Jumps to Task Creation Page with pre-filled title.
	- (default) - Search for input.

File Metadata

Mime Type: text/x-diff
Expires: Fri, Feb 7, 12:56 AM (1 d, 17 h)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 34049
Default Alt Text: (6 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions