No OneTemporary
Actions

Size

75 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php
	index fa6ce29a98..b2cdd3df61 100644
	--- a/src/applications/base/controller/PhabricatorController.php
	+++ b/src/applications/base/controller/PhabricatorController.php
	@@ -1,314 +1,325 @@
	<?php

	abstract class PhabricatorController extends AphrontController {

	private $handles;

	public function shouldRequireLogin() {

	// If this install is configured to allow public resources and the
	// controller works in public mode, allow the request through.
	$is_public_allowed = PhabricatorEnv::getEnvConfig('policy.allow-public');
	if ($is_public_allowed && $this->shouldAllowPublic()) {
	return false;
	}

	return true;
	}

	public function shouldRequireAdmin() {
	return false;
	}

	public function shouldRequireEnabledUser() {
	return true;
	}

	public function shouldAllowPublic() {
	return false;
	}

	public function shouldRequireEmailVerification() {
	$need_verify = PhabricatorUserEmail::isEmailVerificationRequired();
	$need_login = $this->shouldRequireLogin();

	return ($need_login && $need_verify);
	}

	final public function willBeginExecution() {

	$request = $this->getRequest();

	$user = new PhabricatorUser();

	$phusr = $request->getCookie('phusr');
	$phsid = $request->getCookie('phsid');

	if (strlen($phusr) && $phsid) {
	$info = queryfx_one(
	$user->establishConnection('r'),
	'SELECT u.* FROM %T u JOIN %T s ON u.phid = s.userPHID
	AND s.type LIKE %> AND s.sessionKey = %s',
	$user->getTableName(),
	'phabricator_session',
	'web-',
	$phsid);
	if ($info) {
	$user->loadFromArray($info);
	}
	}

	$translation = $user->getTranslation();
	if ($translation &&
	$translation != PhabricatorEnv::getEnvConfig('translation.provider')) {
	$translation = newv($translation, array());
	PhutilTranslator::getInstance()
	->setLanguage($translation->getLanguage())
	->addTranslations($translation->getTranslations());
	}

	$request->setUser($user);

	if ($user->getIsDisabled() && $this->shouldRequireEnabledUser()) {
	$disabled_user_controller = new PhabricatorDisabledUserController(
	$request);
	return $this->delegateToController($disabled_user_controller);
	}

	$event = new PhabricatorEvent(
	PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST,
	array(
	'request' => $request,
	'controller' => $this,
	));
	$event->setUser($user);
	PhutilEventEngine::dispatchEvent($event);
	$checker_controller = $event->getValue('controller');
	if ($checker_controller != $this) {
	return $this->delegateToController($checker_controller);
	}

	$preferences = $user->loadPreferences();

	if (PhabricatorEnv::getEnvConfig('darkconsole.enabled')) {
	$dark_console = PhabricatorUserPreferences::PREFERENCE_DARK_CONSOLE;
	if ($preferences->getPreference($dark_console) \|\|
	PhabricatorEnv::getEnvConfig('darkconsole.always-on')) {
	$console = new DarkConsoleCore();
	$request->getApplicationConfiguration()->setConsole($console);
	}
	}

	if ($this->shouldRequireLogin() && !$user->getPHID()) {
	$login_controller = new PhabricatorLoginController($request);
	return $this->delegateToController($login_controller);
	}

	if ($this->shouldRequireEmailVerification()) {
	$email = $user->loadPrimaryEmail();
	if (!$email) {
	throw new Exception(
	"No primary email address associated with this account!");
	}
	if (!$email->getIsVerified()) {
	$verify_controller = new PhabricatorMustVerifyEmailController($request);
	return $this->delegateToController($verify_controller);
	}
	}

	if ($this->shouldRequireAdmin() && !$user->getIsAdmin()) {
	return new Aphront403Response();
	}

	}

	public function buildStandardPageView() {
	$view = new PhabricatorStandardPageView();
	$view->setRequest($this->getRequest());
	$view->setController($this);
	return $view;
	}

	public function buildStandardPageResponse($view, array $data) {
	$page = $this->buildStandardPageView();
	$page->appendChild($view);
	$response = new AphrontWebpageResponse();
	$response->setContent($page->render());
	return $response;
	}

	public function getApplicationURI($path = '') {
	if (!$this->getCurrentApplication()) {
	throw new Exception("No application!");
	}
	return $this->getCurrentApplication()->getBaseURI().ltrim($path, '/');
	}

	public function buildApplicationPage($view, array $options) {
	$page = $this->buildStandardPageView();

	$title = PhabricatorEnv::getEnvConfig('phabricator.serious-business') ?
	'Phabricator' :
	pht('Bacon Ice Cream for Breakfast');

	$application = $this->getCurrentApplication();
	$page->setTitle(idx($options, 'title', $title));
	if ($application) {
	$page->setApplicationName($application->getName());
	if ($application->getTitleGlyph()) {
	$page->setGlyph($application->getTitleGlyph());
	}
	}

	if (!($view instanceof AphrontSideNavFilterView)) {
	$nav = new AphrontSideNavFilterView();
	$nav->appendChild($view);
	$view = $nav;
	}

	- $view->setUser($this->getRequest()->getUser());
	+ $user = $this->getRequest()->getUser();
	+ $view->setUser($user);

	$page->appendChild($view);

	+ $object_phids = idx($options, 'pageObjects', array());
	+ if ($object_phids) {
	+ $page->appendPageObjects($object_phids);
	+ foreach ($object_phids as $object_phid) {
	+ PhabricatorFeedStoryNotification::updateObjectNotificationViews(
	+ $user,
	+ $object_phid);
	+ }
	+ }
	+
	if (idx($options, 'device')) {
	$page->setDeviceReady(true);
	}

	$page->setShowChrome(idx($options, 'chrome', true));
	$page->setDust(idx($options, 'dust', false));

	$application_menu = $this->buildApplicationMenu();
	if ($application_menu) {
	$page->setApplicationMenu($application_menu);
	}

	$response = new AphrontWebpageResponse();
	return $response->setContent($page->render());
	}

	public function didProcessRequest($response) {
	$request = $this->getRequest();
	$response->setRequest($request);

	$seen = array();
	while ($response instanceof AphrontProxyResponse) {

	$hash = spl_object_hash($response);
	if (isset($seen[$hash])) {
	$seen[] = get_class($response);
	throw new Exception(
	"Cycle while reducing proxy responses: ".
	implode(' -> ', $seen));
	}
	$seen[$hash] = get_class($response);

	$response = $response->reduceProxyResponse();
	}

	if ($response instanceof AphrontDialogResponse) {
	if (!$request->isAjax()) {
	$view = new PhabricatorStandardPageView();
	$view->setRequest($request);
	$view->setController($this);
	$view->appendChild(hsprintf(
	'<div style="padding: 2em 0;">%s</div>',
	$response->buildResponseString()));
	$response = new AphrontWebpageResponse();
	$response->setContent($view->render());
	return $response;
	} else {
	return id(new AphrontAjaxResponse())
	->setContent(array(
	'dialog' => $response->buildResponseString(),
	));
	}
	} else if ($response instanceof AphrontRedirectResponse) {
	if ($request->isAjax()) {
	return id(new AphrontAjaxResponse())
	->setContent(
	array(
	'redirect' => $response->getURI(),
	));
	}
	}
	return $response;
	}

	protected function getHandle($phid) {
	if (empty($this->handles[$phid])) {
	throw new Exception(
	"Attempting to access handle which wasn't loaded: {$phid}");
	}
	return $this->handles[$phid];
	}

	protected function loadHandles(array $phids) {
	$phids = array_filter($phids);
	$this->handles = $this->loadViewerHandles($phids);
	return $this;
	}

	protected function getLoadedHandles() {
	return $this->handles;
	}

	protected function loadViewerHandles(array $phids) {
	return id(new PhabricatorObjectHandleData($phids))
	->setViewer($this->getRequest()->getUser())
	->loadHandles();
	}


	/**
	* Render a list of links to handles, identified by PHIDs. The handles must
	* already be loaded.
	*
	* @param list<phid> List of PHIDs to render links to.
	* @param string Style, one of "\n" (to put each item on its own line)
	* or "," (to list items inline, separated by commas).
	* @return string Rendered list of handle links.
	*/
	protected function renderHandlesForPHIDs(array $phids, $style = "\n") {
	$style_map = array(
	"\n" => phutil_tag('br'),
	',' => ', ',
	);

	if (empty($style_map[$style])) {
	throw new Exception("Unknown handle list style '{$style}'!");
	}

	return implode_selected_handle_links($style_map[$style],
	$this->getLoadedHandles(),
	$phids);
	}

	protected function buildApplicationMenu() {
	return null;
	}

	protected function buildApplicationCrumbs() {

	$crumbs = array();

	$application = $this->getCurrentApplication();
	if ($application) {
	$sprite = $application->getIconName();
	if (!$sprite) {
	$sprite = 'application';
	}

	$crumbs[] = id(new PhabricatorCrumbView())
	->setHref($this->getApplicationURI())
	->setIcon($sprite);
	}

	$view = new PhabricatorCrumbsView();
	foreach ($crumbs as $crumb) {
	$view->addCrumb($crumb);
	}

	return $view;
	}

	}
	diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
	index 841b494445..99a0f5e03c 100644
	--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
	+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
	@@ -1,977 +1,975 @@
	<?php

	final class DifferentialRevisionViewController extends DifferentialController {

	private $revisionID;

	public function shouldRequireLogin() {
	return !$this->allowsAnonymousAccess();
	}

	public function willProcessRequest(array $data) {
	$this->revisionID = $data['id'];
	}

	public function processRequest() {

	$request = $this->getRequest();
	$user = $request->getUser();
	$viewer_is_anonymous = !$user->isLoggedIn();

	$revision = id(new DifferentialRevision())->load($this->revisionID);
	if (!$revision) {
	return new Aphront404Response();
	}

	$revision->loadRelationships();

	$diffs = $revision->loadDiffs();

	if (!$diffs) {
	throw new Exception(
	"This revision has no diffs. Something has gone quite wrong.");
	}

	$diff_vs = $request->getInt('vs');

	$target_id = $request->getInt('id');
	$target = idx($diffs, $target_id, end($diffs));

	$target_manual = $target;
	if (!$target_id) {
	foreach ($diffs as $diff) {
	if ($diff->getCreationMethod() != 'commit') {
	$target_manual = $diff;
	}
	}
	}

	if (empty($diffs[$diff_vs])) {
	$diff_vs = null;
	}

	$arc_project = $target->loadArcanistProject();
	$repository = ($arc_project ? $arc_project->loadRepository() : null);

	list($changesets, $vs_map, $vs_changesets, $rendering_references) =
	$this->loadChangesetsAndVsMap(
	$target,
	idx($diffs, $diff_vs),
	$repository);

	if ($request->getExists('download')) {
	return $this->buildRawDiffResponse(
	$changesets,
	$vs_changesets,
	$vs_map,
	$repository);
	}

	$props = id(new DifferentialDiffProperty())->loadAllWhere(
	'diffID = %d',
	$target_manual->getID());
	$props = mpull($props, 'getData', 'getName');

	$aux_fields = $this->loadAuxiliaryFields($revision);

	$comments = $revision->loadComments();
	$comments = array_merge(
	$this->getImplicitComments($revision, reset($diffs)),
	$comments);

	$all_changesets = $changesets;
	$inlines = $this->loadInlineComments($comments, $all_changesets);

	$object_phids = array_merge(
	$revision->getReviewers(),
	$revision->getCCPHIDs(),
	$revision->loadCommitPHIDs(),
	array(
	$revision->getAuthorPHID(),
	$user->getPHID(),
	),
	mpull($comments, 'getAuthorPHID'));

	foreach ($comments as $comment) {
	$metadata = $comment->getMetadata();
	$added_reviewers = idx(
	$metadata,
	DifferentialComment::METADATA_ADDED_REVIEWERS);
	if ($added_reviewers) {
	foreach ($added_reviewers as $phid) {
	$object_phids[] = $phid;
	}
	}
	$added_ccs = idx(
	$metadata,
	DifferentialComment::METADATA_ADDED_CCS);
	if ($added_ccs) {
	foreach ($added_ccs as $phid) {
	$object_phids[] = $phid;
	}
	}
	}

	foreach ($revision->getAttached() as $type => $phids) {
	foreach ($phids as $phid => $info) {
	$object_phids[] = $phid;
	}
	}

	$aux_phids = array();
	foreach ($aux_fields as $key => $aux_field) {
	$aux_field->setDiff($target);
	$aux_field->setManualDiff($target_manual);
	$aux_field->setDiffProperties($props);
	$aux_phids[$key] = $aux_field->getRequiredHandlePHIDsForRevisionView();
	}
	$object_phids = array_merge($object_phids, array_mergev($aux_phids));
	$object_phids = array_unique($object_phids);

	$handles = $this->loadViewerHandles($object_phids);

	foreach ($aux_fields as $key => $aux_field) {
	// Make sure each field only has access to handles it specifically
	// requested, not all handles. Otherwise you can get a field which works
	// only in the presence of other fields.
	$aux_field->setHandles(array_select_keys($handles, $aux_phids[$key]));
	}

	$reviewer_warning = null;
	if ($revision->getStatus() ==
	ArcanistDifferentialRevisionStatus::NEEDS_REVIEW) {
	$has_live_reviewer = false;
	foreach ($revision->getReviewers() as $reviewer) {
	if (!$handles[$reviewer]->isDisabled()) {
	$has_live_reviewer = true;
	break;
	}
	}
	if (!$has_live_reviewer) {
	$reviewer_warning = new AphrontErrorView();
	$reviewer_warning->setSeverity(AphrontErrorView::SEVERITY_WARNING);
	$reviewer_warning->setTitle(pht('No Active Reviewers'));
	if ($revision->getReviewers()) {
	$reviewer_warning->appendChild(
	phutil_tag(
	'p',
	array(),
	pht('All specified reviewers are disabled and this revision '.
	'needs review. You may want to add some new reviewers.')));
	} else {
	$reviewer_warning->appendChild(
	phutil_tag(
	'p',
	array(),
	pht('This revision has no specified reviewers and needs '.
	'review. You may want to add some reviewers.')));
	}
	}
	}

	$request_uri = $request->getRequestURI();

	$limit = 100;
	$large = $request->getStr('large');
	if (count($changesets) > $limit && !$large) {
	$count = count($changesets);
	$warning = new AphrontErrorView();
	$warning->setTitle('Very Large Diff');
	$warning->setSeverity(AphrontErrorView::SEVERITY_WARNING);
	$warning->appendChild(hsprintf(
	'%s <strong>%s</strong>',
	pht(
	'This diff is very large and affects %s files. Load each file '.
	'individually.',
	new PhutilNumber($count)),
	phutil_tag(
	'a',
	array(
	'href' => $request_uri
	->alter('large', 'true')
	->setFragment('toc'),
	),
	pht('Show All Files Inline'))));
	$warning = $warning->render();

	$my_inlines = id(new DifferentialInlineComment())->loadAllWhere(
	'revisionID = %d AND commentID IS NULL AND authorPHID = %s AND '.
	'changesetID IN (%Ld)',
	$this->revisionID,
	$user->getPHID(),
	mpull($changesets, 'getID'));

	$visible_changesets = array();
	foreach ($inlines + $my_inlines as $inline) {
	$changeset_id = $inline->getChangesetID();
	if (isset($changesets[$changeset_id])) {
	$visible_changesets[$changeset_id] = $changesets[$changeset_id];
	}
	}

	if (!empty($props['arc:lint'])) {
	$changeset_paths = mpull($changesets, null, 'getFilename');
	foreach ($props['arc:lint'] as $lint) {
	$changeset = idx($changeset_paths, $lint['path']);
	if ($changeset) {
	$visible_changesets[$changeset->getID()] = $changeset;
	}
	}
	}

	} else {
	$warning = null;
	$visible_changesets = $changesets;
	}

	$revision_detail = new DifferentialRevisionDetailView();
	$revision_detail->setRevision($revision);
	$revision_detail->setDiff(end($diffs));
	$revision_detail->setAuxiliaryFields($aux_fields);

	$actions = $this->getRevisionActions($revision);

	$custom_renderer_class = PhabricatorEnv::getEnvConfig(
	'differential.revision-custom-detail-renderer');
	if ($custom_renderer_class) {

	// TODO: build a better version of the action links and deprecate the
	// whole DifferentialRevisionDetailRenderer class.
	$custom_renderer = newv($custom_renderer_class, array());
	$custom_renderer->setUser($user);
	$custom_renderer->setDiff($target);
	if ($diff_vs) {
	$custom_renderer->setVSDiff($diffs[$diff_vs]);
	}
	$actions = array_merge(
	$actions,
	$custom_renderer->generateActionLinks($revision, $target_manual));
	}

	$whitespace = $request->getStr(
	'whitespace',
	DifferentialChangesetParser::WHITESPACE_IGNORE_ALL);

	if ($arc_project) {
	list($symbol_indexes, $project_phids) = $this->buildSymbolIndexes(
	$arc_project,
	$visible_changesets);
	} else {
	$symbol_indexes = array();
	$project_phids = null;
	}

	$revision_detail->setActions($actions);
	$revision_detail->setUser($user);

	$comment_view = new DifferentialRevisionCommentListView();
	$comment_view->setComments($comments);
	$comment_view->setHandles($handles);
	$comment_view->setInlineComments($inlines);
	$comment_view->setChangesets($all_changesets);
	$comment_view->setUser($user);
	$comment_view->setTargetDiff($target);
	$comment_view->setVersusDiffID($diff_vs);

	if ($arc_project) {
	Javelin::initBehavior(
	'repository-crossreference',
	array(
	'section' => $comment_view->getID(),
	'projects' => $project_phids,
	));
	}

	$changeset_view = new DifferentialChangesetListView();
	$changeset_view->setChangesets($changesets);
	$changeset_view->setVisibleChangesets($visible_changesets);

	if (!$viewer_is_anonymous) {
	$changeset_view->setInlineCommentControllerURI(
	'/differential/comment/inline/edit/'.$revision->getID().'/');
	}

	$changeset_view->setStandaloneURI('/differential/changeset/');
	$changeset_view->setRawFileURIs(
	'/differential/changeset/?view=old',
	'/differential/changeset/?view=new');

	$changeset_view->setUser($user);
	$changeset_view->setDiff($target);
	$changeset_view->setRenderingReferences($rendering_references);
	$changeset_view->setVsMap($vs_map);
	$changeset_view->setWhitespace($whitespace);
	if ($repository) {
	$changeset_view->setRepository($repository);
	}
	$changeset_view->setSymbolIndexes($symbol_indexes);
	$changeset_view->setTitle('Diff '.$target->getID());

	$diff_history = new DifferentialRevisionUpdateHistoryView();
	$diff_history->setDiffs($diffs);
	$diff_history->setSelectedVersusDiffID($diff_vs);
	$diff_history->setSelectedDiffID($target->getID());
	$diff_history->setSelectedWhitespace($whitespace);
	$diff_history->setUser($user);

	$local_view = new DifferentialLocalCommitsView();
	$local_view->setUser($user);
	$local_view->setLocalCommits(idx($props, 'local:commits'));

	if ($repository) {
	$other_revisions = $this->loadOtherRevisions(
	$changesets,
	$target,
	$repository);
	} else {
	$other_revisions = array();
	}

	$other_view = null;
	if ($other_revisions) {
	$other_view = $this->renderOtherRevisions($other_revisions);
	}

	$toc_view = new DifferentialDiffTableOfContentsView();
	$toc_view->setChangesets($changesets);
	$toc_view->setVisibleChangesets($visible_changesets);
	$toc_view->setRenderingReferences($rendering_references);
	$toc_view->setUnitTestData(idx($props, 'arc:unit', array()));
	if ($repository) {
	$toc_view->setRepository($repository);
	}
	$toc_view->setDiff($target);
	$toc_view->setUser($user);
	$toc_view->setRevisionID($revision->getID());
	$toc_view->setWhitespace($whitespace);

	$comment_form = null;
	if (!$viewer_is_anonymous) {
	$draft = id(new PhabricatorDraft())->loadOneWhere(
	'authorPHID = %s AND draftKey = %s',
	$user->getPHID(),
	'differential-comment-'.$revision->getID());

	$reviewers = array();
	$ccs = array();
	if ($draft) {
	$reviewers = idx($draft->getMetadata(), 'reviewers', array());
	$ccs = idx($draft->getMetadata(), 'ccs', array());
	if ($reviewers \|\| $ccs) {
	$handles = $this->loadViewerHandles(array_merge($reviewers, $ccs));
	$reviewers = array_select_keys($handles, $reviewers);
	$ccs = array_select_keys($handles, $ccs);
	}
	}

	$comment_form = new DifferentialAddCommentView();
	$comment_form->setRevision($revision);
	$comment_form->setAuxFields($aux_fields);
	$comment_form->setActions($this->getRevisionCommentActions($revision));
	$comment_form->setActionURI('/differential/comment/save/');
	$comment_form->setUser($user);
	$comment_form->setDraft($draft);
	$comment_form->setReviewers(mpull($reviewers, 'getFullName', 'getPHID'));
	$comment_form->setCCs(mpull($ccs, 'getFullName', 'getPHID'));
	}

	$pane_id = celerity_generate_unique_node_id();
	Javelin::initBehavior(
	'differential-keyboard-navigation',
	array(
	'haunt' => $pane_id,
	));
	Javelin::initBehavior('differential-user-select');

	$page_pane = id(new DifferentialPrimaryPaneView())
	->setID($pane_id)
	->appendChild(array(
	$comment_view->render(),
	$diff_history->render(),
	$warning,
	$local_view->render(),
	$toc_view->render(),
	$other_view,
	$changeset_view->render(),
	));
	if ($comment_form) {
	$page_pane->appendChild($comment_form->render());
	}

	- PhabricatorFeedStoryNotification::updateObjectNotificationViews(
	- $user, $revision->getPHID());
	-
	$object_id = 'D'.$revision->getID();

	$top_anchor = id(new PhabricatorAnchorView())
	->setAnchorName('top')
	->setNavigationMarker(true);

	$content = array(
	$reviewer_warning,
	$top_anchor,
	$revision_detail,
	$page_pane,
	);

	$crumbs = $this->buildApplicationCrumbs();
	$crumbs->addCrumb(
	id(new PhabricatorCrumbView())
	->setName($object_id)
	->setHref('/'.$object_id));

	$prefs = $user->loadPreferences();

	$pref_filetree = PhabricatorUserPreferences::PREFERENCE_DIFF_FILETREE;
	if ($prefs->getPreference($pref_filetree)) {
	$collapsed = $prefs->getPreference(
	PhabricatorUserPreferences::PREFERENCE_NAV_COLLAPSED,
	false);

	$nav = id(new DifferentialChangesetFileTreeSideNavBuilder())
	->setAnchorName('top')
	->setTitle('D'.$revision->getID())
	->setBaseURI(new PhutilURI('/D'.$revision->getID()))
	->setCollapsed((bool)$collapsed)
	->build($changesets);
	$nav->appendChild($content);
	$nav->setCrumbs($crumbs);
	$content = $nav;
	} else {
	array_unshift($content, $crumbs);
	}

	return $this->buildApplicationPage(
	$content,
	array(
	'title' => $object_id.' '.$revision->getTitle(),
	+ 'pageObjects' => array($revision->getPHID()),
	));
	}

	private function getImplicitComments(
	DifferentialRevision $revision,
	DifferentialDiff $diff) {

	$author_phid = nonempty(
	$diff->getAuthorPHID(),
	$revision->getAuthorPHID());

	$template = new DifferentialComment();
	$template->setAuthorPHID($author_phid);
	$template->setRevisionID($revision->getID());
	$template->setDateCreated($revision->getDateCreated());

	$comments = array();

	if (strlen($revision->getSummary())) {
	$summary_comment = clone $template;
	$summary_comment->setContent($revision->getSummary());
	$summary_comment->setAction(DifferentialAction::ACTION_SUMMARIZE);
	$comments[] = $summary_comment;
	}

	if (strlen($revision->getTestPlan())) {
	$testplan_comment = clone $template;
	$testplan_comment->setContent($revision->getTestPlan());
	$testplan_comment->setAction(DifferentialAction::ACTION_TESTPLAN);
	$comments[] = $testplan_comment;
	}

	return $comments;
	}

	private function getRevisionActions(DifferentialRevision $revision) {
	$user = $this->getRequest()->getUser();
	$viewer_phid = $user->getPHID();
	$viewer_is_owner = ($revision->getAuthorPHID() == $viewer_phid);
	$viewer_is_reviewer = in_array($viewer_phid, $revision->getReviewers());
	$viewer_is_cc = in_array($viewer_phid, $revision->getCCPHIDs());
	$viewer_is_anonymous = !$this->getRequest()->getUser()->isLoggedIn();
	$status = $revision->getStatus();
	$revision_id = $revision->getID();
	$revision_phid = $revision->getPHID();

	$links = array();

	if ($viewer_is_owner) {
	$links[] = array(
	'icon' => 'edit',
	'href' => "/differential/revision/edit/{$revision_id}/",
	'name' => pht('Edit Revision'),
	);
	}

	if (!$viewer_is_anonymous) {

	if (!$viewer_is_owner && !$viewer_is_reviewer) {
	$action = $viewer_is_cc ? 'rem' : 'add';
	$links[] = array(
	'icon' => $viewer_is_cc ? 'subscribe-delete' : 'subscribe-add',
	'href' => "/differential/subscribe/{$action}/{$revision_id}/",
	'name' => $viewer_is_cc ? pht('Unsubscribe') : pht('Subscribe'),
	'instant' => true,
	);
	} else {
	$links[] = array(
	'icon' => 'subscribe-auto',
	'name' => pht('Automatically Subscribed'),
	'disabled' => true,
	);
	}

	require_celerity_resource('phabricator-object-selector-css');
	require_celerity_resource('javelin-behavior-phabricator-object-selector');

	$links[] = array(
	'icon' => 'link',
	'name' => pht('Edit Dependencies'),
	'href' => "/search/attach/{$revision_phid}/DREV/dependencies/",
	'sigil' => 'workflow',
	);

	$maniphest = 'PhabricatorApplicationManiphest';
	if (PhabricatorApplication::isClassInstalled($maniphest)) {
	$links[] = array(
	'icon' => 'attach',
	'name' => pht('Edit Maniphest Tasks'),
	'href' => "/search/attach/{$revision_phid}/TASK/",
	'sigil' => 'workflow',
	);
	}
	}

	$request_uri = $this->getRequest()->getRequestURI();
	$links[] = array(
	'icon' => 'download',
	'name' => pht('Download Raw Diff'),
	'href' => $request_uri->alter('download', 'true')
	);

	return $links;
	}

	private function getRevisionCommentActions(DifferentialRevision $revision) {

	$actions = array(
	DifferentialAction::ACTION_COMMENT => true,
	);

	$viewer = $this->getRequest()->getUser();
	$viewer_phid = $viewer->getPHID();
	$viewer_is_owner = ($viewer_phid == $revision->getAuthorPHID());
	$viewer_is_reviewer = in_array($viewer_phid, $revision->getReviewers());
	$viewer_did_accept = ($viewer_phid === $revision->loadReviewedBy());
	$status = $revision->getStatus();

	$allow_self_accept = PhabricatorEnv::getEnvConfig(
	'differential.allow-self-accept');
	$always_allow_close = PhabricatorEnv::getEnvConfig(
	'differential.always-allow-close');
	$allow_reopen = PhabricatorEnv::getEnvConfig(
	'differential.allow-reopen');

	if ($viewer_is_owner) {
	switch ($status) {
	case ArcanistDifferentialRevisionStatus::NEEDS_REVIEW:
	$actions[DifferentialAction::ACTION_ACCEPT] = $allow_self_accept;
	$actions[DifferentialAction::ACTION_ABANDON] = true;
	$actions[DifferentialAction::ACTION_RETHINK] = true;
	break;
	case ArcanistDifferentialRevisionStatus::NEEDS_REVISION:
	$actions[DifferentialAction::ACTION_ACCEPT] = $allow_self_accept;
	$actions[DifferentialAction::ACTION_ABANDON] = true;
	$actions[DifferentialAction::ACTION_REQUEST] = true;
	break;
	case ArcanistDifferentialRevisionStatus::ACCEPTED:
	$actions[DifferentialAction::ACTION_ABANDON] = true;
	$actions[DifferentialAction::ACTION_REQUEST] = true;
	$actions[DifferentialAction::ACTION_RETHINK] = true;
	$actions[DifferentialAction::ACTION_CLOSE] = true;
	break;
	case ArcanistDifferentialRevisionStatus::CLOSED:
	break;
	case ArcanistDifferentialRevisionStatus::ABANDONED:
	$actions[DifferentialAction::ACTION_RECLAIM] = true;
	break;
	}
	} else {
	switch ($status) {
	case ArcanistDifferentialRevisionStatus::NEEDS_REVIEW:
	$actions[DifferentialAction::ACTION_ACCEPT] = true;
	$actions[DifferentialAction::ACTION_REJECT] = true;
	$actions[DifferentialAction::ACTION_RESIGN] = $viewer_is_reviewer;
	break;
	case ArcanistDifferentialRevisionStatus::NEEDS_REVISION:
	$actions[DifferentialAction::ACTION_ACCEPT] = true;
	$actions[DifferentialAction::ACTION_RESIGN] = $viewer_is_reviewer;
	break;
	case ArcanistDifferentialRevisionStatus::ACCEPTED:
	$actions[DifferentialAction::ACTION_REJECT] = true;
	$actions[DifferentialAction::ACTION_RESIGN] =
	$viewer_is_reviewer && !$viewer_did_accept;
	break;
	case ArcanistDifferentialRevisionStatus::CLOSED:
	case ArcanistDifferentialRevisionStatus::ABANDONED:
	break;
	}
	if ($status != ArcanistDifferentialRevisionStatus::CLOSED) {
	$actions[DifferentialAction::ACTION_CLAIM] = true;
	$actions[DifferentialAction::ACTION_CLOSE] = $always_allow_close;
	}
	}

	$actions[DifferentialAction::ACTION_ADDREVIEWERS] = true;
	$actions[DifferentialAction::ACTION_ADDCCS] = true;
	$actions[DifferentialAction::ACTION_REOPEN] = $allow_reopen &&
	($status == ArcanistDifferentialRevisionStatus::CLOSED);

	$actions = array_keys(array_filter($actions));
	$actions_dict = array();
	foreach ($actions as $action) {
	$actions_dict[$action] = DifferentialAction::getActionVerb($action);
	}

	return $actions_dict;
	}

	private function loadInlineComments(array $comments, array &$changesets) {
	assert_instances_of($comments, 'DifferentialComment');
	assert_instances_of($changesets, 'DifferentialChangeset');

	$inline_comments = array();

	$comment_ids = array_filter(mpull($comments, 'getID'));
	if (!$comment_ids) {
	return $inline_comments;
	}

	$inline_comments = id(new DifferentialInlineComment())
	->loadAllWhere(
	'commentID in (%Ld)',
	$comment_ids);

	$load_changesets = array();
	foreach ($inline_comments as $inline) {
	$changeset_id = $inline->getChangesetID();
	if (isset($changesets[$changeset_id])) {
	continue;
	}
	$load_changesets[$changeset_id] = true;
	}

	$more_changesets = array();
	if ($load_changesets) {
	$changeset_ids = array_keys($load_changesets);
	$more_changesets += id(new DifferentialChangeset())
	->loadAllWhere(
	'id IN (%Ld)',
	$changeset_ids);
	}

	if ($more_changesets) {
	$changesets += $more_changesets;
	$changesets = msort($changesets, 'getSortKey');
	}

	return $inline_comments;
	}

	private function loadChangesetsAndVsMap(
	DifferentialDiff $target,
	DifferentialDiff $diff_vs = null,
	PhabricatorRepository $repository = null) {

	$load_ids = array();
	if ($diff_vs) {
	$load_ids[] = $diff_vs->getID();
	}
	$load_ids[] = $target->getID();

	$raw_changesets = id(new DifferentialChangeset())
	->loadAllWhere(
	'diffID IN (%Ld)',
	$load_ids);
	$changeset_groups = mgroup($raw_changesets, 'getDiffID');

	$changesets = idx($changeset_groups, $target->getID(), array());
	$changesets = mpull($changesets, null, 'getID');

	$refs = array();
	$vs_map = array();
	$vs_changesets = array();
	if ($diff_vs) {
	$vs_id = $diff_vs->getID();
	$vs_changesets_path_map = array();
	foreach (idx($changeset_groups, $vs_id, array()) as $changeset) {
	$path = $changeset->getAbsoluteRepositoryPath($repository, $diff_vs);
	$vs_changesets_path_map[$path] = $changeset;
	$vs_changesets[$changeset->getID()] = $changeset;
	}
	foreach ($changesets as $key => $changeset) {
	$path = $changeset->getAbsoluteRepositoryPath($repository, $target);
	if (isset($vs_changesets_path_map[$path])) {
	$vs_map[$changeset->getID()] =
	$vs_changesets_path_map[$path]->getID();
	$refs[$changeset->getID()] =
	$changeset->getID().'/'.$vs_changesets_path_map[$path]->getID();
	unset($vs_changesets_path_map[$path]);
	} else {
	$refs[$changeset->getID()] = $changeset->getID();
	}
	}
	foreach ($vs_changesets_path_map as $path => $changeset) {
	$changesets[$changeset->getID()] = $changeset;
	$vs_map[$changeset->getID()] = -1;
	$refs[$changeset->getID()] = $changeset->getID().'/-1';
	}
	} else {
	foreach ($changesets as $changeset) {
	$refs[$changeset->getID()] = $changeset->getID();
	}
	}

	$changesets = msort($changesets, 'getSortKey');

	return array($changesets, $vs_map, $vs_changesets, $refs);
	}

	private function loadAuxiliaryFields(DifferentialRevision $revision) {

	$aux_fields = DifferentialFieldSelector::newSelector()
	->getFieldSpecifications();
	foreach ($aux_fields as $key => $aux_field) {
	if (!$aux_field->shouldAppearOnRevisionView()) {
	unset($aux_fields[$key]);
	} else {
	$aux_field->setUser($this->getRequest()->getUser());
	}
	}

	$aux_fields = DifferentialAuxiliaryField::loadFromStorage(
	$revision,
	$aux_fields);

	return $aux_fields;
	}

	private function buildSymbolIndexes(
	PhabricatorRepositoryArcanistProject $arc_project,
	array $visible_changesets) {
	assert_instances_of($visible_changesets, 'DifferentialChangeset');

	$engine = PhabricatorSyntaxHighlighter::newEngine();

	$langs = $arc_project->getSymbolIndexLanguages();
	if (!$langs) {
	return array(array(), array());
	}

	$symbol_indexes = array();

	$project_phids = array_merge(
	array($arc_project->getPHID()),
	nonempty($arc_project->getSymbolIndexProjects(), array()));

	$indexed_langs = array_fill_keys($langs, true);
	foreach ($visible_changesets as $key => $changeset) {
	$lang = $engine->getLanguageFromFilename($changeset->getFilename());
	if (isset($indexed_langs[$lang])) {
	$symbol_indexes[$key] = array(
	'lang' => $lang,
	'projects' => $project_phids,
	);
	}
	}

	return array($symbol_indexes, $project_phids);
	}

	private function loadOtherRevisions(
	array $changesets,
	DifferentialDiff $target,
	PhabricatorRepository $repository) {
	assert_instances_of($changesets, 'DifferentialChangeset');

	$paths = array();
	foreach ($changesets as $changeset) {
	$paths[] = $changeset->getAbsoluteRepositoryPath(
	$repository,
	$target);
	}

	if (!$paths) {
	return array();
	}

	$path_map = id(new DiffusionPathIDQuery($paths))->loadPathIDs();

	if (!$path_map) {
	return array();
	}

	$query = id(new DifferentialRevisionQuery())
	->withStatus(DifferentialRevisionQuery::STATUS_OPEN)
	->setOrder(DifferentialRevisionQuery::ORDER_PATH_MODIFIED)
	->setLimit(10)
	->needRelationships(true);

	foreach ($path_map as $path => $path_id) {
	$query->withPath($repository->getID(), $path_id);
	}

	$results = $query->execute();

	// Strip out this revision.
	foreach ($results as $key => $result) {
	if ($result->getID() == $this->revisionID) {
	unset($results[$key]);
	}
	}

	return $results;
	}

	private function renderOtherRevisions(array $revisions) {
	assert_instances_of($revisions, 'DifferentialRevision');

	$user = $this->getRequest()->getUser();

	$view = id(new DifferentialRevisionListView())
	->setRevisions($revisions)
	->setFields(DifferentialRevisionListView::getDefaultFields($user))
	->setUser($user)
	->loadAssets();

	$phids = $view->getRequiredHandlePHIDs();
	$handles = $this->loadViewerHandles($phids);
	$view->setHandles($handles);

	return hsprintf(
	'%s<div class="differential-panel">%s</div>',
	id(new PhabricatorHeaderView())
	->setHeader(pht('Open Revisions Affecting These Files'))
	->render(),
	$view->render());
	}

	/**
	* Straight copy of the loadFileByPhid method in
	* @{class:DifferentialReviewRequestMail}.
	*
	* This is because of the code similarity between the buildPatch method in
	* @{class:DifferentialReviewRequestMail} and @{method:buildRawDiffResponse}
	* in this class. Both of these methods end up using call_user_func and this
	* piece of code is the lucky function.
	*
	* @return mixed (@{class:PhabricatorFile} if found, null if not)
	*/
	public function loadFileByPHID($phid) {
	$file = id(new PhabricatorFile())->loadOneWhere(
	'phid = %s',
	$phid);
	if (!$file) {
	return null;
	}
	return $file->loadFileData();
	}

	/**
	* Note this code is somewhat similar to the buildPatch method in
	* @{class:DifferentialReviewRequestMail}.
	*
	* @return @{class:AphrontRedirectResponse}
	*/
	private function buildRawDiffResponse(
	array $changesets,
	array $vs_changesets,
	array $vs_map,
	PhabricatorRepository $repository = null) {

	assert_instances_of($changesets, 'DifferentialChangeset');
	assert_instances_of($vs_changesets, 'DifferentialChangeset');

	$engine = new PhabricatorDifferenceEngine();
	$generated_changesets = array();
	foreach ($changesets as $changeset) {
	$changeset->attachHunks($changeset->loadHunks());
	$right = $changeset->makeNewFile();
	$choice = $changeset;
	$vs = idx($vs_map, $changeset->getID());
	if ($vs == -1) {
	$left = $right;
	$right = $changeset->makeOldFile();
	} else if ($vs) {
	$choice = $vs_changeset = $vs_changesets[$vs];
	$vs_changeset->attachHunks($vs_changeset->loadHunks());
	$left = $vs_changeset->makeNewFile();
	} else {
	$left = $changeset->makeOldFile();
	}

	$synthetic = $engine->generateChangesetFromFileContent(
	$left,
	$right);

	if (!$synthetic->getAffectedLineCount()) {
	$filetype = $choice->getFileType();
	if ($filetype == DifferentialChangeType::FILE_TEXT \|\|
	$filetype == DifferentialChangeType::FILE_SYMLINK) {
	continue;
	}
	}

	$choice->attachHunks($synthetic->getHunks());

	$generated_changesets[] = $choice;
	}

	$diff = new DifferentialDiff();
	$diff->attachChangesets($generated_changesets);
	$diff_dict = $diff->getDiffDict();

	$changes = array();
	foreach ($diff_dict['changes'] as $changedict) {
	$changes[] = ArcanistDiffChange::newFromDictionary($changedict);
	}
	$bundle = ArcanistBundle::newFromChanges($changes);

	$bundle->setLoadFileDataCallback(array($this, 'loadFileByPHID'));

	$vcs = $repository ? $repository->getVersionControlSystem() : null;
	switch ($vcs) {
	case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
	case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
	$raw_diff = $bundle->toGitPatch();
	break;
	case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	default:
	$raw_diff = $bundle->toUnifiedDiff();
	break;
	}

	$request_uri = $this->getRequest()->getRequestURI();

	// this ends up being something like
	// D123.diff
	// or the verbose
	// D123.vs123.id123.whitespaceignore-all.diff
	// lame but nice to include these options
	$file_name = ltrim($request_uri->getPath(), '/').'.';
	foreach ($request_uri->getQueryParams() as $key => $value) {
	if ($key == 'download') {
	continue;
	}
	$file_name .= $key.$value.'.';
	}
	$file_name .= 'diff';

	$file = PhabricatorFile::buildFromFileDataOrHash(
	$raw_diff,
	array(
	'name' => $file_name,
	));

	return id(new AphrontRedirectResponse())->setURI($file->getBestURI());

	}
	}
	diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
	index ffe573d521..1292a90f76 100644
	--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
	+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
	@@ -1,595 +1,592 @@
	<?php

	/**
	* @group maniphest
	*/
	final class ManiphestTaskDetailController extends ManiphestController {

	private $id;

	public function willProcessRequest(array $data) {
	$this->id = $data['id'];
	}

	public function processRequest() {

	$request = $this->getRequest();
	$user = $request->getUser();

	$e_title = null;

	$priority_map = ManiphestTaskPriority::getTaskPriorityMap();

	$task = id(new ManiphestTask())->load($this->id);
	if (!$task) {
	return new Aphront404Response();
	}

	$workflow = $request->getStr('workflow');
	$parent_task = null;
	if ($workflow && is_numeric($workflow)) {
	$parent_task = id(new ManiphestTask())->load($workflow);
	}

	$transactions = id(new ManiphestTransaction())->loadAllWhere(
	'taskID = %d ORDER BY id ASC',
	$task->getID());

	$extensions = ManiphestTaskExtensions::newExtensions();
	$aux_fields = $extensions->loadFields($task, $user);

	$e_commit = PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT;
	$e_dep_on = PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK;
	$e_dep_by = PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK;
	$e_rev = PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV;

	$phid = $task->getPHID();

	$query = id(new PhabricatorEdgeQuery())
	->withSourcePHIDs(array($phid))
	->withEdgeTypes(
	array(
	$e_commit,
	$e_dep_on,
	$e_dep_by,
	$e_rev,
	));
	$edges = idx($query->execute(), $phid);
	$phids = array_fill_keys($query->getDestinationPHIDs(), true);

	foreach ($transactions as $transaction) {
	foreach ($transaction->extractPHIDs() as $phid) {
	$phids[$phid] = true;
	}
	}
	foreach ($task->getCCPHIDs() as $phid) {
	$phids[$phid] = true;
	}
	foreach ($task->getProjectPHIDs() as $phid) {
	$phids[$phid] = true;
	}
	if ($task->getOwnerPHID()) {
	$phids[$task->getOwnerPHID()] = true;
	}
	$phids[$task->getAuthorPHID()] = true;

	$attached = $task->getAttached();
	foreach ($attached as $type => $list) {
	foreach ($list as $phid => $info) {
	$phids[$phid] = true;
	}
	}

	if ($parent_task) {
	$phids[$parent_task->getPHID()] = true;
	}

	$phids = array_keys($phids);

	$phids = array_merge(
	$phids,
	array_mergev(mpull($aux_fields, 'getRequiredHandlePHIDs')));

	$this->loadHandles($phids);

	$handles = $this->getLoadedHandles();
	foreach ($aux_fields as $aux_field) {
	$aux_field->setHandles($handles);
	}

	$context_bar = null;

	if ($parent_task) {
	$context_bar = new AphrontContextBarView();
	$context_bar->addButton(phutil_tag(
	'a',
	array(
	'href' => '/maniphest/task/create/?parent='.$parent_task->getID(),
	'class' => 'green button',
	),
	pht('Create Another Subtask')));
	$context_bar->appendChild(hsprintf(
	'Created a subtask of <strong>%s</strong>',
	$this->getHandle($parent_task->getPHID())->renderLink()));
	} else if ($workflow == 'create') {
	$context_bar = new AphrontContextBarView();
	$context_bar->addButton(phutil_tag('label', array(), 'Create Another'));
	$context_bar->addButton(phutil_tag(
	'a',
	array(
	'href' => '/maniphest/task/create/?template='.$task->getID(),
	'class' => 'green button',
	),
	pht('Similar Task')));
	$context_bar->addButton(phutil_tag(
	'a',
	array(
	'href' => '/maniphest/task/create/',
	'class' => 'green button',
	),
	pht('Empty Task')));
	$context_bar->appendChild(pht('New task created.'));
	}

	$engine = new PhabricatorMarkupEngine();
	$engine->setViewer($user);
	$engine->addObject($task, ManiphestTask::MARKUP_FIELD_DESCRIPTION);
	foreach ($transactions as $xaction) {
	if ($xaction->hasComments()) {
	$engine->addObject($xaction, ManiphestTransaction::MARKUP_FIELD_BODY);
	}
	}

	foreach ($aux_fields as $aux_field) {
	foreach ($aux_field->getMarkupFields() as $markup_field) {
	$engine->addObject($aux_field, $markup_field);
	$aux_field->setMarkupEngine($engine);
	}
	}

	$engine->process();

	$transaction_types = ManiphestTransactionType::getTransactionTypeMap();
	$resolution_types = ManiphestTaskStatus::getTaskStatusMap();

	if ($task->getStatus() == ManiphestTaskStatus::STATUS_OPEN) {
	$resolution_types = array_select_keys(
	$resolution_types,
	array(
	ManiphestTaskStatus::STATUS_CLOSED_RESOLVED,
	ManiphestTaskStatus::STATUS_CLOSED_WONTFIX,
	ManiphestTaskStatus::STATUS_CLOSED_INVALID,
	ManiphestTaskStatus::STATUS_CLOSED_SPITE,
	));
	} else {
	$resolution_types = array(
	ManiphestTaskStatus::STATUS_OPEN => 'Reopened',
	);
	$transaction_types[ManiphestTransactionType::TYPE_STATUS] =
	'Reopen Task';
	unset($transaction_types[ManiphestTransactionType::TYPE_PRIORITY]);
	unset($transaction_types[ManiphestTransactionType::TYPE_OWNER]);
	}

	$default_claim = array(
	$user->getPHID() => $user->getUsername().' ('.$user->getRealName().')',
	);

	$draft = id(new PhabricatorDraft())->loadOneWhere(
	'authorPHID = %s AND draftKey = %s',
	$user->getPHID(),
	$task->getPHID());
	if ($draft) {
	$draft_text = $draft->getDraft();
	} else {
	$draft_text = null;
	}

	$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');

	if ($is_serious) {
	// Prevent tasks from being closed "out of spite" in serious business
	// installs.
	unset($resolution_types[ManiphestTaskStatus::STATUS_CLOSED_SPITE]);
	}

	$comment_form = new AphrontFormView();
	$comment_form
	->setUser($user)
	->setAction('/maniphest/transaction/save/')
	->setEncType('multipart/form-data')
	->addHiddenInput('taskID', $task->getID())
	->appendChild(
	id(new AphrontFormSelectControl())
	->setLabel(pht('Action'))
	->setName('action')
	->setOptions($transaction_types)
	->setID('transaction-action'))
	->appendChild(
	id(new AphrontFormSelectControl())
	->setLabel(pht('Resolution'))
	->setName('resolution')
	->setControlID('resolution')
	->setControlStyle('display: none')
	->setOptions($resolution_types))
	->appendChild(
	id(new AphrontFormTokenizerControl())
	->setLabel(pht('Assign To'))
	->setName('assign_to')
	->setControlID('assign_to')
	->setControlStyle('display: none')
	->setID('assign-tokenizer')
	->setDisableBehavior(true))
	->appendChild(
	id(new AphrontFormTokenizerControl())
	->setLabel(pht('CCs'))
	->setName('ccs')
	->setControlID('ccs')
	->setControlStyle('display: none')
	->setID('cc-tokenizer')
	->setDisableBehavior(true))
	->appendChild(
	id(new AphrontFormSelectControl())
	->setLabel(pht('Priority'))
	->setName('priority')
	->setOptions($priority_map)
	->setControlID('priority')
	->setControlStyle('display: none')
	->setValue($task->getPriority()))
	->appendChild(
	id(new AphrontFormTokenizerControl())
	->setLabel(pht('Projects'))
	->setName('projects')
	->setControlID('projects')
	->setControlStyle('display: none')
	->setID('projects-tokenizer')
	->setDisableBehavior(true))
	->appendChild(
	id(new AphrontFormFileControl())
	->setLabel(pht('File'))
	->setName('file')
	->setControlID('file')
	->setControlStyle('display: none'))
	->appendChild(
	id(new PhabricatorRemarkupControl())
	->setLabel(pht('Comments'))
	->setName('comments')
	->setValue($draft_text)
	->setID('transaction-comments')
	->setUser($user))
	->appendChild(
	id(new AphrontFormDragAndDropUploadControl())
	->setLabel(pht('Attached Files'))
	->setName('files')
	->setActivatedClass('aphront-panel-view-drag-and-drop'))
	->appendChild(
	id(new AphrontFormSubmitControl())
	->setValue($is_serious ? pht('Submit') : pht('Avast!')));

	$control_map = array(
	ManiphestTransactionType::TYPE_STATUS => 'resolution',
	ManiphestTransactionType::TYPE_OWNER => 'assign_to',
	ManiphestTransactionType::TYPE_CCS => 'ccs',
	ManiphestTransactionType::TYPE_PRIORITY => 'priority',
	ManiphestTransactionType::TYPE_PROJECTS => 'projects',
	ManiphestTransactionType::TYPE_ATTACH => 'file',
	);

	$tokenizer_map = array(
	ManiphestTransactionType::TYPE_PROJECTS => array(
	'id' => 'projects-tokenizer',
	'src' => '/typeahead/common/projects/',
	'ondemand' => PhabricatorEnv::getEnvConfig('tokenizer.ondemand'),
	'placeholder' => pht('Type a project name...'),
	),
	ManiphestTransactionType::TYPE_OWNER => array(
	'id' => 'assign-tokenizer',
	'src' => '/typeahead/common/users/',
	'value' => $default_claim,
	'limit' => 1,
	'ondemand' => PhabricatorEnv::getEnvConfig('tokenizer.ondemand'),
	'placeholder' => pht('Type a user name...'),
	),
	ManiphestTransactionType::TYPE_CCS => array(
	'id' => 'cc-tokenizer',
	'src' => '/typeahead/common/mailable/',
	'ondemand' => PhabricatorEnv::getEnvConfig('tokenizer.ondemand'),
	'placeholder' => pht('Type a user or mailing list...'),
	),
	);

	Javelin::initBehavior('maniphest-transaction-controls', array(
	'select' => 'transaction-action',
	'controlMap' => $control_map,
	'tokenizers' => $tokenizer_map,
	));

	Javelin::initBehavior('maniphest-transaction-preview', array(
	'uri' => '/maniphest/transaction/preview/'.$task->getID().'/',
	'preview' => 'transaction-preview',
	'comments' => 'transaction-comments',
	'action' => 'transaction-action',
	'map' => $control_map,
	'tokenizers' => $tokenizer_map,
	));

	$comment_header = id(new PhabricatorHeaderView())
	->setHeader($is_serious ? pht('Add Comment') : pht('Weigh In'));

	$preview_panel = hsprintf(
	'<div class="aphront-panel-preview">
	<div id="transaction-preview">
	<div class="aphront-panel-preview-loading-text">%s</div>
	</div>
	</div>',
	pht('Loading preview...'));

	$transaction_view = new ManiphestTransactionListView();
	$transaction_view->setTransactions($transactions);
	$transaction_view->setHandles($this->getLoadedHandles());
	$transaction_view->setUser($user);
	$transaction_view->setAuxiliaryFields($aux_fields);
	$transaction_view->setMarkupEngine($engine);

	- PhabricatorFeedStoryNotification::updateObjectNotificationViews(
	- $user, $task->getPHID());
	-
	$object_name = 'T'.$task->getID();
	$actions = $this->buildActionView($task);

	$crumbs = $this->buildApplicationCrumbs();
	$crumbs->addCrumb(
	id(new PhabricatorCrumbView())
	->setName($object_name)
	->setHref('/'.$object_name))
	->setActionList($actions)
	->addAction(
	id(new PhabricatorMenuItemView())
	->setHref($this->getApplicationURI('/task/create/'))
	->setName(pht('Create Task'))
	->setIcon('create'));

	$header = $this->buildHeaderView($task);
	$properties = $this->buildPropertyView($task, $aux_fields, $edges, $engine);

	return $this->buildApplicationPage(
	array(
	$crumbs,
	$context_bar,
	$header,
	$actions,
	$properties,
	$transaction_view,
	$comment_header,
	$comment_form,
	$preview_panel,
	),
	array(
	'title' => 'T'.$task->getID().' '.$task->getTitle(),
	'pageObjects' => array($task->getPHID()),
	'device' => true,
	));
	}

	private function buildHeaderView(ManiphestTask $task) {
	$view = id(new PhabricatorHeaderView())
	->setHeader($task->getTitle());

	$view->addTag(ManiphestView::renderTagForTask($task));

	return $view;
	}


	private function buildActionView(ManiphestTask $task) {
	$viewer = $this->getRequest()->getUser();
	$viewer_phid = $viewer->getPHID();
	$viewer_is_cc = in_array($viewer_phid, $task->getCCPHIDs());

	$id = $task->getID();
	$phid = $task->getPHID();

	$view = new PhabricatorActionListView();
	$view->setUser($viewer);
	$view->setObject($task);

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Edit Task'))
	->setIcon('edit')
	->setHref($this->getApplicationURI("/task/edit/{$id}/")));

	if ($task->getOwnerPHID() === $viewer_phid) {
	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Automatically Subscribed'))
	->setDisabled(true)
	->setIcon('subscribe-auto'));
	} else {
	$action = $viewer_is_cc ? 'rem' : 'add';
	$name = $viewer_is_cc ? 'Unsubscribe' : 'Subscribe';
	$icon = $viewer_is_cc ? 'subscribe-delete' : 'subscribe-add';

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht($name))
	->setHref("/maniphest/subscribe/{$action}/{$id}/")
	->setRenderAsForm(true)
	->setUser($viewer)
	->setIcon($icon));
	}

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Merge Duplicates'))
	->setHref("/search/attach/{$phid}/TASK/merge/")
	->setWorkflow(true)
	->setIcon('merge'));

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Create Subtask'))
	->setHref($this->getApplicationURI("/task/create/?parent={$id}"))
	->setIcon('fork'));

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Edit Dependencies'))
	->setHref("/search/attach/{$phid}/TASK/dependencies/")
	->setWorkflow(true)
	->setIcon('link'));

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Edit Differential Revisions'))
	->setHref("/search/attach/{$phid}/DREV/")
	->setWorkflow(true)
	->setIcon('attach'));

	return $view;
	}

	private function buildPropertyView(
	ManiphestTask $task,
	array $aux_fields,
	array $edges,
	PhabricatorMarkupEngine $engine) {

	$viewer = $this->getRequest()->getUser();

	$view = id(new PhabricatorPropertyListView())
	->setUser($viewer)
	->setObject($task);

	$view->addProperty(
	pht('Assigned To'),
	$task->getOwnerPHID()
	? $this->getHandle($task->getOwnerPHID())->renderLink()
	: phutil_tag('em', array(), pht('None')));

	$view->addProperty(
	pht('Priority'),
	ManiphestTaskPriority::getTaskPriorityName($task->getPriority()));

	$view->addProperty(
	pht('Subscribers'),
	$task->getCCPHIDs()
	? $this->renderHandlesForPHIDs($task->getCCPHIDs(), ',')
	: phutil_tag('em', array(), pht('None')));

	$view->addProperty(
	pht('Author'),
	$this->getHandle($task->getAuthorPHID())->renderLink());

	$source = $task->getOriginalEmailSource();
	if ($source) {
	$subject = '[T'.$task->getID().'] '.$task->getTitle();
	$view->addProperty(
	pht('From Email'),
	phutil_tag(
	'a',
	array(
	'href' => 'mailto:'.$source.'?subject='.$subject
	),
	$source));
	}

	$view->addProperty(
	pht('Projects'),
	$task->getProjectPHIDs()
	? $this->renderHandlesForPHIDs($task->getProjectPHIDs(), ',')
	: phutil_tag('em', array(), pht('None')));

	foreach ($aux_fields as $aux_field) {
	$value = $aux_field->renderForDetailView();
	if (strlen($value)) {
	$view->addProperty($aux_field->getLabel(), $value);
	}
	}


	$edge_types = array(
	PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK
	=> pht('Dependent Tasks'),
	PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK
	=> pht('Depends On'),
	PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV
	=> pht('Differential Revisions'),
	);

	$revisions_commits = array();
	$handles = $this->getLoadedHandles();

	$commit_phids = array_keys(
	$edges[PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT]);
	if ($commit_phids) {
	$commit_drev = PhabricatorEdgeConfig::TYPE_COMMIT_HAS_DREV;
	$drev_edges = id(new PhabricatorEdgeQuery())
	->withSourcePHIDs($commit_phids)
	->withEdgeTypes(array($commit_drev))
	->execute();

	foreach ($commit_phids as $phid) {
	$revisions_commits[$phid] = $handles[$phid]->renderLink();
	$revision_phid = key($drev_edges[$phid][$commit_drev]);
	$revision_handle = idx($handles, $revision_phid);
	if ($revision_handle) {
	$task_drev = PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV;
	unset($edges[$task_drev][$revision_phid]);
	$revisions_commits[$phid] = hsprintf(
	'%s / %s',
	$revision_handle->renderLink($revision_handle->getName()),
	$revisions_commits[$phid]);
	}
	}
	}

	foreach ($edge_types as $edge_type => $edge_name) {
	if ($edges[$edge_type]) {
	$view->addProperty(
	$edge_name,
	$this->renderHandlesForPHIDs(array_keys($edges[$edge_type])));
	}
	}

	if ($revisions_commits) {
	$view->addProperty(
	pht('Commits'),
	phutil_implode_html(phutil_tag('br'), $revisions_commits));
	}

	$attached = $task->getAttached();
	$file_infos = idx($attached, PhabricatorPHIDConstants::PHID_TYPE_FILE);
	if ($file_infos) {
	$file_phids = array_keys($file_infos);

	$files = id(new PhabricatorFile())->loadAllWhere(
	'phid IN (%Ls)',
	$file_phids);

	$file_view = new PhabricatorFileLinkListView();
	$file_view->setFiles($files);

	$view->addProperty(
	pht('Files'),
	$file_view->render());
	}

	$view->invokeWillRenderEvent();

	if (strlen($task->getDescription())) {
	$view->addSectionHeader(pht('Description'));
	$view->addTextContent(
	phutil_tag(
	'div',
	array(
	'class' => 'phabricator-remarkup',
	),
	$engine->getOutput($task, ManiphestTask::MARKUP_FIELD_DESCRIPTION)));
	}

	return $view;
	}


	}
	diff --git a/src/applications/paste/controller/PhabricatorPasteViewController.php b/src/applications/paste/controller/PhabricatorPasteViewController.php
	index f0e4c3f59c..2462f452cc 100644
	--- a/src/applications/paste/controller/PhabricatorPasteViewController.php
	+++ b/src/applications/paste/controller/PhabricatorPasteViewController.php
	@@ -1,158 +1,159 @@
	<?php

	final class PhabricatorPasteViewController extends PhabricatorPasteController {

	public function shouldAllowPublic() {
	return true;
	}

	private $id;
	private $handles;

	public function willProcessRequest(array $data) {
	$this->id = $data['id'];
	}

	public function processRequest() {
	$request = $this->getRequest();
	$user = $request->getUser();

	$paste = id(new PhabricatorPasteQuery())
	->setViewer($user)
	->withIDs(array($this->id))
	->needContent(true)
	->executeOne();
	if (!$paste) {
	return new Aphront404Response();
	}

	$file = id(new PhabricatorFile())->loadOneWhere(
	'phid = %s',
	$paste->getFilePHID());
	if (!$file) {
	return new Aphront400Response();
	}

	$forks = id(new PhabricatorPasteQuery())
	->setViewer($user)
	->withParentPHIDs(array($paste->getPHID()))
	->execute();
	$fork_phids = mpull($forks, 'getPHID');

	$this->loadHandles(
	array_merge(
	array(
	$paste->getAuthorPHID(),
	$paste->getParentPHID(),
	),
	$fork_phids));

	$header = $this->buildHeaderView($paste);
	$actions = $this->buildActionView($user, $paste, $file);
	$properties = $this->buildPropertyView($paste, $fork_phids);
	$source_code = $this->buildSourceCodeView($paste);

	$crumbs = $this->buildApplicationCrumbs($this->buildSideNavView())
	->setActionList($actions)
	->addCrumb(
	id(new PhabricatorCrumbView())
	->setName('P'.$paste->getID())
	->setHref('/P'.$paste->getID()));

	return $this->buildApplicationPage(
	array(
	$crumbs,
	$header,
	$actions,
	$properties,
	$source_code,
	),
	array(
	'title' => $paste->getFullName(),
	'device' => true,
	+ 'pageObjects' => array($paste->getPHID()),
	));
	}

	private function buildHeaderView(PhabricatorPaste $paste) {
	return id(new PhabricatorHeaderView())
	->setHeader($paste->getTitle());
	}

	private function buildActionView(
	PhabricatorUser $user,
	PhabricatorPaste $paste,
	PhabricatorFile $file) {

	$can_edit = PhabricatorPolicyFilter::hasCapability(
	$user,
	$paste,
	PhabricatorPolicyCapability::CAN_EDIT);

	$can_fork = $user->isLoggedIn();
	$fork_uri = $this->getApplicationURI('/create/?parent='.$paste->getID());

	return id(new PhabricatorActionListView())
	->setUser($user)
	->setObject($paste)
	->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Fork This Paste'))
	->setIcon('fork')
	->setDisabled(!$can_fork)
	->setWorkflow(!$can_fork)
	->setHref($fork_uri))
	->addAction(
	id(new PhabricatorActionView())
	->setName(pht('View Raw File'))
	->setIcon('file')
	->setHref($file->getBestURI()))
	->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Edit Paste'))
	->setIcon('edit')
	->setDisabled(!$can_edit)
	->setWorkflow(!$can_edit)
	->setHref($this->getApplicationURI('/edit/'.$paste->getID().'/')));
	}

	private function buildPropertyView(
	PhabricatorPaste $paste,
	array $child_phids) {

	$user = $this->getRequest()->getUser();
	$properties = id(new PhabricatorPropertyListView())
	->setUser($user)
	->setObject($paste);

	$properties->addProperty(
	pht('Author'),
	$this->getHandle($paste->getAuthorPHID())->renderLink());

	$properties->addProperty(
	pht('Created'),
	phabricator_datetime($paste->getDateCreated(), $user));

	if ($paste->getParentPHID()) {
	$properties->addProperty(
	pht('Forked From'),
	$this->getHandle($paste->getParentPHID())->renderLink());
	}

	if ($child_phids) {
	$properties->addProperty(
	pht('Forks'),
	$this->renderHandlesForPHIDs($child_phids));
	}

	$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
	$user,
	$paste);

	$properties->addProperty(
	pht('Visible To'),
	$descriptions[PhabricatorPolicyCapability::CAN_VIEW]);

	return $properties;
	}

	}
	diff --git a/src/applications/pholio/controller/PholioMockViewController.php b/src/applications/pholio/controller/PholioMockViewController.php
	index b34d48087e..4fea7369da 100644
	--- a/src/applications/pholio/controller/PholioMockViewController.php
	+++ b/src/applications/pholio/controller/PholioMockViewController.php
	@@ -1,220 +1,216 @@
	<?php

	/**
	* @group pholio
	*/
	final class PholioMockViewController extends PholioController {

	private $id;
	private $imageID;

	public function shouldAllowPublic() {
	return true;
	}

	public function willProcessRequest(array $data) {
	$this->id = $data['id'];
	$this->imageID = idx($data, 'imageID');
	}

	public function processRequest() {
	$request = $this->getRequest();
	$user = $request->getUser();

	$mock = id(new PholioMockQuery())
	->setViewer($user)
	->withIDs(array($this->id))
	->needImages(true)
	->needCoverFiles(true)
	->executeOne();

	if (!$mock) {
	return new Aphront404Response();
	}

	$xactions = id(new PholioTransactionQuery())
	->setViewer($user)
	->withObjectPHIDs(array($mock->getPHID()))
	->execute();

	$subscribers = PhabricatorSubscribersQuery::loadSubscribersForPHID(
	$mock->getPHID());

	$phids = array();
	$phids[] = $mock->getAuthorPHID();
	foreach ($subscribers as $subscriber) {
	$phids[] = $subscriber;
	}
	$this->loadHandles($phids);


	$engine = id(new PhabricatorMarkupEngine())
	->setViewer($user);
	$engine->addObject($mock, PholioMock::MARKUP_FIELD_DESCRIPTION);
	foreach ($xactions as $xaction) {
	if ($xaction->getComment()) {
	$engine->addObject(
	$xaction->getComment(),
	PhabricatorApplicationTransactionComment::MARKUP_FIELD_COMMENT);
	}
	}
	$engine->process();

	$title = $mock->getName();

	$header = id(new PhabricatorHeaderView())
	->setHeader($title);

	$actions = $this->buildActionView($mock);
	$properties = $this->buildPropertyView($mock, $engine, $subscribers);

	require_celerity_resource('pholio-css');
	require_celerity_resource('pholio-inline-comments-css');

	$output = id(new PholioMockImagesView())
	->setRequestURI($request->getRequestURI())
	->setUser($user)
	->setMock($mock)
	->setImageID($this->imageID);

	$xaction_view = id(new PholioTransactionView())
	->setUser($this->getRequest()->getUser())
	->setTransactions($xactions)
	->setMarkupEngine($engine);

	$add_comment = $this->buildAddCommentView($mock);

	$crumbs = $this->buildApplicationCrumbs($this->buildSideNav());
	$crumbs->setActionList($actions);
	$crumbs->addCrumb(
	id(new PhabricatorCrumbView())
	->setName('M'.$mock->getID())
	->setHref('/M'.$mock->getID()));

	$content = array(
	$crumbs,
	$header,
	$actions,
	$properties,
	$output->render(),
	$xaction_view,
	$add_comment,
	);

	- PhabricatorFeedStoryNotification::updateObjectNotificationViews(
	- $user,
	- $mock->getPHID());
	-
	return $this->buildApplicationPage(
	$content,
	array(
	'title' => 'M'.$mock->getID().' '.$title,
	'device' => true,
	'pageObjects' => array($mock->getPHID()),
	));
	}

	private function buildActionView(PholioMock $mock) {
	$user = $this->getRequest()->getUser();

	$actions = id(new PhabricatorActionListView())
	->setUser($user)
	->setObject($mock);

	$can_edit = PhabricatorPolicyFilter::hasCapability(
	$user,
	$mock,
	PhabricatorPolicyCapability::CAN_EDIT);

	$actions->addAction(
	id(new PhabricatorActionView())
	->setIcon('edit')
	->setName(pht('Edit Mock'))
	->setHref($this->getApplicationURI('/edit/'.$mock->getID().'/'))
	->setDisabled(!$can_edit)
	->setWorkflow(!$can_edit));

	return $actions;
	}

	private function buildPropertyView(
	PholioMock $mock,
	PhabricatorMarkupEngine $engine,
	array $subscribers) {

	$user = $this->getRequest()->getUser();

	$properties = id(new PhabricatorPropertyListView())
	->setUser($user)
	->setObject($mock);

	$properties->addProperty(
	pht('Author'),
	$this->getHandle($mock->getAuthorPHID())->renderLink());

	$properties->addProperty(
	pht('Created'),
	phabricator_datetime($mock->getDateCreated(), $user));

	$descriptions = PhabricatorPolicyQuery::renderPolicyDescriptions(
	$user,
	$mock);

	$properties->addProperty(
	pht('Visible To'),
	$descriptions[PhabricatorPolicyCapability::CAN_VIEW]);

	if ($subscribers) {
	$sub_view = array();
	foreach ($subscribers as $subscriber) {
	$sub_view[] = $this->getHandle($subscriber)->renderLink();
	}
	$sub_view = phutil_implode_html(', ', $sub_view);
	} else {
	$sub_view = phutil_tag('em', array(), pht('None'));
	}

	$properties->addProperty(
	pht('Subscribers'),
	$sub_view);

	$properties->invokeWillRenderEvent();

	$properties->addImageContent(
	$engine->getOutput($mock, PholioMock::MARKUP_FIELD_DESCRIPTION));

	return $properties;
	}

	private function buildAddCommentView(PholioMock $mock) {
	$user = $this->getRequest()->getUser();

	$draft = PhabricatorDraft::newFromUserAndKey($user, $mock->getPHID());

	$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');

	$title = $is_serious
	? pht('Add Comment')
	: pht('History Beckons');

	$header = id(new PhabricatorHeaderView())
	->setHeader($title);

	$button_name = $is_serious
	? pht('Add Comment')
	: pht('Answer The Call');

	$form = id(new PhabricatorApplicationTransactionCommentView())
	->setUser($user)
	->setDraft($draft)
	->setSubmitButtonName($button_name)
	->setAction($this->getApplicationURI('/comment/'.$mock->getID().'/'))
	->setRequestURI($this->getRequest()->getRequestURI());

	return array(
	$header,
	$form,
	);
	}

	}
	diff --git a/src/applications/tokens/event/PhabricatorTokenUIEventListener.php b/src/applications/tokens/event/PhabricatorTokenUIEventListener.php
	index a046c4cd5e..ec4c9e08f7 100644
	--- a/src/applications/tokens/event/PhabricatorTokenUIEventListener.php
	+++ b/src/applications/tokens/event/PhabricatorTokenUIEventListener.php
	@@ -1,122 +1,124 @@
	<?php

	final class PhabricatorTokenUIEventListener
	extends PhutilEventListener {

	public function register() {
	$this->listen(PhabricatorEventType::TYPE_UI_DIDRENDERACTIONS);
	$this->listen(PhabricatorEventType::TYPE_UI_WILLRENDERPROPERTIES);
	}

	public function handleEvent(PhutilEvent $event) {
	switch ($event->getType()) {
	case PhabricatorEventType::TYPE_UI_DIDRENDERACTIONS:
	$this->handleActionEvent($event);
	break;
	case PhabricatorEventType::TYPE_UI_WILLRENDERPROPERTIES:
	$this->handlePropertyEvent($event);
	break;
	}
	}

	private function handleActionEvent($event) {
	$user = $event->getUser();
	$object = $event->getValue('object');

	if (!$object \|\| !$object->getPHID()) {
	// No object, or the object has no PHID yet..
	return;
	}

	if (!($object instanceof PhabricatorTokenReceiverInterface)) {
	// This object isn't a token receiver.
	return;
	}

	$current = id(new PhabricatorTokenGivenQuery())
	->setViewer($user)
	->withAuthorPHIDs(array($user->getPHID()))
	->withObjectPHIDs(array($object->getPHID()))
	->execute();

	if (!$current) {
	$token_action = id(new PhabricatorActionView())
	->setUser($user)
	->setWorkflow(true)
	->setHref('/token/give/'.$object->getPHID().'/')
	->setName(pht('Award Token'))
	->setIcon('like');
	} else {
	$token_action = id(new PhabricatorActionView())
	->setUser($user)
	->setWorkflow(true)
	->setHref('/token/give/'.$object->getPHID().'/')
	->setName(pht('Rescind Token'))
	->setIcon('dislike');
	}

	$actions = $event->getValue('actions');
	$actions[] = $token_action;
	$event->setValue('actions', $actions);
	}

	private function handlePropertyEvent($event) {
	$user = $event->getUser();
	$object = $event->getValue('object');

	if (!$object \|\| !$object->getPHID()) {
	// No object, or the object has no PHID yet..
	return;
	}

	if (!($object instanceof PhabricatorTokenReceiverInterface)) {
	// This object isn't a token receiver.
	return;
	}

	$limit = 1;

	$tokens_given = id(new PhabricatorTokenGivenQuery())
	->setViewer($user)
	->withObjectPHIDs(array($object->getPHID()))
	->execute();

	if (!$tokens_given) {
	return;
	}

	$tokens = id(new PhabricatorTokenQuery())
	->setViewer($user)
	->withPHIDs(mpull($tokens_given, 'getTokenPHID'))
	->execute();
	$tokens = mpull($tokens, null, 'getPHID');

	$author_phids = mpull($tokens_given, 'getAuthorPHID');
	$handles = id(new PhabricatorObjectHandleData($author_phids))
	->setViewer($user)
	->loadHandles();

	+ Javelin::initBehavior('phabricator-tooltips');
	+
	$list = array();
	foreach ($tokens_given as $token_given) {
	if (!idx($tokens, $token_given->getTokenPHID())) {
	continue;
	}

	$token = $tokens[$token_given->getTokenPHID()];

	$list[] = javelin_tag(
	'span',
	array(
	'sigil' => 'has-tooltip',
	'meta' => array(
	'tip' => $handles[$token_given->getAuthorPHID()]->getName(),
	),
	),
	$token->renderIcon());
	}

	$view = $event->getValue('view');
	$view->addProperty(pht('Tokens'), $list);
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Tue, Jul 29, 11:33 AM (3 w, 1 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 188552
Default Alt Text: (75 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions