No OneTemporary
Actions

Size

108 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php b/src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php
	index 4d6f26a844..5f49aa3a76 100644
	--- a/src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php
	+++ b/src/applications/maniphest/conduit/ConduitAPI_maniphest_Method.php
	@@ -1,305 +1,292 @@
	<?php

	/**
	* @group conduit
	*/
	abstract class ConduitAPI_maniphest_Method extends ConduitAPIMethod {

	public function getApplication() {
	return PhabricatorApplication::getByClass(
	'PhabricatorApplicationManiphest');
	}

	public function defineErrorTypes() {
	return array(
	'ERR-INVALID-PARAMETER' => 'Missing or malformed parameter.'
	);
	}

	protected function buildTaskInfoDictionary(ManiphestTask $task) {
	$results = $this->buildTaskInfoDictionaries(array($task));
	return idx($results, $task->getPHID());
	}

	protected function getTaskFields($is_new) {
	$fields = array();

	if (!$is_new) {
	$fields += array(
	'id' => 'optional int',
	'phid' => 'optional int',
	);
	}

	$fields += array(
	'title' => $is_new ? 'required string' : 'optional string',
	'description' => 'optional string',
	'ownerPHID' => 'optional phid',
	'ccPHIDs' => 'optional list<phid>',
	'priority' => 'optional int',
	'projectPHIDs' => 'optional list<phid>',
	- 'filePHIDs' => 'optional list<phid>',
	'auxiliary' => 'optional dict',
	);

	if (!$is_new) {
	$fields += array(
	'status' => 'optional int',
	'comments' => 'optional string',
	);
	}

	return $fields;
	}

	protected function applyRequest(
	ManiphestTask $task,
	ConduitAPIRequest $request,
	$is_new) {

	$changes = array();

	if ($is_new) {
	$task->setTitle((string)$request->getValue('title'));
	$task->setDescription((string)$request->getValue('description'));
	$changes[ManiphestTransaction::TYPE_STATUS] =
	ManiphestTaskStatus::getDefaultStatus();
	} else {

	$comments = $request->getValue('comments');
	if (!$is_new && $comments !== null) {
	$changes[PhabricatorTransactions::TYPE_COMMENT] = null;
	}

	$title = $request->getValue('title');
	if ($title !== null) {
	$changes[ManiphestTransaction::TYPE_TITLE] = $title;
	}

	$desc = $request->getValue('description');
	if ($desc !== null) {
	$changes[ManiphestTransaction::TYPE_DESCRIPTION] = $desc;
	}

	$status = $request->getValue('status');
	if ($status !== null) {
	$valid_statuses = ManiphestTaskStatus::getTaskStatusMap();
	if (!isset($valid_statuses[$status])) {
	throw id(new ConduitException('ERR-INVALID-PARAMETER'))
	->setErrorDescription('Status set to invalid value.');
	}
	$changes[ManiphestTransaction::TYPE_STATUS] = $status;
	}
	}

	$priority = $request->getValue('priority');
	if ($priority !== null) {
	$valid_priorities = ManiphestTaskPriority::getTaskPriorityMap();
	if (!isset($valid_priorities[$priority])) {
	throw id(new ConduitException('ERR-INVALID-PARAMETER'))
	->setErrorDescription('Priority set to invalid value.');
	}
	$changes[ManiphestTransaction::TYPE_PRIORITY] = $priority;
	}

	$owner_phid = $request->getValue('ownerPHID');
	if ($owner_phid !== null) {
	$this->validatePHIDList(array($owner_phid),
	PhabricatorPeoplePHIDTypeUser::TYPECONST,
	'ownerPHID');
	$changes[ManiphestTransaction::TYPE_OWNER] = $owner_phid;
	}

	$ccs = $request->getValue('ccPHIDs');
	if ($ccs !== null) {
	$this->validatePHIDList($ccs,
	PhabricatorPeoplePHIDTypeUser::TYPECONST,
	'ccPHIDS');
	$changes[ManiphestTransaction::TYPE_CCS] = $ccs;
	}

	$project_phids = $request->getValue('projectPHIDs');
	if ($project_phids !== null) {
	$this->validatePHIDList($project_phids,
	PhabricatorProjectPHIDTypeProject::TYPECONST,
	'projectPHIDS');
	$changes[ManiphestTransaction::TYPE_PROJECTS] = $project_phids;
	}

	- $file_phids = $request->getValue('filePHIDs');
	- if ($file_phids !== null) {
	- $this->validatePHIDList($file_phids,
	- PhabricatorFilePHIDTypeFile::TYPECONST,
	- 'filePHIDS');
	- $file_map = array_fill_keys($file_phids, true);
	- $attached = $task->getAttached();
	- $attached[PhabricatorFilePHIDTypeFile::TYPECONST] = $file_map;
	-
	- $changes[ManiphestTransaction::TYPE_ATTACH] = $attached;
	- }
	-
	$template = new ManiphestTransaction();

	$transactions = array();
	foreach ($changes as $type => $value) {
	$transaction = clone $template;
	$transaction->setTransactionType($type);
	if ($type == PhabricatorTransactions::TYPE_COMMENT) {
	$transaction->attachComment(
	id(new ManiphestTransactionComment())
	->setContent($comments));
	} else {
	$transaction->setNewValue($value);
	}

	$transactions[] = $transaction;
	}

	$field_list = PhabricatorCustomField::getObjectFields(
	$task,
	PhabricatorCustomField::ROLE_EDIT);
	$field_list->readFieldsFromStorage($task);

	$auxiliary = $request->getValue('auxiliary');
	if ($auxiliary) {
	foreach ($field_list->getFields() as $key => $field) {
	if (!array_key_exists($key, $auxiliary)) {
	continue;
	}
	$transaction = clone $template;
	$transaction->setTransactionType(
	PhabricatorTransactions::TYPE_CUSTOMFIELD);
	$transaction->setMetadataValue('customfield:key', $key);
	$transaction->setOldValue(
	$field->getOldValueForApplicationTransactions());
	$transaction->setNewValue($auxiliary[$key]);
	$transactions[] = $transaction;
	}
	}

	if (!$transactions) {
	return;
	}

	$event = new PhabricatorEvent(
	PhabricatorEventType::TYPE_MANIPHEST_WILLEDITTASK,
	array(
	'task' => $task,
	'new' => $is_new,
	'transactions' => $transactions,
	));
	$event->setUser($request->getUser());
	$event->setConduitRequest($request);
	PhutilEventEngine::dispatchEvent($event);

	$task = $event->getValue('task');
	$transactions = $event->getValue('transactions');

	$content_source = PhabricatorContentSource::newForSource(
	PhabricatorContentSource::SOURCE_CONDUIT,
	array());

	$editor = id(new ManiphestTransactionEditor())
	->setActor($request->getUser())
	->setContentSource($content_source)
	->setContinueOnNoEffect(true);

	if (!$is_new) {
	$editor->setContinueOnMissingFields(true);
	}

	$editor->applyTransactions($task, $transactions);

	$event = new PhabricatorEvent(
	PhabricatorEventType::TYPE_MANIPHEST_DIDEDITTASK,
	array(
	'task' => $task,
	'new' => $is_new,
	'transactions' => $transactions,
	));
	$event->setUser($request->getUser());
	$event->setConduitRequest($request);
	PhutilEventEngine::dispatchEvent($event);

	}

	protected function buildTaskInfoDictionaries(array $tasks) {
	assert_instances_of($tasks, 'ManiphestTask');
	if (!$tasks) {
	return array();
	}

	$task_phids = mpull($tasks, 'getPHID');

	$all_deps = id(new PhabricatorEdgeQuery())
	->withSourcePHIDs($task_phids)
	->withEdgeTypes(array(PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK));
	$all_deps->execute();

	$result = array();
	foreach ($tasks as $task) {
	// TODO: Batch this get as CustomField gets cleaned up.
	$field_list = PhabricatorCustomField::getObjectFields(
	$task,
	PhabricatorCustomField::ROLE_EDIT);
	$field_list->readFieldsFromStorage($task);

	$auxiliary = mpull(
	$field_list->getFields(),
	'getValueForStorage',
	'getFieldKey');

	$task_deps = $all_deps->getDestinationPHIDs(
	array($task->getPHID()),
	array(PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK));

	$result[$task->getPHID()] = array(
	'id' => $task->getID(),
	'phid' => $task->getPHID(),
	'authorPHID' => $task->getAuthorPHID(),
	'ownerPHID' => $task->getOwnerPHID(),
	'ccPHIDs' => $task->getCCPHIDs(),
	'status' => $task->getStatus(),
	'statusName' => ManiphestTaskStatus::getTaskStatusName(
	$task->getStatus()),
	'isClosed' => $task->isClosed(),
	'priority' => ManiphestTaskPriority::getTaskPriorityName(
	$task->getPriority()),
	'priorityColor' => ManiphestTaskPriority::getTaskPriorityColor(
	$task->getPriority()),
	'title' => $task->getTitle(),
	'description' => $task->getDescription(),
	'projectPHIDs' => $task->getProjectPHIDs(),
	'uri' => PhabricatorEnv::getProductionURI('/T'.$task->getID()),
	'auxiliary' => $auxiliary,

	'objectName' => 'T'.$task->getID(),
	'dateCreated' => $task->getDateCreated(),
	'dateModified' => $task->getDateModified(),
	'dependsOnTaskPHIDs' => $task_deps,
	);
	}

	return $result;
	}

	/**
	* Note this is a temporary stop gap since its easy to make malformed Tasks.
	* Long-term, the values set in @{method:defineParamTypes} will be used to
	* validate data implicitly within the larger Conduit application.
	*
	* TODO -- remove this in favor of generalized Conduit hotness
	*/
	private function validatePHIDList(array $phid_list, $phid_type, $field) {
	$phid_groups = phid_group_by_type($phid_list);
	unset($phid_groups[$phid_type]);
	if (!empty($phid_groups)) {
	throw id(new ConduitException('ERR-INVALID-PARAMETER'))
	->setErrorDescription(
	'One or more PHIDs were invalid for '.$field.'.');
	}

	return true;
	}

	}
	diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
	index 6a670f0167..144b32dfd5 100644
	--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
	+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
	@@ -1,724 +1,722 @@
	<?php

	final class ManiphestTaskDetailController extends ManiphestController {

	private $id;

	public function shouldAllowPublic() {
	return true;
	}

	public function willProcessRequest(array $data) {
	$this->id = $data['id'];
	}

	public function processRequest() {

	$request = $this->getRequest();
	$user = $request->getUser();

	$e_title = null;

	$priority_map = ManiphestTaskPriority::getTaskPriorityMap();

	$task = id(new ManiphestTaskQuery())
	->setViewer($user)
	->withIDs(array($this->id))
	->executeOne();
	if (!$task) {
	return new Aphront404Response();
	}

	$workflow = $request->getStr('workflow');
	$parent_task = null;
	if ($workflow && is_numeric($workflow)) {
	$parent_task = id(new ManiphestTaskQuery())
	->setViewer($user)
	->withIDs(array($workflow))
	->executeOne();
	}

	$transactions = id(new ManiphestTransactionQuery())
	->setViewer($user)
	->withObjectPHIDs(array($task->getPHID()))
	->needComments(true)
	->execute();

	$field_list = PhabricatorCustomField::getObjectFields(
	$task,
	PhabricatorCustomField::ROLE_VIEW);
	$field_list
	->setViewer($user)
	->readFieldsFromStorage($task);

	$e_commit = PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT;
	$e_dep_on = PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK;
	$e_dep_by = PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK;
	$e_rev = PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV;
	$e_mock = PhabricatorEdgeConfig::TYPE_TASK_HAS_MOCK;

	$phid = $task->getPHID();

	$query = id(new PhabricatorEdgeQuery())
	->withSourcePHIDs(array($phid))
	->withEdgeTypes(
	array(
	$e_commit,
	$e_dep_on,
	$e_dep_by,
	$e_rev,
	$e_mock,
	));
	$edges = idx($query->execute(), $phid);
	$phids = array_fill_keys($query->getDestinationPHIDs(), true);

	foreach ($task->getCCPHIDs() as $phid) {
	$phids[$phid] = true;
	}
	foreach ($task->getProjectPHIDs() as $phid) {
	$phids[$phid] = true;
	}
	if ($task->getOwnerPHID()) {
	$phids[$task->getOwnerPHID()] = true;
	}
	$phids[$task->getAuthorPHID()] = true;

	$attached = $task->getAttached();
	foreach ($attached as $type => $list) {
	foreach ($list as $phid => $info) {
	$phids[$phid] = true;
	}
	}

	if ($parent_task) {
	$phids[$parent_task->getPHID()] = true;
	}

	$phids = array_keys($phids);

	$this->loadHandles($phids);

	$handles = $this->getLoadedHandles();

	$context_bar = null;

	if ($parent_task) {
	$context_bar = new AphrontContextBarView();
	$context_bar->addButton(phutil_tag(
	'a',
	array(
	'href' => '/maniphest/task/create/?parent='.$parent_task->getID(),
	'class' => 'green button',
	),
	pht('Create Another Subtask')));
	$context_bar->appendChild(hsprintf(
	'Created a subtask of <strong>%s</strong>',
	$this->getHandle($parent_task->getPHID())->renderLink()));
	} else if ($workflow == 'create') {
	$context_bar = new AphrontContextBarView();
	$context_bar->addButton(phutil_tag('label', array(), 'Create Another'));
	$context_bar->addButton(phutil_tag(
	'a',
	array(
	'href' => '/maniphest/task/create/?template='.$task->getID(),
	'class' => 'green button',
	),
	pht('Similar Task')));
	$context_bar->addButton(phutil_tag(
	'a',
	array(
	'href' => '/maniphest/task/create/',
	'class' => 'green button',
	),
	pht('Empty Task')));
	$context_bar->appendChild(pht('New task created.'));
	}

	$engine = new PhabricatorMarkupEngine();
	$engine->setViewer($user);
	$engine->addObject($task, ManiphestTask::MARKUP_FIELD_DESCRIPTION);
	foreach ($transactions as $modern_xaction) {
	if ($modern_xaction->getComment()) {
	$engine->addObject(
	$modern_xaction->getComment(),
	PhabricatorApplicationTransactionComment::MARKUP_FIELD_COMMENT);
	}
	}

	$engine->process();

	$resolution_types = ManiphestTaskStatus::getTaskStatusMap();

	$transaction_types = array(
	PhabricatorTransactions::TYPE_COMMENT => pht('Comment'),
	ManiphestTransaction::TYPE_STATUS => pht('Change Status'),
	ManiphestTransaction::TYPE_OWNER => pht('Reassign / Claim'),
	ManiphestTransaction::TYPE_CCS => pht('Add CCs'),
	ManiphestTransaction::TYPE_PRIORITY => pht('Change Priority'),
	- ManiphestTransaction::TYPE_ATTACH => pht('Upload File'),
	ManiphestTransaction::TYPE_PROJECTS => pht('Associate Projects'),
	);

	// Remove actions the user doesn't have permission to take.

	$requires = array(
	ManiphestTransaction::TYPE_OWNER =>
	ManiphestCapabilityEditAssign::CAPABILITY,
	ManiphestTransaction::TYPE_PRIORITY =>
	ManiphestCapabilityEditPriority::CAPABILITY,
	ManiphestTransaction::TYPE_PROJECTS =>
	ManiphestCapabilityEditProjects::CAPABILITY,
	ManiphestTransaction::TYPE_STATUS =>
	ManiphestCapabilityEditStatus::CAPABILITY,
	);

	foreach ($transaction_types as $type => $name) {
	if (isset($requires[$type])) {
	if (!$this->hasApplicationCapability($requires[$type])) {
	unset($transaction_types[$type]);
	}
	}
	}

	// Don't show an option to change to the current status, or to change to
	// the duplicate status explicitly.
	unset($resolution_types[$task->getStatus()]);
	unset($resolution_types[ManiphestTaskStatus::getDuplicateStatus()]);

	// Don't show owner/priority changes for closed tasks, as they don't make
	// much sense.
	if ($task->isClosed()) {
	unset($transaction_types[ManiphestTransaction::TYPE_PRIORITY]);
	unset($transaction_types[ManiphestTransaction::TYPE_OWNER]);
	}

	$default_claim = array(
	$user->getPHID() => $user->getUsername().' ('.$user->getRealName().')',
	);

	$draft = id(new PhabricatorDraft())->loadOneWhere(
	'authorPHID = %s AND draftKey = %s',
	$user->getPHID(),
	$task->getPHID());
	if ($draft) {
	$draft_text = $draft->getDraft();
	} else {
	$draft_text = null;
	}

	$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');

	$submit_text = $is_serious
	? pht('Submit')
	: pht('Avast!');

	$close_text = $is_serious
	? pht('Close Task')
	: pht('Scuttle Task');

	$submit_control = id(new PHUIFormMultiSubmitControl());
	if (!$task->isClosed()) {
	$close_image = id(new PHUIIconView())
	->setSpriteSheet(PHUIIconView::SPRITE_ICONS)
	->setSpriteIcon('check');
	$submit_control->addButtonView(
	id(new PHUIButtonView())
	->setColor(PHUIButtonView::GREY)
	->setIcon($close_image)
	->setText($close_text)
	->setName('scuttle')
	->addSigil('alternate-submit-button'));
	}
	$submit_control->addSubmitButton($submit_text);

	$comment_form = new AphrontFormView();
	$comment_form
	->setUser($user)
	->setWorkflow(true)
	->setAction('/maniphest/transaction/save/')
	->setEncType('multipart/form-data')
	->addHiddenInput('taskID', $task->getID())
	->appendChild(
	id(new AphrontFormSelectControl())
	->setLabel(pht('Action'))
	->setName('action')
	->setOptions($transaction_types)
	->setID('transaction-action'))
	->appendChild(
	id(new AphrontFormSelectControl())
	->setLabel(pht('Status'))
	->setName('resolution')
	->setControlID('resolution')
	->setControlStyle('display: none')
	->setOptions($resolution_types))
	->appendChild(
	id(new AphrontFormTokenizerControl())
	->setLabel(pht('Assign To'))
	->setName('assign_to')
	->setControlID('assign_to')
	->setControlStyle('display: none')
	->setID('assign-tokenizer')
	->setDisableBehavior(true))
	->appendChild(
	id(new AphrontFormTokenizerControl())
	->setLabel(pht('CCs'))
	->setName('ccs')
	->setControlID('ccs')
	->setControlStyle('display: none')
	->setID('cc-tokenizer')
	->setDisableBehavior(true))
	->appendChild(
	id(new AphrontFormSelectControl())
	->setLabel(pht('Priority'))
	->setName('priority')
	->setOptions($priority_map)
	->setControlID('priority')
	->setControlStyle('display: none')
	->setValue($task->getPriority()))
	->appendChild(
	id(new AphrontFormTokenizerControl())
	->setLabel(pht('Projects'))
	->setName('projects')
	->setControlID('projects')
	->setControlStyle('display: none')
	->setID('projects-tokenizer')
	->setDisableBehavior(true))
	->appendChild(
	id(new AphrontFormFileControl())
	->setLabel(pht('File'))
	->setName('file')
	->setControlID('file')
	->setControlStyle('display: none'))
	->appendChild(
	id(new PhabricatorRemarkupControl())
	->setLabel(pht('Comments'))
	->setName('comments')
	->setValue($draft_text)
	->setID('transaction-comments')
	->setUser($user))
	->appendChild($submit_control);

	$control_map = array(
	ManiphestTransaction::TYPE_STATUS => 'resolution',
	ManiphestTransaction::TYPE_OWNER => 'assign_to',
	ManiphestTransaction::TYPE_CCS => 'ccs',
	ManiphestTransaction::TYPE_PRIORITY => 'priority',
	ManiphestTransaction::TYPE_PROJECTS => 'projects',
	- ManiphestTransaction::TYPE_ATTACH => 'file',
	);

	$tokenizer_map = array(
	ManiphestTransaction::TYPE_PROJECTS => array(
	'id' => 'projects-tokenizer',
	'src' => '/typeahead/common/projects/',
	'placeholder' => pht('Type a project name...'),
	),
	ManiphestTransaction::TYPE_OWNER => array(
	'id' => 'assign-tokenizer',
	'src' => '/typeahead/common/users/',
	'value' => $default_claim,
	'limit' => 1,
	'placeholder' => pht('Type a user name...'),
	),
	ManiphestTransaction::TYPE_CCS => array(
	'id' => 'cc-tokenizer',
	'src' => '/typeahead/common/mailable/',
	'placeholder' => pht('Type a user or mailing list...'),
	),
	);

	// TODO: Initializing these behaviors for logged out users fatals things.
	if ($user->isLoggedIn()) {
	Javelin::initBehavior('maniphest-transaction-controls', array(
	'select' => 'transaction-action',
	'controlMap' => $control_map,
	'tokenizers' => $tokenizer_map,
	));

	Javelin::initBehavior('maniphest-transaction-preview', array(
	'uri' => '/maniphest/transaction/preview/'.$task->getID().'/',
	'preview' => 'transaction-preview',
	'comments' => 'transaction-comments',
	'action' => 'transaction-action',
	'map' => $control_map,
	'tokenizers' => $tokenizer_map,
	));
	}

	$comment_header = $is_serious
	? pht('Add Comment')
	: pht('Weigh In');

	$preview_panel = phutil_tag_div(
	'aphront-panel-preview',
	phutil_tag(
	'div',
	array('id' => 'transaction-preview'),
	phutil_tag_div(
	'aphront-panel-preview-loading-text',
	pht('Loading preview...'))));

	$timeline = id(new PhabricatorApplicationTransactionView())
	->setUser($user)
	->setObjectPHID($task->getPHID())
	->setTransactions($transactions)
	->setMarkupEngine($engine);

	$object_name = 'T'.$task->getID();
	$actions = $this->buildActionView($task);

	$crumbs = $this->buildApplicationCrumbs()
	->addTextCrumb($object_name, '/'.$object_name)
	->setActionList($actions);

	$header = $this->buildHeaderView($task);
	$properties = $this->buildPropertyView(
	$task, $field_list, $edges, $actions);
	$description = $this->buildDescriptionView($task, $engine);

	if (!$user->isLoggedIn()) {
	// TODO: Eventually, everything should run through this. For now, we're
	// only using it to get a consistent "Login to Comment" button.
	$comment_box = id(new PhabricatorApplicationTransactionCommentView())
	->setUser($user)
	->setRequestURI($request->getRequestURI());
	$preview_panel = null;
	} else {
	$comment_box = id(new PHUIObjectBoxView())
	->setFlush(true)
	->setHeaderText($comment_header)
	->appendChild($comment_form);
	}

	$object_box = id(new PHUIObjectBoxView())
	->setHeader($header)
	->addPropertyList($properties);

	if ($description) {
	$object_box->addPropertyList($description);
	}

	return $this->buildApplicationPage(
	array(
	$crumbs,
	$context_bar,
	$object_box,
	$timeline,
	$comment_box,
	$preview_panel,
	),
	array(
	'title' => 'T'.$task->getID().' '.$task->getTitle(),
	'pageObjects' => array($task->getPHID()),
	'device' => true,
	));
	}

	private function buildHeaderView(ManiphestTask $task) {
	$view = id(new PHUIHeaderView())
	->setHeader($task->getTitle())
	->setUser($this->getRequest()->getUser())
	->setPolicyObject($task);

	$status = $task->getStatus();
	$status_name = ManiphestTaskStatus::renderFullDescription($status);

	$view->addProperty(PHUIHeaderView::PROPERTY_STATUS, $status_name);

	return $view;
	}


	private function buildActionView(ManiphestTask $task) {
	$viewer = $this->getRequest()->getUser();
	$viewer_phid = $viewer->getPHID();
	$viewer_is_cc = in_array($viewer_phid, $task->getCCPHIDs());

	$id = $task->getID();
	$phid = $task->getPHID();

	$can_edit = PhabricatorPolicyFilter::hasCapability(
	$viewer,
	$task,
	PhabricatorPolicyCapability::CAN_EDIT);

	$view = id(new PhabricatorActionListView())
	->setUser($viewer)
	->setObject($task)
	->setObjectURI($this->getRequest()->getRequestURI());

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Edit Task'))
	->setIcon('edit')
	->setHref($this->getApplicationURI("/task/edit/{$id}/"))
	->setDisabled(!$can_edit)
	->setWorkflow(!$can_edit));

	if ($task->getOwnerPHID() === $viewer_phid) {
	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Automatically Subscribed'))
	->setDisabled(true)
	->setIcon('enable'));
	} else {
	$action = $viewer_is_cc ? 'rem' : 'add';
	$name = $viewer_is_cc ? pht('Unsubscribe') : pht('Subscribe');
	$icon = $viewer_is_cc ? 'disable' : 'check';

	$view->addAction(
	id(new PhabricatorActionView())
	->setName($name)
	->setHref("/maniphest/subscribe/{$action}/{$id}/")
	->setRenderAsForm(true)
	->setUser($viewer)
	->setIcon($icon));
	}

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Merge Duplicates In'))
	->setHref("/search/attach/{$phid}/TASK/merge/")
	->setWorkflow(true)
	->setIcon('merge')
	->setDisabled(!$can_edit)
	->setWorkflow(true));

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Create Subtask'))
	->setHref($this->getApplicationURI("/task/create/?parent={$id}"))
	->setIcon('fork'));

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Edit Dependencies'))
	->setHref("/search/attach/{$phid}/TASK/dependencies/")
	->setWorkflow(true)
	->setIcon('link')
	->setDisabled(!$can_edit)
	->setWorkflow(true));

	return $view;
	}

	private function buildPropertyView(
	ManiphestTask $task,
	PhabricatorCustomFieldList $field_list,
	array $edges,
	PhabricatorActionListView $actions) {

	$viewer = $this->getRequest()->getUser();

	$view = id(new PHUIPropertyListView())
	->setUser($viewer)
	->setObject($task)
	->setActionList($actions);

	$view->addProperty(
	pht('Assigned To'),
	$task->getOwnerPHID()
	? $this->getHandle($task->getOwnerPHID())->renderLink()
	: phutil_tag('em', array(), pht('None')));

	$view->addProperty(
	pht('Priority'),
	ManiphestTaskPriority::getTaskPriorityName($task->getPriority()));

	$handles = $this->getLoadedHandles();
	$cc_handles = array_select_keys($handles, $task->getCCPHIDs());
	$subscriber_html = id(new SubscriptionListStringBuilder())
	->setObjectPHID($task->getPHID())
	->setHandles($cc_handles)
	->buildPropertyString();
	$view->addProperty(pht('Subscribers'), $subscriber_html);

	$view->addProperty(
	pht('Author'),
	$this->getHandle($task->getAuthorPHID())->renderLink());

	$source = $task->getOriginalEmailSource();
	if ($source) {
	$subject = '[T'.$task->getID().'] '.$task->getTitle();
	$view->addProperty(
	pht('From Email'),
	phutil_tag(
	'a',
	array(
	'href' => 'mailto:'.$source.'?subject='.$subject
	),
	$source));
	}

	$project_phids = $task->getProjectPHIDs();
	if ($project_phids) {
	require_celerity_resource('maniphest-task-summary-css');

	// If we end up with real-world projects with many hundreds of columns, it
	// might be better to just load all the edges, then load those columns and
	// work backward that way, or denormalize this data more.

	$columns = id(new PhabricatorProjectColumnQuery())
	->setViewer($viewer)
	->withProjectPHIDs($project_phids)
	->execute();
	$columns = mpull($columns, null, 'getPHID');

	$column_edge_type = PhabricatorEdgeConfig::TYPE_OBJECT_HAS_COLUMN;
	$all_column_phids = array_keys($columns);

	$column_edge_query = id(new PhabricatorEdgeQuery())
	->withSourcePHIDs(array($task->getPHID()))
	->withEdgeTypes(array($column_edge_type))
	->withDestinationPHIDs($all_column_phids);
	$column_edge_query->execute();
	$in_column_phids = array_fuse($column_edge_query->getDestinationPHIDs());

	$column_groups = mgroup($columns, 'getProjectPHID');

	$project_rows = array();
	foreach ($project_phids as $project_phid) {
	$row = array();

	$handle = $this->getHandle($project_phid);
	$row[] = $handle->renderLink();

	$columns = idx($column_groups, $project_phid, array());
	$column = head(array_intersect_key($columns, $in_column_phids));
	if ($column) {
	$column_name = pht('(%s)', $column->getDisplayName());
	// TODO: This is really hacky but there's no cleaner way to do it
	// right now, T4022 should give us better tools for this.
	$column_href = str_replace(
	'project/view',
	'project/board',
	$handle->getURI());
	$column_link = phutil_tag(
	'a',
	array(
	'href' => $column_href,
	'class' => 'maniphest-board-link',
	),
	$column_name);

	$row[] = ' ';
	$row[] = $column_link;
	}

	$project_rows[] = phutil_tag('div', array(), $row);
	}
	} else {
	$project_rows = phutil_tag('em', array(), pht('None'));
	}

	$view->addProperty(pht('Projects'), $project_rows);

	$edge_types = array(
	PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK
	=> pht('Dependent Tasks'),
	PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK
	=> pht('Depends On'),
	PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV
	=> pht('Differential Revisions'),
	PhabricatorEdgeConfig::TYPE_TASK_HAS_MOCK
	=> pht('Pholio Mocks'),
	);

	$revisions_commits = array();
	$handles = $this->getLoadedHandles();

	$commit_phids = array_keys(
	$edges[PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT]);
	if ($commit_phids) {
	$commit_drev = PhabricatorEdgeConfig::TYPE_COMMIT_HAS_DREV;
	$drev_edges = id(new PhabricatorEdgeQuery())
	->withSourcePHIDs($commit_phids)
	->withEdgeTypes(array($commit_drev))
	->execute();

	foreach ($commit_phids as $phid) {
	$revisions_commits[$phid] = $handles[$phid]->renderLink();
	$revision_phid = key($drev_edges[$phid][$commit_drev]);
	$revision_handle = idx($handles, $revision_phid);
	if ($revision_handle) {
	$task_drev = PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV;
	unset($edges[$task_drev][$revision_phid]);
	$revisions_commits[$phid] = hsprintf(
	'%s / %s',
	$revision_handle->renderLink($revision_handle->getName()),
	$revisions_commits[$phid]);
	}
	}
	}

	foreach ($edge_types as $edge_type => $edge_name) {
	if ($edges[$edge_type]) {
	$view->addProperty(
	$edge_name,
	$this->renderHandlesForPHIDs(array_keys($edges[$edge_type])));
	}
	}

	if ($revisions_commits) {
	$view->addProperty(
	pht('Commits'),
	phutil_implode_html(phutil_tag('br'), $revisions_commits));
	}

	$attached = $task->getAttached();
	if (!is_array($attached)) {
	$attached = array();
	}

	$file_infos = idx($attached, PhabricatorFilePHIDTypeFile::TYPECONST);
	if ($file_infos) {
	$file_phids = array_keys($file_infos);

	// TODO: These should probably be handles or something; clean this up
	// as we sort out file attachments.
	$files = id(new PhabricatorFileQuery())
	->setViewer($viewer)
	->withPHIDs($file_phids)
	->execute();

	$file_view = new PhabricatorFileLinkListView();
	$file_view->setFiles($files);

	$view->addProperty(
	pht('Files'),
	$file_view->render());
	}

	$field_list->appendFieldsToPropertyList(
	$task,
	$viewer,
	$view);

	$view->invokeWillRenderEvent();

	return $view;
	}

	private function buildDescriptionView(
	ManiphestTask $task,
	PhabricatorMarkupEngine $engine) {

	$section = null;
	if (strlen($task->getDescription())) {
	$section = new PHUIPropertyListView();
	$section->addSectionHeader(
	pht('Description'),
	PHUIPropertyListView::ICON_SUMMARY);
	$section->addTextContent(
	phutil_tag(
	'div',
	array(
	'class' => 'phabricator-remarkup',
	),
	$engine->getOutput($task, ManiphestTask::MARKUP_FIELD_DESCRIPTION)));
	}

	return $section;
	}

	}
	diff --git a/src/applications/maniphest/controller/ManiphestTaskEditController.php b/src/applications/maniphest/controller/ManiphestTaskEditController.php
	index 8c21a332ec..8ecd438cce 100644
	--- a/src/applications/maniphest/controller/ManiphestTaskEditController.php
	+++ b/src/applications/maniphest/controller/ManiphestTaskEditController.php
	@@ -1,772 +1,730 @@
	<?php

	final class ManiphestTaskEditController extends ManiphestController {

	private $id;

	public function willProcessRequest(array $data) {
	$this->id = idx($data, 'id');
	}

	public function processRequest() {

	$request = $this->getRequest();
	$user = $request->getUser();
	$response_type = $request->getStr('responseType', 'task');

	$can_edit_assign = $this->hasApplicationCapability(
	ManiphestCapabilityEditAssign::CAPABILITY);
	$can_edit_policies = $this->hasApplicationCapability(
	ManiphestCapabilityEditPolicies::CAPABILITY);
	$can_edit_priority = $this->hasApplicationCapability(
	ManiphestCapabilityEditPriority::CAPABILITY);
	$can_edit_projects = $this->hasApplicationCapability(
	ManiphestCapabilityEditProjects::CAPABILITY);
	$can_edit_status = $this->hasApplicationCapability(
	ManiphestCapabilityEditStatus::CAPABILITY);

	- $files = array();
	$parent_task = null;
	$template_id = null;

	if ($this->id) {
	$task = id(new ManiphestTaskQuery())
	->setViewer($user)
	->requireCapabilities(
	array(
	PhabricatorPolicyCapability::CAN_VIEW,
	PhabricatorPolicyCapability::CAN_EDIT,
	))
	->withIDs(array($this->id))
	->executeOne();
	if (!$task) {
	return new Aphront404Response();
	}
	} else {
	$task = ManiphestTask::initializeNewTask($user);

	// We currently do not allow you to set the task status when creating
	// a new task, although now that statuses are custom it might make
	// sense.
	$can_edit_status = false;

	// These allow task creation with defaults.
	if (!$request->isFormPost()) {
	$task->setTitle($request->getStr('title'));

	if ($can_edit_projects) {
	$projects = $request->getStr('projects');
	if ($projects) {
	$tokens = $request->getStrList('projects');

	foreach ($tokens as $key => $token) {
	$tokens[$key] = '#'.$token;
	}

	$default_projects = id(new PhabricatorObjectQuery())
	->setViewer($user)
	->withNames($tokens)
	->execute();
	$default_projects = mpull($default_projects, 'getPHID');

	if ($default_projects) {
	$task->setProjectPHIDs($default_projects);
	}
	}
	}

	if ($can_edit_priority) {
	$priority = $request->getInt('priority');
	if ($priority !== null) {
	$priority_map = ManiphestTaskPriority::getTaskPriorityMap();
	if (isset($priority_map[$priority])) {
	$task->setPriority($priority);
	}
	}
	}

	$task->setDescription($request->getStr('description'));

	if ($can_edit_assign) {
	$assign = $request->getStr('assign');
	if (strlen($assign)) {
	$assign_user = id(new PhabricatorPeopleQuery())
	->setViewer($user)
	->withUsernames(array($assign))
	->executeOne();
	if (!$assign_user) {
	$assign_user = id(new PhabricatorPeopleQuery())
	->setViewer($user)
	->withPHIDs(array($assign))
	->executeOne();
	}

	if ($assign_user) {
	$task->setOwnerPHID($assign_user->getPHID());
	}
	}
	}
	}

	- $file_phids = $request->getArr('files', array());
	- if (!$file_phids) {
	- // Allow a single 'file' key instead, mostly since Mac OS X urlencodes
	- // square brackets in URLs when passed to 'open', so you can't 'open'
	- // a URL like '?files[]=xyz' and have PHP interpret it correctly.
	- $phid = $request->getStr('file');
	- if ($phid) {
	- $file_phids = array($phid);
	- }
	- }
	-
	- if ($file_phids) {
	- $files = id(new PhabricatorFileQuery())
	- ->setViewer($user)
	- ->withPHIDs($file_phids)
	- ->execute();
	- }
	-
	$template_id = $request->getInt('template');

	// You can only have a parent task if you're creating a new task.
	$parent_id = $request->getInt('parent');
	if ($parent_id) {
	$parent_task = id(new ManiphestTaskQuery())
	->setViewer($user)
	->withIDs(array($parent_id))
	->executeOne();
	if (!$template_id) {
	$template_id = $parent_id;
	}
	}
	}

	$errors = array();
	$e_title = true;

	$field_list = PhabricatorCustomField::getObjectFields(
	$task,
	PhabricatorCustomField::ROLE_EDIT);
	$field_list->setViewer($user);
	$field_list->readFieldsFromStorage($task);

	$aux_fields = $field_list->getFields();

	if ($request->isFormPost()) {
	$changes = array();

	$new_title = $request->getStr('title');
	$new_desc = $request->getStr('description');
	$new_status = $request->getStr('status');

	if (!$task->getID()) {
	$workflow = 'create';
	} else {
	$workflow = '';
	}

	$changes[ManiphestTransaction::TYPE_TITLE] = $new_title;
	$changes[ManiphestTransaction::TYPE_DESCRIPTION] = $new_desc;

	if ($can_edit_status) {
	$changes[ManiphestTransaction::TYPE_STATUS] = $new_status;
	} else if (!$task->getID()) {
	// Create an initial status transaction for the burndown chart.
	// TODO: We can probably remove this once Facts comes online.
	$changes[ManiphestTransaction::TYPE_STATUS] = $task->getStatus();
	}

	$owner_tokenizer = $request->getArr('assigned_to');
	$owner_phid = reset($owner_tokenizer);

	if (!strlen($new_title)) {
	$e_title = pht('Required');
	$errors[] = pht('Title is required.');
	}

	$old_values = array();
	foreach ($aux_fields as $aux_arr_key => $aux_field) {
	// TODO: This should be buildFieldTransactionsFromRequest() once we
	// switch to ApplicationTransactions properly.

	$aux_old_value = $aux_field->getOldValueForApplicationTransactions();
	$aux_field->readValueFromRequest($request);
	$aux_new_value = $aux_field->getNewValueForApplicationTransactions();

	// TODO: We're faking a call to the ApplicaitonTransaction validation
	// logic here. We need valid objects to pass, but they aren't used
	// in a meaningful way. For now, build User objects. Once the Maniphest
	// objects exist, this will switch over automatically. This is a big
	// hack but shouldn't be long for this world.
	$placeholder_editor = new PhabricatorUserProfileEditor();

	$field_errors = $aux_field->validateApplicationTransactions(
	$placeholder_editor,
	PhabricatorTransactions::TYPE_CUSTOMFIELD,
	array(
	id(new ManiphestTransaction())
	->setOldValue($aux_old_value)
	->setNewValue($aux_new_value),
	));

	foreach ($field_errors as $error) {
	$errors[] = $error->getMessage();
	}

	$old_values[$aux_field->getFieldKey()] = $aux_old_value;
	}

	if ($errors) {
	$task->setTitle($new_title);
	$task->setDescription($new_desc);
	$task->setPriority($request->getInt('priority'));
	$task->setOwnerPHID($owner_phid);
	$task->setCCPHIDs($request->getArr('cc'));
	$task->setProjectPHIDs($request->getArr('projects'));
	} else {

	if ($can_edit_priority) {
	$changes[ManiphestTransaction::TYPE_PRIORITY] =
	$request->getInt('priority');
	}
	if ($can_edit_assign) {
	$changes[ManiphestTransaction::TYPE_OWNER] = $owner_phid;
	}

	$changes[ManiphestTransaction::TYPE_CCS] = $request->getArr('cc');

	if ($can_edit_projects) {
	$projects = $request->getArr('projects');
	$changes[ManiphestTransaction::TYPE_PROJECTS] =
	$projects;
	$column_phid = $request->getStr('columnPHID');
	// allow for putting a task in a project column at creation -only-
	if (!$task->getID() && $column_phid && $projects) {
	$column = id(new PhabricatorProjectColumnQuery())
	->setViewer($user)
	->withProjectPHIDs($projects)
	->withPHIDs(array($column_phid))
	->executeOne();
	if ($column) {
	$changes[ManiphestTransaction::TYPE_PROJECT_COLUMN] =
	array(
	'new' => array(
	'projectPHID' => $column->getProjectPHID(),
	'columnPHIDs' => array($column_phid)),
	'old' => array(
	'projectPHID' => $column->getProjectPHID(),
	'columnPHIDs' => array()));
	}
	}
	}

	if ($can_edit_policies) {
	$changes[PhabricatorTransactions::TYPE_VIEW_POLICY] =
	$request->getStr('viewPolicy');
	$changes[PhabricatorTransactions::TYPE_EDIT_POLICY] =
	$request->getStr('editPolicy');
	}

	- if ($files) {
	- $file_map = mpull($files, 'getPHID');
	- $file_map = array_fill_keys($file_map, array());
	- $changes[ManiphestTransaction::TYPE_ATTACH] = array(
	- PhabricatorFilePHIDTypeFile::TYPECONST => $file_map,
	- );
	- }
	-
	$template = new ManiphestTransaction();
	$transactions = array();

	foreach ($changes as $type => $value) {
	$transaction = clone $template;
	$transaction->setTransactionType($type);
	if ($type == ManiphestTransaction::TYPE_PROJECT_COLUMN) {
	$transaction->setNewValue($value['new']);
	$transaction->setOldValue($value['old']);
	} else {
	$transaction->setNewValue($value);
	}
	$transactions[] = $transaction;
	}

	if ($aux_fields) {
	foreach ($aux_fields as $aux_field) {
	$transaction = clone $template;
	$transaction->setTransactionType(
	PhabricatorTransactions::TYPE_CUSTOMFIELD);
	$aux_key = $aux_field->getFieldKey();
	$transaction->setMetadataValue('customfield:key', $aux_key);
	$old = idx($old_values, $aux_key);
	$new = $aux_field->getNewValueForApplicationTransactions();

	$transaction->setOldValue($old);
	$transaction->setNewValue($new);

	$transactions[] = $transaction;
	}
	}

	if ($transactions) {
	$is_new = !$task->getID();

	$event = new PhabricatorEvent(
	PhabricatorEventType::TYPE_MANIPHEST_WILLEDITTASK,
	array(
	'task' => $task,
	'new' => $is_new,
	'transactions' => $transactions,
	));
	$event->setUser($user);
	$event->setAphrontRequest($request);
	PhutilEventEngine::dispatchEvent($event);

	$task = $event->getValue('task');
	$transactions = $event->getValue('transactions');

	$editor = id(new ManiphestTransactionEditor())
	->setActor($user)
	->setContentSourceFromRequest($request)
	->setContinueOnNoEffect(true)
	->applyTransactions($task, $transactions);

	$event = new PhabricatorEvent(
	PhabricatorEventType::TYPE_MANIPHEST_DIDEDITTASK,
	array(
	'task' => $task,
	'new' => $is_new,
	'transactions' => $transactions,
	));
	$event->setUser($user);
	$event->setAphrontRequest($request);
	PhutilEventEngine::dispatchEvent($event);
	}


	if ($parent_task) {
	id(new PhabricatorEdgeEditor())
	->setActor($user)
	->addEdge(
	$parent_task->getPHID(),
	PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK,
	$task->getPHID())
	->save();
	$workflow = $parent_task->getID();
	}

	if ($request->isAjax()) {
	switch ($response_type) {
	case 'card':
	$owner = null;
	if ($task->getOwnerPHID()) {
	$owner = id(new PhabricatorHandleQuery())
	->setViewer($user)
	->withPHIDs(array($task->getOwnerPHID()))
	->executeOne();
	}
	$tasks = id(new ProjectBoardTaskCard())
	->setViewer($user)
	->setTask($task)
	->setOwner($owner)
	->setCanEdit(true)
	->getItem();
	$column_phid = $request->getStr('columnPHID');
	$column = id(new PhabricatorProjectColumnQuery())
	->setViewer($user)
	->withPHIDs(array($column_phid))
	->executeOne();
	if ($column->isDefaultColumn()) {
	$column_tasks = array();
	$potential_col_tasks = id(new ManiphestTaskQuery())
	->setViewer($user)
	->withAllProjects(array($column->getProjectPHID()))
	->withStatuses(ManiphestTaskStatus::getOpenStatusConstants())
	->setOrderBy(ManiphestTaskQuery::ORDER_PRIORITY)
	->execute();
	$potential_col_tasks = mpull(
	$potential_col_tasks,
	null,
	'getPHID');
	$potential_task_phids = array_keys($potential_col_tasks);
	if ($potential_task_phids) {
	$edge_type = PhabricatorEdgeConfig::TYPE_OBJECT_HAS_COLUMN;
	$edge_query = id(new PhabricatorEdgeQuery())
	->withSourcePHIDs($potential_task_phids)
	->withEdgeTypes(array($edge_type));
	$edges = $edge_query->execute();
	foreach ($potential_col_tasks as $task_phid => $curr_task) {
	$curr_column_phids = $edges[$task_phid][$edge_type];
	$curr_column_phid = head_key($curr_column_phids);
	if (!$curr_column_phid \|\|
	$curr_column_phid == $column_phid) {
	$column_tasks[] = $curr_task;
	}
	}
	}
	} else {
	$column_task_phids = PhabricatorEdgeQuery::loadDestinationPHIDs(
	$column_phid,
	PhabricatorEdgeConfig::TYPE_COLUMN_HAS_OBJECT);
	$column_tasks = id(new ManiphestTaskQuery())
	->setViewer($user)
	->withPHIDs($column_task_phids)
	->withStatuses(ManiphestTaskStatus::getOpenStatusConstants())
	->setOrderBy(ManiphestTaskQuery::ORDER_PRIORITY)
	->execute();
	}
	$column_task_phids = mpull($column_tasks, 'getPHID');
	$task_phid = $task->getPHID();
	$after_phid = null;
	foreach ($column_task_phids as $phid) {
	if ($phid == $task_phid) {
	break;
	}
	$after_phid = $phid;
	}
	$data = array(
	'insertAfterPHID' => $after_phid);
	break;
	case 'task':
	default:
	$tasks = $this->renderSingleTask($task);
	$data = array();
	break;
	}
	return id(new AphrontAjaxResponse())->setContent(
	array(
	'tasks' => $tasks,
	'data' => $data,
	));
	}

	$redirect_uri = '/T'.$task->getID();

	if ($workflow) {
	$redirect_uri .= '?workflow='.$workflow;
	}

	return id(new AphrontRedirectResponse())
	->setURI($redirect_uri);
	}
	} else {
	if (!$task->getID()) {
	$task->setCCPHIDs(array(
	$user->getPHID(),
	));
	if ($template_id) {
	$template_task = id(new ManiphestTaskQuery())
	->setViewer($user)
	->withIDs(array($template_id))
	->executeOne();
	if ($template_task) {
	$task->setCCPHIDs($template_task->getCCPHIDs());
	$task->setProjectPHIDs($template_task->getProjectPHIDs());
	$task->setOwnerPHID($template_task->getOwnerPHID());
	$task->setPriority($template_task->getPriority());
	$task->setViewPolicy($template_task->getViewPolicy());
	$task->setEditPolicy($template_task->getEditPolicy());

	$template_fields = PhabricatorCustomField::getObjectFields(
	$template_task,
	PhabricatorCustomField::ROLE_EDIT);

	$fields = $template_fields->getFields();
	foreach ($fields as $key => $field) {
	if (!$field->shouldCopyWhenCreatingSimilarTask()) {
	unset($fields[$key]);
	}
	if (empty($aux_fields[$key])) {
	unset($fields[$key]);
	}
	}

	if ($fields) {
	id(new PhabricatorCustomFieldList($fields))
	->setViewer($user)
	->readFieldsFromStorage($template_task);

	foreach ($fields as $key => $field) {
	$aux_fields[$key]->setValueFromStorage(
	$field->getValueForStorage());
	}
	}
	}
	}
	}
	}

	$phids = array_merge(
	array($task->getOwnerPHID()),
	$task->getCCPHIDs(),
	$task->getProjectPHIDs());

	if ($parent_task) {
	$phids[] = $parent_task->getPHID();
	}

	$phids = array_filter($phids);
	$phids = array_unique($phids);

	$handles = $this->loadViewerHandles($phids);

	$error_view = null;
	if ($errors) {
	$error_view = new AphrontErrorView();
	$error_view->setErrors($errors);
	}

	$priority_map = ManiphestTaskPriority::getTaskPriorityMap();

	if ($task->getOwnerPHID()) {
	$assigned_value = array($handles[$task->getOwnerPHID()]);
	} else {
	$assigned_value = array();
	}

	if ($task->getCCPHIDs()) {
	$cc_value = array_select_keys($handles, $task->getCCPHIDs());
	} else {
	$cc_value = array();
	}

	if ($task->getProjectPHIDs()) {
	$projects_value = array_select_keys($handles, $task->getProjectPHIDs());
	} else {
	$projects_value = array();
	}

	$cancel_id = nonempty($task->getID(), $template_id);
	if ($cancel_id) {
	$cancel_uri = '/T'.$cancel_id;
	} else {
	$cancel_uri = '/maniphest/';
	}

	if ($task->getID()) {
	$button_name = pht('Save Task');
	$header_name = pht('Edit Task');
	} else if ($parent_task) {
	$cancel_uri = '/T'.$parent_task->getID();
	$button_name = pht('Create Task');
	$header_name = pht('Create New Subtask');
	} else {
	$button_name = pht('Create Task');
	$header_name = pht('Create New Task');
	}

	require_celerity_resource('maniphest-task-edit-css');

	$project_tokenizer_id = celerity_generate_unique_node_id();

	$form = new AphrontFormView();
	$form
	->setUser($user)
	->addHiddenInput('template', $template_id)
	->addHiddenInput('responseType', $response_type)
	->addHiddenInput('columnPHID', $request->getStr('columnPHID'));

	if ($parent_task) {
	$form
	->appendChild(
	id(new AphrontFormStaticControl())
	->setLabel(pht('Parent Task'))
	->setValue($handles[$parent_task->getPHID()]->getFullName()))
	->addHiddenInput('parent', $parent_task->getID());
	}

	$form
	->appendChild(
	id(new AphrontFormTextAreaControl())
	->setLabel(pht('Title'))
	->setName('title')
	->setError($e_title)
	->setHeight(AphrontFormTextAreaControl::HEIGHT_VERY_SHORT)
	->setValue($task->getTitle()));

	if ($can_edit_status) {
	$form
	->appendChild(
	id(new AphrontFormSelectControl())
	->setLabel(pht('Status'))
	->setName('status')
	->setValue($task->getStatus())
	->setOptions(ManiphestTaskStatus::getTaskStatusMap()));
	}

	$policies = id(new PhabricatorPolicyQuery())
	->setViewer($user)
	->setObject($task)
	->execute();

	if ($can_edit_assign) {
	$form->appendChild(
	id(new AphrontFormTokenizerControl())
	->setLabel(pht('Assigned To'))
	->setName('assigned_to')
	->setValue($assigned_value)
	->setUser($user)
	->setDatasource('/typeahead/common/users/')
	->setLimit(1));
	}

	$form
	->appendChild(
	id(new AphrontFormTokenizerControl())
	->setLabel(pht('CC'))
	->setName('cc')
	->setValue($cc_value)
	->setUser($user)
	->setDatasource('/typeahead/common/mailable/'));

	if ($can_edit_priority) {
	$form
	->appendChild(
	id(new AphrontFormSelectControl())
	->setLabel(pht('Priority'))
	->setName('priority')
	->setOptions($priority_map)
	->setValue($task->getPriority()));
	}

	if ($can_edit_policies) {
	$form
	->appendChild(
	id(new AphrontFormPolicyControl())
	->setUser($user)
	->setCapability(PhabricatorPolicyCapability::CAN_VIEW)
	->setPolicyObject($task)
	->setPolicies($policies)
	->setName('viewPolicy'))
	->appendChild(
	id(new AphrontFormPolicyControl())
	->setUser($user)
	->setCapability(PhabricatorPolicyCapability::CAN_EDIT)
	->setPolicyObject($task)
	->setPolicies($policies)
	->setName('editPolicy'));
	}

	if ($can_edit_projects) {
	$form
	->appendChild(
	id(new AphrontFormTokenizerControl())
	->setLabel(pht('Projects'))
	->setName('projects')
	->setValue($projects_value)
	->setID($project_tokenizer_id)
	->setCaption(
	javelin_tag(
	'a',
	array(
	'href' => '/project/create/',
	'mustcapture' => true,
	'sigil' => 'project-create',
	),
	pht('Create New Project')))
	->setDatasource('/typeahead/common/projects/'));
	}

	$field_list->appendFieldsToForm($form);

	require_celerity_resource('aphront-error-view-css');

	Javelin::initBehavior('project-create', array(
	'tokenizerID' => $project_tokenizer_id,
	));

	- if ($files) {
	- $file_display = mpull($files, 'getName');
	- $file_display = phutil_implode_html(phutil_tag('br'), $file_display);
	-
	- $form->appendChild(
	- id(new AphrontFormMarkupControl())
	- ->setLabel(pht('Files'))
	- ->setValue($file_display));
	-
	- foreach ($files as $ii => $file) {
	- $form->addHiddenInput('files['.$ii.']', $file->getPHID());
	- }
	- }
	-
	-
	$description_control = new PhabricatorRemarkupControl();
	// "Upsell" creating tasks via email in create flows if the instance is
	// configured for this awesomeness.
	$email_create = PhabricatorEnv::getEnvConfig(
	'metamta.maniphest.public-create-email');
	if (!$task->getID() && $email_create) {
	$email_hint = pht(
	'You can also create tasks by sending an email to: %s',
	phutil_tag('tt', array(), $email_create));
	$description_control->setCaption($email_hint);
	}

	$description_control
	->setLabel(pht('Description'))
	->setName('description')
	->setID('description-textarea')
	->setValue($task->getDescription())
	->setUser($user);

	$form
	->appendChild($description_control);


	if ($request->isAjax()) {
	$dialog = id(new AphrontDialogView())
	->setUser($user)
	->setWidth(AphrontDialogView::WIDTH_FULL)
	->setTitle($header_name)
	->appendChild(
	array(
	$error_view,
	$form->buildLayoutView(),
	))
	->addCancelButton($cancel_uri)
	->addSubmitButton($button_name);
	return id(new AphrontDialogResponse())->setDialog($dialog);
	}

	$form
	->appendChild(
	id(new AphrontFormSubmitControl())
	->addCancelButton($cancel_uri)
	->setValue($button_name));

	$form_box = id(new PHUIObjectBoxView())
	->setHeaderText($header_name)
	->setFormErrors($errors)
	->setForm($form);

	$preview = id(new PHUIRemarkupPreviewPanel())
	->setHeader(pht('Description Preview'))
	->setControlID('description-textarea')
	->setPreviewURI($this->getApplicationURI('task/descriptionpreview/'));

	if ($task->getID()) {
	$page_objects = array($task->getPHID());
	} else {
	$page_objects = array();
	}

	$crumbs = $this->buildApplicationCrumbs();

	if ($task->getID()) {
	$crumbs->addTextCrumb('T'.$task->getID(), '/T'.$task->getID());
	}

	$crumbs->addTextCrumb($header_name);

	return $this->buildApplicationPage(
	array(
	$crumbs,
	$form_box,
	$preview,
	),
	array(
	'title' => $header_name,
	'pageObjects' => $page_objects,
	'device' => true,
	));
	}
	}
	diff --git a/src/applications/maniphest/controller/ManiphestTransactionSaveController.php b/src/applications/maniphest/controller/ManiphestTransactionSaveController.php
	index 2ca12c1846..48686842e6 100644
	--- a/src/applications/maniphest/controller/ManiphestTransactionSaveController.php
	+++ b/src/applications/maniphest/controller/ManiphestTransactionSaveController.php
	@@ -1,266 +1,213 @@
	<?php

	final class ManiphestTransactionSaveController extends ManiphestController {

	public function processRequest() {
	$request = $this->getRequest();
	$user = $request->getUser();

	$task = id(new ManiphestTaskQuery())
	->setViewer($user)
	->withIDs(array($request->getStr('taskID')))
	->executeOne();
	if (!$task) {
	return new Aphront404Response();
	}

	$task_uri = '/'.$task->getMonogram();

	$transactions = array();

	$action = $request->getStr('action');

	- // If we have drag-and-dropped files, attach them first in a separate
	- // transaction. These can come in on any transaction type, which is why we
	- // handle them separately.
	- $files = array();
	-
	- // Look for drag-and-drop uploads first.
	- $file_phids = $request->getArr('files');
	- if ($file_phids) {
	- $files = id(new PhabricatorFileQuery())
	- ->setViewer($user)
	- ->withPHIDs(array($file_phids))
	- ->execute();
	- }
	-
	- // This means "attach a file" even though we store other types of data
	- // as 'attached'.
	- if ($action == ManiphestTransaction::TYPE_ATTACH) {
	- if (!empty($_FILES['file'])) {
	- $err = idx($_FILES['file'], 'error');
	- if ($err != UPLOAD_ERR_NO_FILE) {
	- $file = PhabricatorFile::newFromPHPUpload(
	- $_FILES['file'],
	- array(
	- 'authorPHID' => $user->getPHID(),
	- ));
	- $files[] = $file;
	- }
	- }
	- }
	-
	- // If we had explicit or drag-and-drop files, create a transaction
	- // for those before we deal with whatever else might have happened.
	- $file_transaction = null;
	- if ($files) {
	- $files = mpull($files, 'getPHID', 'getPHID');
	- $new = $task->getAttached();
	- foreach ($files as $phid) {
	- if (empty($new[PhabricatorFilePHIDTypeFile::TYPECONST])) {
	- $new[PhabricatorFilePHIDTypeFile::TYPECONST] = array();
	- }
	- $new[PhabricatorFilePHIDTypeFile::TYPECONST][$phid] = array();
	- }
	- $transaction = new ManiphestTransaction();
	- $transaction
	- ->setTransactionType(ManiphestTransaction::TYPE_ATTACH);
	- $transaction->setNewValue($new);
	- $transactions[] = $transaction;
	- }
	-
	// Compute new CCs added by @mentions. Several things can cause CCs to
	// be added as side effects: mentions, explicit CCs, users who aren't
	// CC'd interacting with the task, and ownership changes. We build up a
	// list of all the CCs and then construct a transaction for them at the
	// end if necessary.
	$added_ccs = PhabricatorMarkupEngine::extractPHIDsFromMentions(
	array(
	$request->getStr('comments'),
	));

	$cc_transaction = new ManiphestTransaction();
	$cc_transaction
	->setTransactionType(ManiphestTransaction::TYPE_CCS);

	$transaction = new ManiphestTransaction();
	$transaction
	->setTransactionType($action);

	switch ($action) {
	case ManiphestTransaction::TYPE_STATUS:
	$transaction->setNewValue($request->getStr('resolution'));
	break;
	case ManiphestTransaction::TYPE_OWNER:
	$assign_to = $request->getArr('assign_to');
	$assign_to = reset($assign_to);
	$transaction->setNewValue($assign_to);
	break;
	case ManiphestTransaction::TYPE_PROJECTS:
	$projects = $request->getArr('projects');
	$projects = array_merge($projects, $task->getProjectPHIDs());
	$projects = array_filter($projects);
	$projects = array_unique($projects);
	$transaction->setNewValue($projects);
	break;
	case ManiphestTransaction::TYPE_CCS:
	// Accumulate the new explicit CCs into the array that we'll add in
	// the CC transaction later.
	$added_ccs = array_merge($added_ccs, $request->getArr('ccs'));

	// Throw away the primary transaction.
	$transaction = null;
	break;
	case ManiphestTransaction::TYPE_PRIORITY:
	$transaction->setNewValue($request->getInt('priority'));
	break;
	- case ManiphestTransaction::TYPE_ATTACH:
	- // Nuke this, we created it above.
	- $transaction = null;
	- break;
	case PhabricatorTransactions::TYPE_COMMENT:
	// Nuke this, we're going to create it below.
	$transaction = null;
	break;
	default:
	throw new Exception('unknown action');
	}

	if ($transaction) {
	$transactions[] = $transaction;
	}

	$resolution = $request->getStr('resolution');
	$did_scuttle = false;
	if ($action !== ManiphestTransaction::TYPE_STATUS) {
	if ($request->getStr('scuttle')) {
	$transactions[] = id(new ManiphestTransaction())
	->setTransactionType(ManiphestTransaction::TYPE_STATUS)
	->setNewValue(ManiphestTaskStatus::getDefaultClosedStatus());
	$did_scuttle = true;
	$resolution = ManiphestTaskStatus::getDefaultClosedStatus();
	}
	}

	// When you interact with a task, we add you to the CC list so you get
	// further updates, and possibly assign the task to you if you took an
	// ownership action (closing it) but it's currently unowned. We also move
	// previous owners to CC if ownership changes. Detect all these conditions
	// and create side-effect transactions for them.

	$implicitly_claimed = false;
	if ($action == ManiphestTransaction::TYPE_OWNER) {
	if ($task->getOwnerPHID() == $transaction->getNewValue()) {
	// If this is actually no-op, don't generate the side effect.
	} else {
	// Otherwise, when a task is reassigned, move the previous owner to CC.
	$added_ccs[] = $task->getOwnerPHID();
	}
	}

	if ($did_scuttle \|\| ($action == ManiphestTransaction::TYPE_STATUS)) {
	if (!$task->getOwnerPHID() &&
	ManiphestTaskStatus::isClosedStatus($resolution)) {
	// Closing an unassigned task. Assign the user as the owner of
	// this task.
	$assign = new ManiphestTransaction();
	$assign->setTransactionType(ManiphestTransaction::TYPE_OWNER);
	$assign->setNewValue($user->getPHID());
	$transactions[] = $assign;

	$implicitly_claimed = true;
	}
	}

	$user_owns_task = false;
	if ($implicitly_claimed) {
	$user_owns_task = true;
	} else {
	if ($action == ManiphestTransaction::TYPE_OWNER) {
	if ($transaction->getNewValue() == $user->getPHID()) {
	$user_owns_task = true;
	}
	} else if ($task->getOwnerPHID() == $user->getPHID()) {
	$user_owns_task = true;
	}
	}

	if (!$user_owns_task) {
	// If we aren't making the user the new task owner and they aren't the
	// existing task owner, add them to CC unless they're aleady CC'd.
	if (!in_array($user->getPHID(), $task->getCCPHIDs())) {
	$added_ccs[] = $user->getPHID();
	}
	}

	// Evade no-effect detection in the new editor stuff until we can switch
	// to subscriptions.
	$added_ccs = array_filter(array_diff($added_ccs, $task->getCCPHIDs()));

	if ($added_ccs) {
	// We've added CCs, so include a CC transaction.
	$all_ccs = array_merge($task->getCCPHIDs(), $added_ccs);
	$cc_transaction->setNewValue($all_ccs);
	$transactions[] = $cc_transaction;
	}

	$comments = $request->getStr('comments');
	if (strlen($comments) \|\| !$transactions) {
	$transactions[] = id(new ManiphestTransaction())
	->setTransactionType(PhabricatorTransactions::TYPE_COMMENT)
	->attachComment(
	id(new ManiphestTransactionComment())
	->setContent($comments));
	}

	$event = new PhabricatorEvent(
	PhabricatorEventType::TYPE_MANIPHEST_WILLEDITTASK,
	array(
	'task' => $task,
	'new' => false,
	'transactions' => $transactions,
	));
	$event->setUser($user);
	$event->setAphrontRequest($request);
	PhutilEventEngine::dispatchEvent($event);

	$task = $event->getValue('task');
	$transactions = $event->getValue('transactions');

	$editor = id(new ManiphestTransactionEditor())
	->setActor($user)
	->setContentSourceFromRequest($request)
	->setContinueOnMissingFields(true)
	->setContinueOnNoEffect($request->isContinueRequest());

	try {
	$editor->applyTransactions($task, $transactions);
	} catch (PhabricatorApplicationTransactionNoEffectException $ex) {
	return id(new PhabricatorApplicationTransactionNoEffectResponse())
	->setCancelURI($task_uri)
	->setException($ex);
	}

	$draft = id(new PhabricatorDraft())->loadOneWhere(
	'authorPHID = %s AND draftKey = %s',
	$user->getPHID(),
	$task->getPHID());
	if ($draft) {
	$draft->delete();
	}

	$event = new PhabricatorEvent(
	PhabricatorEventType::TYPE_MANIPHEST_DIDEDITTASK,
	array(
	'task' => $task,
	'new' => false,
	'transactions' => $transactions,
	));
	$event->setUser($user);
	$event->setAphrontRequest($request);
	PhutilEventEngine::dispatchEvent($event);

	return id(new AphrontRedirectResponse())->setURI($task_uri);
	}

	}
	diff --git a/src/applications/maniphest/editor/ManiphestTransactionEditor.php b/src/applications/maniphest/editor/ManiphestTransactionEditor.php
	index 3b3c0e65ff..f7d9a957b1 100644
	--- a/src/applications/maniphest/editor/ManiphestTransactionEditor.php
	+++ b/src/applications/maniphest/editor/ManiphestTransactionEditor.php
	@@ -1,496 +1,490 @@
	<?php

	final class ManiphestTransactionEditor
	extends PhabricatorApplicationTransactionEditor {

	private $heraldEmailPHIDs = array();

	public function getTransactionTypes() {
	$types = parent::getTransactionTypes();

	$types[] = PhabricatorTransactions::TYPE_COMMENT;
	$types[] = ManiphestTransaction::TYPE_PRIORITY;
	$types[] = ManiphestTransaction::TYPE_STATUS;
	$types[] = ManiphestTransaction::TYPE_TITLE;
	$types[] = ManiphestTransaction::TYPE_DESCRIPTION;
	$types[] = ManiphestTransaction::TYPE_OWNER;
	$types[] = ManiphestTransaction::TYPE_CCS;
	$types[] = ManiphestTransaction::TYPE_PROJECTS;
	- $types[] = ManiphestTransaction::TYPE_ATTACH;
	$types[] = ManiphestTransaction::TYPE_EDGE;
	$types[] = ManiphestTransaction::TYPE_SUBPRIORITY;
	$types[] = ManiphestTransaction::TYPE_PROJECT_COLUMN;
	$types[] = PhabricatorTransactions::TYPE_VIEW_POLICY;
	$types[] = PhabricatorTransactions::TYPE_EDIT_POLICY;

	return $types;
	}

	protected function getCustomTransactionOldValue(
	PhabricatorLiskDAO $object,
	PhabricatorApplicationTransaction $xaction) {

	switch ($xaction->getTransactionType()) {
	case ManiphestTransaction::TYPE_PRIORITY:
	if ($this->getIsNewObject()) {
	return null;
	}
	return (int)$object->getPriority();
	case ManiphestTransaction::TYPE_STATUS:
	if ($this->getIsNewObject()) {
	return null;
	}
	return $object->getStatus();
	case ManiphestTransaction::TYPE_TITLE:
	if ($this->getIsNewObject()) {
	return null;
	}
	return $object->getTitle();
	case ManiphestTransaction::TYPE_DESCRIPTION:
	if ($this->getIsNewObject()) {
	return null;
	}
	return $object->getDescription();
	case ManiphestTransaction::TYPE_OWNER:
	return nonempty($object->getOwnerPHID(), null);
	case ManiphestTransaction::TYPE_CCS:
	return array_values(array_unique($object->getCCPHIDs()));
	case ManiphestTransaction::TYPE_PROJECTS:
	return array_values(array_unique($object->getProjectPHIDs()));
	- case ManiphestTransaction::TYPE_ATTACH:
	- return $object->getAttached();
	case ManiphestTransaction::TYPE_EDGE:
	case ManiphestTransaction::TYPE_PROJECT_COLUMN:
	// These are pre-populated.
	return $xaction->getOldValue();
	case ManiphestTransaction::TYPE_SUBPRIORITY:
	return $object->getSubpriority();
	}

	}

	protected function getCustomTransactionNewValue(
	PhabricatorLiskDAO $object,
	PhabricatorApplicationTransaction $xaction) {

	switch ($xaction->getTransactionType()) {
	case ManiphestTransaction::TYPE_PRIORITY:
	return (int)$xaction->getNewValue();
	case ManiphestTransaction::TYPE_CCS:
	case ManiphestTransaction::TYPE_PROJECTS:
	return array_values(array_unique($xaction->getNewValue()));
	case ManiphestTransaction::TYPE_OWNER:
	return nonempty($xaction->getNewValue(), null);
	case ManiphestTransaction::TYPE_STATUS:
	case ManiphestTransaction::TYPE_TITLE:
	case ManiphestTransaction::TYPE_DESCRIPTION:
	- case ManiphestTransaction::TYPE_ATTACH:
	case ManiphestTransaction::TYPE_EDGE:
	case ManiphestTransaction::TYPE_SUBPRIORITY:
	case ManiphestTransaction::TYPE_PROJECT_COLUMN:
	return $xaction->getNewValue();
	}
	}


	protected function transactionHasEffect(
	PhabricatorLiskDAO $object,
	PhabricatorApplicationTransaction $xaction) {

	$old = $xaction->getOldValue();
	$new = $xaction->getNewValue();

	switch ($xaction->getTransactionType()) {
	case ManiphestTransaction::TYPE_PROJECTS:
	case ManiphestTransaction::TYPE_CCS:
	sort($old);
	sort($new);
	return ($old !== $new);
	case ManiphestTransaction::TYPE_PROJECT_COLUMN:
	$new_column_phids = $new['columnPHIDs'];
	$old_column_phids = $old['columnPHIDs'];
	sort($new_column_phids);
	sort($old_column_phids);
	return ($old !== $new);
	}

	return parent::transactionHasEffect($object, $xaction);
	}

	protected function applyCustomInternalTransaction(
	PhabricatorLiskDAO $object,
	PhabricatorApplicationTransaction $xaction) {

	switch ($xaction->getTransactionType()) {
	case ManiphestTransaction::TYPE_PRIORITY:
	return $object->setPriority($xaction->getNewValue());
	case ManiphestTransaction::TYPE_STATUS:
	return $object->setStatus($xaction->getNewValue());
	case ManiphestTransaction::TYPE_TITLE:
	return $object->setTitle($xaction->getNewValue());
	case ManiphestTransaction::TYPE_DESCRIPTION:
	return $object->setDescription($xaction->getNewValue());
	case ManiphestTransaction::TYPE_OWNER:
	$phid = $xaction->getNewValue();

	// Update the "ownerOrdering" column to contain the full name of the
	// owner, if the task is assigned.

	$handle = null;
	if ($phid) {
	$handle = id(new PhabricatorHandleQuery())
	->setViewer($this->getActor())
	->withPHIDs(array($phid))
	->executeOne();
	}

	if ($handle) {
	$object->setOwnerOrdering($handle->getName());
	} else {
	$object->setOwnerOrdering(null);
	}

	return $object->setOwnerPHID($phid);
	case ManiphestTransaction::TYPE_CCS:
	return $object->setCCPHIDs($xaction->getNewValue());
	case ManiphestTransaction::TYPE_PROJECTS:
	return $object->setProjectPHIDs($xaction->getNewValue());
	- case ManiphestTransaction::TYPE_ATTACH:
	- return $object->setAttached($xaction->getNewValue());
	case ManiphestTransaction::TYPE_EDGE:
	// These are a weird, funky mess and are already being applied by the
	// time we reach this.
	return;
	case ManiphestTransaction::TYPE_SUBPRIORITY:
	$data = $xaction->getNewValue();
	$new_sub = $this->getNextSubpriority(
	$data['newPriority'],
	$data['newSubpriorityBase'],
	$data['direction']);
	$object->setSubpriority($new_sub);
	return;
	case ManiphestTransaction::TYPE_PROJECT_COLUMN:
	// these do external (edge) updates
	return;
	}

	}

	protected function expandTransaction(
	PhabricatorLiskDAO $object,
	PhabricatorApplicationTransaction $xaction) {

	$xactions = parent::expandTransaction($object, $xaction);
	switch ($xaction->getTransactionType()) {
	case ManiphestTransaction::TYPE_SUBPRIORITY:
	$data = $xaction->getNewValue();
	$new_pri = $data['newPriority'];
	if ($new_pri != $object->getPriority()) {
	$xactions[] = id(new ManiphestTransaction())
	->setTransactionType(ManiphestTransaction::TYPE_PRIORITY)
	->setNewValue($new_pri);
	}
	break;
	default:
	break;
	}

	return $xactions;
	}

	protected function applyCustomExternalTransaction(
	PhabricatorLiskDAO $object,
	PhabricatorApplicationTransaction $xaction) {

	switch ($xaction->getTransactionType()) {
	case ManiphestTransaction::TYPE_PROJECT_COLUMN:
	$new = $xaction->getNewValue();
	$old = $xaction->getOldValue();
	$src = $object->getPHID();
	$dst = head($new['columnPHIDs']);
	$edges = $old['columnPHIDs'];
	$edge_type = PhabricatorEdgeConfig::TYPE_OBJECT_HAS_COLUMN;
	// NOTE: Normally, we expect only one edge to exist, but this works in
	// a general way so it will repair any stray edges.
	$remove = array();
	$edge_missing = true;
	foreach ($edges as $phid) {
	if ($phid == $dst) {
	$edge_missing = false;
	} else {
	$remove[] = $phid;
	}
	}

	$add = array();
	if ($edge_missing) {
	$add[] = $dst;
	}

	// This should never happen because of the code in
	// transactionHasEffect, but keep it for maximum conservativeness
	if (!$add && !$remove) {
	return;
	}

	$editor = id(new PhabricatorEdgeEditor())
	->setActor($this->getActor())
	->setSuppressEvents(true);

	foreach ($add as $phid) {
	$editor->addEdge($src, $edge_type, $phid);
	}
	foreach ($remove as $phid) {
	$editor->removeEdge($src, $edge_type, $phid);
	}
	$editor->save();
	break;
	default:
	break;
	}
	}

	protected function shouldSendMail(
	PhabricatorLiskDAO $object,
	array $xactions) {

	$xactions = mfilter($xactions, 'shouldHide', true);
	return $xactions;
	}

	protected function getMailSubjectPrefix() {
	return PhabricatorEnv::getEnvConfig('metamta.maniphest.subject-prefix');
	}

	protected function getMailThreadID(PhabricatorLiskDAO $object) {
	return 'maniphest-task-'.$object->getPHID();
	}

	protected function getMailTo(PhabricatorLiskDAO $object) {
	return array(
	$object->getOwnerPHID(),
	$this->requireActor()->getPHID(),
	);
	}

	protected function getMailCC(PhabricatorLiskDAO $object) {
	$phids = array();

	foreach ($object->getCCPHIDs() as $phid) {
	$phids[] = $phid;
	}

	foreach ($this->heraldEmailPHIDs as $phid) {
	$phids[] = $phid;
	}

	return $phids;
	}

	protected function buildReplyHandler(PhabricatorLiskDAO $object) {
	return id(new ManiphestReplyHandler())
	->setMailReceiver($object);
	}

	protected function buildMailTemplate(PhabricatorLiskDAO $object) {
	$id = $object->getID();
	$title = $object->getTitle();

	return id(new PhabricatorMetaMTAMail())
	->setSubject("T{$id}: {$title}")
	->addHeader('Thread-Topic', "T{$id}: ".$object->getOriginalTitle());
	}

	protected function buildMailBody(
	PhabricatorLiskDAO $object,
	array $xactions) {

	$body = parent::buildMailBody($object, $xactions);

	if ($this->getIsNewObject()) {
	$body->addTextSection(
	pht('TASK DESCRIPTION'),
	$object->getDescription());
	}

	$body->addTextSection(
	pht('TASK DETAIL'),
	PhabricatorEnv::getProductionURI('/T'.$object->getID()));

	return $body;
	}

	protected function shouldPublishFeedStory(
	PhabricatorLiskDAO $object,
	array $xactions) {
	return $this->shouldSendMail($object, $xactions);
	}

	protected function supportsSearch() {
	return true;
	}

	protected function shouldApplyHeraldRules(
	PhabricatorLiskDAO $object,
	array $xactions) {
	return true;
	}

	protected function buildHeraldAdapter(
	PhabricatorLiskDAO $object,
	array $xactions) {

	return id(new HeraldManiphestTaskAdapter())
	->setTask($object);
	}

	protected function didApplyHeraldRules(
	PhabricatorLiskDAO $object,
	HeraldAdapter $adapter,
	HeraldTranscript $transcript) {

	// TODO: Convert these to transactions. The way Maniphest deals with these
	// transactions is currently unconventional and messy.

	$save_again = false;
	$cc_phids = $adapter->getCcPHIDs();
	if ($cc_phids) {
	$existing_cc = $object->getCCPHIDs();
	$new_cc = array_unique(array_merge($cc_phids, $existing_cc));
	$object->setCCPHIDs($new_cc);
	$save_again = true;
	}

	$project_phids = $adapter->getProjectPHIDs();
	if ($project_phids) {
	$existing_projects = $object->getProjectPHIDs();
	$new_projects = array_unique(
	array_merge($project_phids, $existing_projects));
	$object->setProjectPHIDs($new_projects);
	$save_again = true;
	}

	if ($save_again) {
	$object->save();
	}

	$this->heraldEmailPHIDs = $adapter->getEmailPHIDs();

	$xactions = array();

	$assign_phid = $adapter->getAssignPHID();
	if ($assign_phid) {
	$xactions[] = id(new ManiphestTransaction())
	->setTransactionType(ManiphestTransaction::TYPE_OWNER)
	->setNewValue($assign_phid);
	}

	return $xactions;
	}

	protected function requireCapabilities(
	PhabricatorLiskDAO $object,
	PhabricatorApplicationTransaction $xaction) {

	parent::requireCapabilities($object, $xaction);

	$app_capability_map = array(
	ManiphestTransaction::TYPE_PRIORITY =>
	ManiphestCapabilityEditPriority::CAPABILITY,
	ManiphestTransaction::TYPE_STATUS =>
	ManiphestCapabilityEditStatus::CAPABILITY,
	ManiphestTransaction::TYPE_PROJECTS =>
	ManiphestCapabilityEditProjects::CAPABILITY,
	ManiphestTransaction::TYPE_OWNER =>
	ManiphestCapabilityEditAssign::CAPABILITY,
	PhabricatorTransactions::TYPE_EDIT_POLICY =>
	ManiphestCapabilityEditPolicies::CAPABILITY,
	PhabricatorTransactions::TYPE_VIEW_POLICY =>
	ManiphestCapabilityEditPolicies::CAPABILITY,
	);

	$transaction_type = $xaction->getTransactionType();
	$app_capability = idx($app_capability_map, $transaction_type);

	if ($app_capability) {
	$app = id(new PhabricatorApplicationQuery())
	->setViewer($this->getActor())
	->withClasses(array('PhabricatorApplicationManiphest'))
	->executeOne();
	PhabricatorPolicyFilter::requireCapability(
	$this->getActor(),
	$app,
	$app_capability);
	}
	}

	protected function adjustObjectForPolicyChecks(
	PhabricatorLiskDAO $object,
	array $xactions) {

	$copy = parent::adjustObjectForPolicyChecks($object, $xactions);
	foreach ($xactions as $xaction) {
	switch ($xaction->getTransactionType()) {
	case ManiphestTransaction::TYPE_OWNER:
	$copy->setOwnerPHID($xaction->getNewValue());
	break;
	default:
	continue;
	}
	}

	return $copy;
	}

	private function getNextSubpriority($pri, $sub, $dir = '>') {

	switch ($dir) {
	case '>':
	$order = 'ASC';
	break;
	case '<':
	$order = 'DESC';
	break;
	default:
	throw new Exception('$dir must be ">" or "<".');
	break;
	}

	if ($sub === null) {
	$base = 0;
	} else {
	$base = $sub;
	}

	if ($sub === null) {
	$next = id(new ManiphestTask())->loadOneWhere(
	'priority = %d ORDER BY subpriority %Q LIMIT 1',
	$pri,
	$order);
	if ($next) {
	if ($dir == '>') {
	return $next->getSubpriority() - ((double)(2 << 16));
	} else {
	return $next->getSubpriority() + ((double)(2 << 16));
	}
	}
	} else {
	$next = id(new ManiphestTask())->loadOneWhere(
	'priority = %d AND subpriority %Q %f ORDER BY subpriority %Q LIMIT 1',
	$pri,
	$dir,
	$sub,
	$order);
	if ($next) {
	return ($sub + $next->getSubpriority()) / 2;
	}
	}

	if ($dir == '>') {
	return $base + (double)(2 << 32);
	} else {
	return $base - (double)(2 << 32);
	}
	}

	}
	diff --git a/src/applications/maniphest/storage/ManiphestTransaction.php b/src/applications/maniphest/storage/ManiphestTransaction.php
	index e7ef0af6f2..e05e0de0ed 100644
	--- a/src/applications/maniphest/storage/ManiphestTransaction.php
	+++ b/src/applications/maniphest/storage/ManiphestTransaction.php
	@@ -1,753 +1,756 @@
	<?php

	final class ManiphestTransaction
	extends PhabricatorApplicationTransaction {

	const TYPE_TITLE = 'title';
	const TYPE_STATUS = 'status';
	const TYPE_DESCRIPTION = 'description';
	const TYPE_OWNER = 'reassign';
	const TYPE_CCS = 'ccs';
	const TYPE_PROJECTS = 'projects';
	const TYPE_PRIORITY = 'priority';
	const TYPE_EDGE = 'edge';
	- const TYPE_ATTACH = 'attach';
	const TYPE_SUBPRIORITY = 'subpriority';
	const TYPE_PROJECT_COLUMN = 'projectcolumn';

	+ // NOTE: this type is deprecated. Keep it around for legacy installs
	+ // so any transactions render correctly.
	+ const TYPE_ATTACH = 'attach';
	+
	public function getApplicationName() {
	return 'maniphest';
	}

	public function getApplicationTransactionType() {
	return ManiphestPHIDTypeTask::TYPECONST;
	}

	public function getApplicationTransactionCommentObject() {
	return new ManiphestTransactionComment();
	}

	public function shouldGenerateOldValue() {
	switch ($this->getTransactionType()) {
	case self::TYPE_PROJECT_COLUMN:
	case self::TYPE_EDGE:
	return false;
	}

	return parent::shouldGenerateOldValue();
	}

	public function getRequiredHandlePHIDs() {
	$phids = parent::getRequiredHandlePHIDs();

	$new = $this->getNewValue();
	$old = $this->getOldValue();

	switch ($this->getTransactionType()) {
	case self::TYPE_OWNER:
	if ($new) {
	$phids[] = $new;
	}

	if ($old) {
	$phids[] = $old;
	}
	break;
	case self::TYPE_CCS:
	case self::TYPE_PROJECTS:
	$phids = array_mergev(
	array(
	$phids,
	nonempty($old, array()),
	nonempty($new, array()),
	));
	break;
	case self::TYPE_PROJECT_COLUMN:
	$phids[] = $new['projectPHID'];
	$phids[] = head($new['columnPHIDs']);
	break;
	case self::TYPE_EDGE:
	$phids = array_mergev(
	array(
	$phids,
	array_keys(nonempty($old, array())),
	array_keys(nonempty($new, array())),
	));
	break;
	case self::TYPE_ATTACH:
	$old = nonempty($old, array());
	$new = nonempty($new, array());
	$phids = array_mergev(
	array(
	$phids,
	array_keys(idx($new, 'FILE', array())),
	array_keys(idx($old, 'FILE', array())),
	));
	break;

	}

	return $phids;
	}

	public function shouldHide() {
	switch ($this->getTransactionType()) {
	case self::TYPE_DESCRIPTION:
	case self::TYPE_PRIORITY:
	case self::TYPE_STATUS:
	if ($this->getOldValue() === null) {
	return true;
	} else {
	return false;
	}
	break;
	case self::TYPE_SUBPRIORITY:
	return true;
	}

	return parent::shouldHide();
	}

	public function getActionStrength() {
	switch ($this->getTransactionType()) {
	case self::TYPE_TITLE:
	return 1.4;
	case self::TYPE_STATUS:
	return 1.3;
	case self::TYPE_OWNER:
	return 1.2;
	case self::TYPE_PRIORITY:
	return 1.1;
	}

	return parent::getActionStrength();
	}


	public function getColor() {
	$old = $this->getOldValue();
	$new = $this->getNewValue();

	switch ($this->getTransactionType()) {
	case self::TYPE_OWNER:
	if ($this->getAuthorPHID() == $new) {
	return 'green';
	} else if (!$new) {
	return 'black';
	} else if (!$old) {
	return 'green';
	} else {
	return 'green';
	}

	case self::TYPE_STATUS:
	$color = ManiphestTaskStatus::getStatusColor($new);
	if ($color !== null) {
	return $color;
	}

	if (ManiphestTaskStatus::isOpenStatus($new)) {
	return 'green';
	} else {
	return 'black';
	}

	case self::TYPE_PRIORITY:
	if ($old == ManiphestTaskPriority::getDefaultPriority()) {
	return 'green';
	} else if ($old > $new) {
	return 'grey';
	} else {
	return 'yellow';
	}

	}

	return parent::getColor();
	}

	public function getActionName() {
	$old = $this->getOldValue();
	$new = $this->getNewValue();

	switch ($this->getTransactionType()) {
	case self::TYPE_TITLE:
	if ($old === null) {
	return pht('Created');
	}

	return pht('Retitled');

	case self::TYPE_STATUS:
	$action = ManiphestTaskStatus::getStatusActionName($new);
	if ($action) {
	return $action;
	}

	$old_closed = ManiphestTaskStatus::isClosedStatus($old);
	$new_closed = ManiphestTaskStatus::isClosedStatus($new);

	if ($new_closed && !$old_closed) {
	return pht('Closed');
	} else if (!$new_closed && $old_closed) {
	return pht('Reopened');
	} else {
	return pht('Changed Status');
	}

	case self::TYPE_DESCRIPTION:
	return pht('Edited');

	case self::TYPE_OWNER:
	if ($this->getAuthorPHID() == $new) {
	return pht('Claimed');
	} else if (!$new) {
	return pht('Up For Grabs');
	} else if (!$old) {
	return pht('Assigned');
	} else {
	return pht('Reassigned');
	}

	case self::TYPE_CCS:
	return pht('Changed CC');

	case self::TYPE_PROJECTS:
	return pht('Changed Projects');

	case self::TYPE_PROJECT_COLUMN:
	return pht('Changed Project Column');

	case self::TYPE_PRIORITY:
	if ($old == ManiphestTaskPriority::getDefaultPriority()) {
	return pht('Triaged');
	} else if ($old > $new) {
	return pht('Lowered Priority');
	} else {
	return pht('Raised Priority');
	}

	case self::TYPE_EDGE:
	case self::TYPE_ATTACH:
	return pht('Attached');
	}

	return parent::getActionName();
	}

	public function getIcon() {
	$old = $this->getOldValue();
	$new = $this->getNewValue();

	switch ($this->getTransactionType()) {
	case self::TYPE_OWNER:
	return 'user';

	case self::TYPE_CCS:
	return 'meta-mta';

	case self::TYPE_TITLE:
	if ($old === null) {
	return 'create';
	}

	return 'edit';

	case self::TYPE_STATUS:
	$action = ManiphestTaskStatus::getStatusIcon($new);
	if ($action !== null) {
	return $action;
	}

	if (ManiphestTaskStatus::isClosedStatus($new)) {
	return 'check';
	} else {
	return 'edit';
	}

	case self::TYPE_DESCRIPTION:
	return 'edit';

	case self::TYPE_PROJECTS:
	return 'project';

	case self::TYPE_PROJECT_COLUMN:
	return 'workboard';

	case self::TYPE_PRIORITY:
	if ($old == ManiphestTaskPriority::getDefaultPriority()) {
	return 'normal-priority';
	return pht('Triaged');
	} else if ($old > $new) {
	return 'lower-priority';
	} else {
	return 'raise-priority';
	}

	case self::TYPE_EDGE:
	case self::TYPE_ATTACH:
	return 'attach';

	}

	return parent::getIcon();
	}



	public function getTitle() {
	$author_phid = $this->getAuthorPHID();

	$old = $this->getOldValue();
	$new = $this->getNewValue();

	switch ($this->getTransactionType()) {
	case self::TYPE_TITLE:
	if ($old === null) {
	return pht(
	'%s created this task.',
	$this->renderHandleLink($author_phid));
	}
	return pht(
	'%s changed the title from "%s" to "%s".',
	$this->renderHandleLink($author_phid),
	$old,
	$new);

	case self::TYPE_DESCRIPTION:
	return pht(
	'%s edited the task description.',
	$this->renderHandleLink($author_phid));

	case self::TYPE_STATUS:
	$old_closed = ManiphestTaskStatus::isClosedStatus($old);
	$new_closed = ManiphestTaskStatus::isClosedStatus($new);

	$old_name = ManiphestTaskStatus::getTaskStatusName($old);
	$new_name = ManiphestTaskStatus::getTaskStatusName($new);

	if ($new_closed && !$old_closed) {
	if ($new == ManiphestTaskStatus::getDuplicateStatus()) {
	return pht(
	'%s closed this task as a duplicate.',
	$this->renderHandleLink($author_phid));
	} else {
	return pht(
	'%s closed this task as "%s".',
	$this->renderHandleLink($author_phid),
	$new_name);
	}
	} else if (!$new_closed && $old_closed) {
	return pht(
	'%s reopened this task as "%s".',
	$this->renderHandleLink($author_phid),
	$new_name);
	} else {
	return pht(
	'%s changed the task status from "%s" to "%s".',
	$this->renderHandleLink($author_phid),
	$old_name,
	$new_name);
	}

	case self::TYPE_OWNER:
	if ($author_phid == $new) {
	return pht(
	'%s claimed this task.',
	$this->renderHandleLink($author_phid));
	} else if (!$new) {
	return pht(
	'%s placed this task up for grabs.',
	$this->renderHandleLink($author_phid));
	} else if (!$old) {
	return pht(
	'%s assigned this task to %s.',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($new));
	} else {
	return pht(
	'%s reassigned this task from %s to %s.',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($old),
	$this->renderHandleLink($new));
	}

	case self::TYPE_PROJECTS:
	$added = array_diff($new, $old);
	$removed = array_diff($old, $new);
	if ($added && !$removed) {
	return pht(
	'%s added %d project(s): %s',
	$this->renderHandleLink($author_phid),
	count($added),
	$this->renderHandleList($added));
	} else if ($removed && !$added) {
	return pht(
	'%s removed %d project(s): %s',
	$this->renderHandleLink($author_phid),
	count($removed),
	$this->renderHandleList($removed));
	} else if ($removed && $added) {
	return pht(
	'%s changed project(s), added %d: %s; removed %d: %s',
	$this->renderHandleLink($author_phid),
	count($added),
	$this->renderHandleList($added),
	count($removed),
	$this->renderHandleList($removed));
	} else {
	// This is hit when rendering previews.
	return pht(
	'%s changed projects...',
	$this->renderHandleLink($author_phid));
	}

	case self::TYPE_PRIORITY:
	$old_name = ManiphestTaskPriority::getTaskPriorityName($old);
	$new_name = ManiphestTaskPriority::getTaskPriorityName($new);

	if ($old == ManiphestTaskPriority::getDefaultPriority()) {
	return pht(
	'%s triaged this task as "%s" priority.',
	$this->renderHandleLink($author_phid),
	$new_name);
	} else if ($old > $new) {
	return pht(
	'%s lowered the priority of this task from "%s" to "%s".',
	$this->renderHandleLink($author_phid),
	$old_name,
	$new_name);
	} else {
	return pht(
	'%s raised the priority of this task from "%s" to "%s".',
	$this->renderHandleLink($author_phid),
	$old_name,
	$new_name);
	}

	case self::TYPE_CCS:
	// TODO: Remove this when we switch to subscribers. Just reuse the
	// code in the parent.
	$clone = clone $this;
	$clone->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS);
	return $clone->getTitle();

	case self::TYPE_EDGE:
	// TODO: Remove this when we switch to real edges. Just reuse the
	// code in the parent;
	$clone = clone $this;
	$clone->setTransactionType(PhabricatorTransactions::TYPE_EDGE);
	return $clone->getTitle();

	case self::TYPE_ATTACH:
	$old = nonempty($old, array());
	$new = nonempty($new, array());
	$new = array_keys(idx($new, 'FILE', array()));
	$old = array_keys(idx($old, 'FILE', array()));

	$added = array_diff($new, $old);
	$removed = array_diff($old, $new);
	if ($added && !$removed) {
	return pht(
	'%s attached %d file(s): %s',
	$this->renderHandleLink($author_phid),
	count($added),
	$this->renderHandleList($added));
	} else if ($removed && !$added) {
	return pht(
	'%s detached %d file(s): %s',
	$this->renderHandleLink($author_phid),
	count($removed),
	$this->renderHandleList($removed));
	} else {
	return pht(
	'%s changed file(s), attached %d: %s; detached %d: %s',
	$this->renderHandleLink($author_phid),
	count($added),
	$this->renderHandleList($added),
	count($removed),
	$this->renderHandleList($removed));
	}

	case self::TYPE_PROJECT_COLUMN:
	$project_phid = $new['projectPHID'];
	$column_phid = head($new['columnPHIDs']);
	return pht(
	'%s moved this task to %s on the %s workboard.',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($column_phid),
	$this->renderHandleLink($project_phid));
	break;


	}

	return parent::getTitle();
	}

	public function getTitleForFeed(PhabricatorFeedStory $story) {
	$author_phid = $this->getAuthorPHID();
	$object_phid = $this->getObjectPHID();

	$old = $this->getOldValue();
	$new = $this->getNewValue();

	switch ($this->getTransactionType()) {
	case self::TYPE_TITLE:
	if ($old === null) {
	return pht(
	'%s created %s.',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid));
	}

	return pht(
	'%s renamed %s from "%s" to "%s".',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	$old,
	$new);

	case self::TYPE_DESCRIPTION:
	return pht(
	'%s edited the description of %s.',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid));

	case self::TYPE_STATUS:
	$old_closed = ManiphestTaskStatus::isClosedStatus($old);
	$new_closed = ManiphestTaskStatus::isClosedStatus($new);

	$old_name = ManiphestTaskStatus::getTaskStatusName($old);
	$new_name = ManiphestTaskStatus::getTaskStatusName($new);

	if ($new_closed && !$old_closed) {
	if ($new == ManiphestTaskStatus::getDuplicateStatus()) {
	return pht(
	'%s closed %s as a duplicate.',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid));
	} else {
	return pht(
	'%s closed %s as "%s".',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	$new_name);
	}
	} else if (!$new_closed && $old_closed) {
	return pht(
	'%s reopened %s as "%s".',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	$new_name);
	} else {
	return pht(
	'%s changed the status of %s from "%s" to "%s".',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	$old_name,
	$new_name);
	}

	case self::TYPE_OWNER:
	if ($author_phid == $new) {
	return pht(
	'%s claimed %s.',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid));
	} else if (!$new) {
	return pht(
	'%s placed %s up for grabs.',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid));
	} else if (!$old) {
	return pht(
	'%s assigned %s to %s.',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	$this->renderHandleLink($new));
	} else {
	return pht(
	'%s reassigned %s from %s to %s.',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	$this->renderHandleLink($old),
	$this->renderHandleLink($new));
	}

	case self::TYPE_PROJECTS:
	$added = array_diff($new, $old);
	$removed = array_diff($old, $new);
	if ($added && !$removed) {
	return pht(
	'%s added %d project(s) to %s: %s',
	$this->renderHandleLink($author_phid),
	count($added),
	$this->renderHandleLink($object_phid),
	$this->renderHandleList($added));
	} else if ($removed && !$added) {
	return pht(
	'%s removed %d project(s) from %s: %s',
	$this->renderHandleLink($author_phid),
	count($removed),
	$this->renderHandleLink($object_phid),
	$this->renderHandleList($removed));
	} else if ($removed && $added) {
	return pht(
	'%s changed project(s) of %s, added %d: %s; removed %d: %s',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	count($added),
	$this->renderHandleList($added),
	count($removed),
	$this->renderHandleList($removed));
	}

	case self::TYPE_PRIORITY:
	$old_name = ManiphestTaskPriority::getTaskPriorityName($old);
	$new_name = ManiphestTaskPriority::getTaskPriorityName($new);

	if ($old == ManiphestTaskPriority::getDefaultPriority()) {
	return pht(
	'%s triaged %s as "%s" priority.',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	$new_name);
	} else if ($old > $new) {
	return pht(
	'%s lowered the priority of %s from "%s" to "%s".',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	$old_name,
	$new_name);
	} else {
	return pht(
	'%s raised the priority of %s from "%s" to "%s".',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	$old_name,
	$new_name);
	}

	case self::TYPE_CCS:
	// TODO: Remove this when we switch to subscribers. Just reuse the
	// code in the parent.
	$clone = clone $this;
	$clone->setTransactionType(PhabricatorTransactions::TYPE_SUBSCRIBERS);
	return $clone->getTitleForFeed($story);

	case self::TYPE_EDGE:
	// TODO: Remove this when we switch to real edges. Just reuse the
	// code in the parent;
	$clone = clone $this;
	$clone->setTransactionType(PhabricatorTransactions::TYPE_EDGE);
	return $clone->getTitleForFeed($story);

	case self::TYPE_ATTACH:
	$old = nonempty($old, array());
	$new = nonempty($new, array());
	$new = array_keys(idx($new, 'FILE', array()));
	$old = array_keys(idx($old, 'FILE', array()));

	$added = array_diff($new, $old);
	$removed = array_diff($old, $new);
	if ($added && !$removed) {
	return pht(
	'%s attached %d file(s) of %s: %s',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	count($added),
	$this->renderHandleList($added));
	} else if ($removed && !$added) {
	return pht(
	'%s detached %d file(s) of %s: %s',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	count($removed),
	$this->renderHandleList($removed));
	} else {
	return pht(
	'%s changed file(s) for %s, attached %d: %s; detached %d: %s',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	count($added),
	$this->renderHandleList($added),
	count($removed),
	$this->renderHandleList($removed));
	}

	case self::TYPE_PROJECT_COLUMN:
	$project_phid = $new['projectPHID'];
	$column_phid = head($new['columnPHIDs']);
	return pht(
	'%s moved %s to %s on the %s workboard.',
	$this->renderHandleLink($author_phid),
	$this->renderHandleLink($object_phid),
	$this->renderHandleLink($column_phid),
	$this->renderHandleLink($project_phid));
	break;
	}

	return parent::getTitleForFeed($story);
	}

	public function hasChangeDetails() {
	switch ($this->getTransactionType()) {
	case self::TYPE_DESCRIPTION:
	return true;
	}
	return parent::hasChangeDetails();
	}

	public function renderChangeDetails(PhabricatorUser $viewer) {
	return $this->renderTextCorpusChangeDetails(
	$viewer,
	$this->getOldValue(),
	$this->getNewValue());
	}

	public function getMailTags() {
	$tags = array();
	switch ($this->getTransactionType()) {
	case self::TYPE_STATUS:
	$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_STATUS;
	break;
	case self::TYPE_OWNER:
	$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_OWNER;
	break;
	case self::TYPE_CCS:
	$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_CC;
	break;
	case self::TYPE_PROJECTS:
	$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_PROJECTS;
	break;
	case self::TYPE_PRIORITY:
	$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_PRIORITY;
	break;
	case PhabricatorTransactions::TYPE_COMMENT:
	$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_COMMENT;
	break;
	default:
	$tags[] = MetaMTANotificationType::TYPE_MANIPHEST_OTHER;
	break;
	}
	return $tags;
	}

	public function getNoEffectDescription() {

	switch ($this->getTransactionType()) {
	case self::TYPE_STATUS:
	return pht('The task already has the selected status.');
	case self::TYPE_OWNER:
	return pht('The task already has the selected owner.');
	case self::TYPE_PROJECTS:
	return pht('The task is already associated with those projects.');
	case self::TYPE_PRIORITY:
	return pht('The task already has the selected priority.');
	}

	return parent::getNoEffectDescription();
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Tue, Jul 29, 6:06 AM (2 w, 5 d ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 188110
Default Alt Text: (108 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions