Page MenuHomestyx hydra
Files F233727

No OneTemporary
Actions

View Options

diff --git a/src/applications/config/check/PhabricatorSetupCheckAuth.php b/src/applications/config/check/PhabricatorSetupCheckAuth.php
index 9cc2348aa6..b34d643f8a 100644
--- a/src/applications/config/check/PhabricatorSetupCheckAuth.php
+++ b/src/applications/config/check/PhabricatorSetupCheckAuth.php
@@ -1,27 +1,41 @@
<?php
final class PhabricatorSetupCheckAuth extends PhabricatorSetupCheck {
protected function executeChecks() {
- $providers = PhabricatorAuthProvider::getAllEnabledProviders();
- if (!$providers) {
+ // NOTE: We're not actually building these providers. Building providers
+ // can require additional configuration to be present (e.g., to build
+ // redirect and login URIs using `phabricator.base-uri`) and it won't
+ // necessarily be available when running setup checks.
+
+ // Since this check is only meant as a hint to new administrators about
+ // steps they should take, we don't need to be thorough about checking
+ // that providers are enabled, available, correctly configured, etc. As
+ // long as they've created some kind of provider in the auth app before,
+ // they know that it exists and don't need the hint to go check it out.
+
+ $configs = id(new PhabricatorAuthProviderConfigQuery())
+ ->setViewer(PhabricatorUser::getOmnipotentUser())
+ ->execute();
+
+ if (!$configs) {
$message = pht(
'You have not configured any authentication providers yet. You '.
'should add a provider (like username/password, LDAP, or GitHub '.
'OAuth) so users can register and log in. You can add and configure '.
'providers %s.',
phutil_tag(
'a',
array(
'href' => '/auth/',
),
pht('using the "Auth" application')));
$this
->newIssue('auth.noproviders')
->setShortName(pht('No Auth Providers'))
->setName(pht('No Authentication Providers Configured'))
->setMessage($message);
}
}
}

File Metadata

Mime Type
text/x-diff
Expires
Mon, Jul 28, 10:11 AM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
186699
Default Alt Text
(1 KB)

Event Timeline

styx copyright 2020 sirocyl / ellie (kymkdd) / ncommander / styx contributors
Use of other names and brands is not intended to reflect a claim of, or right to, use the name or brand.
styx is an operating system using the Linux kernel and components, and "styx Linux" as a phrase does not reflect the inclusion of the Linux brand or trademark in the styx project.
Linux® is the registered trademark of Linus Torvalds in the U.S. and other countries.
Terms and Conditions (TODO: fix this!)