Page MenuHomestyx hydra

No OneTemporary

diff --git a/src/applications/differential/query/DifferentialTransactionQuery.php b/src/applications/differential/query/DifferentialTransactionQuery.php
index 8b60bbc03f..5691a34285 100644
--- a/src/applications/differential/query/DifferentialTransactionQuery.php
+++ b/src/applications/differential/query/DifferentialTransactionQuery.php
@@ -1,24 +1,33 @@
<?php
final class DifferentialTransactionQuery
extends PhabricatorApplicationTransactionQuery {
public function getTemplateApplicationTransaction() {
return new DifferentialTransaction();
}
public static function loadUnsubmittedInlineComments(
PhabricatorUser $viewer,
DifferentialRevision $revision) {
- return id(new DifferentialDiffInlineCommentQuery())
+ $inlines = id(new DifferentialDiffInlineCommentQuery())
->setViewer($viewer)
->withRevisionPHIDs(array($revision->getPHID()))
->withAuthorPHIDs(array($viewer->getPHID()))
->withHasTransaction(false)
->withIsDeleted(false)
->needReplyToComments(true)
->execute();
+
+ // Don't count empty inlines when considering draft state.
+ foreach ($inlines as $key => $inline) {
+ if ($inline->isEmptyInlineComment()) {
+ unset($inlines[$key]);
+ }
+ }
+
+ return $inlines;
}
}

File Metadata

Mime Type
text/x-diff
Expires
Sun, Jul 27, 11:34 AM (6 d, 15 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
185661
Default Alt Text
(1 KB)

Event Timeline