No OneTemporary
Actions

Size

30 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/differential/view/DifferentialRevisionDetailView.php b/src/applications/differential/view/DifferentialRevisionDetailView.php
	index 45f304d22d..364fe796a1 100644
	--- a/src/applications/differential/view/DifferentialRevisionDetailView.php
	+++ b/src/applications/differential/view/DifferentialRevisionDetailView.php
	@@ -1,129 +1,134 @@
	<?php

	final class DifferentialRevisionDetailView extends AphrontView {

	private $revision;
	private $actions;
	private $auxiliaryFields = array();
	private $diff;

	public function setDiff(DifferentialDiff $diff) {
	$this->diff = $diff;
	return $this;
	}
	private function getDiff() {
	return $this->diff;
	}

	public function setRevision(DifferentialRevision $revision) {
	$this->revision = $revision;
	return $this;
	}

	public function setActions(array $actions) {
	$this->actions = $actions;
	return $this;
	}
	private function getActions() {
	return $this->actions;
	}

	public function setAuxiliaryFields(array $fields) {
	assert_instances_of($fields, 'DifferentialFieldSpecification');
	$this->auxiliaryFields = $fields;
	return $this;
	}

	public function render() {

	require_celerity_resource('differential-core-view-css');

	$revision = $this->revision;
	$user = $this->getUser();

	$header = $this->renderHeader($revision);

	$actions = id(new PhabricatorActionListView())
	->setUser($user)
	->setObject($revision);
	foreach ($this->getActions() as $action) {
	$obj = id(new PhabricatorActionView())
	->setIcon(idx($action, 'icon', 'edit'))
	->setName($action['name'])
	->setHref(idx($action, 'href'))
	->setWorkflow(idx($action, 'sigil') == 'workflow')
	->setRenderAsForm(!empty($action['instant']))
	->setUser($user)
	->setDisabled(idx($action, 'disabled', false));
	$actions->addAction($obj);
	}

	$properties = id(new PhabricatorPropertyListView())
	->setUser($user)
	->setObject($revision);

	$status = $revision->getStatus();
	$local_vcs = $this->getDiff()->getSourceControlSystem();

	$next_step = null;
	if ($status == ArcanistDifferentialRevisionStatus::ACCEPTED) {
	switch ($local_vcs) {
	case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
	$bookmark = $this->getDiff()->getBookmark();
	$next_step = ($bookmark != ''
	? csprintf('arc land %s', $bookmark)
	: 'arc land');
	break;

	case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
	$branch = $this->getDiff()->getBranch();
	$next_step = ($branch != ''
	? csprintf('arc land %s', $branch)
	: 'arc land');
	break;

	case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
	$next_step = 'arc commit';
	break;
	}
	}
	if ($next_step) {
	$next_step = phutil_tag('tt', array(), $next_step);
	$properties->addProperty(pht('Next Step'), $next_step);
	}

	foreach ($this->auxiliaryFields as $field) {
	$value = $field->renderValueForRevisionView();
	if ($value !== null) {
	$label = rtrim($field->renderLabelForRevisionView(), ':');
	$properties->addProperty($label, $value);
	}
	}
	$properties->setHasKeyboardShortcuts(true);

	return hsprintf(
	'%s%s%s',
	$header->render(),
	$actions->render(),
	$properties->render());
	}

	private function renderHeader(DifferentialRevision $revision) {
	$view = id(new PhabricatorHeaderView())
	- ->setHeader($revision->getTitle());
	+ ->setHeader($revision->getTitle($revision));
	+
	+ $view->addTag(self::renderTagForRevision($revision));
	+
	+ return $view;
	+ }
	+
	+ public static function renderTagForRevision(
	+ DifferentialRevision $revision) {

	$status = $revision->getStatus();
	$status_name =
	ArcanistDifferentialRevisionStatus::getNameForRevisionStatus($status);
	$status_color =
	DifferentialRevisionStatus::getRevisionStatusTagColor($status);

	- $view->addTag(
	- id(new PhabricatorTagView())
	+ return id(new PhabricatorTagView())
	->setType(PhabricatorTagView::TYPE_STATE)
	->setName($status_name)
	- ->setBackgroundColor($status_color));
	-
	- return $view;
	+ ->setBackgroundColor($status_color);
	}
	}
	diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
	index 0e077497d3..ad01efbe19 100644
	--- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php
	+++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php
	@@ -1,550 +1,542 @@
	<?php

	/**
	* @group maniphest
	*/
	final class ManiphestTaskDetailController extends ManiphestController {

	private $id;

	public function willProcessRequest(array $data) {
	$this->id = $data['id'];
	}

	public function processRequest() {

	$request = $this->getRequest();
	$user = $request->getUser();

	$e_title = null;

	$priority_map = ManiphestTaskPriority::getTaskPriorityMap();

	$task = id(new ManiphestTask())->load($this->id);
	if (!$task) {
	return new Aphront404Response();
	}

	$workflow = $request->getStr('workflow');
	$parent_task = null;
	if ($workflow && is_numeric($workflow)) {
	$parent_task = id(new ManiphestTask())->load($workflow);
	}

	$transactions = id(new ManiphestTransaction())->loadAllWhere(
	'taskID = %d ORDER BY id ASC',
	$task->getID());

	$extensions = ManiphestTaskExtensions::newExtensions();
	$aux_fields = $extensions->loadFields($task, $user);

	$e_commit = PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT;
	$e_dep_on = PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK;
	$e_dep_by = PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK;
	$e_rev = PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV;

	$phid = $task->getPHID();

	$query = id(new PhabricatorEdgeQuery())
	->withSourcePHIDs(array($phid))
	->withEdgeTypes(
	array(
	$e_commit,
	$e_dep_on,
	$e_dep_by,
	$e_rev,
	));
	$edges = idx($query->execute(), $phid);
	$phids = array_fill_keys($query->getDestinationPHIDs(), true);

	foreach ($transactions as $transaction) {
	foreach ($transaction->extractPHIDs() as $phid) {
	$phids[$phid] = true;
	}
	}
	foreach ($task->getCCPHIDs() as $phid) {
	$phids[$phid] = true;
	}
	foreach ($task->getProjectPHIDs() as $phid) {
	$phids[$phid] = true;
	}
	if ($task->getOwnerPHID()) {
	$phids[$task->getOwnerPHID()] = true;
	}
	$phids[$task->getAuthorPHID()] = true;

	$attached = $task->getAttached();
	foreach ($attached as $type => $list) {
	foreach ($list as $phid => $info) {
	$phids[$phid] = true;
	}
	}

	if ($parent_task) {
	$phids[$parent_task->getPHID()] = true;
	}

	$phids = array_keys($phids);

	$phids = array_merge(
	$phids,
	array_mergev(mpull($aux_fields, 'getRequiredHandlePHIDs')));

	$this->loadHandles($phids);

	$handles = $this->getLoadedHandles();
	foreach ($aux_fields as $aux_field) {
	$aux_field->setHandles($handles);
	}

	$context_bar = null;

	if ($parent_task) {
	$context_bar = new AphrontContextBarView();
	$context_bar->addButton(phutil_tag(
	'a',
	array(
	'href' => '/maniphest/task/create/?parent='.$parent_task->getID(),
	'class' => 'green button',
	),
	pht('Create Another Subtask')));
	$context_bar->appendChild(hsprintf(
	'Created a subtask of <strong>%s</strong>',
	$this->getHandle($parent_task->getPHID())->renderLink()));
	} else if ($workflow == 'create') {
	$context_bar = new AphrontContextBarView();
	$context_bar->addButton(phutil_tag('label', array(), 'Create Another'));
	$context_bar->addButton(phutil_tag(
	'a',
	array(
	'href' => '/maniphest/task/create/?template='.$task->getID(),
	'class' => 'green button',
	),
	pht('Similar Task')));
	$context_bar->addButton(phutil_tag(
	'a',
	array(
	'href' => '/maniphest/task/create/',
	'class' => 'green button',
	),
	pht('Empty Task')));
	$context_bar->appendChild(pht('New task created.'));
	}

	$engine = new PhabricatorMarkupEngine();
	$engine->setViewer($user);
	$engine->addObject($task, ManiphestTask::MARKUP_FIELD_DESCRIPTION);
	foreach ($transactions as $xaction) {
	if ($xaction->hasComments()) {
	$engine->addObject($xaction, ManiphestTransaction::MARKUP_FIELD_BODY);
	}
	}

	foreach ($aux_fields as $aux_field) {
	foreach ($aux_field->getMarkupFields() as $markup_field) {
	$engine->addObject($aux_field, $markup_field);
	$aux_field->setMarkupEngine($engine);
	}
	}

	$engine->process();

	$transaction_types = ManiphestTransactionType::getTransactionTypeMap();
	$resolution_types = ManiphestTaskStatus::getTaskStatusMap();

	if ($task->getStatus() == ManiphestTaskStatus::STATUS_OPEN) {
	$resolution_types = array_select_keys(
	$resolution_types,
	array(
	ManiphestTaskStatus::STATUS_CLOSED_RESOLVED,
	ManiphestTaskStatus::STATUS_CLOSED_WONTFIX,
	ManiphestTaskStatus::STATUS_CLOSED_INVALID,
	ManiphestTaskStatus::STATUS_CLOSED_SPITE,
	));
	} else {
	$resolution_types = array(
	ManiphestTaskStatus::STATUS_OPEN => 'Reopened',
	);
	$transaction_types[ManiphestTransactionType::TYPE_STATUS] =
	'Reopen Task';
	unset($transaction_types[ManiphestTransactionType::TYPE_PRIORITY]);
	unset($transaction_types[ManiphestTransactionType::TYPE_OWNER]);
	}

	$default_claim = array(
	$user->getPHID() => $user->getUsername().' ('.$user->getRealName().')',
	);

	$draft = id(new PhabricatorDraft())->loadOneWhere(
	'authorPHID = %s AND draftKey = %s',
	$user->getPHID(),
	$task->getPHID());
	if ($draft) {
	$draft_text = $draft->getDraft();
	} else {
	$draft_text = null;
	}

	$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');

	if ($is_serious) {
	// Prevent tasks from being closed "out of spite" in serious business
	// installs.
	unset($resolution_types[ManiphestTaskStatus::STATUS_CLOSED_SPITE]);
	}

	$comment_form = new AphrontFormView();
	$comment_form
	->setUser($user)
	->setAction('/maniphest/transaction/save/')
	->setEncType('multipart/form-data')
	->addHiddenInput('taskID', $task->getID())
	->appendChild(
	id(new AphrontFormSelectControl())
	->setLabel(pht('Action'))
	->setName('action')
	->setOptions($transaction_types)
	->setID('transaction-action'))
	->appendChild(
	id(new AphrontFormSelectControl())
	->setLabel(pht('Resolution'))
	->setName('resolution')
	->setControlID('resolution')
	->setControlStyle('display: none')
	->setOptions($resolution_types))
	->appendChild(
	id(new AphrontFormTokenizerControl())
	->setLabel(pht('Assign To'))
	->setName('assign_to')
	->setControlID('assign_to')
	->setControlStyle('display: none')
	->setID('assign-tokenizer')
	->setDisableBehavior(true))
	->appendChild(
	id(new AphrontFormTokenizerControl())
	->setLabel(pht('CCs'))
	->setName('ccs')
	->setControlID('ccs')
	->setControlStyle('display: none')
	->setID('cc-tokenizer')
	->setDisableBehavior(true))
	->appendChild(
	id(new AphrontFormSelectControl())
	->setLabel(pht('Priority'))
	->setName('priority')
	->setOptions($priority_map)
	->setControlID('priority')
	->setControlStyle('display: none')
	->setValue($task->getPriority()))
	->appendChild(
	id(new AphrontFormTokenizerControl())
	->setLabel(pht('Projects'))
	->setName('projects')
	->setControlID('projects')
	->setControlStyle('display: none')
	->setID('projects-tokenizer')
	->setDisableBehavior(true))
	->appendChild(
	id(new AphrontFormFileControl())
	->setLabel(pht('File'))
	->setName('file')
	->setControlID('file')
	->setControlStyle('display: none'))
	->appendChild(
	id(new PhabricatorRemarkupControl())
	->setLabel(pht('Comments'))
	->setName('comments')
	->setValue($draft_text)
	->setID('transaction-comments')
	->setUser($user))
	->appendChild(
	id(new AphrontFormDragAndDropUploadControl())
	->setLabel(pht('Attached Files'))
	->setName('files')
	->setActivatedClass('aphront-panel-view-drag-and-drop'))
	->appendChild(
	id(new AphrontFormSubmitControl())
	->setValue($is_serious ? pht('Submit') : pht('Avast!')));

	$control_map = array(
	ManiphestTransactionType::TYPE_STATUS => 'resolution',
	ManiphestTransactionType::TYPE_OWNER => 'assign_to',
	ManiphestTransactionType::TYPE_CCS => 'ccs',
	ManiphestTransactionType::TYPE_PRIORITY => 'priority',
	ManiphestTransactionType::TYPE_PROJECTS => 'projects',
	ManiphestTransactionType::TYPE_ATTACH => 'file',
	);

	$tokenizer_map = array(
	ManiphestTransactionType::TYPE_PROJECTS => array(
	'id' => 'projects-tokenizer',
	'src' => '/typeahead/common/projects/',
	'ondemand' => PhabricatorEnv::getEnvConfig('tokenizer.ondemand'),
	'placeholder' => pht('Type a project name...'),
	),
	ManiphestTransactionType::TYPE_OWNER => array(
	'id' => 'assign-tokenizer',
	'src' => '/typeahead/common/users/',
	'value' => $default_claim,
	'limit' => 1,
	'ondemand' => PhabricatorEnv::getEnvConfig('tokenizer.ondemand'),
	'placeholder' => pht('Type a user name...'),
	),
	ManiphestTransactionType::TYPE_CCS => array(
	'id' => 'cc-tokenizer',
	'src' => '/typeahead/common/mailable/',
	'ondemand' => PhabricatorEnv::getEnvConfig('tokenizer.ondemand'),
	'placeholder' => pht('Type a user or mailing list...'),
	),
	);

	Javelin::initBehavior('maniphest-transaction-controls', array(
	'select' => 'transaction-action',
	'controlMap' => $control_map,
	'tokenizers' => $tokenizer_map,
	));

	Javelin::initBehavior('maniphest-transaction-preview', array(
	'uri' => '/maniphest/transaction/preview/'.$task->getID().'/',
	'preview' => 'transaction-preview',
	'comments' => 'transaction-comments',
	'action' => 'transaction-action',
	'map' => $control_map,
	'tokenizers' => $tokenizer_map,
	));

	$comment_header = id(new PhabricatorHeaderView())
	->setHeader($is_serious ? pht('Add Comment') : pht('Weigh In'));

	$preview_panel = hsprintf(
	'<div class="aphront-panel-preview">
	<div id="transaction-preview">
	<div class="aphront-panel-preview-loading-text">%s</div>
	</div>
	</div>',
	pht('Loading preview...'));

	$transaction_view = new ManiphestTransactionListView();
	$transaction_view->setTransactions($transactions);
	$transaction_view->setHandles($this->getLoadedHandles());
	$transaction_view->setUser($user);
	$transaction_view->setAuxiliaryFields($aux_fields);
	$transaction_view->setMarkupEngine($engine);

	PhabricatorFeedStoryNotification::updateObjectNotificationViews(
	$user, $task->getPHID());

	$object_name = 'T'.$task->getID();

	$crumbs = $this->buildApplicationCrumbs();
	$crumbs->addCrumb(
	id(new PhabricatorCrumbView())
	->setName($object_name)
	->setHref('/'.$object_name))
	->addAction(
	id(new PhabricatorMenuItemView())
	->setHref($this->getApplicationURI('/task/create/'))
	->setName(pht('Create Task'))
	->setIcon('create'));

	$header = $this->buildHeaderView($task);
	$actions = $this->buildActionView($task);
	$properties = $this->buildPropertyView($task, $aux_fields, $edges, $engine);

	return $this->buildApplicationPage(
	array(
	$crumbs,
	$context_bar,
	$header,
	$actions,
	$properties,
	$transaction_view,
	$comment_header,
	$comment_form,
	$preview_panel,
	),
	array(
	'title' => 'T'.$task->getID().' '.$task->getTitle(),
	'pageObjects' => array($task->getPHID()),
	'device' => true,
	));
	}

	private function buildHeaderView(ManiphestTask $task) {
	$view = id(new PhabricatorHeaderView())
	->setHeader($task->getTitle());

	- $status = $task->getStatus();
	- $status_name = ManiphestTaskStatus::getTaskStatusFullName($status);
	- $status_color = ManiphestTaskStatus::getTaskStatusTagColor($status);
	-
	- $view->addTag(
	- id(new PhabricatorTagView())
	- ->setType(PhabricatorTagView::TYPE_STATE)
	- ->setName($status_name)
	- ->setBackgroundColor($status_color));
	+ $view->addTag(ManiphestView::renderTagForTask($task));

	return $view;
	}


	private function buildActionView(ManiphestTask $task) {
	$viewer = $this->getRequest()->getUser();

	$id = $task->getID();
	$phid = $task->getPHID();

	$view = new PhabricatorActionListView();
	$view->setUser($viewer);
	$view->setObject($task);

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Edit Task'))
	->setIcon('edit')
	->setHref($this->getApplicationURI("/task/edit/{$id}/")));

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Merge Duplicates'))
	->setHref("/search/attach/{$phid}/TASK/merge/")
	->setWorkflow(true)
	->setWorkflow(true)
	->setIcon('merge'));

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Create Subtask'))
	->setHref($this->getApplicationURI("/task/create/?parent={$id}"))
	->setIcon('fork'));

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Edit Dependencies'))
	->setHref("/search/attach/{$phid}/TASK/dependencies/")
	->setWorkflow(true)
	->setIcon('link'));

	$view->addAction(
	id(new PhabricatorActionView())
	->setName(pht('Edit Differential Revisions'))
	->setHref("/search/attach/{$phid}/DREV/")
	->setWorkflow(true)
	->setIcon('attach'));

	return $view;
	}

	private function buildPropertyView(
	ManiphestTask $task,
	array $aux_fields,
	array $edges,
	PhabricatorMarkupEngine $engine) {

	$viewer = $this->getRequest()->getUser();

	$view = id(new PhabricatorPropertyListView())
	->setUser($viewer)
	->setObject($task);

	$view->addProperty(
	pht('Assigned To'),
	$task->getOwnerPHID()
	? $this->getHandle($task->getOwnerPHID())->renderLink()
	: phutil_tag('em', array(), pht('None')));

	$view->addProperty(
	pht('Priority'),
	ManiphestTaskPriority::getTaskPriorityName($task->getPriority()));

	$view->addProperty(
	pht('Subscribers'),
	$task->getCCPHIDs()
	? $this->renderHandlesForPHIDs($task->getCCPHIDs(), ',')
	: phutil_tag('em', array(), pht('None')));

	$view->addProperty(
	pht('Author'),
	$this->getHandle($task->getAuthorPHID())->renderLink());

	$source = $task->getOriginalEmailSource();
	if ($source) {
	$subject = '[T'.$task->getID().'] '.$task->getTitle();
	$view->addProperty(
	pht('From Email'),
	phutil_tag(
	'a',
	array(
	'href' => 'mailto:'.$source.'?subject='.$subject
	),
	$source));
	}

	$view->addProperty(
	pht('Projects'),
	$task->getProjectPHIDs()
	? $this->renderHandlesForPHIDs($task->getProjectPHIDs(), ',')
	: phutil_tag('em', array(), pht('None')));

	foreach ($aux_fields as $aux_field) {
	$value = $aux_field->renderForDetailView();
	if (strlen($value)) {
	$view->addProperty($aux_field->getLabel(), $value);
	}
	}


	$edge_types = array(
	PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK
	=> pht('Dependent Tasks'),
	PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK
	=> pht('Depends On'),
	PhabricatorEdgeConfig::TYPE_TASK_HAS_RELATED_DREV
	=> pht('Differential Revisions'),
	PhabricatorEdgeConfig::TYPE_TASK_HAS_COMMIT
	=> pht('Commits'),
	);

	foreach ($edge_types as $edge_type => $edge_name) {
	if ($edges[$edge_type]) {
	$view->addProperty(
	$edge_name,
	$this->renderHandlesForPHIDs(array_keys($edges[$edge_type])));
	}
	}

	$attached = $task->getAttached();
	$file_infos = idx($attached, PhabricatorPHIDConstants::PHID_TYPE_FILE);
	if ($file_infos) {
	$file_phids = array_keys($file_infos);

	$files = id(new PhabricatorFile())->loadAllWhere(
	'phid IN (%Ls)',
	$file_phids);

	$file_view = new PhabricatorFileLinkListView();
	$file_view->setFiles($files);

	$view->addProperty(
	pht('Files'),
	$file_view->render());
	}

	$view->invokeWillRenderEvent();

	if (strlen($task->getDescription())) {
	$view->addSectionHeader(pht('Description'));
	$view->addTextContent(
	phutil_tag(
	'div',
	array(
	'class' => 'phabricator-remarkup',
	),
	$engine->getOutput($task, ManiphestTask::MARKUP_FIELD_DESCRIPTION)));
	}

	return $view;
	}


	}
	diff --git a/src/applications/maniphest/storage/ManiphestTask.php b/src/applications/maniphest/storage/ManiphestTask.php
	index c51f5bf546..c20172b268 100644
	--- a/src/applications/maniphest/storage/ManiphestTask.php
	+++ b/src/applications/maniphest/storage/ManiphestTask.php
	@@ -1,303 +1,302 @@
	<?php

	/**
	* @group maniphest
	*/
	final class ManiphestTask extends ManiphestDAO
	implements
	PhabricatorMarkupInterface,
	PhabricatorPolicyInterface,
	PhabricatorTokenReceiverInterface,
	PhrequentTrackableInterface {

	const MARKUP_FIELD_DESCRIPTION = 'markup:desc';

	protected $phid;
	protected $authorPHID;
	protected $ownerPHID;
	protected $ccPHIDs = array();

	protected $status;
	protected $priority;
	protected $subpriority;

	protected $title;
	protected $originalTitle;
	protected $description;
	protected $originalEmailSource;
	protected $mailKey;

	protected $attached = array();
	protected $projectPHIDs = array();
	private $projectsNeedUpdate;
	private $subscribersNeedUpdate;

	protected $ownerOrdering;

	private $auxiliaryAttributes;
	private $auxiliaryDirty = array();

	public function getConfiguration() {
	return array(
	self::CONFIG_AUX_PHID => true,
	self::CONFIG_SERIALIZATION => array(
	'ccPHIDs' => self::SERIALIZATION_JSON,
	'attached' => self::SERIALIZATION_JSON,
	'projectPHIDs' => self::SERIALIZATION_JSON,
	),
	) + parent::getConfiguration();
	}

	public function loadDependsOnTaskPHIDs() {
	return PhabricatorEdgeQuery::loadDestinationPHIDs(
	$this->getPHID(),
	PhabricatorEdgeConfig::TYPE_TASK_DEPENDS_ON_TASK);
	}

	public function loadDependedOnByTaskPHIDs() {
	return PhabricatorEdgeQuery::loadDestinationPHIDs(
	$this->getPHID(),
	PhabricatorEdgeConfig::TYPE_TASK_DEPENDED_ON_BY_TASK);
	}

	public function getAttachedPHIDs($type) {
	return array_keys(idx($this->attached, $type, array()));
	}

	public function generatePHID() {
	return PhabricatorPHID::generateNewPHID(
	PhabricatorPHIDConstants::PHID_TYPE_TASK);
	}

	public function getCCPHIDs() {
	return array_values(nonempty($this->ccPHIDs, array()));
	}

	public function setProjectPHIDs(array $phids) {
	$this->projectPHIDs = array_values($phids);
	$this->projectsNeedUpdate = true;
	return $this;
	}

	public function getProjectPHIDs() {
	return array_values(nonempty($this->projectPHIDs, array()));
	}

	public function setCCPHIDs(array $phids) {
	$this->ccPHIDs = array_values($phids);
	$this->subscribersNeedUpdate = true;
	return $this;
	}

	public function setOwnerPHID($phid) {
	$this->ownerPHID = $phid;
	$this->subscribersNeedUpdate = true;
	return $this;
	}

	public function getAuxiliaryAttribute($key, $default = null) {
	if ($this->auxiliaryAttributes === null) {
	throw new Exception("Attach auxiliary attributes before getting them!");
	}
	return idx($this->auxiliaryAttributes, $key, $default);
	}

	public function setAuxiliaryAttribute($key, $val) {
	if ($this->auxiliaryAttributes === null) {
	throw new Exception("Attach auxiliary attributes before setting them!");
	}
	$this->auxiliaryAttributes[$key] = $val;
	$this->auxiliaryDirty[$key] = true;
	return $this;
	}

	public function setTitle($title) {
	$this->title = $title;
	if (!$this->getID()) {
	$this->originalTitle = $title;
	}
	return $this;
	}

	public function attachAuxiliaryAttributes(array $attrs) {
	if ($this->auxiliaryDirty) {
	throw new Exception(
	"This object has dirty attributes, you can not attach new attributes ".
	"without writing or discarding the dirty attributes.");
	}
	$this->auxiliaryAttributes = $attrs;
	return $this;
	}

	public function loadAndAttachAuxiliaryAttributes() {
	if (!$this->getPHID()) {
	$this->auxiliaryAttributes = array();
	return $this;
	}

	$storage = id(new ManiphestTaskAuxiliaryStorage())->loadAllWhere(
	'taskPHID = %s',
	$this->getPHID());

	$this->auxiliaryAttributes = mpull($storage, 'getValue', 'getName');

	return $this;
	}

	-
	public function save() {
	if (!$this->mailKey) {
	$this->mailKey = Filesystem::readRandomCharacters(20);
	}

	$result = parent::save();

	if ($this->projectsNeedUpdate) {
	// If we've changed the project PHIDs for this task, update the link
	// table.
	ManiphestTaskProject::updateTaskProjects($this);
	$this->projectsNeedUpdate = false;
	}

	if ($this->subscribersNeedUpdate) {
	// If we've changed the subscriber PHIDs for this task, update the link
	// table.
	ManiphestTaskSubscriber::updateTaskSubscribers($this);
	$this->subscribersNeedUpdate = false;
	}

	if ($this->auxiliaryDirty) {
	$this->writeAuxiliaryUpdates();
	$this->auxiliaryDirty = array();
	}

	return $result;
	}

	private function writeAuxiliaryUpdates() {
	$table = new ManiphestTaskAuxiliaryStorage();
	$conn_w = $table->establishConnection('w');
	$update = array();
	$remove = array();

	foreach ($this->auxiliaryDirty as $key => $dirty) {
	$value = $this->getAuxiliaryAttribute($key);
	if ($value === null) {
	$remove[$key] = true;
	} else {
	$update[$key] = $value;
	}
	}

	if ($remove) {
	queryfx(
	$conn_w,
	'DELETE FROM %T WHERE taskPHID = %s AND name IN (%Ls)',
	$table->getTableName(),
	$this->getPHID(),
	array_keys($remove));
	}

	if ($update) {
	$sql = array();
	foreach ($update as $key => $val) {
	$sql[] = qsprintf(
	$conn_w,
	'(%s, %s, %s, %d, %d)',
	$this->getPHID(),
	$key,
	$val,
	time(),
	time());
	}
	queryfx(
	$conn_w,
	'INSERT INTO %T (taskPHID, name, value, dateCreated, dateModified)
	VALUES %Q ON DUPLICATE KEY
	UPDATE value = VALUES(value), dateModified = VALUES(dateModified)',
	$table->getTableName(),
	implode(', ', $sql));
	}
	}


	/* -( Markup Interface )--------------------------------------------------- */


	/**
	* @task markup
	*/
	public function getMarkupFieldKey($field) {
	$hash = PhabricatorHash::digest($this->getMarkupText($field));
	$id = $this->getID();
	return "maniphest:T{$id}:{$field}:{$hash}";
	}


	/**
	* @task markup
	*/
	public function getMarkupText($field) {
	return $this->getDescription();
	}


	/**
	* @task markup
	*/
	public function newMarkupEngine($field) {
	return PhabricatorMarkupEngine::newManiphestMarkupEngine();
	}


	/**
	* @task markup
	*/
	public function didMarkupText(
	$field,
	$output,
	PhutilMarkupEngine $engine) {
	return $output;
	}


	/**
	* @task markup
	*/
	public function shouldUseMarkupCache($field) {
	return (bool)$this->getID();
	}


	/* -( Policy Interface )--------------------------------------------------- */


	public function getCapabilities() {
	return array(
	PhabricatorPolicyCapability::CAN_VIEW,
	PhabricatorPolicyCapability::CAN_EDIT,
	);
	}

	public function getPolicy($capability) {
	return PhabricatorPolicies::POLICY_USER;
	}

	public function hasAutomaticCapability($capability, PhabricatorUser $user) {
	return false;
	}


	/* -( PhabricatorTokenReceiverInterface )---------------------------------- */

	public function getUsersToNotifyOfTokenGiven() {
	// Sort of ambiguous who this was intended for; just let them both know.
	return array_filter(
	array_unique(
	array(
	$this->getAuthorPHID(),
	$this->getOwnerPHID(),
	)));
	}

	}
	diff --git a/src/applications/maniphest/view/ManiphestView.php b/src/applications/maniphest/view/ManiphestView.php
	index d0b710b492..c6543eadc1 100644
	--- a/src/applications/maniphest/view/ManiphestView.php
	+++ b/src/applications/maniphest/view/ManiphestView.php
	@@ -1,8 +1,19 @@
	<?php

	/**
	* @group maniphest
	*/
	abstract class ManiphestView extends AphrontView {

	+ public static function renderTagForTask(ManiphestTask $task) {
	+ $status = $task->getStatus();
	+ $status_name = ManiphestTaskStatus::getTaskStatusFullName($status);
	+ $status_color = ManiphestTaskStatus::getTaskStatusTagColor($status);
	+
	+ return id(new PhabricatorTagView())
	+ ->setType(PhabricatorTagView::TYPE_STATE)
	+ ->setName($status_name)
	+ ->setBackgroundColor($status_color);
	+ }
	+
	}

File Metadata

Mime Type: text/x-diff
Expires: Tue, Dec 2, 1:10 AM (16 h, 24 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 431543
Default Alt Text: (30 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions