View Options

	diff --git a/src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php b/src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php
	index 125334079d..4e0e214961 100644
	--- a/src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php
	+++ b/src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php
	@@ -1,122 +1,122 @@
	<?php

	final class HarbormasterBuildUnitMessage
	extends HarbormasterDAO {

	protected $buildTargetPHID;
	protected $engine;
	protected $namespace;
	protected $name;
	protected $result;
	protected $duration;
	protected $properties = array();

	private $buildTarget = self::ATTACHABLE;

	public static function initializeNewUnitMessage(
	HarbormasterBuildTarget $build_target) {
	return id(new HarbormasterBuildUnitMessage())
	->setBuildTargetPHID($build_target->getPHID());
	}

	public static function newFromDictionary(
	HarbormasterBuildTarget $build_target,
	array $dict) {

	$obj = self::initializeNewUnitMessage($build_target);

	$spec = array(
	'engine' => 'optional string',
	'namespace' => 'optional string',
	'name' => 'string',
	'result' => 'string',
	'duration' => 'optional float',
	'path' => 'optional string',
	'coverage' => 'optional map<string, wild>',
	);

	// We're just going to ignore extra keys for now, to make it easier to
	// add stuff here later on.
	$dict = array_select_keys($dict, array_keys($spec));
	PhutilTypeSpec::checkMap($dict, $spec);

	$obj->setEngine(idx($dict, 'engine', ''));
	$obj->setNamespace(idx($dict, 'namespace', ''));
	$obj->setName($dict['name']);
	$obj->setResult($dict['result']);
	$obj->setDuration(idx($dict, 'duration'));

	$path = idx($dict, 'path');
	if (strlen($path)) {
	$obj->setProperty('path', $path);
	}

	$coverage = idx($dict, 'coverage');
	- if (strlen($coverage)) {
	+ if ($coverage) {
	$obj->setProperty('coverage', $coverage);
	}

	return $obj;
	}

	protected function getConfiguration() {
	return array(
	self::CONFIG_SERIALIZATION => array(
	'properties' => self::SERIALIZATION_JSON,
	),
	self::CONFIG_COLUMN_SCHEMA => array(
	'engine' => 'text255',
	'namespace' => 'text255',
	'name' => 'text255',
	'result' => 'text32',
	'duration' => 'double?',
	),
	self::CONFIG_KEY_SCHEMA => array(
	'key_target' => array(
	'columns' => array('buildTargetPHID'),
	),
	),
	) + parent::getConfiguration();
	}

	public function attachBuildTarget(HarbormasterBuildTarget $build_target) {
	$this->buildTarget = $build_target;
	return $this;
	}

	public function getBuildTarget() {
	return $this->assertAttached($this->buildTarget);
	}

	public function getProperty($key, $default = null) {
	return idx($this->properties, $key, $default);
	}

	public function setProperty($key, $value) {
	$this->properties[$key] = $value;
	return $this;
	}

	public function getSortKey() {
	// TODO: Maybe use more numeric values after T6861.
	$map = array(
	ArcanistUnitTestResult::RESULT_FAIL => 'A',
	ArcanistUnitTestResult::RESULT_BROKEN => 'B',
	ArcanistUnitTestResult::RESULT_UNSOUND => 'C',
	ArcanistUnitTestResult::RESULT_PASS => 'Z',
	);

	$result = idx($map, $this->getResult(), 'N');

	$parts = array(
	$result,
	$this->getEngine(),
	$this->getNamespace(),
	$this->getName(),
	$this->getID(),
	);

	return implode("\0", $parts);
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Tue, Jun 10, 9:00 PM (1 d, 5 h)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 141022
Default Alt Text: (3 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions