Page MenuHomestyx hydra

No OneTemporary

diff --git a/src/applications/notification/view/PhabricatorNotificationStatusView.php b/src/applications/notification/view/PhabricatorNotificationStatusView.php
index e962395bba..69939525cc 100644
--- a/src/applications/notification/view/PhabricatorNotificationStatusView.php
+++ b/src/applications/notification/view/PhabricatorNotificationStatusView.php
@@ -1,73 +1,80 @@
<?php
final class PhabricatorNotificationStatusView extends AphrontTagView {
protected function getTagAttributes() {
if (!$this->getID()) {
$this->setID(celerity_generate_unique_node_id());
}
Javelin::initBehavior(
'aphlict-status',
array(
'nodeID' => $this->getID(),
'pht' => array(
'setup' => pht('Setting Up Client'),
'open' => pht('Connected'),
'closed' => pht('Disconnected'),
),
'icon' => array(
'open' => array(
'icon' => 'fa-circle',
'color' => 'green',
),
'setup' => array(
'icon' => 'fa-circle',
'color' => 'yellow',
),
'closed' => array(
'icon' => 'fa-circle',
'color' => 'red',
),
),
));
return array(
'class' => 'aphlict-connection-status',
);
}
protected function getTagContent() {
$have = PhabricatorEnv::getEnvConfig('notification.servers');
if ($have) {
- $icon = id(new PHUIIconView())
- ->setIcon('fa-circle-o yellow');
- $text = pht('Connecting...');
- return phutil_tag(
- 'span',
- array(
- 'class' => 'connection-status-text '.
- 'aphlict-connection-status-connecting',
- ),
- array(
- $icon,
- $text,
- ));
+ return $this->buildMessageView(
+ 'aphlict-connection-status-connecting',
+ 'fa-circle-o yellow',
+ pht('Connecting...'));
} else {
- $text = pht('Notification server not enabled');
- $icon = id(new PHUIIconView())
- ->setIcon('fa-circle-o grey');
- return phutil_tag(
- 'span',
- array(
- 'class' => 'connection-status-text '.
- 'aphlict-connection-status-notenabled',
- ),
- array(
- $icon,
- $text,
- ));
+ return $this->buildMessageView(
+ 'aphlict-connection-status-notenabled',
+ 'fa-circle-o grey',
+ pht('Notification server not enabled'));
}
}
+ /**
+ * Create an icon and a message.
+ *
+ * @param string $class_name Raw CSS class name(s) space separated
+ * @param string $icon_name Icon name
+ * @param string $text Text to be shown
+ * @return array
+ */
+ private function buildMessageView($class_name, $icon_name, $text) {
+ $icon = id(new PHUIIconView())
+ ->setIcon($icon_name);
+
+ $message = phutil_tag(
+ 'span',
+ array(
+ 'class' => 'connection-status-text '.$class_name,
+ ),
+ $text);
+
+ return array(
+ $icon,
+ $message,
+ );
+ }
+
}

File Metadata

Mime Type
text/x-diff
Expires
Tue, Nov 26, 7:21 PM (1 d, 19 h)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1231
Default Alt Text
(3 KB)

Event Timeline