View Options

	diff --git a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php
	index 3ee42a531c..f56f958a62 100644
	--- a/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php
	+++ b/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldInt.php
	@@ -1,132 +1,145 @@
	<?php

	final class PhabricatorStandardCustomFieldInt
	extends PhabricatorStandardCustomField {

	public function getFieldType() {
	return 'int';
	}

	public function buildFieldIndexes() {
	$indexes = array();

	$value = $this->getFieldValue();
	if (phutil_nonempty_scalar($value)) {
	$indexes[] = $this->newNumericIndex((int)$value);
	}

	return $indexes;
	}

	public function buildOrderIndex() {
	return $this->newNumericIndex(0);
	}

	public function getValueForStorage() {
	$value = $this->getFieldValue();
	$is_nonempty = phutil_string_cast($value) !== '';
	if ($is_nonempty) {
	return $value;
	} else {
	return null;
	}
	}

	public function setValueFromStorage($value) {
	if (phutil_nonempty_scalar($value)) {
	$value = (int)$value;
	} else {
	$value = null;
	}
	return $this->setFieldValue($value);
	}

	public function readApplicationSearchValueFromRequest(
	PhabricatorApplicationSearchEngine $engine,
	AphrontRequest $request) {

	return $request->getStr($this->getFieldKey());
	}

	+ /**
	+ * Apply an application search constraint to a query.
	+ * If you have a field of type integer, and a value (or an array of values),
	+ * the result set will be limited to the rows with these values.
	+ * @param PhabricatorApplicationSearchEngine $engine
	+ * @param PhabricatorCursorPagedPolicyAwareQuery $query
	+ * @param mixed $value Single value or array of values (IN query).
	+ */
	public function applyApplicationSearchConstraintToQuery(
	PhabricatorApplicationSearchEngine $engine,
	PhabricatorCursorPagedPolicyAwareQuery $query,
	$value) {

	- if (phutil_nonempty_scalar($value)) {
	- $query->withApplicationSearchContainsConstraint(
	- $this->newNumericIndex(null),
	- $value);
	+ // The basic use case is with a single value.
	+ // The backend really works with an array. So also array allowed.
	+ if (is_array($value) \|\| phutil_nonempty_scalar($value)) {
	+ $value = (array)$value;
	+ if ($value) {
	+ $query->withApplicationSearchContainsConstraint(
	+ $this->newNumericIndex(null),
	+ $value);
	+ }
	}
	}

	public function appendToApplicationSearchForm(
	PhabricatorApplicationSearchEngine $engine,
	AphrontFormView $form,
	$value) {

	$form->appendChild(
	id(new AphrontFormTextControl())
	->setLabel($this->getFieldName())
	->setName($this->getFieldKey())
	->setValue($value));
	}

	public function validateApplicationTransactions(
	PhabricatorApplicationTransactionEditor $editor,
	$type,
	array $xactions) {

	$errors = parent::validateApplicationTransactions(
	$editor,
	$type,
	$xactions);

	foreach ($xactions as $xaction) {
	$value = $xaction->getNewValue();
	if (phutil_nonempty_scalar($value)) {
	if (!preg_match('/^-?\d+/', $value)) {
	$errors[] = new PhabricatorApplicationTransactionValidationError(
	$type,
	pht('Invalid'),
	pht('%s must be an integer.', $this->getFieldName()),
	$xaction);
	$this->setFieldError(pht('Invalid'));
	}
	}
	}

	return $errors;
	}

	public function getApplicationTransactionHasEffect(
	PhabricatorApplicationTransaction $xaction) {

	$old = $xaction->getOldValue();
	$new = $xaction->getNewValue();
	if (!phutil_nonempty_scalar($old) && phutil_nonempty_scalar($new)) {
	return true;
	} else if (phutil_nonempty_scalar($old) && !phutil_nonempty_scalar($new)) {
	return true;
	} else {
	return ((int)$old !== (int)$new);
	}
	}

	protected function getHTTPParameterType() {
	return new AphrontIntHTTPParameterType();
	}

	protected function newConduitSearchParameterType() {
	return new ConduitIntParameterType();
	}

	protected function newConduitEditParameterType() {
	return new ConduitIntParameterType();
	}

	protected function newExportFieldType() {
	return new PhabricatorIntExportField();
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Tue, Nov 26, 12:26 PM (1 d, 11 h)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 1198
Default Alt Text: (4 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions