No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/settings/setting/PhabricatorMonospacedFontSetting.php b/src/applications/settings/setting/PhabricatorMonospacedFontSetting.php
	index 3ce55b26ad..2a96f5d95f 100644
	--- a/src/applications/settings/setting/PhabricatorMonospacedFontSetting.php
	+++ b/src/applications/settings/setting/PhabricatorMonospacedFontSetting.php
	@@ -1,48 +1,48 @@
	<?php

	final class PhabricatorMonospacedFontSetting
	extends PhabricatorStringSetting {

	const SETTINGKEY = 'monospaced';

	public function getSettingName() {
	return pht('Monospaced Font');
	}

	public function getSettingPanelKey() {
	return PhabricatorDisplayPreferencesSettingsPanel::PANELKEY;
	}

	protected function getSettingOrder() {
	return 500;
	}

	protected function getControlInstructions() {
	return pht(
	'You can customize the font used when showing monospaced text, '.
	'including source code. You should enter a valid CSS font declaration '.
	'like: `13px Consolas`');
	}

	public function validateTransactionValue($value) {
	if (!strlen($value)) {
	return;
	}

	$filtered = self::filterMonospacedCSSRule($value);
	if ($filtered !== $value) {
	throw new Exception(
	pht(
	'Monospaced font value "%s" is unsafe. You may only enter '.
	- 'letters, numbers, spaces, commas, periods, forward slashes '.
	- 'and double quotes.',
	+ 'letters, numbers, spaces, commas, periods, hyphens, '.
	+ 'forward slashes, and double quotes',
	$value));
	}
	}

	public static function filterMonospacedCSSRule($monospaced) {
	// Prevent the user from doing dangerous things.
	- return preg_replace('([^a-z0-9 ,"./]+)i', '', $monospaced);
	+ return preg_replace('([^a-z0-9 ,"./-]+)i', '', $monospaced);
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Thu, Nov 6, 9:47 AM (30 m, 24 s)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 321890
Default Alt Text: (1 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions