View Options

	diff --git a/src/applications/harbormaster/editor/HarbormasterBuildPlanEditEngine.php b/src/applications/harbormaster/editor/HarbormasterBuildPlanEditEngine.php
	index c0fa80d71b..b7d73f238b 100644
	--- a/src/applications/harbormaster/editor/HarbormasterBuildPlanEditEngine.php
	+++ b/src/applications/harbormaster/editor/HarbormasterBuildPlanEditEngine.php
	@@ -1,124 +1,124 @@
	<?php

	final class HarbormasterBuildPlanEditEngine
	extends PhabricatorEditEngine {

	const ENGINECONST = 'harbormaster.buildplan';

	public function isEngineConfigurable() {
	return false;
	}

	public function getEngineName() {
	return pht('Harbormaster Build Plans');
	}

	public function getSummaryHeader() {
	return pht('Edit Harbormaster Build Plan Configurations');
	}

	public function getSummaryText() {
	return pht('This engine is used to edit Harbormaster build plans.');
	}

	public function getEngineApplicationClass() {
	return 'PhabricatorHarbormasterApplication';
	}

	protected function newEditableObject() {
	$viewer = $this->getViewer();
	return HarbormasterBuildPlan::initializeNewBuildPlan($viewer);
	}

	protected function newObjectQuery() {
	return new HarbormasterBuildPlanQuery();
	}

	protected function getObjectCreateTitleText($object) {
	return pht('Create Build Plan');
	}

	protected function getObjectCreateButtonText($object) {
	return pht('Create Build Plan');
	}

	protected function getObjectEditTitleText($object) {
	return pht('Edit Build Plan: %s', $object->getName());
	}

	protected function getObjectEditShortText($object) {
	return pht('Edit Build Plan');
	}

	protected function getObjectCreateShortText() {
	return pht('Create Build Plan');
	}

	protected function getObjectName() {
	return pht('Build Plan');
	}

	protected function getEditorURI() {
	return '/harbormaster/plan/edit/';
	}

	protected function getObjectCreateCancelURI($object) {
	return '/harbormaster/plan/';
	}

	protected function getObjectViewURI($object) {
	$id = $object->getID();
	return "/harbormaster/plan/{$id}/";
	}

	protected function getCreateNewObjectPolicy() {
	return $this->getApplication()->getPolicy(
	HarbormasterCreatePlansCapability::CAPABILITY);
	}

	protected function buildCustomEditFields($object) {
	$fields = array(
	id(new PhabricatorTextEditField())
	->setKey('name')
	->setLabel(pht('Name'))
	->setIsRequired(true)
	->setTransactionType(
	HarbormasterBuildPlanNameTransaction::TRANSACTIONTYPE)
	->setDescription(pht('The build plan name.'))
	->setConduitDescription(pht('Rename the plan.'))
	->setConduitTypeDescription(pht('New plan name.'))
	->setValue($object->getName()),
	);


	$metadata_key = HarbormasterBuildPlanBehavior::getTransactionMetadataKey();

	$behaviors = HarbormasterBuildPlanBehavior::newPlanBehaviors();
	foreach ($behaviors as $behavior) {
	$key = $behavior->getKey();

	// Get the raw key off the object so that we don't reset stuff to
	// default values by mistake if a behavior goes missing somehow.
	$storage_key = HarbormasterBuildPlanBehavior::getStorageKeyForBehaviorKey(
	$key);
	$behavior_option = $object->getPlanProperty($storage_key);

	- if (!strlen($behavior_option)) {
	+ if (!phutil_nonempty_string($behavior_option)) {
	$behavior_option = $behavior->getPlanOption($object)->getKey();
	}

	$fields[] = id(new PhabricatorSelectEditField())
	->setIsFormField(false)
	->setKey(sprintf('behavior.%s', $behavior->getKey()))
	->setMetadataValue($metadata_key, $behavior->getKey())
	->setLabel(pht('Behavior: %s', $behavior->getName()))
	->setTransactionType(
	HarbormasterBuildPlanBehaviorTransaction::TRANSACTIONTYPE)
	->setValue($behavior_option)
	->setOptions($behavior->getOptionMap());
	}

	return $fields;
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Wed, Apr 30, 7:18 PM (1 d, 4 h)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 108796
Default Alt Text: (4 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions