No OneTemporary
Actions

Size

40 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
	index ad668db376..a5c98dc202 100644
	--- a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
	+++ b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
	@@ -1,542 +1,562 @@
	<?php

	final class ManiphestTaskSearchEngine
	extends PhabricatorApplicationSearchEngine {

	private $showBatchControls;
	private $baseURI;
	private $isBoardView;

	public function setIsBoardView($is_board_view) {
	$this->isBoardView = $is_board_view;
	return $this;
	}

	public function getIsBoardView() {
	return $this->isBoardView;
	}

	public function setBaseURI($base_uri) {
	$this->baseURI = $base_uri;
	return $this;
	}

	public function getBaseURI() {
	return $this->baseURI;
	}

	public function setShowBatchControls($show_batch_controls) {
	$this->showBatchControls = $show_batch_controls;
	return $this;
	}

	public function getResultTypeDescription() {
	return pht('Maniphest Tasks');
	}

	public function getApplicationClassName() {
	return 'PhabricatorManiphestApplication';
	}

	public function newQuery() {
	return id(new ManiphestTaskQuery())
	->needProjectPHIDs(true);
	}

	protected function buildCustomSearchFields() {
	// Hide the "Subtypes" constraint from the web UI if the install only
	// defines one task subtype, since it isn't of any use in this case.
	$subtype_map = id(new ManiphestTask())->newEditEngineSubtypeMap();
	$hide_subtypes = (count($subtype_map) == 1);

	return array(
	id(new PhabricatorOwnersSearchField())
	->setLabel(pht('Assigned To'))
	->setKey('assignedPHIDs')
	->setConduitKey('assigned')
	->setAliases(array('assigned'))
	->setDescription(
	pht('Search for tasks owned by a user from a list.')),
	id(new PhabricatorUsersSearchField())
	->setLabel(pht('Authors'))
	->setKey('authorPHIDs')
	->setAliases(array('author', 'authors'))
	->setDescription(
	pht('Search for tasks with given authors.')),
	id(new PhabricatorSearchDatasourceField())
	->setLabel(pht('Statuses'))
	->setKey('statuses')
	->setAliases(array('status'))
	->setDescription(
	pht('Search for tasks with given statuses.'))
	->setDatasource(new ManiphestTaskStatusFunctionDatasource()),
	id(new PhabricatorSearchDatasourceField())
	->setLabel(pht('Priorities'))
	->setKey('priorities')
	->setAliases(array('priority'))
	->setDescription(
	pht('Search for tasks with given priorities.'))
	->setConduitParameterType(new ConduitIntListParameterType())
	->setDatasource(new ManiphestTaskPriorityDatasource()),
	id(new PhabricatorSearchDatasourceField())
	->setLabel(pht('Subtypes'))
	->setKey('subtypes')
	->setAliases(array('subtype'))
	->setDescription(
	pht('Search for tasks with given subtypes.'))
	->setDatasource(new ManiphestTaskSubtypeDatasource())
	->setIsHidden($hide_subtypes),
	id(new PhabricatorSearchThreeStateField())
	->setLabel(pht('Open Parents'))
	->setKey('hasParents')
	->setAliases(array('blocking'))
	->setOptions(
	pht('(Show All)'),
	pht('Show Only Tasks With Open Parents'),
	pht('Show Only Tasks Without Open Parents')),
	id(new PhabricatorSearchThreeStateField())
	->setLabel(pht('Open Subtasks'))
	->setKey('hasSubtasks')
	->setAliases(array('blocked'))
	->setOptions(
	pht('(Show All)'),
	pht('Show Only Tasks With Open Subtasks'),
	pht('Show Only Tasks Without Open Subtasks')),
	id(new PhabricatorIDsSearchField())
	->setLabel(pht('Parent IDs'))
	->setKey('parentIDs')
	->setAliases(array('parentID')),
	id(new PhabricatorIDsSearchField())
	->setLabel(pht('Subtask IDs'))
	->setKey('subtaskIDs')
	->setAliases(array('subtaskID')),
	id(new PhabricatorSearchSelectField())
	->setLabel(pht('Group By'))
	->setKey('group')
	->setOptions($this->getGroupOptions()),
	id(new PhabricatorSearchDateField())
	->setLabel(pht('Created After'))
	->setKey('createdStart'),
	id(new PhabricatorSearchDateField())
	->setLabel(pht('Created Before'))
	->setKey('createdEnd'),
	id(new PhabricatorSearchDateField())
	->setLabel(pht('Updated After'))
	->setKey('modifiedStart'),
	id(new PhabricatorSearchDateField())
	->setLabel(pht('Updated Before'))
	->setKey('modifiedEnd'),
	id(new PhabricatorSearchTextField())
	->setLabel(pht('Page Size'))
	->setKey('limit'),
	);
	}

	protected function getDefaultFieldOrder() {
	return array(
	'assignedPHIDs',
	'projectPHIDs',
	'authorPHIDs',
	'subscriberPHIDs',
	'statuses',
	'priorities',
	'subtypes',
	'hasParents',
	'hasSubtasks',
	'parentIDs',
	'subtaskIDs',
	'group',
	'order',
	'ids',
	'...',
	'createdStart',
	'createdEnd',
	'modifiedStart',
	'modifiedEnd',
	'limit',
	);
	}

	protected function getHiddenFields() {
	$keys = array();

	if ($this->getIsBoardView()) {
	$keys[] = 'group';
	$keys[] = 'order';
	$keys[] = 'limit';
	}

	return $keys;
	}

	protected function buildQueryFromParameters(array $map) {
	$query = $this->newQuery();

	if ($map['assignedPHIDs']) {
	$query->withOwners($map['assignedPHIDs']);
	}

	if ($map['authorPHIDs']) {
	$query->withAuthors($map['authorPHIDs']);
	}

	if ($map['statuses']) {
	$query->withStatuses($map['statuses']);
	}

	if ($map['priorities']) {
	$query->withPriorities($map['priorities']);
	}

	if ($map['subtypes']) {
	$query->withSubtypes($map['subtypes']);
	}

	if ($map['createdStart']) {
	$query->withDateCreatedAfter($map['createdStart']);
	}

	if ($map['createdEnd']) {
	$query->withDateCreatedBefore($map['createdEnd']);
	}

	if ($map['modifiedStart']) {
	$query->withDateModifiedAfter($map['modifiedStart']);
	}

	if ($map['modifiedEnd']) {
	$query->withDateModifiedBefore($map['modifiedEnd']);
	}

	if ($map['hasParents'] !== null) {
	$query->withOpenParents($map['hasParents']);
	}

	if ($map['hasSubtasks'] !== null) {
	$query->withOpenSubtasks($map['hasSubtasks']);
	}

	if ($map['parentIDs']) {
	$query->withParentTaskIDs($map['parentIDs']);
	}

	if ($map['subtaskIDs']) {
	$query->withSubtaskIDs($map['subtaskIDs']);
	}

	$group = idx($map, 'group');
	$group = idx($this->getGroupValues(), $group);
	if ($group) {
	$query->setGroupBy($group);
	}

	if ($map['ids']) {
	$ids = $map['ids'];
	foreach ($ids as $key => $id) {
	$id = trim($id, ' Tt');
	if (!$id \|\| !is_numeric($id)) {
	unset($ids[$key]);
	} else {
	$ids[$key] = $id;
	}
	}

	if ($ids) {
	$query->withIDs($ids);
	}
	}

	return $query;
	}

	protected function getURI($path) {
	if ($this->baseURI) {
	return $this->baseURI.$path;
	}
	return '/maniphest/'.$path;
	}

	protected function getBuiltinQueryNames() {
	$names = array();

	if ($this->requireViewer()->isLoggedIn()) {
	$names['assigned'] = pht('Assigned');
	$names['authored'] = pht('Authored');
	$names['subscribed'] = pht('Subscribed');
	}

	$names['open'] = pht('Open Tasks');
	$names['all'] = pht('All Tasks');

	return $names;
	}

	public function buildSavedQueryFromBuiltin($query_key) {

	$query = $this->newSavedQuery();
	$query->setQueryKey($query_key);

	$viewer_phid = $this->requireViewer()->getPHID();

	switch ($query_key) {
	case 'all':
	return $query;
	case 'assigned':
	return $query
	->setParameter('assignedPHIDs', array($viewer_phid))
	->setParameter(
	'statuses',
	ManiphestTaskStatus::getOpenStatusConstants());
	case 'subscribed':
	return $query
	->setParameter('subscriberPHIDs', array($viewer_phid))
	->setParameter(
	'statuses',
	ManiphestTaskStatus::getOpenStatusConstants());
	case 'open':
	return $query
	->setParameter(
	'statuses',
	ManiphestTaskStatus::getOpenStatusConstants());
	case 'authored':
	return $query
	->setParameter('authorPHIDs', array($viewer_phid))
	->setParameter('order', 'created')
	->setParameter('group', 'none');
	}

	return parent::buildSavedQueryFromBuiltin($query_key);
	}

	private function getGroupOptions() {
	return array(
	'priority' => pht('Priority'),
	'assigned' => pht('Assigned'),
	'status' => pht('Status'),
	'project' => pht('Project'),
	'none' => pht('None'),
	);
	}

	private function getGroupValues() {
	return array(
	'priority' => ManiphestTaskQuery::GROUP_PRIORITY,
	'assigned' => ManiphestTaskQuery::GROUP_OWNER,
	'status' => ManiphestTaskQuery::GROUP_STATUS,
	'project' => ManiphestTaskQuery::GROUP_PROJECT,
	'none' => ManiphestTaskQuery::GROUP_NONE,
	);
	}

	protected function renderResultList(
	array $tasks,
	PhabricatorSavedQuery $saved,
	array $handles) {

	$viewer = $this->requireViewer();

	if ($this->isPanelContext()) {
	$can_edit_priority = false;
	$can_bulk_edit = false;
	} else {
	$can_edit_priority = PhabricatorPolicyFilter::hasCapability(
	$viewer,
	$this->getApplication(),
	ManiphestEditPriorityCapability::CAPABILITY);

	$can_bulk_edit = PhabricatorPolicyFilter::hasCapability(
	$viewer,
	$this->getApplication(),
	ManiphestBulkEditCapability::CAPABILITY);
	}

	$list = id(new ManiphestTaskResultListView())
	->setUser($viewer)
	->setTasks($tasks)
	->setSavedQuery($saved)
	->setCanEditPriority($can_edit_priority)
	->setCanBatchEdit($can_bulk_edit)
	->setShowBatchControls($this->showBatchControls);

	$result = new PhabricatorApplicationSearchResultView();
	$result->setContent($list);

	return $result;
	}

	protected function willUseSavedQuery(PhabricatorSavedQuery $saved) {

	// The 'withUnassigned' parameter may be present in old saved queries from
	// before parameterized typeaheads, and is retained for compatibility. We
	// could remove it by migrating old saved queries.
	$assigned_phids = $saved->getParameter('assignedPHIDs', array());
	if ($saved->getParameter('withUnassigned')) {
	$assigned_phids[] = PhabricatorPeopleNoOwnerDatasource::FUNCTION_TOKEN;
	}
	$saved->setParameter('assignedPHIDs', $assigned_phids);

	// The 'projects' and other parameters may be present in old saved queries
	// from before parameterized typeaheads.
	$project_phids = $saved->getParameter('projectPHIDs', array());

	$old = $saved->getParameter('projects', array());
	foreach ($old as $phid) {
	$project_phids[] = $phid;
	}

	$all = $saved->getParameter('allProjectPHIDs', array());
	foreach ($all as $phid) {
	$project_phids[] = $phid;
	}

	$any = $saved->getParameter('anyProjectPHIDs', array());
	foreach ($any as $phid) {
	$project_phids[] = 'any('.$phid.')';
	}

	$not = $saved->getParameter('excludeProjectPHIDs', array());
	foreach ($not as $phid) {
	$project_phids[] = 'not('.$phid.')';
	}

	$users = $saved->getParameter('userProjectPHIDs', array());
	foreach ($users as $phid) {
	$project_phids[] = 'projects('.$phid.')';
	}

	$no = $saved->getParameter('withNoProject');
	if ($no) {
	$project_phids[] = 'null()';
	}

	$saved->setParameter('projectPHIDs', $project_phids);
	}

	protected function getNewUserBody() {
	$viewer = $this->requireViewer();

	$create_button = id(new ManiphestEditEngine())
	->setViewer($viewer)
	->newNUXBUtton(pht('Create a Task'));

	$icon = $this->getApplication()->getIcon();
	$app_name = $this->getApplication()->getName();
	$view = id(new PHUIBigInfoView())
	->setIcon($icon)
	->setTitle(pht('Welcome to %s', $app_name))
	->setDescription(
	pht('Use Maniphest to track bugs, features, todos, or anything else '.
	'you need to get done. Tasks assigned to you will appear here.'))
	->addAction($create_button);

	return $view;
	}


	protected function newExportFields() {
	$fields = array(
	id(new PhabricatorStringExportField())
	->setKey('monogram')
	->setLabel(pht('Monogram')),
	id(new PhabricatorPHIDExportField())
	->setKey('authorPHID')
	->setLabel(pht('Author PHID')),
	id(new PhabricatorStringExportField())
	->setKey('author')
	->setLabel(pht('Author')),
	id(new PhabricatorPHIDExportField())
	->setKey('ownerPHID')
	->setLabel(pht('Owner PHID')),
	id(new PhabricatorStringExportField())
	->setKey('owner')
	->setLabel(pht('Owner')),
	id(new PhabricatorStringExportField())
	->setKey('status')
	->setLabel(pht('Status')),
	id(new PhabricatorStringExportField())
	->setKey('statusName')
	->setLabel(pht('Status Name')),
	+ id(new PhabricatorEpochExportField())
	+ ->setKey('dateClosed')
	+ ->setLabel(pht('Date Closed')),
	+ id(new PhabricatorPHIDExportField())
	+ ->setKey('closerPHID')
	+ ->setLabel(pht('Closer PHID')),
	+ id(new PhabricatorStringExportField())
	+ ->setKey('closer')
	+ ->setLabel(pht('Closer')),
	id(new PhabricatorStringExportField())
	->setKey('priority')
	->setLabel(pht('Priority')),
	id(new PhabricatorStringExportField())
	->setKey('priorityName')
	->setLabel(pht('Priority Name')),
	id(new PhabricatorStringExportField())
	->setKey('subtype')
	->setLabel('Subtype'),
	id(new PhabricatorURIExportField())
	->setKey('uri')
	->setLabel(pht('URI')),
	id(new PhabricatorStringExportField())
	->setKey('title')
	->setLabel(pht('Title')),
	id(new PhabricatorStringExportField())
	->setKey('description')
	->setLabel(pht('Description')),
	);

	if (ManiphestTaskPoints::getIsEnabled()) {
	$fields[] = id(new PhabricatorIntExportField())
	->setKey('points')
	->setLabel('Points');
	}

	return $fields;
	}

	protected function newExportData(array $tasks) {
	$viewer = $this->requireViewer();

	$phids = array();
	foreach ($tasks as $task) {
	$phids[] = $task->getAuthorPHID();
	$phids[] = $task->getOwnerPHID();
	+ $phids[] = $task->getCloserPHID();
	}
	$handles = $viewer->loadHandles($phids);

	$export = array();
	foreach ($tasks as $task) {

	$author_phid = $task->getAuthorPHID();
	if ($author_phid) {
	$author_name = $handles[$author_phid]->getName();
	} else {
	$author_name = null;
	}

	$owner_phid = $task->getOwnerPHID();
	if ($owner_phid) {
	$owner_name = $handles[$owner_phid]->getName();
	} else {
	$owner_name = null;
	}

	+ $closer_phid = $task->getCloserPHID();
	+ if ($closer_phid) {
	+ $closer_name = $handles[$closer_phid]->getName();
	+ } else {
	+ $closer_name = null;
	+ }
	+
	$status_value = $task->getStatus();
	$status_name = ManiphestTaskStatus::getTaskStatusName($status_value);

	$priority_value = $task->getPriority();
	$priority_name = ManiphestTaskPriority::getTaskPriorityName(
	$priority_value);

	$export[] = array(
	'monogram' => $task->getMonogram(),
	'authorPHID' => $author_phid,
	'author' => $author_name,
	'ownerPHID' => $owner_phid,
	'owner' => $owner_name,
	'status' => $status_value,
	'statusName' => $status_name,
	'priority' => $priority_value,
	'priorityName' => $priority_name,
	'points' => $task->getPoints(),
	'subtype' => $task->getSubtype(),
	'title' => $task->getTitle(),
	'uri' => PhabricatorEnv::getProductionURI($task->getURI()),
	'description' => $task->getDescription(),
	+ 'dateClosed' => $task->getClosedEpoch(),
	+ 'closerPHID' => $closer_phid,
	+ 'closer' => $closer_name,
	);
	}

	return $export;
	}
	}
	diff --git a/src/applications/maniphest/storage/ManiphestTask.php b/src/applications/maniphest/storage/ManiphestTask.php
	index 7ff70abd80..a93fe58c3f 100644
	--- a/src/applications/maniphest/storage/ManiphestTask.php
	+++ b/src/applications/maniphest/storage/ManiphestTask.php
	@@ -1,616 +1,633 @@
	<?php

	final class ManiphestTask extends ManiphestDAO
	implements
	PhabricatorSubscribableInterface,
	PhabricatorMarkupInterface,
	PhabricatorPolicyInterface,
	PhabricatorTokenReceiverInterface,
	PhabricatorFlaggableInterface,
	PhabricatorMentionableInterface,
	PhrequentTrackableInterface,
	PhabricatorCustomFieldInterface,
	PhabricatorDestructibleInterface,
	PhabricatorApplicationTransactionInterface,
	PhabricatorProjectInterface,
	PhabricatorSpacesInterface,
	PhabricatorConduitResultInterface,
	PhabricatorFulltextInterface,
	PhabricatorFerretInterface,
	DoorkeeperBridgedObjectInterface,
	PhabricatorEditEngineSubtypeInterface,
	PhabricatorEditEngineLockableInterface {

	const MARKUP_FIELD_DESCRIPTION = 'markup:desc';

	protected $authorPHID;
	protected $ownerPHID;

	protected $status;
	protected $priority;
	protected $subpriority = 0;

	protected $title = '';
	protected $description = '';
	protected $originalEmailSource;
	protected $mailKey;
	protected $viewPolicy = PhabricatorPolicies::POLICY_USER;
	protected $editPolicy = PhabricatorPolicies::POLICY_USER;

	protected $ownerOrdering;
	protected $spacePHID;
	protected $bridgedObjectPHID;
	protected $properties = array();
	protected $points;
	protected $subtype;

	protected $closedEpoch;
	protected $closerPHID;

	private $subscriberPHIDs = self::ATTACHABLE;
	private $groupByProjectPHID = self::ATTACHABLE;
	private $customFields = self::ATTACHABLE;
	private $edgeProjectPHIDs = self::ATTACHABLE;
	private $bridgedObject = self::ATTACHABLE;

	public static function initializeNewTask(PhabricatorUser $actor) {
	$app = id(new PhabricatorApplicationQuery())
	->setViewer($actor)
	->withClasses(array('PhabricatorManiphestApplication'))
	->executeOne();

	$view_policy = $app->getPolicy(ManiphestDefaultViewCapability::CAPABILITY);
	$edit_policy = $app->getPolicy(ManiphestDefaultEditCapability::CAPABILITY);

	return id(new ManiphestTask())
	->setStatus(ManiphestTaskStatus::getDefaultStatus())
	->setPriority(ManiphestTaskPriority::getDefaultPriority())
	->setAuthorPHID($actor->getPHID())
	->setViewPolicy($view_policy)
	->setEditPolicy($edit_policy)
	->setSpacePHID($actor->getDefaultSpacePHID())
	->setSubtype(PhabricatorEditEngineSubtype::SUBTYPE_DEFAULT)
	->attachProjectPHIDs(array())
	->attachSubscriberPHIDs(array());
	}

	protected function getConfiguration() {
	return array(
	self::CONFIG_AUX_PHID => true,
	self::CONFIG_SERIALIZATION => array(
	'properties' => self::SERIALIZATION_JSON,
	),
	self::CONFIG_COLUMN_SCHEMA => array(
	'ownerPHID' => 'phid?',
	'status' => 'text64',
	'priority' => 'uint32',
	'title' => 'sort',
	'description' => 'text',
	'mailKey' => 'bytes20',
	'ownerOrdering' => 'text64?',
	'originalEmailSource' => 'text255?',
	'subpriority' => 'double',
	'points' => 'double?',
	'bridgedObjectPHID' => 'phid?',
	'subtype' => 'text64',
	'closedEpoch' => 'epoch?',
	'closerPHID' => 'phid?',
	),
	self::CONFIG_KEY_SCHEMA => array(
	'key_phid' => null,
	'phid' => array(
	'columns' => array('phid'),
	'unique' => true,
	),
	'priority' => array(
	'columns' => array('priority', 'status'),
	),
	'status' => array(
	'columns' => array('status'),
	),
	'ownerPHID' => array(
	'columns' => array('ownerPHID', 'status'),
	),
	'authorPHID' => array(
	'columns' => array('authorPHID', 'status'),
	),
	'ownerOrdering' => array(
	'columns' => array('ownerOrdering'),
	),
	'priority_2' => array(
	'columns' => array('priority', 'subpriority'),
	),
	'key_dateCreated' => array(
	'columns' => array('dateCreated'),
	),
	'key_dateModified' => array(
	'columns' => array('dateModified'),
	),
	'key_title' => array(
	'columns' => array('title(64)'),
	),
	'key_bridgedobject' => array(
	'columns' => array('bridgedObjectPHID'),
	'unique' => true,
	),
	'key_subtype' => array(
	'columns' => array('subtype'),
	),
	'key_closed' => array(
	'columns' => array('closedEpoch'),
	),
	'key_closer' => array(
	'columns' => array('closerPHID', 'closedEpoch'),
	),
	),
	) + parent::getConfiguration();
	}

	public function loadDependsOnTaskPHIDs() {
	return PhabricatorEdgeQuery::loadDestinationPHIDs(
	$this->getPHID(),
	ManiphestTaskDependsOnTaskEdgeType::EDGECONST);
	}

	public function loadDependedOnByTaskPHIDs() {
	return PhabricatorEdgeQuery::loadDestinationPHIDs(
	$this->getPHID(),
	ManiphestTaskDependedOnByTaskEdgeType::EDGECONST);
	}

	public function generatePHID() {
	return PhabricatorPHID::generateNewPHID(ManiphestTaskPHIDType::TYPECONST);
	}

	public function getSubscriberPHIDs() {
	return $this->assertAttached($this->subscriberPHIDs);
	}

	public function getProjectPHIDs() {
	return $this->assertAttached($this->edgeProjectPHIDs);
	}

	public function attachProjectPHIDs(array $phids) {
	$this->edgeProjectPHIDs = $phids;
	return $this;
	}

	public function attachSubscriberPHIDs(array $phids) {
	$this->subscriberPHIDs = $phids;
	return $this;
	}

	public function setOwnerPHID($phid) {
	$this->ownerPHID = nonempty($phid, null);
	return $this;
	}

	public function getMonogram() {
	return 'T'.$this->getID();
	}

	public function getURI() {
	return '/'.$this->getMonogram();
	}

	public function attachGroupByProjectPHID($phid) {
	$this->groupByProjectPHID = $phid;
	return $this;
	}

	public function getGroupByProjectPHID() {
	return $this->assertAttached($this->groupByProjectPHID);
	}

	public function save() {
	if (!$this->mailKey) {
	$this->mailKey = Filesystem::readRandomCharacters(20);
	}

	$result = parent::save();

	return $result;
	}

	public function isClosed() {
	return ManiphestTaskStatus::isClosedStatus($this->getStatus());
	}

	public function isLocked() {
	return ManiphestTaskStatus::isLockedStatus($this->getStatus());
	}

	public function setProperty($key, $value) {
	$this->properties[$key] = $value;
	return $this;
	}

	public function getProperty($key, $default = null) {
	return idx($this->properties, $key, $default);
	}

	public function getCoverImageFilePHID() {
	return idx($this->properties, 'cover.filePHID');
	}

	public function getCoverImageThumbnailPHID() {
	return idx($this->properties, 'cover.thumbnailPHID');
	}

	public function getWorkboardOrderVectors() {
	return array(
	PhabricatorProjectColumn::ORDER_PRIORITY => array(
	(int)-$this->getPriority(),
	(double)-$this->getSubpriority(),
	(int)-$this->getID(),
	),
	);
	}

	public function getPriorityKeyword() {
	$priority = $this->getPriority();

	$keyword = ManiphestTaskPriority::getKeywordForTaskPriority($priority);
	if ($keyword !== null) {
	return $keyword;
	}

	return ManiphestTaskPriority::UNKNOWN_PRIORITY_KEYWORD;
	}

	private function comparePriorityTo(ManiphestTask $other) {
	$upri = $this->getPriority();
	$vpri = $other->getPriority();

	if ($upri != $vpri) {
	return ($upri - $vpri);
	}

	$usub = $this->getSubpriority();
	$vsub = $other->getSubpriority();

	if ($usub != $vsub) {
	return ($usub - $vsub);
	}

	$uid = $this->getID();
	$vid = $other->getID();

	if ($uid != $vid) {
	return ($uid - $vid);
	}

	return 0;
	}

	public function isLowerPriorityThan(ManiphestTask $other) {
	return ($this->comparePriorityTo($other) < 0);
	}

	public function isHigherPriorityThan(ManiphestTask $other) {
	return ($this->comparePriorityTo($other) > 0);
	}

	public function getWorkboardProperties() {
	return array(
	'status' => $this->getStatus(),
	'points' => (double)$this->getPoints(),
	);
	}


	/* -( PhabricatorSubscribableInterface )----------------------------------- */


	public function isAutomaticallySubscribed($phid) {
	return ($phid == $this->getOwnerPHID());
	}


	/* -( Markup Interface )--------------------------------------------------- */


	/**
	* @task markup
	*/
	public function getMarkupFieldKey($field) {
	$content = $this->getMarkupText($field);
	return PhabricatorMarkupEngine::digestRemarkupContent($this, $content);
	}


	/**
	* @task markup
	*/
	public function getMarkupText($field) {
	return $this->getDescription();
	}


	/**
	* @task markup
	*/
	public function newMarkupEngine($field) {
	return PhabricatorMarkupEngine::newManiphestMarkupEngine();
	}


	/**
	* @task markup
	*/
	public function didMarkupText(
	$field,
	$output,
	PhutilMarkupEngine $engine) {
	return $output;
	}


	/**
	* @task markup
	*/
	public function shouldUseMarkupCache($field) {
	return (bool)$this->getID();
	}


	/* -( Policy Interface )--------------------------------------------------- */


	public function getCapabilities() {
	return array(
	PhabricatorPolicyCapability::CAN_VIEW,
	PhabricatorPolicyCapability::CAN_INTERACT,
	PhabricatorPolicyCapability::CAN_EDIT,
	);
	}

	public function getPolicy($capability) {
	switch ($capability) {
	case PhabricatorPolicyCapability::CAN_VIEW:
	return $this->getViewPolicy();
	case PhabricatorPolicyCapability::CAN_INTERACT:
	if ($this->isLocked()) {
	return PhabricatorPolicies::POLICY_NOONE;
	} else {
	return $this->getViewPolicy();
	}
	case PhabricatorPolicyCapability::CAN_EDIT:
	return $this->getEditPolicy();
	}
	}

	public function hasAutomaticCapability($capability, PhabricatorUser $user) {
	// The owner of a task can always view and edit it.
	$owner_phid = $this->getOwnerPHID();
	if ($owner_phid) {
	$user_phid = $user->getPHID();
	if ($user_phid == $owner_phid) {
	return true;
	}
	}

	return false;
	}

	public function describeAutomaticCapability($capability) {
	return pht('The owner of a task can always view and edit it.');
	}


	/* -( PhabricatorTokenReceiverInterface )---------------------------------- */


	public function getUsersToNotifyOfTokenGiven() {
	// Sort of ambiguous who this was intended for; just let them both know.
	return array_filter(
	array_unique(
	array(
	$this->getAuthorPHID(),
	$this->getOwnerPHID(),
	)));
	}


	/* -( PhabricatorCustomFieldInterface )------------------------------------ */


	public function getCustomFieldSpecificationForRole($role) {
	return PhabricatorEnv::getEnvConfig('maniphest.fields');
	}

	public function getCustomFieldBaseClass() {
	return 'ManiphestCustomField';
	}

	public function getCustomFields() {
	return $this->assertAttached($this->customFields);
	}

	public function attachCustomFields(PhabricatorCustomFieldAttachment $fields) {
	$this->customFields = $fields;
	return $this;
	}


	/* -( PhabricatorDestructibleInterface )----------------------------------- */


	public function destroyObjectPermanently(
	PhabricatorDestructionEngine $engine) {

	$this->openTransaction();
	$this->delete();
	$this->saveTransaction();
	}


	/* -( PhabricatorApplicationTransactionInterface )------------------------- */


	public function getApplicationTransactionEditor() {
	return new ManiphestTransactionEditor();
	}

	public function getApplicationTransactionObject() {
	return $this;
	}

	public function getApplicationTransactionTemplate() {
	return new ManiphestTransaction();
	}

	public function willRenderTimeline(
	PhabricatorApplicationTransactionView $timeline,
	AphrontRequest $request) {

	return $timeline;
	}


	/* -( PhabricatorSpacesInterface )----------------------------------------- */


	public function getSpacePHID() {
	return $this->spacePHID;
	}


	/* -( PhabricatorConduitResultInterface )---------------------------------- */


	public function getFieldSpecificationsForConduit() {
	return array(
	id(new PhabricatorConduitSearchFieldSpecification())
	->setKey('title')
	->setType('string')
	->setDescription(pht('The title of the task.')),
	id(new PhabricatorConduitSearchFieldSpecification())
	->setKey('description')
	->setType('remarkup')
	->setDescription(pht('The task description.')),
	id(new PhabricatorConduitSearchFieldSpecification())
	->setKey('authorPHID')
	->setType('phid')
	->setDescription(pht('Original task author.')),
	id(new PhabricatorConduitSearchFieldSpecification())
	->setKey('ownerPHID')
	->setType('phid?')
	->setDescription(pht('Current task owner, if task is assigned.')),
	id(new PhabricatorConduitSearchFieldSpecification())
	->setKey('status')
	->setType('map<string, wild>')
	->setDescription(pht('Information about task status.')),
	id(new PhabricatorConduitSearchFieldSpecification())
	->setKey('priority')
	->setType('map<string, wild>')
	->setDescription(pht('Information about task priority.')),
	id(new PhabricatorConduitSearchFieldSpecification())
	->setKey('points')
	->setType('points')
	->setDescription(pht('Point value of the task.')),
	id(new PhabricatorConduitSearchFieldSpecification())
	->setKey('subtype')
	->setType('string')
	->setDescription(pht('Subtype of the task.')),
	+ id(new PhabricatorConduitSearchFieldSpecification())
	+ ->setKey('closerPHID')
	+ ->setType('phid?')
	+ ->setDescription(
	+ pht('User who closed the task, if the task is closed.')),
	+ id(new PhabricatorConduitSearchFieldSpecification())
	+ ->setKey('dateClosed')
	+ ->setType('int?')
	+ ->setDescription(
	+ pht('Epoch timestamp when the task was closed.')),
	);
	}

	public function getFieldValuesForConduit() {
	$status_value = $this->getStatus();
	$status_info = array(
	'value' => $status_value,
	'name' => ManiphestTaskStatus::getTaskStatusName($status_value),
	'color' => ManiphestTaskStatus::getStatusColor($status_value),
	);

	$priority_value = (int)$this->getPriority();
	$priority_info = array(
	'value' => $priority_value,
	'subpriority' => (double)$this->getSubpriority(),
	'name' => ManiphestTaskPriority::getTaskPriorityName($priority_value),
	'color' => ManiphestTaskPriority::getTaskPriorityColor($priority_value),
	);

	+ $closed_epoch = $this->getClosedEpoch();
	+ if ($closed_epoch !== null) {
	+ $closed_epoch = (int)$closed_epoch;
	+ }
	+
	return array(
	'name' => $this->getTitle(),
	'description' => array(
	'raw' => $this->getDescription(),
	),
	'authorPHID' => $this->getAuthorPHID(),
	'ownerPHID' => $this->getOwnerPHID(),
	'status' => $status_info,
	'priority' => $priority_info,
	'points' => $this->getPoints(),
	'subtype' => $this->getSubtype(),
	+ 'closerPHID' => $this->getCloserPHID(),
	+ 'dateClosed' => $closed_epoch,
	);
	}

	public function getConduitSearchAttachments() {
	return array(
	id(new PhabricatorBoardColumnsSearchEngineAttachment())
	->setAttachmentKey('columns'),
	);
	}

	public function newSubtypeObject() {
	$subtype_key = $this->getEditEngineSubtype();
	$subtype_map = $this->newEditEngineSubtypeMap();
	return idx($subtype_map, $subtype_key);
	}

	/* -( PhabricatorFulltextInterface )--------------------------------------- */


	public function newFulltextEngine() {
	return new ManiphestTaskFulltextEngine();
	}


	/* -( DoorkeeperBridgedObjectInterface )----------------------------------- */


	public function getBridgedObject() {
	return $this->assertAttached($this->bridgedObject);
	}

	public function attachBridgedObject(
	DoorkeeperExternalObject $object = null) {
	$this->bridgedObject = $object;
	return $this;
	}


	/* -( PhabricatorEditEngineSubtypeInterface )------------------------------ */


	public function getEditEngineSubtype() {
	return $this->getSubtype();
	}

	public function setEditEngineSubtype($value) {
	return $this->setSubtype($value);
	}

	public function newEditEngineSubtypeMap() {
	$config = PhabricatorEnv::getEnvConfig('maniphest.subtypes');
	return PhabricatorEditEngineSubtype::newSubtypeMap($config);
	}


	/* -( PhabricatorEditEngineLockableInterface )----------------------------- */


	public function newEditEngineLock() {
	return new ManiphestTaskEditEngineLock();
	}


	/* -( PhabricatorFerretInterface )----------------------------------------- */


	public function newFerretEngine() {
	return new ManiphestTaskFerretEngine();
	}

	}
	diff --git a/src/applications/maniphest/view/ManiphestTaskListView.php b/src/applications/maniphest/view/ManiphestTaskListView.php
	index de6b386ac8..ba17b8e25d 100644
	--- a/src/applications/maniphest/view/ManiphestTaskListView.php
	+++ b/src/applications/maniphest/view/ManiphestTaskListView.php
	@@ -1,167 +1,182 @@
	<?php

	final class ManiphestTaskListView extends ManiphestView {

	private $tasks;
	private $handles;
	private $showBatchControls;
	private $showSubpriorityControls;
	private $noDataString;

	public function setTasks(array $tasks) {
	assert_instances_of($tasks, 'ManiphestTask');
	$this->tasks = $tasks;
	return $this;
	}

	public function setHandles(array $handles) {
	assert_instances_of($handles, 'PhabricatorObjectHandle');
	$this->handles = $handles;
	return $this;
	}

	public function setShowBatchControls($show_batch_controls) {
	$this->showBatchControls = $show_batch_controls;
	return $this;
	}

	public function setShowSubpriorityControls($show_subpriority_controls) {
	$this->showSubpriorityControls = $show_subpriority_controls;
	return $this;
	}

	public function setNoDataString($text) {
	$this->noDataString = $text;
	return $this;
	}

	public function render() {
	$handles = $this->handles;

	require_celerity_resource('maniphest-task-summary-css');

	$list = new PHUIObjectItemListView();

	if ($this->noDataString) {
	$list->setNoDataString($this->noDataString);
	} else {
	$list->setNoDataString(pht('No tasks.'));
	}

	$status_map = ManiphestTaskStatus::getTaskStatusMap();
	$color_map = ManiphestTaskPriority::getColorMap();
	$priority_map = ManiphestTaskPriority::getTaskPriorityMap();

	if ($this->showBatchControls) {
	Javelin::initBehavior('maniphest-list-editor');
	}

	$subtype_map = id(new ManiphestTask())
	->newEditEngineSubtypeMap();

	foreach ($this->tasks as $task) {
	$item = id(new PHUIObjectItemView())
	->setUser($this->getUser())
	->setObject($task)
	->setObjectName('T'.$task->getID())
	->setHeader($task->getTitle())
	->setHref('/T'.$task->getID());

	if ($task->getOwnerPHID()) {
	$owner = $handles[$task->getOwnerPHID()];
	$item->addByline(pht('Assigned: %s', $owner->renderLink()));
	}

	$status = $task->getStatus();
	$pri = idx($priority_map, $task->getPriority());
	$status_name = idx($status_map, $task->getStatus());
	$tooltip = pht('%s, %s', $status_name, $pri);

	$icon = ManiphestTaskStatus::getStatusIcon($task->getStatus());
	$color = idx($color_map, $task->getPriority(), 'grey');
	if ($task->isClosed()) {
	$item->setDisabled(true);
	$color = 'grey';
	}

	$item->setStatusIcon($icon.' '.$color, $tooltip);

	- $item->addIcon(
	- 'none',
	- phabricator_datetime($task->getDateModified(), $this->getUser()));
	+ if ($task->isClosed()) {
	+ $closed_epoch = $task->getClosedEpoch();
	+
	+ // We don't expect a task to be closed without a closed epoch, but
	+ // recover if we find one. This can happen with older objects or with
	+ // lipsum test data.
	+ if (!$closed_epoch) {
	+ $closed_epoch = $task->getDateModified();
	+ }
	+
	+ $item->addIcon(
	+ 'fa-check-square-o grey',
	+ phabricator_datetime($closed_epoch, $this->getUser()));
	+ } else {
	+ $item->addIcon(
	+ 'none',
	+ phabricator_datetime($task->getDateModified(), $this->getUser()));
	+ }

	if ($this->showSubpriorityControls) {
	$item->setGrippable(true);
	}
	if ($this->showSubpriorityControls \|\| $this->showBatchControls) {
	$item->addSigil('maniphest-task');
	}

	$subtype = $task->newSubtypeObject();
	if ($subtype && $subtype->hasTagView()) {
	$subtype_tag = $subtype->newTagView()
	->setSlimShady(true);
	$item->addAttribute($subtype_tag);
	}

	$project_handles = array_select_keys(
	$handles,
	array_reverse($task->getProjectPHIDs()));

	$item->addAttribute(
	id(new PHUIHandleTagListView())
	->setLimit(4)
	->setNoDataString(pht('No Projects'))
	->setSlim(true)
	->setHandles($project_handles));

	$item->setMetadata(
	array(
	'taskID' => $task->getID(),
	));

	if ($this->showBatchControls) {
	$href = new PhutilURI('/maniphest/task/edit/'.$task->getID().'/');
	if (!$this->showSubpriorityControls) {
	$href->setQueryParam('ungrippable', 'true');
	}
	$item->addAction(
	id(new PHUIListItemView())
	->setIcon('fa-pencil')
	->addSigil('maniphest-edit-task')
	->setHref($href));
	}

	$list->addItem($item);
	}

	return $list;
	}

	public static function loadTaskHandles(
	PhabricatorUser $viewer,
	array $tasks) {
	assert_instances_of($tasks, 'ManiphestTask');

	$phids = array();
	foreach ($tasks as $task) {
	$assigned_phid = $task->getOwnerPHID();
	if ($assigned_phid) {
	$phids[] = $assigned_phid;
	}
	foreach ($task->getProjectPHIDs() as $project_phid) {
	$phids[] = $project_phid;
	}
	}

	if (!$phids) {
	return array();
	}

	return id(new PhabricatorHandleQuery())
	->setViewer($viewer)
	->withPHIDs($phids)
	->execute();
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Mon, Apr 28, 2:21 PM (1 d, 4 h)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 108019
Default Alt Text: (40 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions