View Options

	diff --git a/src/applications/console/core/DarkConsoleCore.php b/src/applications/console/core/DarkConsoleCore.php
	index 437d6f0be7..73065b900e 100644
	--- a/src/applications/console/core/DarkConsoleCore.php
	+++ b/src/applications/console/core/DarkConsoleCore.php
	@@ -1,138 +1,141 @@
	<?php

	final class DarkConsoleCore extends Phobject {

	private $plugins = array();
	const STORAGE_VERSION = 1;

	public function __construct() {
	$this->plugins = id(new PhutilClassMapQuery())
	->setAncestorClass('DarkConsolePlugin')
	->execute();

	foreach ($this->plugins as $plugin) {
	$plugin->setConsoleCore($this);
	$plugin->didStartup();
	}
	}

	public function getPlugins() {
	return $this->plugins;
	}

	public function getKey(AphrontRequest $request) {
	$plugins = $this->getPlugins();

	foreach ($plugins as $plugin) {
	$plugin->setRequest($request);
	$plugin->willShutdown();
	}

	foreach ($plugins as $plugin) {
	$plugin->didShutdown();
	}

	foreach ($plugins as $plugin) {
	$plugin->setData($plugin->generateData());
	}

	$plugins = msort($plugins, 'getOrderKey');

	$key = Filesystem::readRandomCharacters(24);

	$tabs = array();
	$data = array();
	foreach ($plugins as $plugin) {
	$class = get_class($plugin);
	$tabs[] = array(
	'class' => $class,
	'name' => $plugin->getName(),
	'color' => $plugin->getColor(),
	);
	$data[$class] = $this->sanitizeForJSON($plugin->getData());
	}

	$storage = array(
	'vers' => self::STORAGE_VERSION,
	'tabs' => $tabs,
	'data' => $data,
	'user' => $request->getUser()
	? $request->getUser()->getPHID()
	: null,
	);

	$cache = new PhabricatorKeyValueDatabaseCache();
	$cache = new PhutilKeyValueCacheProfiler($cache);
	$cache->setProfiler(PhutilServiceProfiler::getInstance());

	// This encoding may fail if there are, e.g., database queries which
	// include binary data. It would be a little cleaner to try to strip these,
	// but just do something non-broken here if we end up with unrepresentable
	// data.
	$json = @json_encode($storage);
	if (!$json) {
	$json = '{}';
	}

	$cache->setKeys(
	array(
	'darkconsole:'.$key => $json,
	),
	$ttl = (60 * 60 * 6));

	return $key;
	}

	public function getColor() {
	foreach ($this->getPlugins() as $plugin) {
	if ($plugin->getColor()) {
	return $plugin->getColor();
	}
	}
	}

	public function render(AphrontRequest $request) {
	$user = $request->getUser();
	$visible = $user->getUserSetting(
	PhabricatorDarkConsoleVisibleSetting::SETTINGKEY);

	return javelin_tag(
	'div',
	array(
	'id' => 'darkconsole',
	'class' => 'dark-console',
	'style' => $visible ? '' : 'display: none;',
	'data-console-key' => $this->getKey($request),
	'data-console-color' => $this->getColor(),
	),
	'');
	}

	/**
	* Sometimes, tab data includes binary information (like INSERT queries which
	* write file data into the database). To successfully JSON encode it, we
	* need to convert it to UTF-8.
	*/
	private function sanitizeForJSON($data) {
	if (is_object($data)) {
	return '<object:'.get_class($data).'>';
	} else if (is_array($data)) {
	foreach ($data as $key => $value) {
	$data[$key] = $this->sanitizeForJSON($value);
	}
	return $data;
	} else if (is_resource($data)) {
	return '<resource>';
	} else {
	+ // This is very probably not a string in strict sense
	+ $data = phutil_string_cast($data);
	+
	// Truncate huge strings. Since the data doesn't really matter much,
	// just truncate bytes to avoid PhutilUTF8StringTruncator overhead.
	$length = strlen($data);
	$max = 4096;
	if ($length > $max) {
	$data = substr($data, 0, $max).'...<'.$length.' bytes>...';
	}
	return phutil_utf8ize($data);
	}
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Sun, Nov 24, 5:17 AM (1 d, 9 h)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 982
Default Alt Text: (4 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions