R1:e0edb0797c9f

Remove "effector" from HeraldAdapter

Summary:
Ref T7731.

- This does nothing.
- I don't know what this was supposed to do.
- It didn't do anything when it was introduced in rP084c79d85a in 2011, either.

iiam

Test Plan:
- `grep`
- ???

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7731

Differential Revision: https://secure.phabricator.com/D12267