View Options

	diff --git a/src/applications/conduit/check/ConduitDeprecatedCallSetupCheck.php b/src/applications/conduit/check/ConduitDeprecatedCallSetupCheck.php
	index c7ee2765fd..ba81002d8b 100644
	--- a/src/applications/conduit/check/ConduitDeprecatedCallSetupCheck.php
	+++ b/src/applications/conduit/check/ConduitDeprecatedCallSetupCheck.php
	@@ -1,65 +1,69 @@
	<?php

	final class ConduitDeprecatedCallSetupCheck extends PhabricatorSetupCheck {

	protected function executeChecks() {
	+ // NOTE: We still call deprecated methods, so don't enable this until at
	+ // least 30 days after fixing T7111, T7112 and T7113.
	+ return;
	+
	$methods = id(new PhabricatorConduitMethodQuery())
	->setViewer(PhabricatorUser::getOmnipotentUser())
	->withIsDeprecated(true)
	->execute();
	if (!$methods) {
	return;
	}

	$methods = mpull($methods, null, 'getAPIMethodName');
	$method_names = mpull($methods, 'getAPIMethodName');

	$table = new PhabricatorConduitMethodCallLog();
	$conn_r = $table->establishConnection('r');

	$calls = queryfx_all(
	$conn_r,
	'SELECT DISTINCT method FROM %T WHERE dateCreated > %d
	AND method IN (%Ls)',
	$table->getTableName(),
	time() - (60 * 60 * 24 * 30),
	$method_names);
	$calls = ipull($calls, 'method', 'method');

	foreach ($calls as $method_name) {
	$method = $methods[$method_name];

	$summary = pht(
	'Deprecated Conduit method `%s` was called in the last 30 days. '.
	'You should migrate away from use of this method: it will be '.
	'removed in a future version of Phabricator.',
	$method_name);

	$uri = PhabricatorEnv::getURI('/conduit/log/?methods='.$method_name);

	$description = $method->getMethodStatusDescription();

	$message = pht(
	'Deprecated Conduit method %s was called in the last 30 days. '.
	'You should migrate away from use of this method: it will be '.
	'removed in a future version of Phabricator.'.
	"\n\n".
	"%s: %s".
	"\n\n".
	'If you have already migrated all callers away from this method, '.
	'you can safely ignore this setup issue.',
	phutil_tag('tt', array(), $method_name),
	phutil_tag('tt', array(), $method_name),
	$description);

	$this
	->newIssue('conduit.deprecated.'.$method_name)
	->setShortName(pht('Deprecated Conduit Method'))
	->setName(pht('Deprecated Conduit Method "%s" In Use', $method_name))
	->setSummary($summary)
	->setMessage($message)
	->addLink($uri, pht('View Method Call Logs'));
	}
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Wed, Jun 11, 12:55 AM (1 h, 27 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 141535
Default Alt Text: (2 KB)

No OneTemporary
Actions

View Options

File Metadata

Event Timeline

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions