No OneTemporary
Actions

Size

43 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php b/src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php
	index 4f45357956..2459c8c559 100644
	--- a/src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php
	+++ b/src/applications/diffusion/editor/DiffusionRepositoryEditEngine.php
	@@ -1,451 +1,455 @@
	<?php

	final class DiffusionRepositoryEditEngine
	extends PhabricatorEditEngine {

	const ENGINECONST = 'diffusion.repository';

	private $versionControlSystem;

	public function setVersionControlSystem($version_control_system) {
	$this->versionControlSystem = $version_control_system;
	return $this;
	}

	public function getVersionControlSystem() {
	return $this->versionControlSystem;
	}

	public function isEngineConfigurable() {
	return false;
	}

	public function isDefaultQuickCreateEngine() {
	return true;
	}

	+ public function getQuickCreateOrderVector() {
	+ return id(new PhutilSortVector())->addInt(300);
	+ }
	+
	public function getEngineName() {
	return pht('Repositories');
	}

	public function getSummaryHeader() {
	return pht('Edit Repositories');
	}

	public function getSummaryText() {
	return pht('Creates and edits repositories.');
	}

	public function getEngineApplicationClass() {
	return 'PhabricatorDiffusionApplication';
	}

	protected function newEditableObject() {
	$viewer = $this->getViewer();
	$repository = PhabricatorRepository::initializeNewRepository($viewer);

	$repository->setDetail('newly-initialized', true);

	$vcs = $this->getVersionControlSystem();
	if ($vcs) {
	$repository->setVersionControlSystem($vcs);
	}

	// Pick a random open service to allocate this repository on, if any exist.
	// If there are no services, we aren't in cluster mode and will allocate
	// locally. If there are services but none permit allocations, we fail.

	// Eventually we can make this more flexible, but this rule is a reasonable
	// starting point as we begin to deploy cluster services.

	$services = id(new AlmanacServiceQuery())
	->setViewer(PhabricatorUser::getOmnipotentUser())
	->withServiceTypes(
	array(
	AlmanacClusterRepositoryServiceType::SERVICETYPE,
	))
	->needProperties(true)
	->execute();
	if ($services) {
	// Filter out services which do not permit new allocations.
	foreach ($services as $key => $possible_service) {
	if ($possible_service->getAlmanacPropertyValue('closed')) {
	unset($services[$key]);
	}
	}

	if (!$services) {
	throw new Exception(
	pht(
	'This install is configured in cluster mode, but all available '.
	'repository cluster services are closed to new allocations. '.
	'At least one service must be open to allow new allocations to '.
	'take place.'));
	}

	shuffle($services);
	$service = head($services);

	$repository->setAlmanacServicePHID($service->getPHID());
	}

	return $repository;
	}

	protected function newObjectQuery() {
	return new PhabricatorRepositoryQuery();
	}

	protected function getObjectCreateTitleText($object) {
	return pht('Create Repository');
	}

	protected function getObjectCreateButtonText($object) {
	return pht('Create Repository');
	}

	protected function getObjectEditTitleText($object) {
	return pht('Edit Repository: %s', $object->getName());
	}

	protected function getObjectEditShortText($object) {
	return $object->getDisplayName();
	}

	protected function getObjectCreateShortText() {
	return pht('Create Repository');
	}

	protected function getObjectName() {
	return pht('Repository');
	}

	protected function getObjectViewURI($object) {
	return $object->getPathURI('manage/');
	}

	protected function getCreateNewObjectPolicy() {
	return $this->getApplication()->getPolicy(
	DiffusionCreateRepositoriesCapability::CAPABILITY);
	}

	protected function newPages($object) {
	$panels = DiffusionRepositoryManagementPanel::getAllPanels();

	$pages = array();
	$uris = array();
	foreach ($panels as $panel_key => $panel) {
	$panel->setRepository($object);

	$uris[$panel_key] = $panel->getPanelURI();

	$page = $panel->newEditEnginePage();
	if (!$page) {
	continue;
	}
	$pages[] = $page;
	}

	$basics_key = DiffusionRepositoryBasicsManagementPanel::PANELKEY;
	$basics_uri = $uris[$basics_key];

	$more_pages = array(
	id(new PhabricatorEditPage())
	->setKey('encoding')
	->setLabel(pht('Text Encoding'))
	->setViewURI($basics_uri)
	->setFieldKeys(
	array(
	'encoding',
	)),
	id(new PhabricatorEditPage())
	->setKey('extensions')
	->setLabel(pht('Extensions'))
	->setIsDefault(true),
	);

	foreach ($more_pages as $page) {
	$pages[] = $page;
	}

	return $pages;
	}

	protected function willConfigureFields($object, array $fields) {
	// Change the default field order so related fields are adjacent.
	$after = array(
	'policy.edit' => array('policy.push'),
	);

	$result = array();
	foreach ($fields as $key => $value) {
	$result[$key] = $value;

	if (!isset($after[$key])) {
	continue;
	}

	foreach ($after[$key] as $next_key) {
	if (!isset($fields[$next_key])) {
	continue;
	}

	unset($result[$next_key]);
	$result[$next_key] = $fields[$next_key];
	unset($fields[$next_key]);
	}
	}

	return $result;
	}


	protected function buildCustomEditFields($object) {
	$viewer = $this->getViewer();

	$policies = id(new PhabricatorPolicyQuery())
	->setViewer($viewer)
	->setObject($object)
	->execute();

	$track_value = $object->getDetail('branch-filter', array());
	$track_value = array_keys($track_value);

	$autoclose_value = $object->getDetail('close-commits-filter', array());
	$autoclose_value = array_keys($autoclose_value);

	$automation_instructions = pht(
	"Configure Repository Automation to allow Phabricator to ".
	"write to this repository.".
	"\n\n".
	"IMPORTANT: This feature is new, experimental, and not supported. ".
	"Use it at your own risk.");

	$staging_instructions = pht(
	"To make it easier to run integration tests and builds on code ".
	"under review, you can configure a Staging Area. When `arc` ".
	"creates a diff, it will push a copy of the changes to the ".
	"configured staging area with a corresponding tag.".
	"\n\n".
	"IMPORTANT: This feature is new, experimental, and not supported. ".
	"Use it at your own risk.");

	$subpath_instructions = pht(
	'If you want to import only part of a repository, like `trunk/`, '.
	'you can set a path in Import Only. Phabricator will ignore '.
	'commits which do not affect this path.');

	return array(
	id(new PhabricatorSelectEditField())
	->setKey('vcs')
	->setLabel(pht('Version Control System'))
	->setTransactionType(PhabricatorRepositoryTransaction::TYPE_VCS)
	->setIsConduitOnly(true)
	->setIsCopyable(true)
	->setOptions(PhabricatorRepositoryType::getAllRepositoryTypes())
	->setDescription(pht('Underlying repository version control system.'))
	->setConduitDescription(
	pht(
	'Choose which version control system to use when creating a '.
	'repository.'))
	->setConduitTypeDescription(pht('Version control system selection.'))
	->setValue($object->getVersionControlSystem()),
	id(new PhabricatorTextEditField())
	->setKey('name')
	->setLabel(pht('Name'))
	->setIsRequired(true)
	->setTransactionType(PhabricatorRepositoryTransaction::TYPE_NAME)
	->setDescription(pht('The repository name.'))
	->setConduitDescription(pht('Rename the repository.'))
	->setConduitTypeDescription(pht('New repository name.'))
	->setValue($object->getName()),
	id(new PhabricatorTextEditField())
	->setKey('callsign')
	->setLabel(pht('Callsign'))
	->setTransactionType(PhabricatorRepositoryTransaction::TYPE_CALLSIGN)
	->setDescription(pht('The repository callsign.'))
	->setConduitDescription(pht('Change the repository callsign.'))
	->setConduitTypeDescription(pht('New repository callsign.'))
	->setValue($object->getCallsign()),
	id(new PhabricatorTextEditField())
	->setKey('shortName')
	->setLabel(pht('Short Name'))
	->setTransactionType(PhabricatorRepositoryTransaction::TYPE_SLUG)
	->setDescription(pht('Short, unique repository name.'))
	->setConduitDescription(pht('Change the repository short name.'))
	->setConduitTypeDescription(pht('New short name for the repository.'))
	->setValue($object->getRepositorySlug()),
	id(new PhabricatorRemarkupEditField())
	->setKey('description')
	->setLabel(pht('Description'))
	->setTransactionType(PhabricatorRepositoryTransaction::TYPE_DESCRIPTION)
	->setDescription(pht('Repository description.'))
	->setConduitDescription(pht('Change the repository description.'))
	->setConduitTypeDescription(pht('New repository description.'))
	->setValue($object->getDetail('description')),
	id(new PhabricatorTextEditField())
	->setKey('encoding')
	->setLabel(pht('Text Encoding'))
	->setIsCopyable(true)
	->setTransactionType(PhabricatorRepositoryTransaction::TYPE_ENCODING)
	->setDescription(pht('Default text encoding.'))
	->setConduitDescription(pht('Change the default text encoding.'))
	->setConduitTypeDescription(pht('New text encoding.'))
	->setValue($object->getDetail('encoding')),
	id(new PhabricatorBoolEditField())
	->setKey('allowDangerousChanges')
	->setLabel(pht('Allow Dangerous Changes'))
	->setIsCopyable(true)
	->setIsConduitOnly(true)
	->setOptions(
	pht('Prevent Dangerous Changes'),
	pht('Allow Dangerous Changes'))
	->setTransactionType(PhabricatorRepositoryTransaction::TYPE_DANGEROUS)
	->setDescription(pht('Permit dangerous changes to be made.'))
	->setConduitDescription(pht('Allow or prevent dangerous changes.'))
	->setConduitTypeDescription(pht('New protection setting.'))
	->setValue($object->shouldAllowDangerousChanges()),
	id(new PhabricatorSelectEditField())
	->setKey('status')
	->setLabel(pht('Status'))
	->setTransactionType(PhabricatorRepositoryTransaction::TYPE_ACTIVATE)
	->setIsConduitOnly(true)
	->setOptions(PhabricatorRepository::getStatusNameMap())
	->setDescription(pht('Active or inactive status.'))
	->setConduitDescription(pht('Active or deactivate the repository.'))
	->setConduitTypeDescription(pht('New repository status.'))
	->setValue($object->getStatus()),
	id(new PhabricatorTextEditField())
	->setKey('defaultBranch')
	->setLabel(pht('Default Branch'))
	->setTransactionType(
	PhabricatorRepositoryTransaction::TYPE_DEFAULT_BRANCH)
	->setIsCopyable(true)
	->setDescription(pht('Default branch name.'))
	->setConduitDescription(pht('Set the default branch name.'))
	->setConduitTypeDescription(pht('New default branch name.'))
	->setValue($object->getDetail('default-branch')),
	id(new PhabricatorTextAreaEditField())
	->setIsStringList(true)
	->setKey('trackOnly')
	->setLabel(pht('Track Only'))
	->setTransactionType(
	PhabricatorRepositoryTransaction::TYPE_TRACK_ONLY)
	->setIsCopyable(true)
	->setDescription(pht('Track only these branches.'))
	->setConduitDescription(pht('Set the tracked branches.'))
	->setConduitTypeDescription(pht('New tracked branchs.'))
	->setValue($track_value),
	id(new PhabricatorTextAreaEditField())
	->setIsStringList(true)
	->setKey('autocloseOnly')
	->setLabel(pht('Autoclose Only'))
	->setTransactionType(
	PhabricatorRepositoryTransaction::TYPE_AUTOCLOSE_ONLY)
	->setIsCopyable(true)
	->setDescription(pht('Autoclose commits on only these branches.'))
	->setConduitDescription(pht('Set the autoclose branches.'))
	->setConduitTypeDescription(pht('New default tracked branchs.'))
	->setValue($autoclose_value),
	id(new PhabricatorTextEditField())
	->setKey('importOnly')
	->setLabel(pht('Import Only'))
	->setTransactionType(
	PhabricatorRepositoryTransaction::TYPE_SVN_SUBPATH)
	->setIsCopyable(true)
	->setDescription(pht('Subpath to selectively import.'))
	->setConduitDescription(pht('Set the subpath to import.'))
	->setConduitTypeDescription(pht('New subpath to import.'))
	->setValue($object->getDetail('svn-subpath'))
	->setControlInstructions($subpath_instructions),
	id(new PhabricatorTextEditField())
	->setKey('stagingAreaURI')
	->setLabel(pht('Staging Area URI'))
	->setTransactionType(
	PhabricatorRepositoryTransaction::TYPE_STAGING_URI)
	->setIsCopyable(true)
	->setDescription(pht('Staging area URI.'))
	->setConduitDescription(pht('Set the staging area URI.'))
	->setConduitTypeDescription(pht('New staging area URI.'))
	->setValue($object->getStagingURI())
	->setControlInstructions($staging_instructions),
	id(new PhabricatorDatasourceEditField())
	->setKey('automationBlueprintPHIDs')
	->setLabel(pht('Use Blueprints'))
	->setTransactionType(
	PhabricatorRepositoryTransaction::TYPE_AUTOMATION_BLUEPRINTS)
	->setIsCopyable(true)
	->setDatasource(new DrydockBlueprintDatasource())
	->setDescription(pht('Automation blueprints.'))
	->setConduitDescription(pht('Change automation blueprints.'))
	->setConduitTypeDescription(pht('New blueprint PHIDs.'))
	->setValue($object->getAutomationBlueprintPHIDs())
	->setControlInstructions($automation_instructions),
	id(new PhabricatorStringListEditField())
	->setKey('symbolLanguages')
	->setLabel(pht('Languages'))
	->setTransactionType(
	PhabricatorRepositoryTransaction::TYPE_SYMBOLS_LANGUAGE)
	->setIsCopyable(true)
	->setDescription(
	pht('Languages which define symbols in this repository.'))
	->setConduitDescription(
	pht('Change symbol languages for this repository.'))
	->setConduitTypeDescription(
	pht('New symbol langauges.'))
	->setValue($object->getSymbolLanguages()),
	id(new PhabricatorDatasourceEditField())
	->setKey('symbolRepositoryPHIDs')
	->setLabel(pht('Uses Symbols From'))
	->setTransactionType(
	PhabricatorRepositoryTransaction::TYPE_SYMBOLS_SOURCES)
	->setIsCopyable(true)
	->setDatasource(new DiffusionRepositoryDatasource())
	->setDescription(pht('Repositories to link symbols from.'))
	->setConduitDescription(pht('Change symbol source repositories.'))
	->setConduitTypeDescription(pht('New symbol repositories.'))
	->setValue($object->getSymbolSources()),
	id(new PhabricatorBoolEditField())
	->setKey('publish')
	->setLabel(pht('Publish/Notify'))
	->setTransactionType(
	PhabricatorRepositoryTransaction::TYPE_NOTIFY)
	->setIsCopyable(true)
	->setOptions(
	pht('Disable Notifications, Feed, and Herald'),
	pht('Enable Notifications, Feed, and Herald'))
	->setDescription(pht('Configure how changes are published.'))
	->setConduitDescription(pht('Change publishing options.'))
	->setConduitTypeDescription(pht('New notification setting.'))
	->setValue(!$object->getDetail('herald-disabled')),
	id(new PhabricatorBoolEditField())
	->setKey('autoclose')
	->setLabel(pht('Autoclose'))
	->setTransactionType(
	PhabricatorRepositoryTransaction::TYPE_AUTOCLOSE)
	->setIsCopyable(true)
	->setOptions(
	pht('Disable Autoclose'),
	pht('Enable Autoclose'))
	->setDescription(pht('Stop or resume autoclosing in this repository.'))
	->setConduitDescription(pht('Change autoclose setting.'))
	->setConduitTypeDescription(pht('New autoclose setting.'))
	->setValue(!$object->getDetail('disable-autoclose')),
	id(new PhabricatorPolicyEditField())
	->setKey('policy.push')
	->setLabel(pht('Push Policy'))
	->setAliases(array('push'))
	->setIsCopyable(true)
	->setCapability(DiffusionPushCapability::CAPABILITY)
	->setPolicies($policies)
	->setTransactionType(PhabricatorRepositoryTransaction::TYPE_PUSH_POLICY)
	->setDescription(
	pht('Controls who can push changes to the repository.'))
	->setConduitDescription(
	pht('Change the push policy of the repository.'))
	->setConduitTypeDescription(pht('New policy PHID or constant.'))
	->setValue($object->getPolicy(DiffusionPushCapability::CAPABILITY)),
	);
	}

	}
	diff --git a/src/applications/maniphest/editor/ManiphestEditEngine.php b/src/applications/maniphest/editor/ManiphestEditEngine.php
	index 0433e8200a..ad0171592c 100644
	--- a/src/applications/maniphest/editor/ManiphestEditEngine.php
	+++ b/src/applications/maniphest/editor/ManiphestEditEngine.php
	@@ -1,465 +1,469 @@
	<?php

	final class ManiphestEditEngine
	extends PhabricatorEditEngine {

	const ENGINECONST = 'maniphest.task';

	public function getEngineName() {
	return pht('Maniphest Tasks');
	}

	public function getSummaryHeader() {
	return pht('Configure Maniphest Task Forms');
	}

	public function getSummaryText() {
	return pht('Configure how users create and edit tasks.');
	}

	public function getEngineApplicationClass() {
	return 'PhabricatorManiphestApplication';
	}

	public function isDefaultQuickCreateEngine() {
	return true;
	}

	+ public function getQuickCreateOrderVector() {
	+ return id(new PhutilSortVector())->addInt(100);
	+ }
	+
	protected function newEditableObject() {
	return ManiphestTask::initializeNewTask($this->getViewer());
	}

	protected function newObjectQuery() {
	return id(new ManiphestTaskQuery());
	}

	protected function getObjectCreateTitleText($object) {
	return pht('Create New Task');
	}

	protected function getObjectEditTitleText($object) {
	return pht('Edit Task: %s', $object->getTitle());
	}

	protected function getObjectEditShortText($object) {
	return $object->getMonogram();
	}

	protected function getObjectCreateShortText() {
	return pht('Create Task');
	}

	protected function getObjectName() {
	return pht('Task');
	}

	protected function getEditorURI() {
	return $this->getApplication()->getApplicationURI('task/edit/');
	}

	protected function getCommentViewHeaderText($object) {
	return pht('Weigh In');
	}

	protected function getCommentViewButtonText($object) {
	return pht('Set Sail for Adventure');
	}

	protected function getObjectViewURI($object) {
	return '/'.$object->getMonogram();
	}

	protected function buildCustomEditFields($object) {
	$status_map = $this->getTaskStatusMap($object);
	$priority_map = $this->getTaskPriorityMap($object);

	if ($object->isClosed()) {
	$default_status = ManiphestTaskStatus::getDefaultStatus();
	} else {
	$default_status = ManiphestTaskStatus::getDefaultClosedStatus();
	}

	if ($object->getOwnerPHID()) {
	$owner_value = array($object->getOwnerPHID());
	} else {
	$owner_value = array($this->getViewer()->getPHID());
	}

	$column_documentation = pht(<<<EODOCS
	You can use this transaction type to create a task into a particular workboard
	column, or move an existing task between columns.

	The transaction value can be specified in several forms. Some are simpler but
	less powerful, while others are more complex and more powerful.

	The simplest valid value is a single column PHID:

	```lang=json
	"PHID-PCOL-1111"
	```

	This will move the task into that column, or create the task into that column
	if you are creating a new task. If the task is currently on the board, it will
	be moved out of any exclusive columns. If the task is not currently on the
	board, it will be added to the board.

	You can also perform multiple moves at the same time by passing a list of
	PHIDs:

	```lang=json
	["PHID-PCOL-2222", "PHID-PCOL-3333"]
	```

	This is equivalent to performing each move individually.

	The most complex and most powerful form uses a dictionary to provide additional
	information about the move, including an optional specific position within the
	column.

	The target column should be identified as `columnPHID`, and you may select a
	position by passing either `beforePHID` or `afterPHID`, specifying the PHID of
	a task currently in the column that you want to move this task before or after:

	```lang=json
	[
	{
	"columnPHID": "PHID-PCOL-4444",
	"beforePHID": "PHID-TASK-5555"
	}
	]
	```

	Note that this affects only the "natural" position of the task. The task
	position when the board is sorted by some other attribute (like priority)
	depends on that attribute value: change a task's priority to move it on
	priority-sorted boards.
	EODOCS
	);

	$column_map = $this->getColumnMap($object);

	$fields = array(
	id(new PhabricatorHandlesEditField())
	->setKey('parent')
	->setLabel(pht('Parent Task'))
	->setDescription(pht('Task to make this a subtask of.'))
	->setConduitDescription(pht('Create as a subtask of another task.'))
	->setConduitTypeDescription(pht('PHID of the parent task.'))
	->setAliases(array('parentPHID'))
	->setTransactionType(ManiphestTransaction::TYPE_PARENT)
	->setHandleParameterType(new ManiphestTaskListHTTPParameterType())
	->setSingleValue(null)
	->setIsReorderable(false)
	->setIsDefaultable(false)
	->setIsLockable(false),
	id(new PhabricatorColumnsEditField())
	->setKey('column')
	->setLabel(pht('Column'))
	->setDescription(pht('Create a task in a workboard column.'))
	->setConduitDescription(
	pht('Move a task to one or more workboard columns.'))
	->setConduitTypeDescription(
	pht('List of columns to move the task to.'))
	->setConduitDocumentation($column_documentation)
	->setAliases(array('columnPHID', 'columns', 'columnPHIDs'))
	->setTransactionType(PhabricatorTransactions::TYPE_COLUMNS)
	->setIsReorderable(false)
	->setIsDefaultable(false)
	->setIsLockable(false)
	->setCommentActionLabel(pht('Move on Workboard'))
	->setCommentActionOrder(2000)
	->setColumnMap($column_map),
	id(new PhabricatorTextEditField())
	->setKey('title')
	->setLabel(pht('Title'))
	->setDescription(pht('Name of the task.'))
	->setConduitDescription(pht('Rename the task.'))
	->setConduitTypeDescription(pht('New task name.'))
	->setTransactionType(ManiphestTransaction::TYPE_TITLE)
	->setIsRequired(true)
	->setValue($object->getTitle()),
	id(new PhabricatorUsersEditField())
	->setKey('owner')
	->setAliases(array('ownerPHID', 'assign', 'assigned'))
	->setLabel(pht('Assigned To'))
	->setDescription(pht('User who is responsible for the task.'))
	->setConduitDescription(pht('Reassign the task.'))
	->setConduitTypeDescription(
	pht('New task owner, or `null` to unassign.'))
	->setTransactionType(ManiphestTransaction::TYPE_OWNER)
	->setIsCopyable(true)
	->setSingleValue($object->getOwnerPHID())
	->setCommentActionLabel(pht('Assign / Claim'))
	->setCommentActionValue($owner_value),
	id(new PhabricatorSelectEditField())
	->setKey('status')
	->setLabel(pht('Status'))
	->setDescription(pht('Status of the task.'))
	->setConduitDescription(pht('Change the task status.'))
	->setConduitTypeDescription(pht('New task status constant.'))
	->setTransactionType(ManiphestTransaction::TYPE_STATUS)
	->setIsCopyable(true)
	->setValue($object->getStatus())
	->setOptions($status_map)
	->setCommentActionLabel(pht('Change Status'))
	->setCommentActionValue($default_status),
	id(new PhabricatorSelectEditField())
	->setKey('priority')
	->setLabel(pht('Priority'))
	->setDescription(pht('Priority of the task.'))
	->setConduitDescription(pht('Change the priority of the task.'))
	->setConduitTypeDescription(pht('New task priority constant.'))
	->setTransactionType(ManiphestTransaction::TYPE_PRIORITY)
	->setIsCopyable(true)
	->setValue($object->getPriority())
	->setOptions($priority_map)
	->setCommentActionLabel(pht('Change Priority')),
	);

	if (ManiphestTaskPoints::getIsEnabled()) {
	$points_label = ManiphestTaskPoints::getPointsLabel();
	$action_label = ManiphestTaskPoints::getPointsActionLabel();

	$fields[] = id(new PhabricatorPointsEditField())
	->setKey('points')
	->setLabel($points_label)
	->setDescription(pht('Point value of the task.'))
	->setConduitDescription(pht('Change the task point value.'))
	->setConduitTypeDescription(pht('New task point value.'))
	->setTransactionType(ManiphestTransaction::TYPE_POINTS)
	->setIsCopyable(true)
	->setValue($object->getPoints())
	->setCommentActionLabel($action_label);
	}

	$fields[] = id(new PhabricatorRemarkupEditField())
	->setKey('description')
	->setLabel(pht('Description'))
	->setDescription(pht('Task description.'))
	->setConduitDescription(pht('Update the task description.'))
	->setConduitTypeDescription(pht('New task description.'))
	->setTransactionType(ManiphestTransaction::TYPE_DESCRIPTION)
	->setValue($object->getDescription())
	->setPreviewPanel(
	id(new PHUIRemarkupPreviewPanel())
	->setHeader(pht('Description Preview')));

	return $fields;
	}

	private function getTaskStatusMap(ManiphestTask $task) {
	$status_map = ManiphestTaskStatus::getTaskStatusMap();

	$current_status = $task->getStatus();

	// If the current status is something we don't recognize (maybe an older
	// status which was deleted), put a dummy entry in the status map so that
	// saving the form doesn't destroy any data by accident.
	if (idx($status_map, $current_status) === null) {
	$status_map[$current_status] = pht('<Unknown: %s>', $current_status);
	}

	$dup_status = ManiphestTaskStatus::getDuplicateStatus();
	foreach ($status_map as $status => $status_name) {
	// Always keep the task's current status.
	if ($status == $current_status) {
	continue;
	}

	// Don't allow tasks to be changed directly into "Closed, Duplicate"
	// status. Instead, you have to merge them. See T4819.
	if ($status == $dup_status) {
	unset($status_map[$status]);
	continue;
	}

	// Don't let new or existing tasks be moved into a disabled status.
	if (ManiphestTaskStatus::isDisabledStatus($status)) {
	unset($status_map[$status]);
	continue;
	}
	}

	return $status_map;
	}

	private function getTaskPriorityMap(ManiphestTask $task) {
	$priority_map = ManiphestTaskPriority::getTaskPriorityMap();
	$current_priority = $task->getPriority();

	// If the current value isn't a legitimate one, put it in the dropdown
	// anyway so saving the form doesn't cause a side effects.
	if (idx($priority_map, $current_priority) === null) {
	$priority_map[$current_priority] = pht(
	'<Unknown: %s>',
	$current_priority);
	}

	foreach ($priority_map as $priority => $priority_name) {
	// Always keep the current priority.
	if ($priority == $current_priority) {
	continue;
	}

	if (ManiphestTaskPriority::isDisabledPriority($priority)) {
	unset($priority_map[$priority]);
	continue;
	}
	}

	return $priority_map;
	}

	protected function newEditResponse(
	AphrontRequest $request,
	$object,
	array $xactions) {

	if ($request->isAjax()) {
	// Reload the task to make sure we pick up the final task state.
	$viewer = $this->getViewer();
	$task = id(new ManiphestTaskQuery())
	->setViewer($viewer)
	->withIDs(array($object->getID()))
	->needSubscriberPHIDs(true)
	->needProjectPHIDs(true)
	->executeOne();

	switch ($request->getStr('responseType')) {
	case 'card':
	return $this->buildCardResponse($task);
	default:
	return $this->buildListResponse($task);
	}

	}

	return parent::newEditResponse($request, $object, $xactions);
	}

	private function buildListResponse(ManiphestTask $task) {
	$controller = $this->getController();

	$payload = array(
	'tasks' => $controller->renderSingleTask($task),
	'data' => array(),
	);

	return id(new AphrontAjaxResponse())->setContent($payload);
	}

	private function buildCardResponse(ManiphestTask $task) {
	$controller = $this->getController();
	$request = $controller->getRequest();
	$viewer = $request->getViewer();

	$column_phid = $request->getStr('columnPHID');

	$visible_phids = $request->getStrList('visiblePHIDs');
	if (!$visible_phids) {
	$visible_phids = array();
	}

	$column = id(new PhabricatorProjectColumnQuery())
	->setViewer($viewer)
	->withPHIDs(array($column_phid))
	->executeOne();
	if (!$column) {
	return new Aphront404Response();
	}

	$board_phid = $column->getProjectPHID();
	$object_phid = $task->getPHID();

	return id(new PhabricatorBoardResponseEngine())
	->setViewer($viewer)
	->setBoardPHID($board_phid)
	->setObjectPHID($object_phid)
	->setVisiblePHIDs($visible_phids)
	->buildResponse();
	}

	private function getColumnMap(ManiphestTask $task) {
	$phid = $task->getPHID();
	if (!$phid) {
	return array();
	}

	$board_phids = PhabricatorEdgeQuery::loadDestinationPHIDs(
	$phid,
	PhabricatorProjectObjectHasProjectEdgeType::EDGECONST);
	if (!$board_phids) {
	return array();
	}

	$viewer = $this->getViewer();

	$layout_engine = id(new PhabricatorBoardLayoutEngine())
	->setViewer($viewer)
	->setBoardPHIDs($board_phids)
	->setObjectPHIDs(array($task->getPHID()))
	->executeLayout();

	$map = array();
	foreach ($board_phids as $board_phid) {
	$in_columns = $layout_engine->getObjectColumns($board_phid, $phid);
	$in_columns = mpull($in_columns, null, 'getPHID');

	$all_columns = $layout_engine->getColumns($board_phid);
	if (!$all_columns) {
	// This could be a project with no workboard, or a project the viewer
	// does not have permission to see.
	continue;
	}

	$board = head($all_columns)->getProject();

	$options = array();
	foreach ($all_columns as $column) {
	$name = $column->getDisplayName();

	$is_hidden = $column->isHidden();
	$is_selected = isset($in_columns[$column->getPHID()]);

	// Don't show hidden, subproject or milestone columns in this map
	// unless the object is currently in the column.
	$skip_column = ($is_hidden \|\| $column->getProxyPHID());
	if ($skip_column) {
	if (!$is_selected) {
	continue;
	}
	}

	if ($is_hidden) {
	$name = pht('(%s)', $name);
	}

	if ($is_selected) {
	$name = pht("\xE2\x97\x8F %s", $name);
	} else {
	$name = pht("\xE2\x97\x8B %s", $name);
	}

	$option = array(
	'key' => $column->getPHID(),
	'label' => $name,
	'selected' => (bool)$is_selected,
	);

	$options[] = $option;
	}

	$map[] = array(
	'label' => $board->getDisplayName(),
	'options' => $options,
	);
	}

	$map = isort($map, 'label');
	$map = array_values($map);

	return $map;
	}


	}
	diff --git a/src/applications/project/engine/PhabricatorProjectEditEngine.php b/src/applications/project/engine/PhabricatorProjectEditEngine.php
	index 7a0c11be0e..286e9bab0f 100644
	--- a/src/applications/project/engine/PhabricatorProjectEditEngine.php
	+++ b/src/applications/project/engine/PhabricatorProjectEditEngine.php
	@@ -1,312 +1,316 @@
	<?php

	final class PhabricatorProjectEditEngine
	extends PhabricatorEditEngine {

	const ENGINECONST = 'projects.project';

	private $parentProject;
	private $milestoneProject;

	public function setParentProject(PhabricatorProject $parent_project) {
	$this->parentProject = $parent_project;
	return $this;
	}

	public function getParentProject() {
	return $this->parentProject;
	}

	public function setMilestoneProject(PhabricatorProject $milestone_project) {
	$this->milestoneProject = $milestone_project;
	return $this;
	}

	public function getMilestoneProject() {
	return $this->milestoneProject;
	}

	public function isDefaultQuickCreateEngine() {
	return true;
	}

	+ public function getQuickCreateOrderVector() {
	+ return id(new PhutilSortVector())->addInt(200);
	+ }
	+
	public function getEngineName() {
	return pht('Projects');
	}

	public function getSummaryHeader() {
	return pht('Configure Project Forms');
	}

	public function getSummaryText() {
	return pht('Configure forms for creating projects.');
	}

	public function getEngineApplicationClass() {
	return 'PhabricatorProjectApplication';
	}

	protected function newEditableObject() {
	return PhabricatorProject::initializeNewProject($this->getViewer());
	}

	protected function newObjectQuery() {
	return id(new PhabricatorProjectQuery())
	->needSlugs(true);
	}

	protected function getObjectCreateTitleText($object) {
	return pht('Create New Project');
	}

	protected function getObjectEditTitleText($object) {
	return pht('Edit Project: %s', $object->getName());
	}

	protected function getObjectEditShortText($object) {
	return $object->getName();
	}

	protected function getObjectCreateShortText() {
	return pht('Create Project');
	}

	protected function getObjectName() {
	return pht('Project');
	}

	protected function getObjectViewURI($object) {
	if ($this->getIsCreate()) {
	return $object->getURI();
	} else {
	$id = $object->getID();
	return "/project/manage/{$id}/";
	}
	}

	protected function getObjectCreateCancelURI($object) {
	$parent = $this->getParentProject();
	$milestone = $this->getMilestoneProject();

	if ($parent \|\| $milestone) {
	$id = nonempty($parent, $milestone)->getID();
	return "/project/subprojects/{$id}/";
	}

	return parent::getObjectCreateCancelURI($object);
	}

	protected function getCreateNewObjectPolicy() {
	return $this->getApplication()->getPolicy(
	ProjectCreateProjectsCapability::CAPABILITY);
	}

	protected function willConfigureFields($object, array $fields) {
	$is_milestone = ($this->getMilestoneProject() \|\| $object->isMilestone());

	$unavailable = array(
	PhabricatorTransactions::TYPE_VIEW_POLICY,
	PhabricatorTransactions::TYPE_EDIT_POLICY,
	PhabricatorTransactions::TYPE_JOIN_POLICY,
	PhabricatorProjectTransaction::TYPE_ICON,
	PhabricatorProjectTransaction::TYPE_COLOR,
	);
	$unavailable = array_fuse($unavailable);

	if ($is_milestone) {
	foreach ($fields as $key => $field) {
	$xaction_type = $field->getTransactionType();
	if (isset($unavailable[$xaction_type])) {
	unset($fields[$key]);
	}
	}
	}

	return $fields;
	}

	protected function newBuiltinEngineConfigurations() {
	$configuration = head(parent::newBuiltinEngineConfigurations());

	// TODO: This whole method is clumsy, and the ordering for the custom
	// field is especially clumsy. Maybe try to make this more natural to
	// express.

	$configuration
	->setFieldOrder(
	array(
	'parent',
	'milestone',
	'milestone.previous',
	'name',
	'std:project:internal:description',
	'icon',
	'color',
	'slugs',
	));

	return array(
	$configuration,
	);
	}

	protected function buildCustomEditFields($object) {
	$slugs = mpull($object->getSlugs(), 'getSlug');
	$slugs = array_fuse($slugs);
	unset($slugs[$object->getPrimarySlug()]);
	$slugs = array_values($slugs);

	$milestone = $this->getMilestoneProject();
	$parent = $this->getParentProject();

	if ($parent) {
	$parent_phid = $parent->getPHID();
	} else {
	$parent_phid = null;
	}

	$previous_milestone_phid = null;
	if ($milestone) {
	$milestone_phid = $milestone->getPHID();

	// Load the current milestone so we can show the user a hint about what
	// it was called, so they don't have to remember if the next one should
	// be "Sprint 287" or "Sprint 278".

	$number = ($milestone->loadNextMilestoneNumber() - 1);
	if ($number > 0) {
	$previous_milestone = id(new PhabricatorProjectQuery())
	->setViewer($this->getViewer())
	->withParentProjectPHIDs(array($milestone->getPHID()))
	->withIsMilestone(true)
	->withMilestoneNumberBetween($number, $number)
	->executeOne();
	if ($previous_milestone) {
	$previous_milestone_phid = $previous_milestone->getPHID();
	}
	}
	} else {
	$milestone_phid = null;
	}

	$fields = array(
	id(new PhabricatorHandlesEditField())
	->setKey('parent')
	->setLabel(pht('Parent'))
	->setDescription(pht('Create a subproject of an existing project.'))
	->setConduitDescription(
	pht('Choose a parent project to create a subproject beneath.'))
	->setConduitTypeDescription(pht('PHID of the parent project.'))
	->setAliases(array('parentPHID'))
	->setTransactionType(PhabricatorProjectTransaction::TYPE_PARENT)
	->setHandleParameterType(new AphrontPHIDHTTPParameterType())
	->setSingleValue($parent_phid)
	->setIsReorderable(false)
	->setIsDefaultable(false)
	->setIsLockable(false)
	->setIsLocked(true),
	id(new PhabricatorHandlesEditField())
	->setKey('milestone')
	->setLabel(pht('Milestone Of'))
	->setDescription(pht('Parent project to create a milestone for.'))
	->setConduitDescription(
	pht('Choose a parent project to create a new milestone for.'))
	->setConduitTypeDescription(pht('PHID of the parent project.'))
	->setAliases(array('milestonePHID'))
	->setTransactionType(PhabricatorProjectTransaction::TYPE_MILESTONE)
	->setHandleParameterType(new AphrontPHIDHTTPParameterType())
	->setSingleValue($milestone_phid)
	->setIsReorderable(false)
	->setIsDefaultable(false)
	->setIsLockable(false)
	->setIsLocked(true),
	id(new PhabricatorHandlesEditField())
	->setKey('milestone.previous')
	->setLabel(pht('Previous Milestone'))
	->setSingleValue($previous_milestone_phid)
	->setIsReorderable(false)
	->setIsDefaultable(false)
	->setIsLockable(false)
	->setIsLocked(true),
	id(new PhabricatorTextEditField())
	->setKey('name')
	->setLabel(pht('Name'))
	->setTransactionType(PhabricatorProjectTransaction::TYPE_NAME)
	->setIsRequired(true)
	->setDescription(pht('Project name.'))
	->setConduitDescription(pht('Rename the project'))
	->setConduitTypeDescription(pht('New project name.'))
	->setValue($object->getName()),
	id(new PhabricatorIconSetEditField())
	->setKey('icon')
	->setLabel(pht('Icon'))
	->setTransactionType(PhabricatorProjectTransaction::TYPE_ICON)
	->setIconSet(new PhabricatorProjectIconSet())
	->setDescription(pht('Project icon.'))
	->setConduitDescription(pht('Change the project icon.'))
	->setConduitTypeDescription(pht('New project icon.'))
	->setValue($object->getIcon()),
	id(new PhabricatorSelectEditField())
	->setKey('color')
	->setLabel(pht('Color'))
	->setTransactionType(PhabricatorProjectTransaction::TYPE_COLOR)
	->setOptions(PhabricatorProjectIconSet::getColorMap())
	->setDescription(pht('Project tag color.'))
	->setConduitDescription(pht('Change the project tag color.'))
	->setConduitTypeDescription(pht('New project tag color.'))
	->setValue($object->getColor()),
	id(new PhabricatorStringListEditField())
	->setKey('slugs')
	->setLabel(pht('Additional Hashtags'))
	->setTransactionType(PhabricatorProjectTransaction::TYPE_SLUGS)
	->setDescription(pht('Additional project slugs.'))
	->setConduitDescription(pht('Change project slugs.'))
	->setConduitTypeDescription(pht('New list of slugs.'))
	->setValue($slugs),
	);

	$can_edit_members = (!$milestone) &&
	(!$object->isMilestone()) &&
	(!$object->getHasSubprojects());

	if ($can_edit_members) {

	// Show this on the web UI when creating a project, but not when editing
	// one. It is always available via Conduit.
	$conduit_only = !$this->getIsCreate();

	$members_field = id(new PhabricatorUsersEditField())
	->setKey('members')
	->setAliases(array('memberPHIDs'))
	->setLabel(pht('Initial Members'))
	->setIsConduitOnly($conduit_only)
	->setUseEdgeTransactions(true)
	->setTransactionType(PhabricatorTransactions::TYPE_EDGE)
	->setMetadataValue(
	'edge:type',
	PhabricatorProjectProjectHasMemberEdgeType::EDGECONST)
	->setDescription(pht('Initial project members.'))
	->setConduitDescription(pht('Set project members.'))
	->setConduitTypeDescription(pht('New list of members.'))
	->setValue(array());

	$members_field->setViewer($this->getViewer());

	$edit_add = $members_field->getConduitEditType('members.add')
	->setConduitDescription(pht('Add members.'));

	$edit_set = $members_field->getConduitEditType('members.set')
	->setConduitDescription(
	pht('Set members, overwriting the current value.'));

	$edit_rem = $members_field->getConduitEditType('members.remove')
	->setConduitDescription(pht('Remove members.'));

	$fields[] = $members_field;
	}

	return $fields;

	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Fri, Mar 14, 3:21 PM (1 d, 13 h)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 71989
Default Alt Text: (43 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions