Page MenuHomestyx hydra
Files F234585

No OneTemporary
Actions

View Options

diff --git a/src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php b/src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php
index bff54277de..4a7342dc5f 100644
--- a/src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php
+++ b/src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php
@@ -1,66 +1,69 @@
<?php
final class PhabricatorProjectColumnNameTransaction
extends PhabricatorProjectColumnTransactionType {
const TRANSACTIONTYPE = 'project:col:name';
public function generateOldValue($object) {
return $object->getName();
}
public function applyInternalEffects($object, $value) {
$object->setName($value);
}
public function getTitle() {
$old = $this->getOldValue();
$new = $this->getNewValue();
if (!strlen($old)) {
return pht(
'%s named this column %s.',
$this->renderAuthor(),
$this->renderNewValue());
} else if (strlen($new)) {
return pht(
'%s renamed this column from %s to %s.',
$this->renderAuthor(),
$this->renderOldValue(),
$this->renderNewValue());
} else {
return pht(
'%s removed the custom name of this column.',
$this->renderAuthor());
}
}
public function validateTransactions($object, array $xactions) {
$errors = array();
if ($this->isEmptyTextTransaction($object->getName(), $xactions)) {
// The default "Backlog" column is allowed to be unnamed, which
// means we use the default name.
- if (!$object->isDefaultColumn()) {
+
+ // Proxy columns can't have a name, so don't raise an error here.
+
+ if (!$object->isDefaultColumn() && !$object->getProxy()) {
$errors[] = $this->newRequiredError(
pht('Columns must have a name.'));
}
}
$max_length = $object->getColumnMaximumByteLength('name');
foreach ($xactions as $xaction) {
$new_value = $xaction->getNewValue();
$new_length = strlen($new_value);
if ($new_length > $max_length) {
$errors[] = $this->newInvalidError(
pht(
'Column names must not be longer than %s characters.',
new PhutilNumber($max_length)),
$xaction);
}
}
return $errors;
}
}

File Metadata

Mime Type
text/x-diff
Expires
Mon, Jul 28, 6:33 PM (1 w, 3 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
187350
Default Alt Text
(2 KB)

Event Timeline

styx copyright 2020 sirocyl / ellie (kymkdd) / ncommander / styx contributors
Use of other names and brands is not intended to reflect a claim of, or right to, use the name or brand.
styx is an operating system using the Linux kernel and components, and "styx Linux" as a phrase does not reflect the inclusion of the Linux brand or trademark in the styx project.
Linux® is the registered trademark of Linus Torvalds in the U.S. and other countries.
Terms and Conditions (TODO: fix this!)