No OneTemporary
Actions

Size

51 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/maniphest/editor/ManiphestEditEngine.php b/src/applications/maniphest/editor/ManiphestEditEngine.php
	index b7e3cee965..058a8a98b6 100644
	--- a/src/applications/maniphest/editor/ManiphestEditEngine.php
	+++ b/src/applications/maniphest/editor/ManiphestEditEngine.php
	@@ -1,348 +1,350 @@
	<?php

	final class ManiphestEditEngine
	extends PhabricatorEditEngine {

	const ENGINECONST = 'maniphest.task';

	public function getEngineName() {
	return pht('Maniphest Tasks');
	}

	public function getSummaryHeader() {
	return pht('Configure Maniphest Task Forms');
	}

	public function getSummaryText() {
	return pht('Configure how users create and edit tasks.');
	}

	public function getEngineApplicationClass() {
	return 'PhabricatorManiphestApplication';
	}

	protected function newEditableObject() {
	return ManiphestTask::initializeNewTask($this->getViewer());
	}

	protected function newObjectQuery() {
	return id(new ManiphestTaskQuery());
	}

	protected function getObjectCreateTitleText($object) {
	return pht('Create New Task');
	}

	protected function getObjectEditTitleText($object) {
	return pht('Edit %s %s', $object->getMonogram(), $object->getTitle());
	}

	protected function getObjectEditShortText($object) {
	return $object->getMonogram();
	}

	protected function getObjectCreateShortText() {
	return pht('Create Task');
	}

	protected function getEditorURI() {
	return $this->getApplication()->getApplicationURI('task/edit/');
	}

	protected function getCommentViewHeaderText($object) {
	return pht('Weigh In');
	}

	protected function getCommentViewButtonText($object) {
	return pht('Set Sail for Adventure');
	}

	protected function getObjectViewURI($object) {
	return '/'.$object->getMonogram();
	}

	protected function buildCustomEditFields($object) {
	$status_map = $this->getTaskStatusMap($object);
	$priority_map = $this->getTaskPriorityMap($object);

	if ($object->isClosed()) {
	$default_status = ManiphestTaskStatus::getDefaultStatus();
	} else {
	$default_status = ManiphestTaskStatus::getDefaultClosedStatus();
	}

	if ($object->getOwnerPHID()) {
	$owner_value = array($object->getOwnerPHID());
	} else {
	$owner_value = array($this->getViewer()->getPHID());
	}

	return array(
	id(new PhabricatorHandlesEditField())
	->setKey('parent')
	->setLabel(pht('Parent Task'))
	->setDescription(pht('Task to make this a subtask of.'))
	->setConduitDescription(pht('Create as a subtask of another task.'))
	->setConduitTypeDescription(pht('PHID of the parent task.'))
	->setAliases(array('parentPHID'))
	->setTransactionType(ManiphestTransaction::TYPE_PARENT)
	->setHandleParameterType(new ManiphestTaskListHTTPParameterType())
	->setSingleValue(null)
	->setIsReorderable(false)
	->setIsDefaultable(false)
	->setIsLockable(false),
	id(new PhabricatorHandlesEditField())
	->setKey('column')
	->setLabel(pht('Column'))
	->setDescription(pht('Workboard column to create this task into.'))
	->setConduitDescription(pht('Create into a workboard column.'))
	->setConduitTypeDescription(pht('PHID of workboard column.'))
	->setAliases(array('columnPHID'))
	->setTransactionType(ManiphestTransaction::TYPE_COLUMN)
	->setSingleValue(null)
	->setIsInvisible(true)
	->setIsReorderable(false)
	->setIsDefaultable(false)
	->setIsLockable(false),
	id(new PhabricatorTextEditField())
	->setKey('title')
	->setLabel(pht('Title'))
	->setDescription(pht('Name of the task.'))
	->setConduitDescription(pht('Rename the task.'))
	->setConduitTypeDescription(pht('New task name.'))
	->setTransactionType(ManiphestTransaction::TYPE_TITLE)
	->setIsRequired(true)
	->setValue($object->getTitle()),
	id(new PhabricatorUsersEditField())
	->setKey('owner')
	->setAliases(array('ownerPHID', 'assign', 'assigned'))
	->setLabel(pht('Assigned To'))
	->setDescription(pht('User who is responsible for the task.'))
	->setConduitDescription(pht('Reassign the task.'))
	->setConduitTypeDescription(
	pht('New task owner, or `null` to unassign.'))
	->setTransactionType(ManiphestTransaction::TYPE_OWNER)
	->setIsCopyable(true)
	->setSingleValue($object->getOwnerPHID())
	->setCommentActionLabel(pht('Assign / Claim'))
	->setCommentActionValue($owner_value),
	id(new PhabricatorSelectEditField())
	->setKey('status')
	->setLabel(pht('Status'))
	->setDescription(pht('Status of the task.'))
	->setConduitDescription(pht('Change the task status.'))
	->setConduitTypeDescription(pht('New task status constant.'))
	->setTransactionType(ManiphestTransaction::TYPE_STATUS)
	->setIsCopyable(true)
	->setValue($object->getStatus())
	->setOptions($status_map)
	->setCommentActionLabel(pht('Change Status'))
	->setCommentActionValue($default_status),
	id(new PhabricatorSelectEditField())
	->setKey('priority')
	->setLabel(pht('Priority'))
	->setDescription(pht('Priority of the task.'))
	->setConduitDescription(pht('Change the priority of the task.'))
	->setConduitTypeDescription(pht('New task priority constant.'))
	->setTransactionType(ManiphestTransaction::TYPE_PRIORITY)
	->setIsCopyable(true)
	->setValue($object->getPriority())
	->setOptions($priority_map)
	->setCommentActionLabel(pht('Change Priority')),
	id(new PhabricatorRemarkupEditField())
	->setKey('description')
	->setLabel(pht('Description'))
	->setDescription(pht('Task description.'))
	->setConduitDescription(pht('Update the task description.'))
	->setConduitTypeDescription(pht('New task description.'))
	->setTransactionType(ManiphestTransaction::TYPE_DESCRIPTION)
	->setValue($object->getDescription())
	->setPreviewPanel(
	id(new PHUIRemarkupPreviewPanel())
	->setHeader(pht('Description Preview'))),
	);
	}

	private function getTaskStatusMap(ManiphestTask $task) {
	$status_map = ManiphestTaskStatus::getTaskStatusMap();

	$current_status = $task->getStatus();

	// If the current status is something we don't recognize (maybe an older
	// status which was deleted), put a dummy entry in the status map so that
	// saving the form doesn't destroy any data by accident.
	if (idx($status_map, $current_status) === null) {
	$status_map[$current_status] = pht('<Unknown: %s>', $current_status);
	}

	$dup_status = ManiphestTaskStatus::getDuplicateStatus();
	foreach ($status_map as $status => $status_name) {
	// Always keep the task's current status.
	if ($status == $current_status) {
	continue;
	}

	// Don't allow tasks to be changed directly into "Closed, Duplicate"
	// status. Instead, you have to merge them. See T4819.
	if ($status == $dup_status) {
	unset($status_map[$status]);
	continue;
	}

	// Don't let new or existing tasks be moved into a disabled status.
	if (ManiphestTaskStatus::isDisabledStatus($status)) {
	unset($status_map[$status]);
	continue;
	}
	}

	return $status_map;
	}

	private function getTaskPriorityMap(ManiphestTask $task) {
	$priority_map = ManiphestTaskPriority::getTaskPriorityMap();
	$current_priority = $task->getPriority();

	// If the current value isn't a legitimate one, put it in the dropdown
	// anyway so saving the form doesn't cause a side effects.
	if (idx($priority_map, $current_priority) === null) {
	$priority_map[$current_priority] = pht(
	'<Unknown: %s>',
	$current_priority);
	}

	foreach ($priority_map as $priority => $priority_name) {
	// Always keep the current priority.
	if ($priority == $current_priority) {
	continue;
	}

	if (ManiphestTaskPriority::isDisabledPriority($priority)) {
	unset($priority_map[$priority]);
	continue;
	}
	}

	return $priority_map;
	}

	protected function newEditResponse(
	AphrontRequest $request,
	$object,
	array $xactions) {

	if ($request->isAjax()) {
	// Reload the task to make sure we pick up the final task state.
	$viewer = $this->getViewer();
	$task = id(new ManiphestTaskQuery())
	->setViewer($viewer)
	->withIDs(array($object->getID()))
	->needSubscriberPHIDs(true)
	->needProjectPHIDs(true)
	->executeOne();

	switch ($request->getStr('responseType')) {
	case 'card':
	return $this->buildCardResponse($task);
	default:
	return $this->buildListResponse($task);
	}

	}

	return parent::newEditResponse($request, $object, $xactions);
	}

	private function buildListResponse(ManiphestTask $task) {
	$controller = $this->getController();

	$payload = array(
	'tasks' => $controller->renderSingleTask($task),
	'data' => array(),
	);

	return id(new AphrontAjaxResponse())->setContent($payload);
	}

	private function buildCardResponse(ManiphestTask $task) {
	$controller = $this->getController();
	$request = $controller->getRequest();
	$viewer = $request->getViewer();

	$column_phid = $request->getStr('columnPHID');
	$order = $request->getStr('order');

	$column = id(new PhabricatorProjectColumnQuery())
	->setViewer($viewer)
	->withPHIDs(array($column_phid))
	->executeOne();
	if (!$column) {
	return new Aphront404Response();
	}

	// If the workboard's project has been removed from the card's project
	// list, we are going to remove it from the board completely.
	$project_map = array_fuse($task->getProjectPHIDs());
	$remove_card = empty($project_map[$column->getProjectPHID()]);

	$positions = id(new PhabricatorProjectColumnPositionQuery())
	->setViewer($viewer)
	->withColumns(array($column))
	->execute();
	$task_phids = mpull($positions, 'getObjectPHID');

	$column_tasks = id(new ManiphestTaskQuery())
	->setViewer($viewer)
	->withPHIDs($task_phids)
	+ ->needProjectPHIDs(true)
	->execute();

	if ($order == PhabricatorProjectColumn::ORDER_NATURAL) {
	// TODO: This is a little bit awkward, because PHP and JS use
	// slightly different sort order parameters to achieve the same
	// effect. It would be good to unify this a bit at some point.
	$sort_map = array();
	foreach ($positions as $position) {
	$sort_map[$position->getObjectPHID()] = array(
	-$position->getSequence(),
	$position->getID(),
	);
	}
	} else {
	$sort_map = mpull(
	$column_tasks,
	'getPrioritySortVector',
	'getPHID');
	}

	$data = array(
	'removeFromBoard' => $remove_card,
	'sortMap' => $sort_map,
	);

	// TODO: This should just use HandlePool once we get through the EditEngine
	// transition.
	$owner = null;
	if ($task->getOwnerPHID()) {
	$owner = id(new PhabricatorHandleQuery())
	->setViewer($viewer)
	->withPHIDs(array($task->getOwnerPHID()))
	->executeOne();
	}

	$tasks = id(new ProjectBoardTaskCard())
	->setViewer($viewer)
	->setTask($task)
	->setOwner($owner)
	+ ->setProject($column->getProject())
	->setCanEdit(true)
	->getItem();

	$payload = array(
	'tasks' => $tasks,
	'data' => $data,
	);

	return id(new AphrontAjaxResponse())->setContent($payload);
	}


	}
	diff --git a/src/applications/phid/view/PHUIHandleTagListView.php b/src/applications/phid/view/PHUIHandleTagListView.php
	index 73cbef2350..0bbfc4d249 100644
	--- a/src/applications/phid/view/PHUIHandleTagListView.php
	+++ b/src/applications/phid/view/PHUIHandleTagListView.php
	@@ -1,120 +1,120 @@
	<?php

	final class PHUIHandleTagListView extends AphrontTagView {

	private $handles;
	private $annotations = array();
	private $limit;
	private $noDataString;
	private $slim;
	private $showHovercards;

	- public function setHandles(array $handles) {
	+ public function setHandles($handles) {
	$this->handles = $handles;
	return $this;
	}

	public function setAnnotations(array $annotations) {
	$this->annotations = $annotations;
	return $this;
	}

	public function setLimit($limit) {
	$this->limit = $limit;
	return $this;
	}

	public function setNoDataString($no_data) {
	$this->noDataString = $no_data;
	return $this;
	}

	public function setSlim($slim) {
	$this->slim = true;
	return $this;
	}

	public function setShowHovercards($show_hovercards) {
	$this->showHovercards = $show_hovercards;
	return $this;
	}

	protected function getTagName() {
	return 'ul';
	}

	protected function getTagAttributes() {
	return array(
	'class' => 'phabricator-handle-tag-list',
	);
	}

	protected function getTagContent() {
	$handles = $this->handles;

	// If the list is empty, we may render a "No Projects" tag.
	if (!$handles) {
	if (strlen($this->noDataString)) {
	$no_data_tag = $this->newPlaceholderTag()
	->setName($this->noDataString);
	return $this->newItem($no_data_tag);
	}
	}

	if ($this->limit) {
	$handles = array_slice($handles, 0, $this->limit);
	}

	$list = array();
	foreach ($handles as $handle) {
	$tag = $handle->renderTag();
	if ($this->showHovercards) {
	$tag->setPHID($handle->getPHID());
	}
	if ($this->slim) {
	$tag->setSlimShady(true);
	}
	$list[] = $this->newItem(
	array(
	$tag,
	idx($this->annotations, $handle->getPHID(), null),
	));
	}

	if ($this->limit) {
	if ($this->limit < count($this->handles)) {
	$tip_text = implode(', ', mpull($this->handles, 'getName'));

	$more = $this->newPlaceholderTag()
	->setName("\xE2\x80\xA6")
	->addSigil('has-tooltip')
	->setMetadata(
	array(
	'tip' => $tip_text,
	'size' => 200,
	));

	$list[] = $this->newItem($more);
	}
	}

	return $list;
	}

	private function newItem($content) {
	return phutil_tag(
	'li',
	array(
	'class' => 'phabricator-handle-tag-list-item',
	),
	$content);
	}

	private function newPlaceholderTag() {
	return id(new PHUITagView())
	->setType(PHUITagView::TYPE_OBJECT)
	->setShade(PHUITagView::COLOR_DISABLED)
	->setSlimShady($this->slim);
	}

	}
	diff --git a/src/applications/project/controller/PhabricatorProjectBoardViewController.php b/src/applications/project/controller/PhabricatorProjectBoardViewController.php
	index 4d83ca6fa3..2c064eaf71 100644
	--- a/src/applications/project/controller/PhabricatorProjectBoardViewController.php
	+++ b/src/applications/project/controller/PhabricatorProjectBoardViewController.php
	@@ -1,831 +1,832 @@
	<?php

	final class PhabricatorProjectBoardViewController
	extends PhabricatorProjectBoardController {

	const BATCH_EDIT_ALL = 'all';

	private $id;
	private $slug;
	private $handles;
	private $queryKey;
	private $filter;
	private $sortKey;
	private $showHidden;

	public function shouldAllowPublic() {
	return true;
	}

	public function handleRequest(AphrontRequest $request) {
	$viewer = $request->getUser();

	$response = $this->loadProject();
	if ($response) {
	return $response;
	}

	$project = $this->getProject();

	$this->readRequestState();
	$columns = $this->loadColumns($project);

	// TODO: Expand the checks here if we add the ability
	// to hide the Backlog column
	if (!$columns) {
	$can_edit = PhabricatorPolicyFilter::hasCapability(
	$viewer,
	$project,
	PhabricatorPolicyCapability::CAN_EDIT);
	if (!$can_edit) {
	$content = $this->buildNoAccessContent($project);
	} else {
	$content = $this->buildInitializeContent($project);
	}

	if ($content instanceof AphrontResponse) {
	return $content;
	}

	$nav = $this->getProfileMenu();
	$nav->selectFilter(PhabricatorProject::PANEL_WORKBOARD);

	$crumbs = $this->buildApplicationCrumbs();
	$crumbs->addTextCrumb(pht('Workboard'));

	return $this->newPage()
	->setTitle(
	array(
	pht('Workboard'),
	$project->getName(),
	))
	->setNavigation($nav)
	->setCrumbs($crumbs)
	->appendChild($content);
	}

	$board_uri = $this->getApplicationURI('board/'.$project->getID().'/');

	$engine = id(new ManiphestTaskSearchEngine())
	->setViewer($viewer)
	->setBaseURI($board_uri)
	->setIsBoardView(true);

	if ($request->isFormPost()) {
	$saved = $engine->buildSavedQueryFromRequest($request);
	$engine->saveQuery($saved);
	$filter_form = id(new AphrontFormView())
	->setUser($viewer);
	$engine->buildSearchForm($filter_form, $saved);
	if ($engine->getErrors()) {
	return $this->newDialog()
	->setWidth(AphrontDialogView::WIDTH_FULL)
	->setTitle(pht('Advanced Filter'))
	->appendChild($filter_form->buildLayoutView())
	->setErrors($engine->getErrors())
	->setSubmitURI($board_uri)
	->addSubmitButton(pht('Apply Filter'))
	->addCancelButton($board_uri);
	}
	return id(new AphrontRedirectResponse())->setURI(
	$this->getURIWithState(
	$engine->getQueryResultsPageURI($saved->getQueryKey())));
	}

	$query_key = $request->getURIData('queryKey');
	if (!$query_key) {
	$query_key = 'open';
	}
	$this->queryKey = $query_key;

	$custom_query = null;
	if ($engine->isBuiltinQuery($query_key)) {
	$saved = $engine->buildSavedQueryFromBuiltin($query_key);
	} else {
	$saved = id(new PhabricatorSavedQueryQuery())
	->setViewer($viewer)
	->withQueryKeys(array($query_key))
	->executeOne();

	if (!$saved) {
	return new Aphront404Response();
	}

	$custom_query = $saved;
	}

	if ($request->getURIData('filter')) {
	$filter_form = id(new AphrontFormView())
	->setUser($viewer);
	$engine->buildSearchForm($filter_form, $saved);

	return $this->newDialog()
	->setWidth(AphrontDialogView::WIDTH_FULL)
	->setTitle(pht('Advanced Filter'))
	->appendChild($filter_form->buildLayoutView())
	->setSubmitURI($board_uri)
	->addSubmitButton(pht('Apply Filter'))
	->addCancelButton($board_uri);
	}

	$task_query = $engine->buildQueryFromSavedQuery($saved);

	$tasks = $task_query
	->withEdgeLogicPHIDs(
	PhabricatorProjectObjectHasProjectEdgeType::EDGECONST,
	PhabricatorQueryConstraint::OPERATOR_AND,
	array($project->getPHID()))
	->setOrder(ManiphestTaskQuery::ORDER_PRIORITY)
	->setViewer($viewer)
	->execute();
	$tasks = mpull($tasks, null, 'getPHID');

	if ($tasks) {
	$positions = id(new PhabricatorProjectColumnPositionQuery())
	->setViewer($viewer)
	->withObjectPHIDs(mpull($tasks, 'getPHID'))
	->withColumns($columns)
	->execute();
	$positions = mpull($positions, null, 'getObjectPHID');
	} else {
	$positions = array();
	}

	$task_map = array();
	foreach ($tasks as $task) {
	$task_phid = $task->getPHID();
	if (empty($positions[$task_phid])) {
	// This shouldn't normally be possible because we create positions on
	// demand, but we might have raced as an object was removed from the
	// board. Just drop the task if we don't have a position for it.
	continue;
	}

	$position = $positions[$task_phid];
	$task_map[$position->getColumnPHID()][] = $task_phid;
	}

	// If we're showing the board in "natural" order, sort columns by their
	// column positions.
	if ($this->sortKey == PhabricatorProjectColumn::ORDER_NATURAL) {
	foreach ($task_map as $column_phid => $task_phids) {
	$order = array();
	foreach ($task_phids as $task_phid) {
	if (isset($positions[$task_phid])) {
	$order[$task_phid] = $positions[$task_phid]->getOrderingKey();
	} else {
	$order[$task_phid] = 0;
	}
	}
	asort($order);
	$task_map[$column_phid] = array_keys($order);
	}
	}

	$task_can_edit_map = id(new PhabricatorPolicyFilter())
	->setViewer($viewer)
	->requireCapabilities(array(PhabricatorPolicyCapability::CAN_EDIT))
	->apply($tasks);

	// If this is a batch edit, select the editable tasks in the chosen column
	// and ship the user into the batch editor.
	$batch_edit = $request->getStr('batch');
	if ($batch_edit) {
	if ($batch_edit !== self::BATCH_EDIT_ALL) {
	$column_id_map = mpull($columns, null, 'getID');
	$batch_column = idx($column_id_map, $batch_edit);
	if (!$batch_column) {
	return new Aphront404Response();
	}

	$batch_task_phids = idx($task_map, $batch_column->getPHID(), array());
	foreach ($batch_task_phids as $key => $batch_task_phid) {
	if (empty($task_can_edit_map[$batch_task_phid])) {
	unset($batch_task_phids[$key]);
	}
	}

	$batch_tasks = array_select_keys($tasks, $batch_task_phids);
	} else {
	$batch_tasks = $task_can_edit_map;
	}

	if (!$batch_tasks) {
	$cancel_uri = $this->getURIWithState($board_uri);
	return $this->newDialog()
	->setTitle(pht('No Editable Tasks'))
	->appendParagraph(
	pht(
	'The selected column contains no visible tasks which you '.
	'have permission to edit.'))
	->addCancelButton($board_uri);
	}

	$batch_ids = mpull($batch_tasks, 'getID');
	$batch_ids = implode(',', $batch_ids);

	$batch_uri = new PhutilURI('/maniphest/batch/');
	$batch_uri->setQueryParam('board', $this->id);
	$batch_uri->setQueryParam('batch', $batch_ids);
	return id(new AphrontRedirectResponse())
	->setURI($batch_uri);
	}

	$board_id = celerity_generate_unique_node_id();

	$board = id(new PHUIWorkboardView())
	->setUser($viewer)
	->setID($board_id);

	$behavior_config = array(
	'boardID' => $board_id,
	'projectPHID' => $project->getPHID(),
	'moveURI' => $this->getApplicationURI('move/'.$project->getID().'/'),
	'createURI' => $this->getCreateURI(),
	'order' => $this->sortKey,
	);
	$this->initBehavior(
	'project-boards',
	$behavior_config);

	$this->handles = ManiphestTaskListView::loadTaskHandles($viewer, $tasks);

	foreach ($columns as $column) {
	$task_phids = idx($task_map, $column->getPHID(), array());
	$column_tasks = array_select_keys($tasks, $task_phids);

	$panel = id(new PHUIWorkpanelView())
	->setHeader($column->getDisplayName())
	->setSubHeader($column->getDisplayType())
	->addSigil('workpanel');

	$header_icon = $column->getHeaderIcon();
	if ($header_icon) {
	$panel->setHeaderIcon($header_icon);
	}

	if ($column->isHidden()) {
	$panel->addClass('project-panel-hidden');
	}

	$column_menu = $this->buildColumnMenu($project, $column);
	$panel->addHeaderAction($column_menu);

	$tag_id = celerity_generate_unique_node_id();
	$tag_content_id = celerity_generate_unique_node_id();

	$count_tag = id(new PHUITagView())
	->setType(PHUITagView::TYPE_SHADE)
	->setShade(PHUITagView::COLOR_BLUE)
	->setID($tag_id)
	->setName(phutil_tag('span', array('id' => $tag_content_id), '-'))
	->setStyle('display: none');

	$panel->setHeaderTag($count_tag);

	$cards = id(new PHUIObjectItemListView())
	->setUser($viewer)
	->setFlush(true)
	->setAllowEmptyList(true)
	->addSigil('project-column')
	->setMetadata(
	array(
	'columnPHID' => $column->getPHID(),
	'countTagID' => $tag_id,
	'countTagContentID' => $tag_content_id,
	'pointLimit' => $column->getPointLimit(),
	));

	foreach ($column_tasks as $task) {
	$owner = null;
	if ($task->getOwnerPHID()) {
	$owner = $this->handles[$task->getOwnerPHID()];
	}
	$can_edit = idx($task_can_edit_map, $task->getPHID(), false);
	$cards->addItem(id(new ProjectBoardTaskCard())
	->setViewer($viewer)
	+ ->setProject($project)
	->setTask($task)
	->setOwner($owner)
	->setCanEdit($can_edit)
	->getItem());
	}
	$panel->setCards($cards);
	$board->addPanel($panel);
	}

	$sort_menu = $this->buildSortMenu(
	$viewer,
	$this->sortKey);

	$filter_menu = $this->buildFilterMenu(
	$viewer,
	$custom_query,
	$engine,
	$query_key);

	$manage_menu = $this->buildManageMenu($project, $this->showHidden);

	$header_link = phutil_tag(
	'a',
	array(
	'href' => $this->getApplicationURI('profile/'.$project->getID().'/'),
	),
	$project->getName());

	$board_box = id(new PHUIBoxView())
	->appendChild($board)
	->addClass('project-board-wrapper');

	$nav = $this->getProfileMenu();

	$crumbs = $this->buildApplicationCrumbs();
	$crumbs->addTextCrumb(pht('Workboard'));
	$crumbs->setBorder(true);

	$crumbs->addAction($sort_menu);
	$crumbs->addAction($filter_menu);
	$crumbs->addAction($manage_menu);

	return $this->newPage()
	->setTitle(pht('%s Board', $project->getName()))
	->setPageObjectPHIDs(array($project->getPHID()))
	->setShowFooter(false)
	->setNavigation($nav)
	->setCrumbs($crumbs)
	->addQuicksandConfig(
	array(
	'boardConfig' => $behavior_config,
	))
	->appendChild(
	array(
	$board_box,
	));
	}

	private function readRequestState() {
	$request = $this->getRequest();
	$project = $this->getProject();

	$this->showHidden = $request->getBool('hidden');
	$this->id = $project->getID();

	$sort_key = $request->getStr('order');
	switch ($sort_key) {
	case PhabricatorProjectColumn::ORDER_NATURAL:
	case PhabricatorProjectColumn::ORDER_PRIORITY:
	break;
	default:
	$sort_key = PhabricatorProjectColumn::DEFAULT_ORDER;
	break;
	}
	$this->sortKey = $sort_key;
	}

	private function loadColumns(PhabricatorProject $project) {
	$viewer = $this->getViewer();

	$column_query = id(new PhabricatorProjectColumnQuery())
	->setViewer($viewer)
	->withProjectPHIDs(array($project->getPHID()));

	if (!$this->showHidden) {
	$column_query->withStatuses(
	array(PhabricatorProjectColumn::STATUS_ACTIVE));
	}

	$columns = $column_query->execute();
	$columns = mpull($columns, null, 'getSequence');
	ksort($columns);

	return $columns;
	}

	private function buildSortMenu(
	PhabricatorUser $viewer,
	$sort_key) {

	$sort_icon = id(new PHUIIconView())
	->setIcon('fa-sort-amount-asc bluegrey');

	$named = array(
	PhabricatorProjectColumn::ORDER_NATURAL => pht('Natural'),
	PhabricatorProjectColumn::ORDER_PRIORITY => pht('Sort by Priority'),
	);

	$base_uri = $this->getURIWithState();

	$items = array();
	foreach ($named as $key => $name) {
	$is_selected = ($key == $sort_key);
	if ($is_selected) {
	$active_order = $name;
	}

	$item = id(new PhabricatorActionView())
	->setIcon('fa-sort-amount-asc')
	->setSelected($is_selected)
	->setName($name);

	$uri = $base_uri->alter('order', $key);
	$item->setHref($uri);

	$items[] = $item;
	}

	$sort_menu = id(new PhabricatorActionListView())
	->setUser($viewer);
	foreach ($items as $item) {
	$sort_menu->addAction($item);
	}

	$sort_button = id(new PHUIListItemView())
	->setName(pht('Sort: %s', $active_order))
	->setIcon('fa-sort-amount-asc')
	->setHref('#')
	->addSigil('boards-dropdown-menu')
	->setMetadata(
	array(
	'items' => hsprintf('%s', $sort_menu),
	));

	return $sort_button;
	}
	private function buildFilterMenu(
	PhabricatorUser $viewer,
	$custom_query,
	PhabricatorApplicationSearchEngine $engine,
	$query_key) {

	$named = array(
	'open' => pht('Open Tasks'),
	'all' => pht('All Tasks'),
	);

	if ($viewer->isLoggedIn()) {
	$named['assigned'] = pht('Assigned to Me');
	}

	if ($custom_query) {
	$named[$custom_query->getQueryKey()] = pht('Custom Filter');
	}

	$items = array();
	foreach ($named as $key => $name) {
	$is_selected = ($key == $query_key);
	if ($is_selected) {
	$active_filter = $name;
	}

	$is_custom = false;
	if ($custom_query) {
	$is_custom = ($key == $custom_query->getQueryKey());
	}

	$item = id(new PhabricatorActionView())
	->setIcon('fa-search')
	->setSelected($is_selected)
	->setName($name);

	if ($is_custom) {
	$uri = $this->getApplicationURI(
	'board/'.$this->id.'/filter/query/'.$key.'/');
	$item->setWorkflow(true);
	} else {
	$uri = $engine->getQueryResultsPageURI($key);
	}

	$uri = $this->getURIWithState($uri);
	$item->setHref($uri);

	$items[] = $item;
	}

	$items[] = id(new PhabricatorActionView())
	->setIcon('fa-cog')
	->setHref($this->getApplicationURI('board/'.$this->id.'/filter/'))
	->setWorkflow(true)
	->setName(pht('Advanced Filter...'));

	$filter_menu = id(new PhabricatorActionListView())
	->setUser($viewer);
	foreach ($items as $item) {
	$filter_menu->addAction($item);
	}

	$filter_button = id(new PHUIListItemView())
	->setName(pht('Filter: %s', $active_filter))
	->setIcon('fa-search')
	->setHref('#')
	->addSigil('boards-dropdown-menu')
	->setMetadata(
	array(
	'items' => hsprintf('%s', $filter_menu),
	));

	return $filter_button;
	}

	private function buildManageMenu(
	PhabricatorProject $project,
	$show_hidden) {

	$request = $this->getRequest();
	$viewer = $request->getUser();

	$can_edit = PhabricatorPolicyFilter::hasCapability(
	$viewer,
	$project,
	PhabricatorPolicyCapability::CAN_EDIT);

	$manage_items = array();

	$manage_items[] = id(new PhabricatorActionView())
	->setIcon('fa-plus')
	->setName(pht('Add Column'))
	->setHref($this->getApplicationURI('board/'.$this->id.'/edit/'))
	->setDisabled(!$can_edit)
	->setWorkflow(!$can_edit);

	$manage_items[] = id(new PhabricatorActionView())
	->setIcon('fa-exchange')
	->setName(pht('Reorder Columns'))
	->setHref($this->getApplicationURI('board/'.$this->id.'/reorder/'))
	->setDisabled(!$can_edit)
	->setWorkflow(true);

	if ($show_hidden) {
	$hidden_uri = $this->getURIWithState()
	->setQueryParam('hidden', null);
	$hidden_icon = 'fa-eye-slash';
	$hidden_text = pht('Hide Hidden Columns');
	} else {
	$hidden_uri = $this->getURIWithState()
	->setQueryParam('hidden', 'true');
	$hidden_icon = 'fa-eye';
	$hidden_text = pht('Show Hidden Columns');
	}

	$manage_items[] = id(new PhabricatorActionView())
	->setIcon($hidden_icon)
	->setName($hidden_text)
	->setHref($hidden_uri);

	$batch_edit_uri = $request->getRequestURI();
	$batch_edit_uri->setQueryParam('batch', self::BATCH_EDIT_ALL);
	$can_batch_edit = PhabricatorPolicyFilter::hasCapability(
	$viewer,
	PhabricatorApplication::getByClass('PhabricatorManiphestApplication'),
	ManiphestBulkEditCapability::CAPABILITY);

	$manage_items[] = id(new PhabricatorActionView())
	->setIcon('fa-list-ul')
	->setName(pht('Batch Edit Visible Tasks...'))
	->setHref($batch_edit_uri)
	->setDisabled(!$can_batch_edit);

	$manage_menu = id(new PhabricatorActionListView())
	->setUser($viewer);
	foreach ($manage_items as $item) {
	$manage_menu->addAction($item);
	}

	$manage_button = id(new PHUIListItemView())
	->setName(pht('Manage Board'))
	->setIcon('fa-cog')
	->setHref('#')
	->addSigil('boards-dropdown-menu')
	->setMetadata(
	array(
	'items' => hsprintf('%s', $manage_menu),
	));

	return $manage_button;
	}

	private function buildColumnMenu(
	PhabricatorProject $project,
	PhabricatorProjectColumn $column) {

	$request = $this->getRequest();
	$viewer = $request->getUser();

	$can_edit = PhabricatorPolicyFilter::hasCapability(
	$viewer,
	$project,
	PhabricatorPolicyCapability::CAN_EDIT);

	$column_items = array();

	$column_items[] = id(new PhabricatorActionView())
	->setIcon('fa-plus')
	->setName(pht('Create Task...'))
	->setHref($this->getCreateURI())
	->addSigil('column-add-task')
	->setMetadata(
	array(
	'columnPHID' => $column->getPHID(),
	));

	$batch_edit_uri = $request->getRequestURI();
	$batch_edit_uri->setQueryParam('batch', $column->getID());
	$can_batch_edit = PhabricatorPolicyFilter::hasCapability(
	$viewer,
	PhabricatorApplication::getByClass('PhabricatorManiphestApplication'),
	ManiphestBulkEditCapability::CAPABILITY);

	$column_items[] = id(new PhabricatorActionView())
	->setIcon('fa-list-ul')
	->setName(pht('Batch Edit Tasks...'))
	->setHref($batch_edit_uri)
	->setDisabled(!$can_batch_edit);

	$detail_uri = $this->getApplicationURI(
	'board/'.$this->id.'/column/'.$column->getID().'/');

	$column_items[] = id(new PhabricatorActionView())
	->setIcon('fa-columns')
	->setName(pht('Column Details'))
	->setHref($detail_uri);

	$can_hide = ($can_edit && !$column->isDefaultColumn());
	$hide_uri = 'board/'.$this->id.'/hide/'.$column->getID().'/';
	$hide_uri = $this->getApplicationURI($hide_uri);
	$hide_uri = $this->getURIWithState($hide_uri);

	if (!$column->isHidden()) {
	$column_items[] = id(new PhabricatorActionView())
	->setName(pht('Hide Column'))
	->setIcon('fa-eye-slash')
	->setHref($hide_uri)
	->setDisabled(!$can_hide)
	->setWorkflow(true);
	} else {
	$column_items[] = id(new PhabricatorActionView())
	->setName(pht('Show Column'))
	->setIcon('fa-eye')
	->setHref($hide_uri)
	->setDisabled(!$can_hide)
	->setWorkflow(true);
	}

	$column_menu = id(new PhabricatorActionListView())
	->setUser($viewer);
	foreach ($column_items as $item) {
	$column_menu->addAction($item);
	}

	$column_button = id(new PHUIIconView())
	->setIcon('fa-caret-down')
	->setHref('#')
	->addSigil('boards-dropdown-menu')
	->setMetadata(
	array(
	'items' => hsprintf('%s', $column_menu),
	));

	return $column_button;
	}


	/**
	* Add current state parameters (like order and the visibility of hidden
	* columns) to a URI.
	*
	* This allows actions which toggle or adjust one piece of state to keep
	* the rest of the board state persistent. If no URI is provided, this method
	* starts with the request URI.
	*
	* @param string\|null URI to add state parameters to.
	* @return PhutilURI URI with state parameters.
	*/
	private function getURIWithState($base = null) {
	if ($base === null) {
	$base = $this->getRequest()->getRequestURI();
	}

	$base = new PhutilURI($base);

	if ($this->sortKey != PhabricatorProjectColumn::DEFAULT_ORDER) {
	$base->setQueryParam('order', $this->sortKey);
	} else {
	$base->setQueryParam('order', null);
	}

	$base->setQueryParam('hidden', $this->showHidden ? 'true' : null);

	return $base;
	}

	private function getCreateURI() {
	$viewer = $this->getViewer();

	// TODO: This should be cleaned up, but maybe we're going to make options
	// for each column or board?
	$edit_config = id(new ManiphestEditEngine())
	->setViewer($viewer)
	->loadDefaultEditConfiguration();
	if ($edit_config) {
	$form_key = $edit_config->getIdentifier();
	$create_uri = "/maniphest/task/edit/form/{$form_key}/";
	} else {
	$create_uri = '/maniphest/task/edit/';
	}

	return $create_uri;
	}


	private function buildInitializeContent(PhabricatorProject $project) {
	$request = $this->getRequest();
	$viewer = $this->getViewer();

	$type = $request->getStr('initialize-type');

	$id = $project->getID();

	$profile_uri = $this->getApplicationURI("profile/{$id}/");
	$board_uri = $this->getApplicationURI("board/{$id}/");
	$import_uri = $this->getApplicationURI("board/{$id}/import/");

	$set_default = $request->getBool('default');
	if ($set_default) {
	$this
	->getProfilePanelEngine()
	->adjustDefault(PhabricatorProject::PANEL_WORKBOARD);
	}

	if ($request->isFormPost()) {
	if ($type == 'backlog-only') {
	$column = PhabricatorProjectColumn::initializeNewColumn($viewer)
	->setSequence(0)
	->setProperty('isDefault', true)
	->setProjectPHID($project->getPHID())
	->save();

	$project->setHasWorkboard(1)->save();

	return id(new AphrontRedirectResponse())
	->setURI($board_uri);
	} else {
	return id(new AphrontRedirectResponse())
	->setURI($import_uri);
	}
	}

	$new_selector = id(new AphrontFormRadioButtonControl())
	->setLabel(pht('Columns'))
	->setName('initialize-type')
	->setValue('backlog-only')
	->addButton(
	'backlog-only',
	pht('New Empty Board'),
	pht('Create a new board with just a backlog column.'))
	->addButton(
	'import',
	pht('Import Columns'),
	pht('Import board columns from another project.'));

	$default_checkbox = id(new AphrontFormCheckboxControl())
	->setLabel(pht('Make Default'))
	->addCheckbox(
	'default',
	1,
	pht('Make the workboard the default view for this project.'),
	true);

	$form = id(new AphrontFormView())
	->setUser($viewer)
	->appendRemarkupInstructions(
	pht('The workboard for this project has not been created yet.'))
	->appendControl($new_selector)
	->appendControl($default_checkbox)
	->appendControl(
	id(new AphrontFormSubmitControl())
	->addCancelButton($profile_uri)
	->setValue(pht('Create Workboard')));

	$box = id(new PHUIObjectBoxView())
	->setHeaderText(pht('Create Workboard'))
	->setForm($form);

	return $box;
	}

	private function buildNoAccessContent(PhabricatorProject $project) {
	$viewer = $this->getViewer();

	$id = $project->getID();

	$profile_uri = $this->getApplicationURI("profile/{$id}/");

	return $this->newDialog()
	->setTitle(pht('Unable to Create Workboard'))
	->appendParagraph(
	pht(
	'The workboard for this project has not been created yet, '.
	'but you do not have permission to create it. Only users '.
	'who can edit this project can create a workboard for it.'))
	->addCancelButton($profile_uri);
	}

	}
	diff --git a/src/applications/project/controller/PhabricatorProjectMoveController.php b/src/applications/project/controller/PhabricatorProjectMoveController.php
	index 1b2429917c..3fc72e7341 100644
	--- a/src/applications/project/controller/PhabricatorProjectMoveController.php
	+++ b/src/applications/project/controller/PhabricatorProjectMoveController.php
	@@ -1,163 +1,167 @@
	<?php

	final class PhabricatorProjectMoveController
	extends PhabricatorProjectController {

	public function handleRequest(AphrontRequest $request) {
	$viewer = $request->getViewer();
	$id = $request->getURIData('id');

	$column_phid = $request->getStr('columnPHID');
	$object_phid = $request->getStr('objectPHID');
	$after_phid = $request->getStr('afterPHID');
	$before_phid = $request->getStr('beforePHID');
	$order = $request->getStr('order', PhabricatorProjectColumn::DEFAULT_ORDER);


	$project = id(new PhabricatorProjectQuery())
	->setViewer($viewer)
	->requireCapabilities(
	array(
	PhabricatorPolicyCapability::CAN_VIEW,
	))
	->withIDs(array($id))
	->executeOne();
	if (!$project) {
	return new Aphront404Response();
	}

	- $object = id(new PhabricatorObjectQuery())
	+ $object = id(new ManiphestTaskQuery())
	->setViewer($viewer)
	->withPHIDs(array($object_phid))
	+ ->needProjectPHIDs(true)
	->requireCapabilities(
	array(
	PhabricatorPolicyCapability::CAN_VIEW,
	PhabricatorPolicyCapability::CAN_EDIT,
	))
	->executeOne();

	if (!$object) {
	return new Aphront404Response();
	}

	$columns = id(new PhabricatorProjectColumnQuery())
	->setViewer($viewer)
	->withProjectPHIDs(array($project->getPHID()))
	->execute();

	$columns = mpull($columns, null, 'getPHID');
	$column = idx($columns, $column_phid);
	if (!$column) {
	// User is trying to drop this object into a nonexistent column, just kick
	// them out.
	return new Aphront404Response();
	}

	$positions = id(new PhabricatorProjectColumnPositionQuery())
	->setViewer($viewer)
	->withColumns($columns)
	->withObjectPHIDs(array($object_phid))
	->execute();

	$xactions = array();

	if ($order == PhabricatorProjectColumn::ORDER_NATURAL) {
	$order_params = array(
	'afterPHID' => $after_phid,
	'beforePHID' => $before_phid,
	);
	} else {
	$order_params = array();
	}

	$xactions[] = id(new ManiphestTransaction())
	->setTransactionType(ManiphestTransaction::TYPE_PROJECT_COLUMN)
	->setNewValue(
	array(
	'columnPHIDs' => array($column->getPHID()),
	'projectPHID' => $column->getProjectPHID(),
	) + $order_params)
	->setOldValue(
	array(
	'columnPHIDs' => mpull($positions, 'getColumnPHID'),
	'projectPHID' => $column->getProjectPHID(),
	));

	$task_phids = array();
	if ($after_phid) {
	$task_phids[] = $after_phid;
	}
	if ($before_phid) {
	$task_phids[] = $before_phid;
	}

	if ($task_phids && ($order == PhabricatorProjectColumn::ORDER_PRIORITY)) {
	$tasks = id(new ManiphestTaskQuery())
	->setViewer($viewer)
	->withPHIDs($task_phids)
	+ ->needProjectPHIDs(true)
	->requireCapabilities(
	array(
	PhabricatorPolicyCapability::CAN_VIEW,
	PhabricatorPolicyCapability::CAN_EDIT,
	))
	->execute();
	if (count($tasks) != count($task_phids)) {
	return new Aphront404Response();
	}
	$tasks = mpull($tasks, null, 'getPHID');

	$try = array(
	array($after_phid, true),
	array($before_phid, false),
	);

	$pri = null;
	$sub = null;
	foreach ($try as $spec) {
	list($task_phid, $is_after) = $spec;
	$task = idx($tasks, $task_phid);
	if ($task) {
	list($pri, $sub) = ManiphestTransactionEditor::getAdjacentSubpriority(
	$task,
	$is_after);
	break;
	}
	}

	if ($pri !== null) {
	$xactions[] = id(new ManiphestTransaction())
	->setTransactionType(ManiphestTransaction::TYPE_PRIORITY)
	->setNewValue($pri);
	$xactions[] = id(new ManiphestTransaction())
	->setTransactionType(ManiphestTransaction::TYPE_SUBPRIORITY)
	->setNewValue($sub);
	}
	}

	$editor = id(new ManiphestTransactionEditor())
	->setActor($viewer)
	->setContinueOnMissingFields(true)
	->setContinueOnNoEffect(true)
	->setContentSourceFromRequest($request);

	$editor->applyTransactions($object, $xactions);

	$owner = null;
	if ($object->getOwnerPHID()) {
	$owner = id(new PhabricatorHandleQuery())
	->setViewer($viewer)
	->withPHIDs(array($object->getOwnerPHID()))
	->executeOne();
	}
	+
	$card = id(new ProjectBoardTaskCard())
	->setViewer($viewer)
	->setTask($object)
	->setOwner($owner)
	->setCanEdit(true)
	+ ->setProject($project)
	->getItem();

	return id(new AphrontAjaxResponse())->setContent(
	array('task' => $card));
	}

	}
	diff --git a/src/applications/project/view/ProjectBoardTaskCard.php b/src/applications/project/view/ProjectBoardTaskCard.php
	index 4fc26988d7..9ae3ef83c8 100644
	--- a/src/applications/project/view/ProjectBoardTaskCard.php
	+++ b/src/applications/project/view/ProjectBoardTaskCard.php
	@@ -1,79 +1,101 @@
	<?php

	final class ProjectBoardTaskCard extends Phobject {

	private $viewer;
	+ private $project;
	private $task;
	private $owner;
	private $canEdit;

	public function setViewer(PhabricatorUser $viewer) {
	$this->viewer = $viewer;
	return $this;
	}
	public function getViewer() {
	return $this->viewer;
	}

	+ public function setProject(PhabricatorProject $project) {
	+ $this->project = $project;
	+ return $this;
	+ }
	+ public function getProject() {
	+ return $this->project;
	+ }
	+
	public function setTask(ManiphestTask $task) {
	$this->task = $task;
	return $this;
	}
	public function getTask() {
	return $this->task;
	}

	public function setOwner(PhabricatorObjectHandle $owner = null) {
	$this->owner = $owner;
	return $this;
	}
	public function getOwner() {
	return $this->owner;
	}

	public function setCanEdit($can_edit) {
	$this->canEdit = $can_edit;
	return $this;
	}

	public function getCanEdit() {
	return $this->canEdit;
	}

	public function getItem() {
	$task = $this->getTask();
	$owner = $this->getOwner();
	$can_edit = $this->getCanEdit();
	+ $viewer = $this->getViewer();

	$color_map = ManiphestTaskPriority::getColorMap();
	$bar_color = idx($color_map, $task->getPriority(), 'grey');

	$card = id(new PHUIObjectItemView())
	->setObject($task)
	- ->setUser($this->getViewer())
	+ ->setUser($viewer)
	->setObjectName('T'.$task->getID())
	->setHeader($task->getTitle())
	->setGrippable($can_edit)
	->setHref('/T'.$task->getID())
	->addSigil('project-card')
	->setDisabled($task->isClosed())
	->setMetadata(
	array(
	'objectPHID' => $task->getPHID(),
	))
	->addAction(
	id(new PHUIListItemView())
	->setName(pht('Edit'))
	->setIcon('fa-pencil')
	->addSigil('edit-project-card')
	->setHref('/maniphest/task/edit/'.$task->getID().'/'))
	->setBarColor($bar_color);

	if ($owner) {
	$card->addAttribute($owner->renderLink());
	}

	+ $project_phids = array_fuse($task->getProjectPHIDs());
	+ unset($project_phids[$this->project->getPHID()]);
	+
	+ $handle_list = $viewer->loadHandles($project_phids);
	+ $tag_list = id(new PHUIHandleTagListView())
	+ ->setSlim(true)
	+ ->setHandles($handle_list);
	+
	+ if (!$tag_list->isEmpty()) {
	+ $card->addAttribute($tag_list);
	+ }
	+
	return $card;
	}

	}
	diff --git a/src/view/AphrontTagView.php b/src/view/AphrontTagView.php
	index a6eb722383..b82ebef9c3 100644
	--- a/src/view/AphrontTagView.php
	+++ b/src/view/AphrontTagView.php
	@@ -1,154 +1,158 @@
	<?php

	/**
	* View which renders down to a single tag, and provides common access for tag
	* attributes (setting classes, sigils, IDs, etc).
	*/
	abstract class AphrontTagView extends AphrontView {

	private $id;
	private $classes = array();
	private $sigils = array();
	private $style;
	private $metadata;
	private $mustCapture;
	private $workflow;

	public function setWorkflow($workflow) {
	$this->workflow = $workflow;
	return $this;
	}

	public function getWorkflow() {
	return $this->workflow;
	}

	public function setMustCapture($must_capture) {
	$this->mustCapture = $must_capture;
	return $this;
	}

	public function getMustCapture() {
	return $this->mustCapture;
	}

	final public function setMetadata(array $metadata) {
	$this->metadata = $metadata;
	return $this;
	}

	final public function getMetadata() {
	return $this->metadata;
	}

	final public function setStyle($style) {
	$this->style = $style;
	return $this;
	}

	final public function getStyle() {
	return $this->style;
	}

	final public function addSigil($sigil) {
	$this->sigils[] = $sigil;
	return $this;
	}

	final public function getSigils() {
	return $this->sigils;
	}

	public function addClass($class) {
	$this->classes[] = $class;
	return $this;
	}

	public function getClasses() {
	return $this->classes;
	}

	public function setID($id) {
	$this->id = $id;
	return $this;
	}

	public function getID() {
	return $this->id;
	}

	+ public function isEmpty() {
	+ return empty($this->getTagContent());
	+ }
	+
	protected function getTagName() {
	return 'div';
	}

	protected function getTagAttributes() {
	return array();
	}

	protected function getTagContent() {
	return $this->renderChildren();
	}

	final public function render() {
	$this->willRender();

	$attributes = $this->getTagAttributes();

	$implode = array('class', 'sigil');
	foreach ($implode as $attr) {
	if (isset($attributes[$attr])) {
	if (is_array($attributes[$attr])) {
	$attributes[$attr] = implode(' ', $attributes[$attr]);
	}
	}
	}

	if (!is_array($attributes)) {
	$class = get_class($this);
	throw new Exception(
	pht("View '%s' did not return an array from getTagAttributes()!",
	$class));
	}

	$sigils = $this->sigils;
	if ($this->workflow) {
	$sigils[] = 'workflow';
	}

	$tag_view_attributes = array(
	'id' => $this->id,

	'class' => implode(' ', $this->classes),
	'style' => $this->style,

	'meta' => $this->metadata,
	'sigil' => $sigils ? implode(' ', $sigils) : null,
	'mustcapture' => $this->mustCapture,
	);

	foreach ($tag_view_attributes as $key => $value) {
	if ($value === null) {
	continue;
	}
	if (!isset($attributes[$key])) {
	$attributes[$key] = $value;
	continue;
	}
	switch ($key) {
	case 'class':
	case 'sigil':
	$attributes[$key] = $attributes[$key].' '.$value;
	break;
	default:
	// Use the explicitly set value rather than the tag default value.
	$attributes[$key] = $value;
	break;
	}
	}

	return javelin_tag(
	$this->getTagName(),
	$attributes,
	$this->getTagContent());
	}
	}

File Metadata

Mime Type: text/x-diff
Expires: Thu, Jul 3, 2:12 PM (4 h, 5 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 165861
Default Alt Text: (51 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions