No OneTemporary
Actions

Size

2 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/differential/field/specification/summary/DifferentialSummaryFieldSpecification.php b/src/applications/differential/field/specification/summary/DifferentialSummaryFieldSpecification.php
	index b3afbe7dfb..0dd1cdf98c 100644
	--- a/src/applications/differential/field/specification/summary/DifferentialSummaryFieldSpecification.php
	+++ b/src/applications/differential/field/specification/summary/DifferentialSummaryFieldSpecification.php
	@@ -1,77 +1,77 @@
	<?php

	/*
	- * Copyright 2011 Facebook, Inc.
	+ * Copyright 2012 Facebook, Inc.
	*
	* Licensed under the Apache License, Version 2.0 (the "License");
	* you may not use this file except in compliance with the License.
	* You may obtain a copy of the License at
	*
	* http://www.apache.org/licenses/LICENSE-2.0
	*
	* Unless required by applicable law or agreed to in writing, software
	* distributed under the License is distributed on an "AS IS" BASIS,
	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
	* See the License for the specific language governing permissions and
	* limitations under the License.
	*/

	final class DifferentialSummaryFieldSpecification
	extends DifferentialFieldSpecification {

	private $summary = '';

	public function shouldAppearOnEdit() {
	return true;
	}

	protected function didSetRevision() {
	- $this->summary = $this->getRevision()->getSummary();
	+ $this->summary = (string)$this->getRevision()->getSummary();
	}

	public function setValueFromRequest(AphrontRequest $request) {
	$this->summary = $request->getStr('summary');
	return $this;
	}

	public function renderEditControl() {
	return id(new AphrontFormTextAreaControl())
	->setLabel('Summary')
	->setName('summary')
	->setValue($this->summary);
	}

	public function willWriteRevision(DifferentialRevisionEditor $editor) {
	$this->getRevision()->setSummary($this->summary);
	}

	public function shouldAppearOnCommitMessage() {
	return true;
	}

	public function getCommitMessageKey() {
	return 'summary';
	}

	public function setValueFromParsedCommitMessage($value) {
	$this->summary = (string)$value;
	return $this;
	}

	public function shouldOverwriteWhenCommitMessageIsEdited() {
	return true;
	}

	public function renderLabelForCommitMessage() {
	return 'Summary';
	}

	public function renderValueForCommitMessage($is_edit) {
	return $this->summary;
	}

	public function parseValueFromCommitMessage($value) {
	- return $value;
	+ return (string)$value;
	}

	}

File Metadata

Mime Type: text/x-diff
Expires: Mon, Jul 28, 2:47 AM (1 w, 19 h ago)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 186372
Default Alt Text: (2 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions