No OneTemporary
Actions

Size

90 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/config/option/PhabricatorMetaMTAConfigOptions.php b/src/applications/config/option/PhabricatorMetaMTAConfigOptions.php
	index fb81401681..ce24d48ead 100644
	--- a/src/applications/config/option/PhabricatorMetaMTAConfigOptions.php
	+++ b/src/applications/config/option/PhabricatorMetaMTAConfigOptions.php
	@@ -1,291 +1,288 @@
	<?php

	final class PhabricatorMetaMTAConfigOptions
	extends PhabricatorApplicationConfigOptions {

	public function getName() {
	return pht('Mail');
	}

	public function getDescription() {
	return pht('Configure Mail.');
	}

	public function getIcon() {
	return 'fa-send';
	}

	public function getGroup() {
	return 'core';
	}

	public function getOptions() {
	$send_as_user_desc = $this->deformat(pht(<<<EODOC
	When a user takes an action which generates an email notification (like
	commenting on a Differential revision), Phabricator can either send that mail
	"From" the user's email address (like "alincoln@logcabin.com") or "From" the
	'%s' address.

	The user experience is generally better if Phabricator uses the user's real
	address as the "From" since the messages are easier to organize when they appear
	in mail clients, but this will only work if the server is authorized to send
	email on behalf of the "From" domain. Practically, this means:

	- If you are doing an install for Example Corp and all the users will have
	corporate @corp.example.com addresses and any hosts Phabricator is running
	on are authorized to send email from corp.example.com, you can enable this
	to make the user experience a little better.
	- If you are doing an install for an open source project and your users will
	be registering via Facebook and using personal email addresses, you probably
	should not enable this or all of your outgoing email might vanish into SFP
	blackholes.
	- If your install is anything else, you're safer leaving this off, at least
	initially, since the risk in turning it on is that your outgoing mail will
	never arrive.
	EODOC
	,
	'metamta.default-address'));

	$one_mail_per_recipient_desc = $this->deformat(pht(<<<EODOC
	When a message is sent to multiple recipients (for example, several reviewers on
	a code review), Phabricator can either deliver one email to everyone (e.g., "To:
	alincoln, usgrant, htaft") or separate emails to each user (e.g., "To:
	alincoln", "To: usgrant", "To: htaft"). The major advantages and disadvantages
	of each approach are:

	- One mail to everyone:
	- This violates policy controls. The body of the mail is generated without
	respect for object policies.
	- Recipients can see To/Cc at a glance.
	- If you use mailing lists, you won't get duplicate mail if you're
	a normal recipient and also Cc'd on a mailing list.
	- Getting threading to work properly is harder, and probably requires
	making mail less useful by turning off options.
	- Sometimes people will "Reply All", which can send mail to too many
	recipients. Phabricator will try not to send mail to users who already
	received a similar message, but can not prevent all stray email arising
	from "Reply All".
	- Not supported with a private reply-to address.
	- Mail messages are sent in the server default translation.
	- Mail that must be delivered over secure channels will leak the recipient
	list in the "To" and "Cc" headers.
	- One mail to each user:
	- Policy controls work correctly and are enforced per-user.
	- Recipients need to look in the mail body to see To/Cc.
	- If you use mailing lists, recipients may sometimes get duplicate
	mail.
	- Getting threading to work properly is easier, and threading settings
	can be customzied by each user.
	- "Reply All" will never send extra mail to other users involved in the
	thread.
	- Required if private reply-to addresses are configured.
	- Mail messages are sent in the language of user preference.

	EODOC
	));

	$reply_hints_description = $this->deformat(pht(<<<EODOC
	You can disable the hints under "REPLY HANDLER ACTIONS" if users prefer
	smaller messages. The actions themselves will still work properly.
	EODOC
	));

	$recipient_hints_description = $this->deformat(pht(<<<EODOC
	You can disable the "To:" and "Cc:" footers in mail if users prefer smaller
	messages.
	EODOC
	));

	$email_preferences_description = $this->deformat(pht(<<<EODOC
	You can disable the email preference link in emails if users prefer smaller
	emails.
	EODOC
	));

	$re_prefix_description = $this->deformat(pht(<<<EODOC
	Mail.app on OS X Lion won't respect threading headers unless the subject is
	prefixed with "Re:". If you enable this option, Phabricator will add "Re:" to
	the subject line of all mail which is expected to thread. If you've set
	'metamta.one-mail-per-recipient', users can override this setting in their
	preferences.
	EODOC
	));

	$vary_subjects_description = $this->deformat(pht(<<<EODOC
	If true, allow MetaMTA to change mail subjects to put text like '[Accepted]' and
	'[Commented]' in them. This makes subjects more useful, but might break
	threading on some clients. If you've set '%s', users can override this setting
	in their preferences.
	EODOC
	,
	'metamta.one-mail-per-recipient'));

	$reply_to_description = $this->deformat(pht(<<<EODOC
	If you enable `%s`, Phabricator uses "From" to authenticate users. You can
	additionally enable this setting to try to authenticate with 'Reply-To'. Note
	that this is completely spoofable and insecure (any user can set any 'Reply-To'
	address) but depending on the nature of your install or other deliverability
	conditions this might be okay. Generally, you can't do much more by spoofing
	Reply-To than be annoying (you can write but not read content). But this is
	still COMPLETELY INSECURE.
	EODOC
	,
	'metamta.public-replies'));

	$adapter_description = $this->deformat(pht(<<<EODOC
	Adapter class to use to transmit mail to the MTA. The default uses
	PHPMailerLite, which will invoke "sendmail". This is appropriate if sendmail
	actually works on your host, but if you haven't configured mail it may not be so
	great. A number of other mailers are available (e.g., SES, SendGrid, SMTP,
	custom mailers). This option is deprecated in favor of 'cluster.mailers'.
	EODOC
	));

	$public_replies_description = $this->deformat(pht(<<<EODOC
	By default, Phabricator generates unique reply-to addresses and sends a separate
	email to each recipient when you enable reply handling. This is more secure than
	using "From" to establish user identity, but can mean users may receive multiple
	emails when they are on mailing lists. Instead, you can use a single, non-unique
	reply to address and authenticate users based on the "From" address by setting
	this to 'true'. This trades away a little bit of security for convenience, but
	it's reasonable in many installs. Object interactions are still protected using
	hashes in the single public email address, so objects can not be replied to
	blindly.
	EODOC
	));

	$single_description = $this->deformat(pht(<<<EODOC
	If you want to use a single mailbox for Phabricator reply mail, you can use this
	and set a common prefix for reply addresses generated by Phabricator. It will
	make use of the fact that a mail-address such as
	`phabricator+D123+1hjk213h@example.com` will be delivered to the `phabricator`
	user's mailbox. Set this to the left part of the email address and it will be
	prepended to all generated reply addresses.

	For example, if you want to use `phabricator@example.com`, this should be set
	to `phabricator`.
	EODOC
	));

	$address_description = $this->deformat(pht(<<<EODOC
	When email is sent, what format should Phabricator use for user's email
	addresses? Valid values are:

	- `short`: 'gwashington <gwashington@example.com>'
	- `real`: 'George Washington <gwashington@example.com>'
	- `full`: 'gwashington (George Washington) <gwashington@example.com>'

	The default is `full`.
	EODOC
	));

	$mailers_description = $this->deformat(pht(<<<EODOC
	Define one or more mail transmission services. For help with configuring
	mailers, see [[ %s \| %s ]] in the documentation.
	EODOC
	,
	PhabricatorEnv::getDoclink('Configuring Outbound Email'),
	pht('Configuring Outbound Email')));

	return array(
	$this->newOption('cluster.mailers', 'cluster.mailers', array())
	->setHidden(true)
	->setDescription($mailers_description),
	- $this->newOption(
	- 'metamta.default-address',
	- 'string',
	- 'noreply@phabricator.example.com')
	+ $this->newOption('metamta.default-address', 'string', null)
	->setDescription(pht('Default "From" address.')),
	$this->newOption(
	'metamta.one-mail-per-recipient',
	'bool',
	true)
	->setLocked(true)
	->setBoolOptions(
	array(
	pht('Send Mail To Each Recipient'),
	pht('Send Mail To All Recipients'),
	))
	->setSummary(
	pht(
	'Controls whether Phabricator sends one email with multiple '.
	'recipients in the "To:" line, or multiple emails, each with a '.
	'single recipient in the "To:" line.'))
	->setDescription($one_mail_per_recipient_desc),
	$this->newOption('metamta.can-send-as-user', 'bool', false)
	->setBoolOptions(
	array(
	pht('Send as User Taking Action'),
	pht('Send as Phabricator'),
	))
	->setSummary(
	pht(
	'Controls whether Phabricator sends email "From" users.'))
	->setDescription($send_as_user_desc),
	$this->newOption(
	'metamta.reply-handler-domain',
	'string',
	null)
	->setLocked(true)
	->setDescription(pht('Domain used for reply email addresses.'))
	->addExample('phabricator.example.com', ''),
	$this->newOption('metamta.recipients.show-hints', 'bool', true)
	->setBoolOptions(
	array(
	pht('Show Recipient Hints'),
	pht('No Recipient Hints'),
	))
	->setSummary(pht('Show "To:" and "Cc:" footer hints in email.'))
	->setDescription($recipient_hints_description),
	$this->newOption('metamta.email-preferences', 'bool', true)
	->setBoolOptions(
	array(
	pht('Show Email Preferences Link'),
	pht('No Email Preferences Link'),
	))
	->setSummary(pht('Show email preferences link in email.'))
	->setDescription($email_preferences_description),
	$this->newOption('metamta.public-replies', 'bool', false)
	->setBoolOptions(
	array(
	pht('Use Public Replies (Less Secure)'),
	pht('Use Private Replies (More Secure)'),
	))
	->setSummary(
	pht(
	'Phabricator can use less-secure but mailing list friendly public '.
	'reply addresses.'))
	->setDescription($public_replies_description),
	$this->newOption('metamta.single-reply-handler-prefix', 'string', null)
	->setSummary(
	pht('Allow Phabricator to use a single mailbox for all replies.'))
	->setDescription($single_description),
	$this->newOption('metamta.user-address-format', 'enum', 'full')
	->setEnumOptions(
	array(
	'short' => pht('Short'),
	'real' => pht('Real'),
	'full' => pht('Full'),
	))
	->setSummary(pht('Control how Phabricator renders user names in mail.'))
	->setDescription($address_description)
	->addExample('gwashington <gwashington@example.com>', 'short')
	->addExample('George Washington <gwashington@example.com>', 'real')
	->addExample(
	'gwashington (George Washington) <gwashington@example.com>',
	'full'),
	$this->newOption('metamta.email-body-limit', 'int', 524288)
	->setDescription(
	pht(
	'You can set a limit for the maximum byte size of outbound mail. '.
	'Mail which is larger than this limit will be truncated before '.
	'being sent. This can be useful if your MTA rejects mail which '.
	'exceeds some limit (this is reasonably common). Specify a value '.
	'in bytes.'))
	->setSummary(pht('Global cap for size of generated emails (bytes).'))
	->addExample(524288, pht('Truncate at 512KB'))
	->addExample(1048576, pht('Truncate at 1MB')),
	);
	}

	}
	diff --git a/src/applications/metamta/editor/PhabricatorMetaMTAApplicationEmailEditor.php b/src/applications/metamta/editor/PhabricatorMetaMTAApplicationEmailEditor.php
	index 2cbd164a87..8df02793f7 100644
	--- a/src/applications/metamta/editor/PhabricatorMetaMTAApplicationEmailEditor.php
	+++ b/src/applications/metamta/editor/PhabricatorMetaMTAApplicationEmailEditor.php
	@@ -1,145 +1,155 @@
	<?php

	final class PhabricatorMetaMTAApplicationEmailEditor
	extends PhabricatorApplicationTransactionEditor {

	public function getEditorApplicationClass() {
	return pht('PhabricatorMetaMTAApplication');
	}

	public function getEditorObjectsDescription() {
	return pht('Application Emails');
	}

	public function getTransactionTypes() {
	$types = parent::getTransactionTypes();

	$types[] = PhabricatorMetaMTAApplicationEmailTransaction::TYPE_ADDRESS;
	$types[] = PhabricatorMetaMTAApplicationEmailTransaction::TYPE_CONFIG;

	return $types;
	}

	protected function getCustomTransactionOldValue(
	PhabricatorLiskDAO $object,
	PhabricatorApplicationTransaction $xaction) {

	switch ($xaction->getTransactionType()) {
	case PhabricatorMetaMTAApplicationEmailTransaction::TYPE_ADDRESS:
	return $object->getAddress();
	case PhabricatorMetaMTAApplicationEmailTransaction::TYPE_CONFIG:
	$key = $xaction->getMetadataValue(
	PhabricatorMetaMTAApplicationEmailTransaction::KEY_CONFIG);
	return $object->getConfigValue($key);
	}

	return parent::getCustomTransactionOldValue($object, $xaction);
	}

	protected function getCustomTransactionNewValue(
	PhabricatorLiskDAO $object,
	PhabricatorApplicationTransaction $xaction) {

	switch ($xaction->getTransactionType()) {
	case PhabricatorMetaMTAApplicationEmailTransaction::TYPE_ADDRESS:
	case PhabricatorMetaMTAApplicationEmailTransaction::TYPE_CONFIG:
	return $xaction->getNewValue();
	}

	return parent::getCustomTransactionNewValue($object, $xaction);
	}

	protected function applyCustomInternalTransaction(
	PhabricatorLiskDAO $object,
	PhabricatorApplicationTransaction $xaction) {

	$new = $xaction->getNewValue();

	switch ($xaction->getTransactionType()) {
	case PhabricatorMetaMTAApplicationEmailTransaction::TYPE_ADDRESS:
	$object->setAddress($new);
	return;
	case PhabricatorMetaMTAApplicationEmailTransaction::TYPE_CONFIG:
	$key = $xaction->getMetadataValue(
	PhabricatorMetaMTAApplicationEmailTransaction::KEY_CONFIG);
	$object->setConfigValue($key, $new);
	return;
	}

	return parent::applyCustomInternalTransaction($object, $xaction);
	}

	protected function applyCustomExternalTransaction(
	PhabricatorLiskDAO $object,
	PhabricatorApplicationTransaction $xaction) {

	switch ($xaction->getTransactionType()) {
	case PhabricatorMetaMTAApplicationEmailTransaction::TYPE_ADDRESS:
	case PhabricatorMetaMTAApplicationEmailTransaction::TYPE_CONFIG:
	return;
	}

	return parent::applyCustomExternalTransaction($object, $xaction);
	}

	protected function validateTransaction(
	PhabricatorLiskDAO $object,
	$type,
	array $xactions) {

	$errors = parent::validateTransaction($object, $type, $xactions);

	switch ($type) {
	case PhabricatorMetaMTAApplicationEmailTransaction::TYPE_ADDRESS:
	foreach ($xactions as $xaction) {
	$email = $xaction->getNewValue();
	if (!strlen($email)) {
	// We'll deal with this below.
	continue;
	}

	if (!PhabricatorUserEmail::isValidAddress($email)) {
	$errors[] = new PhabricatorApplicationTransactionValidationError(
	$type,
	pht('Invalid'),
	pht('Email address is not formatted properly.'));
	}
	+
	+ $address = new PhutilEmailAddress($email);
	+ if (PhabricatorMailUtil::isReservedAddress($address)) {
	+ $errors[] = new PhabricatorApplicationTransactionValidationError(
	+ $type,
	+ pht('Reserved'),
	+ pht(
	+ 'This email address is reserved. Choose a different '.
	+ 'address.'));
	+ }
	}

	$missing = $this->validateIsEmptyTextField(
	$object->getAddress(),
	$xactions);

	if ($missing) {
	$error = new PhabricatorApplicationTransactionValidationError(
	$type,
	pht('Required'),
	pht('You must provide an email address.'),
	nonempty(last($xactions), null));

	$error->setIsMissingFieldError(true);
	$errors[] = $error;
	}
	break;
	}

	return $errors;
	}

	protected function didCatchDuplicateKeyException(
	PhabricatorLiskDAO $object,
	array $xactions,
	Exception $ex) {

	$errors = array();
	$errors[] = new PhabricatorApplicationTransactionValidationError(
	PhabricatorMetaMTAApplicationEmailTransaction::TYPE_ADDRESS,
	pht('Duplicate'),
	pht('This email address is already in use.'),
	null);

	throw new PhabricatorApplicationTransactionValidationException($errors);
	}


	}
	diff --git a/src/applications/metamta/receiver/__tests__/PhabricatorMailReceiverTestCase.php b/src/applications/metamta/receiver/__tests__/PhabricatorMailReceiverTestCase.php
	index 85389c3256..fb38601717 100644
	--- a/src/applications/metamta/receiver/__tests__/PhabricatorMailReceiverTestCase.php
	+++ b/src/applications/metamta/receiver/__tests__/PhabricatorMailReceiverTestCase.php
	@@ -1,44 +1,70 @@
	<?php

	final class PhabricatorMailReceiverTestCase extends PhabricatorTestCase {

	public function testAddressSimilarity() {
	$env = PhabricatorEnv::beginScopedEnv();
	$env->overrideEnvConfig('metamta.single-reply-handler-prefix', 'prefix');

	$base = 'alincoln@example.com';

	$same = array(
	'alincoln@example.com',
	'"Abrahamn Lincoln" <alincoln@example.com>',
	'ALincoln@example.com',
	'prefix+alincoln@example.com',
	);

	foreach ($same as $address) {
	$this->assertTrue(
	PhabricatorMailUtil::matchAddresses(
	new PhutilEmailAddress($base),
	new PhutilEmailAddress($address)),
	pht('Address %s', $address));
	}

	$diff = array(
	'a.lincoln@example.com',
	'aluncoln@example.com',
	'prefixalincoln@example.com',
	'badprefix+alincoln@example.com',
	'bad+prefix+alincoln@example.com',
	'prefix+alincoln+sufffix@example.com',
	);

	foreach ($diff as $address) {
	$this->assertFalse(
	PhabricatorMailUtil::matchAddresses(
	new PhutilEmailAddress($base),
	new PhutilEmailAddress($address)),
	pht('Address: %s', $address));
	}
	}

	+ public function testReservedAddresses() {
	+ $default_address = id(new PhabricatorMetaMTAMail())
	+ ->newDefaultEmailAddress();
	+
	+ $void_address = id(new PhabricatorMetaMTAMail())
	+ ->newVoidEmailAddress();
	+
	+ $map = array(
	+ 'alincoln@example.com' => false,
	+ 'sysadmin@example.com' => true,
	+ 'hostmaster@example.com' => true,
	+ '"Walter Ebmaster" <webmaster@example.com>' => true,
	+ (string)$default_address => true,
	+ (string)$void_address => true,
	+ );
	+
	+ foreach ($map as $raw_address => $expect) {
	+ $address = new PhutilEmailAddress($raw_address);
	+
	+ $this->assertEqual(
	+ $expect,
	+ PhabricatorMailUtil::isReservedAddress($address),
	+ pht('Reserved: %s', $raw_address));
	+ }
	+ }
	+
	}
	diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
	index 15c8a0945a..1117c4273d 100644
	--- a/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
	+++ b/src/applications/metamta/storage/PhabricatorMetaMTAMail.php
	@@ -1,1634 +1,1649 @@
	<?php

	/**
	* @task recipients Managing Recipients
	*/
	final class PhabricatorMetaMTAMail
	extends PhabricatorMetaMTADAO
	implements
	PhabricatorPolicyInterface,
	PhabricatorDestructibleInterface {

	const RETRY_DELAY = 5;

	protected $actorPHID;
	protected $parameters = array();
	protected $status;
	protected $message;
	protected $relatedPHID;

	private $recipientExpansionMap;
	private $routingMap;

	public function __construct() {

	$this->status = PhabricatorMailOutboundStatus::STATUS_QUEUE;
	$this->parameters = array(
	'sensitive' => true,
	'mustEncrypt' => false,
	);

	parent::__construct();
	}

	protected function getConfiguration() {
	return array(
	self::CONFIG_AUX_PHID => true,
	self::CONFIG_SERIALIZATION => array(
	'parameters' => self::SERIALIZATION_JSON,
	),
	self::CONFIG_COLUMN_SCHEMA => array(
	'actorPHID' => 'phid?',
	'status' => 'text32',
	'relatedPHID' => 'phid?',

	// T6203/NULLABILITY
	// This should just be empty if there's no body.
	'message' => 'text?',
	),
	self::CONFIG_KEY_SCHEMA => array(
	'status' => array(
	'columns' => array('status'),
	),
	'key_actorPHID' => array(
	'columns' => array('actorPHID'),
	),
	'relatedPHID' => array(
	'columns' => array('relatedPHID'),
	),
	'key_created' => array(
	'columns' => array('dateCreated'),
	),
	),
	) + parent::getConfiguration();
	}

	public function generatePHID() {
	return PhabricatorPHID::generateNewPHID(
	PhabricatorMetaMTAMailPHIDType::TYPECONST);
	}

	protected function setParam($param, $value) {
	$this->parameters[$param] = $value;
	return $this;
	}

	protected function getParam($param, $default = null) {
	// Some old mail was saved without parameters because no parameters were
	// set or encoding failed. Recover in these cases so we can perform
	// mail migrations, see T9251.
	if (!is_array($this->parameters)) {
	$this->parameters = array();
	}

	return idx($this->parameters, $param, $default);
	}

	/**
	* These tags are used to allow users to opt out of receiving certain types
	* of mail, like updates when a task's projects change.
	*
	* @param list<const>
	* @return this
	*/
	public function setMailTags(array $tags) {
	$this->setParam('mailtags', array_unique($tags));
	return $this;
	}

	public function getMailTags() {
	return $this->getParam('mailtags', array());
	}

	/**
	* In Gmail, conversations will be broken if you reply to a thread and the
	* server sends back a response without referencing your Message-ID, even if
	* it references a Message-ID earlier in the thread. To avoid this, use the
	* parent email's message ID explicitly if it's available. This overwrites the
	* "In-Reply-To" and "References" headers we would otherwise generate. This
	* needs to be set whenever an action is triggered by an email message. See
	* T251 for more details.
	*
	* @param string The "Message-ID" of the email which precedes this one.
	* @return this
	*/
	public function setParentMessageID($id) {
	$this->setParam('parent-message-id', $id);
	return $this;
	}

	public function getParentMessageID() {
	return $this->getParam('parent-message-id');
	}

	public function getSubject() {
	return $this->getParam('subject');
	}

	public function addTos(array $phids) {
	$phids = array_unique($phids);
	$this->setParam('to', $phids);
	return $this;
	}

	public function addRawTos(array $raw_email) {

	// Strip addresses down to bare emails, since the MailAdapter API currently
	// requires we pass it just the address (like `alincoln@logcabin.org`), not
	// a full string like `"Abraham Lincoln" <alincoln@logcabin.org>`.
	foreach ($raw_email as $key => $email) {
	$object = new PhutilEmailAddress($email);
	$raw_email[$key] = $object->getAddress();
	}

	$this->setParam('raw-to', $raw_email);
	return $this;
	}

	public function addCCs(array $phids) {
	$phids = array_unique($phids);
	$this->setParam('cc', $phids);
	return $this;
	}

	public function setExcludeMailRecipientPHIDs(array $exclude) {
	$this->setParam('exclude', $exclude);
	return $this;
	}

	private function getExcludeMailRecipientPHIDs() {
	return $this->getParam('exclude', array());
	}

	public function setMutedPHIDs(array $muted) {
	$this->setParam('muted', $muted);
	return $this;
	}

	private function getMutedPHIDs() {
	return $this->getParam('muted', array());
	}

	public function setForceHeraldMailRecipientPHIDs(array $force) {
	$this->setParam('herald-force-recipients', $force);
	return $this;
	}

	private function getForceHeraldMailRecipientPHIDs() {
	return $this->getParam('herald-force-recipients', array());
	}

	public function addPHIDHeaders($name, array $phids) {
	$phids = array_unique($phids);
	foreach ($phids as $phid) {
	$this->addHeader($name, '<'.$phid.'>');
	}
	return $this;
	}

	public function addHeader($name, $value) {
	$this->parameters['headers'][] = array($name, $value);
	return $this;
	}

	public function addAttachment(PhabricatorMailAttachment $attachment) {
	$this->parameters['attachments'][] = $attachment->toDictionary();
	return $this;
	}

	public function getAttachments() {
	$dicts = $this->getParam('attachments');

	$result = array();
	foreach ($dicts as $dict) {
	$result[] = PhabricatorMailAttachment::newFromDictionary($dict);
	}
	return $result;
	}

	public function getAttachmentFilePHIDs() {
	$file_phids = array();

	$dictionaries = $this->getParam('attachments');
	if ($dictionaries) {
	foreach ($dictionaries as $dictionary) {
	$file_phid = idx($dictionary, 'filePHID');
	if ($file_phid) {
	$file_phids[] = $file_phid;
	}
	}
	}

	return $file_phids;
	}

	public function loadAttachedFiles(PhabricatorUser $viewer) {
	$file_phids = $this->getAttachmentFilePHIDs();

	if (!$file_phids) {
	return array();
	}

	return id(new PhabricatorFileQuery())
	->setViewer($viewer)
	->withPHIDs($file_phids)
	->execute();
	}

	public function setAttachments(array $attachments) {
	assert_instances_of($attachments, 'PhabricatorMailAttachment');
	$this->setParam('attachments', mpull($attachments, 'toDictionary'));
	return $this;
	}

	public function setFrom($from) {
	$this->setParam('from', $from);
	$this->setActorPHID($from);
	return $this;
	}

	public function getFrom() {
	return $this->getParam('from');
	}

	public function setRawFrom($raw_email, $raw_name) {
	$this->setParam('raw-from', array($raw_email, $raw_name));
	return $this;
	}

	public function setReplyTo($reply_to) {
	$this->setParam('reply-to', $reply_to);
	return $this;
	}

	public function setSubject($subject) {
	$this->setParam('subject', $subject);
	return $this;
	}

	public function setSubjectPrefix($prefix) {
	$this->setParam('subject-prefix', $prefix);
	return $this;
	}

	public function setVarySubjectPrefix($prefix) {
	$this->setParam('vary-subject-prefix', $prefix);
	return $this;
	}

	public function setBody($body) {
	$this->setParam('body', $body);
	return $this;
	}

	public function setSensitiveContent($bool) {
	$this->setParam('sensitive', $bool);
	return $this;
	}

	public function hasSensitiveContent() {
	return $this->getParam('sensitive', true);
	}

	public function setMustEncrypt($bool) {
	return $this->setParam('mustEncrypt', $bool);
	}

	public function getMustEncrypt() {
	return $this->getParam('mustEncrypt', false);
	}

	public function setMustEncryptURI($uri) {
	return $this->setParam('mustEncrypt.uri', $uri);
	}

	public function getMustEncryptURI() {
	return $this->getParam('mustEncrypt.uri');
	}

	public function setMustEncryptSubject($subject) {
	return $this->setParam('mustEncrypt.subject', $subject);
	}

	public function getMustEncryptSubject() {
	return $this->getParam('mustEncrypt.subject');
	}

	public function setMustEncryptReasons(array $reasons) {
	return $this->setParam('mustEncryptReasons', $reasons);
	}

	public function getMustEncryptReasons() {
	return $this->getParam('mustEncryptReasons', array());
	}

	public function setMailStamps(array $stamps) {
	return $this->setParam('stamps', $stamps);
	}

	public function getMailStamps() {
	return $this->getParam('stamps', array());
	}

	public function setMailStampMetadata($metadata) {
	return $this->setParam('stampMetadata', $metadata);
	}

	public function getMailStampMetadata() {
	return $this->getParam('stampMetadata', array());
	}

	public function getMailerKey() {
	return $this->getParam('mailer.key');
	}

	public function setTryMailers(array $mailers) {
	return $this->setParam('mailers.try', $mailers);
	}

	public function setHTMLBody($html) {
	$this->setParam('html-body', $html);
	return $this;
	}

	public function getBody() {
	return $this->getParam('body');
	}

	public function getHTMLBody() {
	return $this->getParam('html-body');
	}

	public function setIsErrorEmail($is_error) {
	$this->setParam('is-error', $is_error);
	return $this;
	}

	public function getIsErrorEmail() {
	return $this->getParam('is-error', false);
	}

	public function getToPHIDs() {
	return $this->getParam('to', array());
	}

	public function getRawToAddresses() {
	return $this->getParam('raw-to', array());
	}

	public function getCcPHIDs() {
	return $this->getParam('cc', array());
	}

	/**
	* Force delivery of a message, even if recipients have preferences which
	* would otherwise drop the message.
	*
	* This is primarily intended to let users who don't want any email still
	* receive things like password resets.
	*
	* @param bool True to force delivery despite user preferences.
	* @return this
	*/
	public function setForceDelivery($force) {
	$this->setParam('force', $force);
	return $this;
	}

	public function getForceDelivery() {
	return $this->getParam('force', false);
	}

	/**
	* Flag that this is an auto-generated bulk message and should have bulk
	* headers added to it if appropriate. Broadly, this means some flavor of
	* "Precedence: bulk" or similar, but is implementation and configuration
	* dependent.
	*
	* @param bool True if the mail is automated bulk mail.
	* @return this
	*/
	public function setIsBulk($is_bulk) {
	$this->setParam('is-bulk', $is_bulk);
	return $this;
	}

	/**
	* Use this method to set an ID used for message threading. MetaMTA will
	* set appropriate headers (Message-ID, In-Reply-To, References and
	* Thread-Index) based on the capabilities of the underlying mailer.
	*
	* @param string Unique identifier, appropriate for use in a Message-ID,
	* In-Reply-To or References headers.
	* @param bool If true, indicates this is the first message in the thread.
	* @return this
	*/
	public function setThreadID($thread_id, $is_first_message = false) {
	$this->setParam('thread-id', $thread_id);
	$this->setParam('is-first-message', $is_first_message);
	return $this;
	}

	/**
	* Save a newly created mail to the database. The mail will eventually be
	* delivered by the MetaMTA daemon.
	*
	* @return this
	*/
	public function saveAndSend() {
	return $this->save();
	}

	/**
	* @return this
	*/
	public function save() {
	if ($this->getID()) {
	return parent::save();
	}

	// NOTE: When mail is sent from CLI scripts that run tasks in-process, we
	// may re-enter this method from within scheduleTask(). The implementation
	// is intended to avoid anything awkward if we end up reentering this
	// method.

	$this->openTransaction();
	// Save to generate a mail ID and PHID.
	$result = parent::save();

	// Write the recipient edges.
	$editor = new PhabricatorEdgeEditor();
	$edge_type = PhabricatorMetaMTAMailHasRecipientEdgeType::EDGECONST;
	$recipient_phids = array_merge(
	$this->getToPHIDs(),
	$this->getCcPHIDs());
	$expanded_phids = $this->expandRecipients($recipient_phids);
	$all_phids = array_unique(array_merge(
	$recipient_phids,
	$expanded_phids));
	foreach ($all_phids as $curr_phid) {
	$editor->addEdge($this->getPHID(), $edge_type, $curr_phid);
	}
	$editor->save();

	$this->saveTransaction();

	// Queue a task to send this mail.
	$mailer_task = PhabricatorWorker::scheduleTask(
	'PhabricatorMetaMTAWorker',
	$this->getID(),
	array(
	'priority' => PhabricatorWorker::PRIORITY_ALERTS,
	));

	return $result;
	}

	/**
	* Attempt to deliver an email immediately, in this process.
	*
	* @return void
	*/
	public function sendNow() {
	if ($this->getStatus() != PhabricatorMailOutboundStatus::STATUS_QUEUE) {
	throw new Exception(pht('Trying to send an already-sent mail!'));
	}

	$mailers = self::newMailers(
	array(
	'outbound' => true,
	));

	$try_mailers = $this->getParam('mailers.try');
	if ($try_mailers) {
	$mailers = mpull($mailers, null, 'getKey');
	$mailers = array_select_keys($mailers, $try_mailers);
	}

	return $this->sendWithMailers($mailers);
	}

	public static function newMailers(array $constraints) {
	PhutilTypeSpec::checkMap(
	$constraints,
	array(
	'types' => 'optional list<string>',
	'inbound' => 'optional bool',
	'outbound' => 'optional bool',
	));

	$mailers = array();

	$config = PhabricatorEnv::getEnvConfig('cluster.mailers');

	$adapters = PhabricatorMailImplementationAdapter::getAllAdapters();
	$next_priority = -1;

	foreach ($config as $spec) {
	$type = $spec['type'];
	if (!isset($adapters[$type])) {
	throw new Exception(
	pht(
	'Unknown mailer ("%s")!',
	$type));
	}

	$key = $spec['key'];
	$mailer = id(clone $adapters[$type])
	->setKey($key);

	$priority = idx($spec, 'priority');
	if (!$priority) {
	$priority = $next_priority;
	$next_priority--;
	}
	$mailer->setPriority($priority);

	$defaults = $mailer->newDefaultOptions();
	$options = idx($spec, 'options', array()) + $defaults;
	$mailer->setOptions($options);

	$mailer->setSupportsInbound(idx($spec, 'inbound', true));
	$mailer->setSupportsOutbound(idx($spec, 'outbound', true));

	$mailers[] = $mailer;
	}

	// Remove mailers with the wrong types.
	if (isset($constraints['types'])) {
	$types = $constraints['types'];
	$types = array_fuse($types);
	foreach ($mailers as $key => $mailer) {
	$mailer_type = $mailer->getAdapterType();
	if (!isset($types[$mailer_type])) {
	unset($mailers[$key]);
	}
	}
	}

	// If we're only looking for inbound mailers, remove mailers with inbound
	// support disabled.
	if (!empty($constraints['inbound'])) {
	foreach ($mailers as $key => $mailer) {
	if (!$mailer->getSupportsInbound()) {
	unset($mailers[$key]);
	}
	}
	}

	// If we're only looking for outbound mailers, remove mailers with outbound
	// support disabled.
	if (!empty($constraints['outbound'])) {
	foreach ($mailers as $key => $mailer) {
	if (!$mailer->getSupportsOutbound()) {
	unset($mailers[$key]);
	}
	}
	}

	$sorted = array();
	$groups = mgroup($mailers, 'getPriority');
	krsort($groups);
	foreach ($groups as $group) {
	// Reorder services within the same priority group randomly.
	shuffle($group);
	foreach ($group as $mailer) {
	$sorted[] = $mailer;
	}
	}

	foreach ($sorted as $mailer) {
	$mailer->prepareForSend();
	}

	return $sorted;
	}

	public function sendWithMailers(array $mailers) {
	if (!$mailers) {
	$any_mailers = self::newMailers(array());

	// NOTE: We can end up here with some custom list of "$mailers", like
	// from a unit test. In that case, this message could be misleading. We
	// can't really tell if the caller made up the list, so just assume they
	// aren't tricking us.

	if ($any_mailers) {
	$void_message = pht(
	'No configured mailers support sending outbound mail.');
	} else {
	$void_message = pht(
	'No mailers are configured.');
	}

	return $this
	->setStatus(PhabricatorMailOutboundStatus::STATUS_VOID)
	->setMessage($void_message)
	->save();
	}

	$exceptions = array();
	foreach ($mailers as $template_mailer) {
	$mailer = null;

	try {
	$mailer = $this->buildMailer($template_mailer);
	} catch (Exception $ex) {
	$exceptions[] = $ex;
	continue;
	}

	if (!$mailer) {
	// If we don't get a mailer back, that means the mail doesn't
	// actually need to be sent (for example, because recipients have
	// declined to receive the mail). Void it and return.
	return $this
	->setStatus(PhabricatorMailOutboundStatus::STATUS_VOID)
	->save();
	}

	try {
	$ok = $mailer->send();
	if (!$ok) {
	// TODO: At some point, we should clean this up and make all mailers
	// throw.
	throw new Exception(
	pht(
	'Mail adapter encountered an unexpected, unspecified '.
	'failure.'));
	}
	} catch (PhabricatorMetaMTAPermanentFailureException $ex) {
	// If any mailer raises a permanent failure, stop trying to send the
	// mail with other mailers.
	$this
	->setStatus(PhabricatorMailOutboundStatus::STATUS_FAIL)
	->setMessage($ex->getMessage())
	->save();

	throw $ex;
	} catch (Exception $ex) {
	$exceptions[] = $ex;
	continue;
	}

	// Keep track of which mailer actually ended up accepting the message.
	$mailer_key = $mailer->getKey();
	if ($mailer_key !== null) {
	$this->setParam('mailer.key', $mailer_key);
	}

	return $this
	->setStatus(PhabricatorMailOutboundStatus::STATUS_SENT)
	->save();
	}

	// If we make it here, no mailer could send the mail but no mailer failed
	// permanently either. We update the error message for the mail, but leave
	// it in the current status (usually, STATUS_QUEUE) and try again later.

	$messages = array();
	foreach ($exceptions as $ex) {
	$messages[] = $ex->getMessage();
	}
	$messages = implode("\n\n", $messages);

	$this
	->setMessage($messages)
	->save();

	if (count($exceptions) === 1) {
	throw head($exceptions);
	}

	throw new PhutilAggregateException(
	pht('Encountered multiple exceptions while transmitting mail.'),
	$exceptions);
	}

	private function buildMailer(PhabricatorMailImplementationAdapter $mailer) {
	$headers = $this->generateHeaders();

	$params = $this->parameters;

	$actors = $this->loadAllActors();
	$deliverable_actors = $this->filterDeliverableActors($actors);

	- $default_from = PhabricatorEnv::getEnvConfig('metamta.default-address');
	+ $default_from = (string)$this->newDefaultEmailAddress();
	if (empty($params['from'])) {
	$mailer->setFrom($default_from);
	}

	$is_first = idx($params, 'is-first-message');
	unset($params['is-first-message']);

	$is_threaded = (bool)idx($params, 'thread-id');
	$must_encrypt = $this->getMustEncrypt();

	$reply_to_name = idx($params, 'reply-to-name', '');
	unset($params['reply-to-name']);

	$add_cc = array();
	$add_to = array();

	// If we're sending one mail to everyone, some recipients will be in
	// "Cc" rather than "To". We'll move them to "To" later (or supply a
	// dummy "To") but need to look for the recipient in either the
	// "To" or "Cc" fields here.
	$target_phid = head(idx($params, 'to', array()));
	if (!$target_phid) {
	$target_phid = head(idx($params, 'cc', array()));
	}

	$preferences = $this->loadPreferences($target_phid);

	foreach ($params as $key => $value) {
	switch ($key) {
	case 'raw-from':
	list($from_email, $from_name) = $value;
	$mailer->setFrom($from_email, $from_name);
	break;
	case 'from':
	// If the mail content must be encrypted, disguise the sender.
	if ($must_encrypt) {
	$mailer->setFrom($default_from, pht('Phabricator'));
	break;
	}

	$from = $value;
	$actor_email = null;
	$actor_name = null;
	$actor = idx($actors, $from);
	if ($actor) {
	$actor_email = $actor->getEmailAddress();
	$actor_name = $actor->getName();
	}
	$can_send_as_user = $actor_email &&
	PhabricatorEnv::getEnvConfig('metamta.can-send-as-user');

	if ($can_send_as_user) {
	$mailer->setFrom($actor_email, $actor_name);
	} else {
	$from_email = coalesce($actor_email, $default_from);
	$from_name = coalesce($actor_name, pht('Phabricator'));

	if (empty($params['reply-to'])) {
	$params['reply-to'] = $from_email;
	$params['reply-to-name'] = $from_name;
	}

	$mailer->setFrom($default_from, $from_name);
	}
	break;
	case 'reply-to':
	$mailer->addReplyTo($value, $reply_to_name);
	break;
	case 'to':
	$to_phids = $this->expandRecipients($value);
	$to_actors = array_select_keys($deliverable_actors, $to_phids);
	$add_to = array_merge(
	$add_to,
	mpull($to_actors, 'getEmailAddress'));
	break;
	case 'raw-to':
	$add_to = array_merge($add_to, $value);
	break;
	case 'cc':
	$cc_phids = $this->expandRecipients($value);
	$cc_actors = array_select_keys($deliverable_actors, $cc_phids);
	$add_cc = array_merge(
	$add_cc,
	mpull($cc_actors, 'getEmailAddress'));
	break;
	case 'attachments':
	$attached_viewer = PhabricatorUser::getOmnipotentUser();
	$files = $this->loadAttachedFiles($attached_viewer);
	foreach ($files as $file) {
	$file->attachToObject($this->getPHID());
	}

	// If the mail content must be encrypted, don't add attachments.
	if ($must_encrypt) {
	break;
	}

	$value = $this->getAttachments();
	foreach ($value as $attachment) {
	$mailer->addAttachment(
	$attachment->getData(),
	$attachment->getFilename(),
	$attachment->getMimeType());
	}
	break;
	case 'subject':
	$subject = array();

	if ($is_threaded) {
	if ($this->shouldAddRePrefix($preferences)) {
	$subject[] = 'Re:';
	}
	}

	$subject[] = trim(idx($params, 'subject-prefix'));

	// If mail content must be encrypted, we replace the subject with
	// a generic one.
	if ($must_encrypt) {
	$encrypt_subject = $this->getMustEncryptSubject();
	if (!strlen($encrypt_subject)) {
	$encrypt_subject = pht('Object Updated');
	}
	$subject[] = $encrypt_subject;
	} else {
	$vary_prefix = idx($params, 'vary-subject-prefix');
	if ($vary_prefix != '') {
	if ($this->shouldVarySubject($preferences)) {
	$subject[] = $vary_prefix;
	}
	}

	$subject[] = $value;
	}

	$mailer->setSubject(implode(' ', array_filter($subject)));
	break;
	case 'thread-id':

	// NOTE: Gmail freaks out about In-Reply-To and References which
	// aren't in the form "<string@domain.tld>"; this is also required
	// by RFC 2822, although some clients are more liberal in what they
	// accept.
	$domain = $this->newMailDomain();
	$value = '<'.$value.'@'.$domain.'>';

	if ($is_first && $mailer->supportsMessageIDHeader()) {
	$headers[] = array('Message-ID', $value);
	} else {
	$in_reply_to = $value;
	$references = array($value);
	$parent_id = $this->getParentMessageID();
	if ($parent_id) {
	$in_reply_to = $parent_id;
	// By RFC 2822, the most immediate parent should appear last
	// in the "References" header, so this order is intentional.
	$references[] = $parent_id;
	}
	$references = implode(' ', $references);
	$headers[] = array('In-Reply-To', $in_reply_to);
	$headers[] = array('References', $references);
	}
	$thread_index = $this->generateThreadIndex($value, $is_first);
	$headers[] = array('Thread-Index', $thread_index);
	break;
	default:
	// Other parameters are handled elsewhere or are not relevant to
	// constructing the message.
	break;
	}
	}

	$stamps = $this->getMailStamps();
	if ($stamps) {
	$headers[] = array('X-Phabricator-Stamps', implode(' ', $stamps));
	}

	$raw_body = idx($params, 'body', '');
	$body = $raw_body;
	if ($must_encrypt) {
	$parts = array();

	$encrypt_uri = $this->getMustEncryptURI();
	if (!strlen($encrypt_uri)) {
	$encrypt_phid = $this->getRelatedPHID();
	if ($encrypt_phid) {
	$encrypt_uri = urisprintf(
	'/object/%s/',
	$encrypt_phid);
	}
	}

	if (strlen($encrypt_uri)) {
	$parts[] = pht(
	'This secure message is notifying you of a change to this object:');
	$parts[] = PhabricatorEnv::getProductionURI($encrypt_uri);
	}

	$parts[] = pht(
	'The content for this message can only be transmitted over a '.
	'secure channel. To view the message content, follow this '.
	'link:');

	$parts[] = PhabricatorEnv::getProductionURI($this->getURI());

	$body = implode("\n\n", $parts);
	} else {
	$body = $raw_body;
	}

	$body_limit = PhabricatorEnv::getEnvConfig('metamta.email-body-limit');
	if (strlen($body) > $body_limit) {
	$body = id(new PhutilUTF8StringTruncator())
	->setMaximumBytes($body_limit)
	->truncateString($body);
	$body .= "\n";
	$body .= pht('(This email was truncated at %d bytes.)', $body_limit);
	}
	$mailer->setBody($body);
	$body_limit -= strlen($body);

	// If we sent a different message body than we were asked to, record
	// what we actually sent to make debugging and diagnostics easier.
	if ($body !== $raw_body) {
	$this->setParam('body.sent', $body);
	}

	if ($must_encrypt) {
	$send_html = false;
	} else {
	$send_html = $this->shouldSendHTML($preferences);
	}

	if ($send_html) {
	$html_body = idx($params, 'html-body');
	if (strlen($html_body)) {
	// NOTE: We just drop the entire HTML body if it won't fit. Safely
	// truncating HTML is hard, and we already have the text body to fall
	// back to.
	if (strlen($html_body) <= $body_limit) {
	$mailer->setHTMLBody($html_body);
	$body_limit -= strlen($html_body);
	}
	}
	}

	// Pass the headers to the mailer, then save the state so we can show
	// them in the web UI. If the mail must be encrypted, we remove headers
	// which are not on a strict whitelist to avoid disclosing information.
	$filtered_headers = $this->filterHeaders($headers, $must_encrypt);
	foreach ($filtered_headers as $header) {
	list($header_key, $header_value) = $header;
	$mailer->addHeader($header_key, $header_value);
	}
	$this->setParam('headers.unfiltered', $headers);
	$this->setParam('headers.sent', $filtered_headers);

	// Save the final deliverability outcomes and reasoning so we can
	// explain why things happened the way they did.
	$actor_list = array();
	foreach ($actors as $actor) {
	$actor_list[$actor->getPHID()] = array(
	'deliverable' => $actor->isDeliverable(),
	'reasons' => $actor->getDeliverabilityReasons(),
	);
	}
	$this->setParam('actors.sent', $actor_list);

	$this->setParam('routing.sent', $this->getParam('routing'));
	$this->setParam('routingmap.sent', $this->getRoutingRuleMap());

	if (!$add_to && !$add_cc) {
	$this->setMessage(
	pht(
	'Message has no valid recipients: all To/Cc are disabled, '.
	'invalid, or configured not to receive this mail.'));

	return null;
	}

	if ($this->getIsErrorEmail()) {
	$all_recipients = array_merge($add_to, $add_cc);
	if ($this->shouldRateLimitMail($all_recipients)) {
	$this->setMessage(
	pht(
	'This is an error email, but one or more recipients have '.
	'exceeded the error email rate limit. Declining to deliver '.
	'message.'));

	return null;
	}
	}

	if (PhabricatorEnv::getEnvConfig('phabricator.silent')) {
	$this->setMessage(
	pht(
	'Phabricator is running in silent mode. See `%s` '.
	'in the configuration to change this setting.',
	'phabricator.silent'));

	return null;
	}

	// Some mailers require a valid "To:" in order to deliver mail. If we don't
	// have any "To:", fill it in with a placeholder "To:". This allows client
	// rules based on whether the recipient is in "To:" or "CC:" to continue
	// behaving in the same way.
	if (!$add_to) {
	$void_recipient = $this->newVoidEmailAddress();
	$add_to = array($void_recipient->getAddress());
	}

	$add_to = array_unique($add_to);
	$add_cc = array_diff(array_unique($add_cc), $add_to);

	$mailer->addTos($add_to);
	if ($add_cc) {
	$mailer->addCCs($add_cc);
	}

	return $mailer;
	}

	private function generateThreadIndex($seed, $is_first_mail) {
	// When threading, Outlook ignores the 'References' and 'In-Reply-To'
	// headers that most clients use. Instead, it uses a custom 'Thread-Index'
	// header. The format of this header is something like this (from
	// camel-exchange-folder.c in Evolution Exchange):

	/* A new post to a folder gets a 27-byte-long thread index. (The value
	* is apparently unique but meaningless.) Each reply to a post gets a
	* 32-byte-long thread index whose first 27 bytes are the same as the
	* parent's thread index. Each reply to any of those gets a
	* 37-byte-long thread index, etc. The Thread-Index header contains a
	* base64 representation of this value.
	*/

	// The specific implementation uses a 27-byte header for the first email
	// a recipient receives, and a random 5-byte suffix (32 bytes total)
	// thereafter. This means that all the replies are (incorrectly) siblings,
	// but it would be very difficult to keep track of the entire tree and this
	// gets us reasonable client behavior.

	$base = substr(md5($seed), 0, 27);
	if (!$is_first_mail) {
	// Not totally sure, but it seems like outlook orders replies by
	// thread-index rather than timestamp, so to get these to show up in the
	// right order we use the time as the last 4 bytes.
	$base .= ' '.pack('N', time());
	}

	return base64_encode($base);
	}

	public static function shouldMailEachRecipient() {
	return PhabricatorEnv::getEnvConfig('metamta.one-mail-per-recipient');
	}


	/* -( Managing Recipients )------------------------------------------------ */


	/**
	* Get all of the recipients for this mail, after preference filters are
	* applied. This list has all objects to whom delivery will be attempted.
	*
	* Note that this expands recipients into their members, because delivery
	* is never directly attempted to aggregate actors like projects.
	*
	* @return list<phid> A list of all recipients to whom delivery will be
	* attempted.
	* @task recipients
	*/
	public function buildRecipientList() {
	$actors = $this->loadAllActors();
	$actors = $this->filterDeliverableActors($actors);
	return mpull($actors, 'getPHID');
	}

	public function loadAllActors() {
	$actor_phids = $this->getExpandedRecipientPHIDs();
	return $this->loadActors($actor_phids);
	}

	public function getExpandedRecipientPHIDs() {
	$actor_phids = $this->getAllActorPHIDs();
	return $this->expandRecipients($actor_phids);
	}

	private function getAllActorPHIDs() {
	return array_merge(
	array($this->getParam('from')),
	$this->getToPHIDs(),
	$this->getCcPHIDs());
	}

	/**
	* Expand a list of recipient PHIDs (possibly including aggregate recipients
	* like projects) into a deaggregated list of individual recipient PHIDs.
	* For example, this will expand project PHIDs into a list of the project's
	* members.
	*
	* @param list<phid> List of recipient PHIDs, possibly including aggregate
	* recipients.
	* @return list<phid> Deaggregated list of mailable recipients.
	*/
	private function expandRecipients(array $phids) {
	if ($this->recipientExpansionMap === null) {
	$all_phids = $this->getAllActorPHIDs();
	$this->recipientExpansionMap = id(new PhabricatorMetaMTAMemberQuery())
	->setViewer(PhabricatorUser::getOmnipotentUser())
	->withPHIDs($all_phids)
	->execute();
	}

	$results = array();
	foreach ($phids as $phid) {
	foreach ($this->recipientExpansionMap[$phid] as $recipient_phid) {
	$results[$recipient_phid] = $recipient_phid;
	}
	}

	return array_keys($results);
	}

	private function filterDeliverableActors(array $actors) {
	assert_instances_of($actors, 'PhabricatorMetaMTAActor');
	$deliverable_actors = array();
	foreach ($actors as $phid => $actor) {
	if ($actor->isDeliverable()) {
	$deliverable_actors[$phid] = $actor;
	}
	}
	return $deliverable_actors;
	}

	private function loadActors(array $actor_phids) {
	$actor_phids = array_filter($actor_phids);
	$viewer = PhabricatorUser::getOmnipotentUser();

	$actors = id(new PhabricatorMetaMTAActorQuery())
	->setViewer($viewer)
	->withPHIDs($actor_phids)
	->execute();

	if (!$actors) {
	return array();
	}

	if ($this->getForceDelivery()) {
	// If we're forcing delivery, skip all the opt-out checks. We don't
	// bother annotating reasoning on the mail in this case because it should
	// always be obvious why the mail hit this rule (e.g., it is a password
	// reset mail).
	foreach ($actors as $actor) {
	$actor->setDeliverable(PhabricatorMetaMTAActor::REASON_FORCE);
	}
	return $actors;
	}

	// Exclude explicit recipients.
	foreach ($this->getExcludeMailRecipientPHIDs() as $phid) {
	$actor = idx($actors, $phid);
	if (!$actor) {
	continue;
	}
	$actor->setUndeliverable(PhabricatorMetaMTAActor::REASON_RESPONSE);
	}

	// Before running more rules, save a list of the actors who were
	// deliverable before we started running preference-based rules. This stops
	// us from trying to send mail to disabled users just because a Herald rule
	// added them, for example.
	$deliverable = array();
	foreach ($actors as $phid => $actor) {
	if ($actor->isDeliverable()) {
	$deliverable[] = $phid;
	}
	}

	// Exclude muted recipients. We're doing this after saving deliverability
	// so that Herald "Send me an email" actions can still punch through a
	// mute.

	foreach ($this->getMutedPHIDs() as $muted_phid) {
	$muted_actor = idx($actors, $muted_phid);
	if (!$muted_actor) {
	continue;
	}
	$muted_actor->setUndeliverable(PhabricatorMetaMTAActor::REASON_MUTED);
	}

	// For the rest of the rules, order matters. We're going to run all the
	// possible rules in order from weakest to strongest, and let the strongest
	// matching rule win. The weaker rules leave annotations behind which help
	// users understand why the mail was routed the way it was.

	// Exclude the actor if their preferences are set.
	$from_phid = $this->getParam('from');
	$from_actor = idx($actors, $from_phid);
	if ($from_actor) {
	$from_user = id(new PhabricatorPeopleQuery())
	->setViewer($viewer)
	->withPHIDs(array($from_phid))
	->needUserSettings(true)
	->execute();
	$from_user = head($from_user);
	if ($from_user) {
	$pref_key = PhabricatorEmailSelfActionsSetting::SETTINGKEY;
	$exclude_self = $from_user->getUserSetting($pref_key);
	if ($exclude_self) {
	$from_actor->setUndeliverable(PhabricatorMetaMTAActor::REASON_SELF);
	}
	}
	}

	$all_prefs = id(new PhabricatorUserPreferencesQuery())
	->setViewer(PhabricatorUser::getOmnipotentUser())
	->withUserPHIDs($actor_phids)
	->needSyntheticPreferences(true)
	->execute();
	$all_prefs = mpull($all_prefs, null, 'getUserPHID');

	$value_email = PhabricatorEmailTagsSetting::VALUE_EMAIL;

	// Exclude all recipients who have set preferences to not receive this type
	// of email (for example, a user who says they don't want emails about task
	// CC changes).
	$tags = $this->getParam('mailtags');
	if ($tags) {
	foreach ($all_prefs as $phid => $prefs) {
	$user_mailtags = $prefs->getSettingValue(
	PhabricatorEmailTagsSetting::SETTINGKEY);

	// The user must have elected to receive mail for at least one
	// of the mailtags.
	$send = false;
	foreach ($tags as $tag) {
	if (((int)idx($user_mailtags, $tag, $value_email)) == $value_email) {
	$send = true;
	break;
	}
	}

	if (!$send) {
	$actors[$phid]->setUndeliverable(
	PhabricatorMetaMTAActor::REASON_MAILTAGS);
	}
	}
	}

	foreach ($deliverable as $phid) {
	switch ($this->getRoutingRule($phid)) {
	case PhabricatorMailRoutingRule::ROUTE_AS_NOTIFICATION:
	$actors[$phid]->setUndeliverable(
	PhabricatorMetaMTAActor::REASON_ROUTE_AS_NOTIFICATION);
	break;
	case PhabricatorMailRoutingRule::ROUTE_AS_MAIL:
	$actors[$phid]->setDeliverable(
	PhabricatorMetaMTAActor::REASON_ROUTE_AS_MAIL);
	break;
	default:
	// No change.
	break;
	}
	}

	// If recipients were initially deliverable and were added by "Send me an
	// email" Herald rules, annotate them as such and make them deliverable
	// again, overriding any changes made by the "self mail" and "mail tags"
	// settings.
	$force_recipients = $this->getForceHeraldMailRecipientPHIDs();
	$force_recipients = array_fuse($force_recipients);
	if ($force_recipients) {
	foreach ($deliverable as $phid) {
	if (isset($force_recipients[$phid])) {
	$actors[$phid]->setDeliverable(
	PhabricatorMetaMTAActor::REASON_FORCE_HERALD);
	}
	}
	}

	// Exclude recipients who don't want any mail. This rule is very strong
	// and runs last.
	foreach ($all_prefs as $phid => $prefs) {
	$exclude = $prefs->getSettingValue(
	PhabricatorEmailNotificationsSetting::SETTINGKEY);
	if ($exclude) {
	$actors[$phid]->setUndeliverable(
	PhabricatorMetaMTAActor::REASON_MAIL_DISABLED);
	}
	}

	// Unless delivery was forced earlier (password resets, confirmation mail),
	// never send mail to unverified addresses.
	foreach ($actors as $phid => $actor) {
	if ($actor->getIsVerified()) {
	continue;
	}

	$actor->setUndeliverable(PhabricatorMetaMTAActor::REASON_UNVERIFIED);
	}

	return $actors;
	}

	private function shouldRateLimitMail(array $all_recipients) {
	try {
	PhabricatorSystemActionEngine::willTakeAction(
	$all_recipients,
	new PhabricatorMetaMTAErrorMailAction(),
	1);
	return false;
	} catch (PhabricatorSystemActionRateLimitException $ex) {
	return true;
	}
	}

	public function generateHeaders() {
	$headers = array();

	$headers[] = array('X-Phabricator-Sent-This-Message', 'Yes');
	$headers[] = array('X-Mail-Transport-Agent', 'MetaMTA');

	// Some clients respect this to suppress OOF and other auto-responses.
	$headers[] = array('X-Auto-Response-Suppress', 'All');

	$mailtags = $this->getParam('mailtags');
	if ($mailtags) {
	$tag_header = array();
	foreach ($mailtags as $mailtag) {
	$tag_header[] = '<'.$mailtag.'>';
	}
	$tag_header = implode(', ', $tag_header);
	$headers[] = array('X-Phabricator-Mail-Tags', $tag_header);
	}

	$value = $this->getParam('headers', array());
	foreach ($value as $pair) {
	list($header_key, $header_value) = $pair;

	// NOTE: If we have \n in a header, SES rejects the email.
	$header_value = str_replace("\n", ' ', $header_value);
	$headers[] = array($header_key, $header_value);
	}

	$is_bulk = $this->getParam('is-bulk');
	if ($is_bulk) {
	$headers[] = array('Precedence', 'bulk');
	}

	if ($this->getMustEncrypt()) {
	$headers[] = array('X-Phabricator-Must-Encrypt', 'Yes');
	}

	$related_phid = $this->getRelatedPHID();
	if ($related_phid) {
	$headers[] = array('Thread-Topic', $related_phid);
	}

	$headers[] = array('X-Phabricator-Mail-ID', $this->getID());

	$unique = Filesystem::readRandomCharacters(16);
	$headers[] = array('X-Phabricator-Send-Attempt', $unique);

	return $headers;
	}

	public function getDeliveredHeaders() {
	return $this->getParam('headers.sent');
	}

	public function getUnfilteredHeaders() {
	$unfiltered = $this->getParam('headers.unfiltered');

	if ($unfiltered === null) {
	// Older versions of Phabricator did not filter headers, and thus did
	// not record unfiltered headers. If we don't have unfiltered header
	// data just return the delivered headers for compatibility.
	return $this->getDeliveredHeaders();
	}

	return $unfiltered;
	}

	public function getDeliveredActors() {
	return $this->getParam('actors.sent');
	}

	public function getDeliveredRoutingRules() {
	return $this->getParam('routing.sent');
	}

	public function getDeliveredRoutingMap() {
	return $this->getParam('routingmap.sent');
	}

	public function getDeliveredBody() {
	return $this->getParam('body.sent');
	}

	private function filterHeaders(array $headers, $must_encrypt) {
	if (!$must_encrypt) {
	return $headers;
	}

	$whitelist = array(
	'In-Reply-To',
	'Message-ID',
	'Precedence',
	'References',
	'Thread-Index',
	'Thread-Topic',

	'X-Mail-Transport-Agent',
	'X-Auto-Response-Suppress',

	'X-Phabricator-Sent-This-Message',
	'X-Phabricator-Must-Encrypt',
	'X-Phabricator-Mail-ID',
	'X-Phabricator-Send-Attempt',
	);

	// NOTE: The major header we want to drop is "X-Phabricator-Mail-Tags".
	// This header contains a significant amount of meaningful information
	// about the object.

	$whitelist_map = array();
	foreach ($whitelist as $term) {
	$whitelist_map[phutil_utf8_strtolower($term)] = true;
	}

	foreach ($headers as $key => $header) {
	list($name, $value) = $header;
	$name = phutil_utf8_strtolower($name);

	if (!isset($whitelist_map[$name])) {
	unset($headers[$key]);
	}
	}

	return $headers;
	}

	public function getURI() {
	return '/mail/detail/'.$this->getID().'/';
	}

	private function newMailDomain() {
	+ $domain = PhabricatorEnv::getEnvConfig('metamta.reply-handler-domain');
	+ if (strlen($domain)) {
	+ return $domain;
	+ }
	+
	$install_uri = PhabricatorEnv::getURI('/');
	$install_uri = new PhutilURI($install_uri);

	return $install_uri->getDomain();
	}

	- public function newVoidEmailAddress() {
	+ public function newDefaultEmailAddress() {
	+ $raw_address = PhabricatorEnv::getEnvConfig('metamta.default-address');
	+ if (strlen($raw_address)) {
	+ return new PhutilEmailAddress($raw_address);
	+ }
	+
	$domain = $this->newMailDomain();
	- $address = "void-recipient@{$domain}";
	+ $address = "noreply@{$domain}";
	+
	return new PhutilEmailAddress($address);
	}

	+ public function newVoidEmailAddress() {
	+ return $this->newDefaultEmailAddress();
	+ }
	+

	/* -( Routing )------------------------------------------------------------ */


	public function addRoutingRule($routing_rule, $phids, $reason_phid) {
	$routing = $this->getParam('routing', array());
	$routing[] = array(
	'routingRule' => $routing_rule,
	'phids' => $phids,
	'reasonPHID' => $reason_phid,
	);
	$this->setParam('routing', $routing);

	// Throw the routing map away so we rebuild it.
	$this->routingMap = null;

	return $this;
	}

	private function getRoutingRule($phid) {
	$map = $this->getRoutingRuleMap();

	$info = idx($map, $phid, idx($map, 'default'));
	if ($info) {
	return idx($info, 'rule');
	}

	return null;
	}

	private function getRoutingRuleMap() {
	if ($this->routingMap === null) {
	$map = array();

	$routing = $this->getParam('routing', array());
	foreach ($routing as $route) {
	$phids = $route['phids'];
	if ($phids === null) {
	$phids = array('default');
	}

	foreach ($phids as $phid) {
	$new_rule = $route['routingRule'];

	$current_rule = idx($map, $phid);
	if ($current_rule === null) {
	$is_stronger = true;
	} else {
	$is_stronger = PhabricatorMailRoutingRule::isStrongerThan(
	$new_rule,
	$current_rule);
	}

	if ($is_stronger) {
	$map[$phid] = array(
	'rule' => $new_rule,
	'reason' => $route['reasonPHID'],
	);
	}
	}
	}

	$this->routingMap = $map;
	}

	return $this->routingMap;
	}

	/* -( Preferences )-------------------------------------------------------- */


	private function loadPreferences($target_phid) {
	$viewer = PhabricatorUser::getOmnipotentUser();

	if (self::shouldMailEachRecipient()) {
	$preferences = id(new PhabricatorUserPreferencesQuery())
	->setViewer($viewer)
	->withUserPHIDs(array($target_phid))
	->needSyntheticPreferences(true)
	->executeOne();
	if ($preferences) {
	return $preferences;
	}
	}

	return PhabricatorUserPreferences::loadGlobalPreferences($viewer);
	}

	private function shouldAddRePrefix(PhabricatorUserPreferences $preferences) {
	$value = $preferences->getSettingValue(
	PhabricatorEmailRePrefixSetting::SETTINGKEY);

	return ($value == PhabricatorEmailRePrefixSetting::VALUE_RE_PREFIX);
	}

	private function shouldVarySubject(PhabricatorUserPreferences $preferences) {
	$value = $preferences->getSettingValue(
	PhabricatorEmailVarySubjectsSetting::SETTINGKEY);

	return ($value == PhabricatorEmailVarySubjectsSetting::VALUE_VARY_SUBJECTS);
	}

	private function shouldSendHTML(PhabricatorUserPreferences $preferences) {
	$value = $preferences->getSettingValue(
	PhabricatorEmailFormatSetting::SETTINGKEY);

	return ($value == PhabricatorEmailFormatSetting::VALUE_HTML_EMAIL);
	}

	public function shouldRenderMailStampsInBody($viewer) {
	$preferences = $this->loadPreferences($viewer->getPHID());
	$value = $preferences->getSettingValue(
	PhabricatorEmailStampsSetting::SETTINGKEY);

	return ($value == PhabricatorEmailStampsSetting::VALUE_BODY_STAMPS);
	}


	/* -( PhabricatorPolicyInterface )----------------------------------------- */


	public function getCapabilities() {
	return array(
	PhabricatorPolicyCapability::CAN_VIEW,
	);
	}

	public function getPolicy($capability) {
	return PhabricatorPolicies::POLICY_NOONE;
	}

	public function hasAutomaticCapability($capability, PhabricatorUser $viewer) {
	$actor_phids = $this->getExpandedRecipientPHIDs();
	return in_array($viewer->getPHID(), $actor_phids);
	}

	public function describeAutomaticCapability($capability) {
	return pht(
	'The mail sender and message recipients can always see the mail.');
	}


	/* -( PhabricatorDestructibleInterface )----------------------------------- */


	public function destroyObjectPermanently(
	PhabricatorDestructionEngine $engine) {

	$files = $this->loadAttachedFiles($engine->getViewer());
	foreach ($files as $file) {
	$engine->destroyObject($file);
	}

	$this->delete();
	}

	}
	diff --git a/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php b/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php
	index 0605c99b89..714e3d3c35 100644
	--- a/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php
	+++ b/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php
	@@ -1,531 +1,540 @@
	<?php

	final class PhabricatorMetaMTAReceivedMail extends PhabricatorMetaMTADAO {

	protected $headers = array();
	protected $bodies = array();
	protected $attachments = array();
	protected $status = '';

	protected $relatedPHID;
	protected $authorPHID;
	protected $message;
	protected $messageIDHash = '';

	protected function getConfiguration() {
	return array(
	self::CONFIG_SERIALIZATION => array(
	'headers' => self::SERIALIZATION_JSON,
	'bodies' => self::SERIALIZATION_JSON,
	'attachments' => self::SERIALIZATION_JSON,
	),
	self::CONFIG_COLUMN_SCHEMA => array(
	'relatedPHID' => 'phid?',
	'authorPHID' => 'phid?',
	'message' => 'text?',
	'messageIDHash' => 'bytes12',
	'status' => 'text32',
	),
	self::CONFIG_KEY_SCHEMA => array(
	'relatedPHID' => array(
	'columns' => array('relatedPHID'),
	),
	'authorPHID' => array(
	'columns' => array('authorPHID'),
	),
	'key_messageIDHash' => array(
	'columns' => array('messageIDHash'),
	),
	'key_created' => array(
	'columns' => array('dateCreated'),
	),
	),
	) + parent::getConfiguration();
	}

	public function setHeaders(array $headers) {
	// Normalize headers to lowercase.
	$normalized = array();
	foreach ($headers as $name => $value) {
	$name = $this->normalizeMailHeaderName($name);
	if ($name == 'message-id') {
	$this->setMessageIDHash(PhabricatorHash::digestForIndex($value));
	}
	$normalized[$name] = $value;
	}
	$this->headers = $normalized;
	return $this;
	}

	public function getHeader($key, $default = null) {
	$key = $this->normalizeMailHeaderName($key);
	return idx($this->headers, $key, $default);
	}

	private function normalizeMailHeaderName($name) {
	return strtolower($name);
	}

	public function getMessageID() {
	return $this->getHeader('Message-ID');
	}

	public function getSubject() {
	return $this->getHeader('Subject');
	}

	public function getCCAddresses() {
	return $this->getRawEmailAddresses(idx($this->headers, 'cc'));
	}

	public function getToAddresses() {
	return $this->getRawEmailAddresses(idx($this->headers, 'to'));
	}

	public function newTargetAddresses() {
	$raw_addresses = array();

	foreach ($this->getToAddresses() as $raw_address) {
	$raw_addresses[] = $raw_address;
	}

	foreach ($this->getCCAddresses() as $raw_address) {
	$raw_addresses[] = $raw_address;
	}

	$raw_addresses = array_unique($raw_addresses);

	$addresses = array();
	foreach ($raw_addresses as $raw_address) {
	$addresses[] = new PhutilEmailAddress($raw_address);
	}

	return $addresses;
	}

	public function loadAllRecipientPHIDs() {
	$addresses = array_merge(
	$this->getToAddresses(),
	$this->getCCAddresses());

	return $this->loadPHIDsFromAddresses($addresses);
	}

	public function loadCCPHIDs() {
	return $this->loadPHIDsFromAddresses($this->getCCAddresses());
	}

	private function loadPHIDsFromAddresses(array $addresses) {
	if (empty($addresses)) {
	return array();
	}
	$users = id(new PhabricatorUserEmail())
	->loadAllWhere('address IN (%Ls)', $addresses);
	return mpull($users, 'getUserPHID');
	}

	public function processReceivedMail() {
	$viewer = $this->getViewer();

	$sender = null;
	try {
	$this->dropMailFromPhabricator();
	$this->dropMailAlreadyReceived();
	$this->dropEmptyMail();

	$sender = $this->loadSender();
	if ($sender) {
	$this->setAuthorPHID($sender->getPHID());

	// If we've identified the sender, mark them as the author of any
	// attached files. We do this before we validate them (below), since
	// they still authored these files even if their account is not allowed
	// to interact via email.

	$attachments = $this->getAttachments();
	if ($attachments) {
	$files = id(new PhabricatorFileQuery())
	->setViewer($viewer)
	->withPHIDs($attachments)
	->execute();
	foreach ($files as $file) {
	$file->setAuthorPHID($sender->getPHID())->save();
	}
	}

	$this->validateSender($sender);
	}

	$receivers = id(new PhutilClassMapQuery())
	->setAncestorClass('PhabricatorMailReceiver')
	->setFilterMethod('isEnabled')
	->execute();

	+ $targets = $this->newTargetAddresses();
	+ foreach ($targets as $key => $target) {
	+ // Never accept any reserved address as a mail target. This prevents
	+ // security issues around "hostmaster@" and bad behavior with
	+ // "noreply@".
	+ if (PhabricatorMailUtil::isReservedAddress($target)) {
	+ unset($targets[$key]);
	+ continue;
	+ }
	+ }
	+
	$any_accepted = false;
	$receiver_exception = null;
	-
	- $targets = $this->newTargetAddresses();
	foreach ($receivers as $receiver) {
	$receiver = id(clone $receiver)
	->setViewer($viewer);

	if ($sender) {
	$receiver->setSender($sender);
	}

	foreach ($targets as $target) {
	try {
	if (!$receiver->canAcceptMail($this, $target)) {
	continue;
	}

	$any_accepted = true;

	$receiver->receiveMail($this, $target);
	} catch (Exception $ex) {
	// If receivers raise exceptions, we'll keep the first one in hope
	// that it points at a root cause.
	if (!$receiver_exception) {
	$receiver_exception = $ex;
	}
	}
	}
	}

	if ($receiver_exception) {
	throw $receiver_exception;
	}

	if (!$any_accepted) {
	if (!$sender) {
	// NOTE: Currently, we'll always drop this mail (since it's headed to
	// an unverified recipient). See T12237. These details are still
	// useful because they'll appear in the mail logs and Mail web UI.

	throw new PhabricatorMetaMTAReceivedMailProcessingException(
	MetaMTAReceivedMailStatus::STATUS_UNKNOWN_SENDER,
	pht(
	'This email was sent from an email address ("%s") that is not '.
	'associated with a Phabricator account. To interact with '.
	'Phabricator via email, add this address to your account.',
	(string)$this->newFromAddress()));
	} else {
	throw new PhabricatorMetaMTAReceivedMailProcessingException(
	MetaMTAReceivedMailStatus::STATUS_NO_RECEIVERS,
	pht(
	'Phabricator can not process this mail because no application '.
	'knows how to handle it. Check that the address you sent it to '.
	'is correct.'.
	"\n\n".
	'(No concrete, enabled subclass of PhabricatorMailReceiver can '.
	'accept this mail.)'));
	}
	}
	} catch (PhabricatorMetaMTAReceivedMailProcessingException $ex) {
	switch ($ex->getStatusCode()) {
	case MetaMTAReceivedMailStatus::STATUS_DUPLICATE:
	case MetaMTAReceivedMailStatus::STATUS_FROM_PHABRICATOR:
	// Don't send an error email back in these cases, since they're
	// very unlikely to be the sender's fault.
	break;
	case MetaMTAReceivedMailStatus::STATUS_EMPTY_IGNORED:
	// This error is explicitly ignored.
	break;
	default:
	$this->sendExceptionMail($ex, $sender);
	break;
	}

	$this
	->setStatus($ex->getStatusCode())
	->setMessage($ex->getMessage())
	->save();
	return $this;
	} catch (Exception $ex) {
	$this->sendExceptionMail($ex, $sender);

	$this
	->setStatus(MetaMTAReceivedMailStatus::STATUS_UNHANDLED_EXCEPTION)
	->setMessage(pht('Unhandled Exception: %s', $ex->getMessage()))
	->save();

	throw $ex;
	}

	return $this->setMessage('OK')->save();
	}

	public function getCleanTextBody() {
	$body = $this->getRawTextBody();
	$parser = new PhabricatorMetaMTAEmailBodyParser();
	return $parser->stripTextBody($body);
	}

	public function parseBody() {
	$body = $this->getRawTextBody();
	$parser = new PhabricatorMetaMTAEmailBodyParser();
	return $parser->parseBody($body);
	}

	public function getRawTextBody() {
	return idx($this->bodies, 'text');
	}

	/**
	* Strip an email address down to the actual user@domain.tld part if
	* necessary, since sometimes it will have formatting like
	* '"Abraham Lincoln" <alincoln@logcab.in>'.
	*/
	private function getRawEmailAddress($address) {
	$matches = null;
	$ok = preg_match('/<(.*)>/', $address, $matches);
	if ($ok) {
	$address = $matches[1];
	}
	return $address;
	}

	private function getRawEmailAddresses($addresses) {
	$raw_addresses = array();
	foreach (explode(',', $addresses) as $address) {
	$raw_addresses[] = $this->getRawEmailAddress($address);
	}
	return array_filter($raw_addresses);
	}

	/**
	* If Phabricator sent the mail, always drop it immediately. This prevents
	* loops where, e.g., the public bug address is also a user email address
	* and creating a bug sends them an email, which loops.
	*/
	private function dropMailFromPhabricator() {
	if (!$this->getHeader('x-phabricator-sent-this-message')) {
	return;
	}

	throw new PhabricatorMetaMTAReceivedMailProcessingException(
	MetaMTAReceivedMailStatus::STATUS_FROM_PHABRICATOR,
	pht(
	"Ignoring email with '%s' header to avoid loops.",
	'X-Phabricator-Sent-This-Message'));
	}

	/**
	* If this mail has the same message ID as some other mail, and isn't the
	* first mail we we received with that message ID, we drop it as a duplicate.
	*/
	private function dropMailAlreadyReceived() {
	$message_id_hash = $this->getMessageIDHash();
	if (!$message_id_hash) {
	// No message ID hash, so we can't detect duplicates. This should only
	// happen with very old messages.
	return;
	}

	$messages = $this->loadAllWhere(
	'messageIDHash = %s ORDER BY id ASC LIMIT 2',
	$message_id_hash);
	$messages_count = count($messages);
	if ($messages_count <= 1) {
	// If we only have one copy of this message, we're good to process it.
	return;
	}

	$first_message = reset($messages);
	if ($first_message->getID() == $this->getID()) {
	// If this is the first copy of the message, it is okay to process it.
	// We may not have been able to to process it immediately when we received
	// it, and could may have received several copies without processing any
	// yet.
	return;
	}

	$message = pht(
	'Ignoring email with "Message-ID" hash "%s" that has been seen %d '.
	'times, including this message.',
	$message_id_hash,
	$messages_count);

	throw new PhabricatorMetaMTAReceivedMailProcessingException(
	MetaMTAReceivedMailStatus::STATUS_DUPLICATE,
	$message);
	}

	private function dropEmptyMail() {
	$body = $this->getCleanTextBody();
	$attachments = $this->getAttachments();

	if (strlen($body) \|\| $attachments) {
	return;
	}

	// Only send an error email if the user is talking to just Phabricator.
	// We can assume if there is only one "To" address it is a Phabricator
	// address since this code is running and everything.
	$is_direct_mail = (count($this->getToAddresses()) == 1) &&
	(count($this->getCCAddresses()) == 0);

	if ($is_direct_mail) {
	$status_code = MetaMTAReceivedMailStatus::STATUS_EMPTY;
	} else {
	$status_code = MetaMTAReceivedMailStatus::STATUS_EMPTY_IGNORED;
	}

	throw new PhabricatorMetaMTAReceivedMailProcessingException(
	$status_code,
	pht(
	'Your message does not contain any body text or attachments, so '.
	'Phabricator can not do anything useful with it. Make sure comment '.
	'text appears at the top of your message: quoted replies, inline '.
	'text, and signatures are discarded and ignored.'));
	}

	private function sendExceptionMail(
	Exception $ex,
	PhabricatorUser $viewer = null) {

	// If we've failed to identify a legitimate sender, we don't send them
	// an error message back. We want to avoid sending mail to unverified
	// addresses. See T12491.
	if (!$viewer) {
	return;
	}

	if ($ex instanceof PhabricatorMetaMTAReceivedMailProcessingException) {
	$status_code = $ex->getStatusCode();
	$status_name = MetaMTAReceivedMailStatus::getHumanReadableName(
	$status_code);

	$title = pht('Error Processing Mail (%s)', $status_name);
	$description = $ex->getMessage();
	} else {
	$title = pht('Error Processing Mail (%s)', get_class($ex));
	$description = pht('%s: %s', get_class($ex), $ex->getMessage());
	}

	// TODO: Since headers don't necessarily have unique names, this may not
	// really be all the headers. It would be nice to pass the raw headers
	// through from the upper layers where possible.

	// On the MimeMailParser pathway, we arrive here with a list value for
	// headers that appeared multiple times in the original mail. Be
	// accommodating until header handling gets straightened out.

	$headers = array();
	foreach ($this->headers as $key => $values) {
	if (!is_array($values)) {
	$values = array($values);
	}
	foreach ($values as $value) {
	$headers[] = pht('%s: %s', $key, $value);
	}
	}
	$headers = implode("\n", $headers);

	$body = pht(<<<EOBODY
	Your email to Phabricator was not processed, because an error occurred while
	trying to handle it:

	%s

	-- Original Message Body -----------------------------------------------------

	%s

	-- Original Message Headers --------------------------------------------------

	%s

	EOBODY
	,
	wordwrap($description, 78),
	$this->getRawTextBody(),
	$headers);

	$mail = id(new PhabricatorMetaMTAMail())
	->setIsErrorEmail(true)
	->setSubject($title)
	->addTos(array($viewer->getPHID()))
	->setBody($body)
	->saveAndSend();
	}

	public function newContentSource() {
	return PhabricatorContentSource::newForSource(
	PhabricatorEmailContentSource::SOURCECONST,
	array(
	'id' => $this->getID(),
	));
	}

	public function newFromAddress() {
	$raw_from = $this->getHeader('From');

	if (strlen($raw_from)) {
	return new PhutilEmailAddress($raw_from);
	}

	return null;
	}

	private function getViewer() {
	return PhabricatorUser::getOmnipotentUser();
	}

	/**
	* Identify the sender's user account for a piece of received mail.
	*
	* Note that this method does not validate that the sender is who they say
	* they are, just that they've presented some credential which corresponds
	* to a recognizable user.
	*/
	private function loadSender() {
	$viewer = $this->getViewer();

	// Try to identify the user based on their "From" address.
	$from_address = $this->newFromAddress();
	if ($from_address) {
	$user = id(new PhabricatorPeopleQuery())
	->setViewer($viewer)
	->withEmails(array($from_address->getAddress()))
	->executeOne();
	if ($user) {
	return $user;
	}
	}

	return null;
	}

	private function validateSender(PhabricatorUser $sender) {
	$failure_reason = null;
	if ($sender->getIsDisabled()) {
	$failure_reason = pht(
	'Your account ("%s") is disabled, so you can not interact with '.
	'Phabricator over email.',
	$sender->getUsername());
	} else if ($sender->getIsStandardUser()) {
	if (!$sender->getIsApproved()) {
	$failure_reason = pht(
	'Your account ("%s") has not been approved yet. You can not '.
	'interact with Phabricator over email until your account is '.
	'approved.',
	$sender->getUsername());
	} else if (PhabricatorUserEmail::isEmailVerificationRequired() &&
	!$sender->getIsEmailVerified()) {
	$failure_reason = pht(
	'You have not verified the email address for your account ("%s"). '.
	'You must verify your email address before you can interact '.
	'with Phabricator over email.',
	$sender->getUsername());
	}
	}

	if ($failure_reason) {
	throw new PhabricatorMetaMTAReceivedMailProcessingException(
	MetaMTAReceivedMailStatus::STATUS_DISABLED_SENDER,
	$failure_reason);
	}
	}

	}
	diff --git a/src/applications/metamta/util/PhabricatorMailUtil.php b/src/applications/metamta/util/PhabricatorMailUtil.php
	index 60eb89dea2..17539a0add 100644
	--- a/src/applications/metamta/util/PhabricatorMailUtil.php
	+++ b/src/applications/metamta/util/PhabricatorMailUtil.php
	@@ -1,65 +1,111 @@
	<?php

	final class PhabricatorMailUtil
	extends Phobject {

	/**
	* Normalize an email address for comparison or lookup.
	*
	* Phabricator can be configured to prepend a prefix to all reply addresses,
	* which can make forwarding rules easier to write. This method strips the
	* prefix if it is present, and normalizes casing and whitespace.
	*
	* @param PhutilEmailAddress Email address.
	* @return PhutilEmailAddress Normalized address.
	*/
	public static function normalizeAddress(PhutilEmailAddress $address) {
	$raw_address = $address->getAddress();
	$raw_address = phutil_utf8_strtolower($raw_address);
	$raw_address = trim($raw_address);

	// If a mailbox prefix is configured and present, strip it off.
	$prefix_key = 'metamta.single-reply-handler-prefix';
	$prefix = PhabricatorEnv::getEnvConfig($prefix_key);
	$len = strlen($prefix);

	if ($len) {
	$prefix = $prefix.'+';
	$len = $len + 1;

	if (!strncasecmp($raw_address, $prefix, $len)) {
	$raw_address = substr($raw_address, $len);
	}
	}

	return id(clone $address)
	->setAddress($raw_address);
	}

	/**
	* Determine if two inbound email addresses are effectively identical.
	*
	* This method strips and normalizes addresses so that equivalent variations
	* are correctly detected as identical. For example, these addresses are all
	* considered to match one another:
	*
	* "Abraham Lincoln" <alincoln@example.com>
	* alincoln@example.com
	* <ALincoln@example.com>
	* "Abraham" <phabricator+ALINCOLN@EXAMPLE.COM> # With configured prefix.
	*
	* @param PhutilEmailAddress Email address.
	* @param PhutilEmailAddress Another email address.
	* @return bool True if addresses are effectively the same address.
	*/
	public static function matchAddresses(
	PhutilEmailAddress $u,
	PhutilEmailAddress $v) {

	$u = self::normalizeAddress($u);
	$v = self::normalizeAddress($v);

	return ($u->getAddress() === $v->getAddress());
	}

	+ public static function isReservedAddress(PhutilEmailAddress $address) {
	+ $address = self::normalizeAddress($address);
	+ $local = $address->getLocalPart();
	+
	+ $reserved = array(
	+ 'admin',
	+ 'administrator',
	+ 'hostmaster',
	+ 'list',
	+ 'list-request',
	+ 'majordomo',
	+ 'postmaster',
	+ 'root',
	+ 'ssl-admin',
	+ 'ssladmin',
	+ 'ssladministrator',
	+ 'sslwebmaster',
	+ 'sysadmin',
	+ 'uucp',
	+ 'webmaster',
	+
	+ 'noreply',
	+ 'no-reply',
	+ );
	+
	+ $reserved = array_fuse($reserved);
	+
	+ if (isset($reserved[$local])) {
	+ return true;
	+ }
	+
	+ $default_address = id(new PhabricatorMetaMTAMail())
	+ ->newDefaultEmailAddress();
	+ if (self::matchAddresses($address, $default_address)) {
	+ return true;
	+ }
	+
	+ $void_address = id(new PhabricatorMetaMTAMail())
	+ ->newVoidEmailAddress();
	+ if (self::matchAddresses($address, $void_address)) {
	+ return true;
	+ }
	+
	+ return false;
	+ }
	+
	}

File Metadata

Mime Type: text/x-diff
Expires: Sun, Sep 7, 8:32 AM (1 d, 42 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 222766
Default Alt Text: (90 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions