No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/applications/diffusion/request/DiffusionMercurialRequest.php b/src/applications/diffusion/request/DiffusionMercurialRequest.php
	index b626d62750..676dc097f7 100644
	--- a/src/applications/diffusion/request/DiffusionMercurialRequest.php
	+++ b/src/applications/diffusion/request/DiffusionMercurialRequest.php
	@@ -1,21 +1,22 @@
	<?php

	final class DiffusionMercurialRequest extends DiffusionRequest {

	protected function isStableCommit($symbol) {
	+ if ($symbol === null) {
	+ return false;
	+ }
	return preg_match('/^[a-f0-9]{40}\z/', $symbol);
	}

	public function getBranch() {
	if ($this->branch) {
	return $this->branch;
	}
	-
	if ($this->repository) {
	return $this->repository->getDefaultBranch();
	}
	-
	throw new Exception(pht('Unable to determine branch!'));
	}

	}
	diff --git a/src/applications/diffusion/request/DiffusionSvnRequest.php b/src/applications/diffusion/request/DiffusionSvnRequest.php
	index 5f50366331..33fc3446f9 100644
	--- a/src/applications/diffusion/request/DiffusionSvnRequest.php
	+++ b/src/applications/diffusion/request/DiffusionSvnRequest.php
	@@ -1,22 +1,25 @@
	<?php

	final class DiffusionSvnRequest extends DiffusionRequest {

	protected function isStableCommit($symbol) {
	+ if ($symbol === null) {
	+ return false;
	+ }
	return preg_match('/^[1-9]\d*\z/', $symbol);
	}

	protected function didInitialize() {
	if ($this->path === null) {
	$subpath = $this->repository->getDetail('svn-subpath');
	if ($subpath) {
	$this->path = $subpath;
	}
	}
	}

	protected function getArcanistBranch() {
	return 'svn';
	}

	}