Page MenuHomestyx hydra
Files F128645

No OneTemporary
Actions

View Options

diff --git a/src/applications/spaces/xaction/PhabricatorSpacesNamespaceNameTransaction.php b/src/applications/spaces/xaction/PhabricatorSpacesNamespaceNameTransaction.php
index d7fcbc2c7a..d88425598f 100644
--- a/src/applications/spaces/xaction/PhabricatorSpacesNamespaceNameTransaction.php
+++ b/src/applications/spaces/xaction/PhabricatorSpacesNamespaceNameTransaction.php
@@ -1,62 +1,62 @@
<?php
final class PhabricatorSpacesNamespaceNameTransaction
extends PhabricatorSpacesNamespaceTransactionType {
const TRANSACTIONTYPE = 'spaces:name';
public function generateOldValue($object) {
return $object->getNamespaceName();
}
public function applyInternalEffects($object, $value) {
$object->setNamespaceName($value);
}
public function getTitle() {
$old = $this->getOldValue();
- if (!strlen($old)) {
+ if (!phutil_nonempty_string($old)) {
return pht(
'%s created this space.',
$this->renderAuthor());
} else {
return pht(
'%s renamed this space from %s to %s.',
$this->renderAuthor(),
$this->renderOldValue(),
$this->renderNewValue());
}
}
public function getTitleForFeed() {
return pht(
'%s renamed space %s from %s to %s.',
$this->renderAuthor(),
$this->renderObject(),
$this->renderOldValue(),
$this->renderNewValue());
}
public function validateTransactions($object, array $xactions) {
$errors = array();
if ($this->isEmptyTextTransaction($object->getNamespaceName(), $xactions)) {
$errors[] = $this->newRequiredError(
pht('Spaces must have a name.'));
}
$max_length = $object->getColumnMaximumByteLength('namespaceName');
foreach ($xactions as $xaction) {
$new_value = $xaction->getNewValue();
$new_length = strlen($new_value);
if ($new_length > $max_length) {
$errors[] = $this->newInvalidError(
pht('The name can be no longer than %s characters.',
new PhutilNumber($max_length)));
}
}
return $errors;
}
}

File Metadata

Mime Type
text/x-diff
Expires
Thu, May 1, 9:41 AM (1 d, 14 h)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
108949
Default Alt Text
(2 KB)

Event Timeline

styx copyright 2020 sirocyl / ellie (kymkdd) / ncommander / styx contributors
Use of other names and brands is not intended to reflect a claim of, or right to, use the name or brand.
styx is an operating system using the Linux kernel and components, and "styx Linux" as a phrase does not reflect the inclusion of the Linux brand or trademark in the styx project.
Linux® is the registered trademark of Linus Torvalds in the U.S. and other countries.
Terms and Conditions (TODO: fix this!)