No OneTemporary
Actions

Size

28 KB

Referenced Files

None

Subscribers

None

View Options

	diff --git a/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php b/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
	index 0fc133d8b6..c64d92ba6a 100644
	--- a/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
	+++ b/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
	@@ -1,341 +1,358 @@
	<?php

	/**
	* @group aphront
	*/
	class AphrontDefaultApplicationConfiguration
	extends AphrontApplicationConfiguration {

	public function __construct() {

	}

	public function getApplicationName() {
	return 'aphront-default';
	}

	public function getURIMap() {
	return $this->getResourceURIMapRules() + array(
	'/(?:(?P<filter>(?:jump))/)?' =>
	'PhabricatorDirectoryMainController',

	'/typeahead/' => array(
	'common/(?P<type>\w+)/'
	=> 'PhabricatorTypeaheadCommonDatasourceController',
	),

	'/oauthserver/' => array(
	'auth/' => 'PhabricatorOAuthServerAuthController',
	'test/' => 'PhabricatorOAuthServerTestController',
	'token/' => 'PhabricatorOAuthServerTokenController',
	'clientauthorization/' => array(
	'' => 'PhabricatorOAuthClientAuthorizationListController',
	'delete/(?P<phid>[^/]+)/' =>
	'PhabricatorOAuthClientAuthorizationDeleteController',
	'edit/(?P<phid>[^/]+)/' =>
	'PhabricatorOAuthClientAuthorizationEditController',
	),
	'client/' => array(
	'' => 'PhabricatorOAuthClientListController',
	'create/' => 'PhabricatorOAuthClientEditController',
	'delete/(?P<phid>[^/]+)/' => 'PhabricatorOAuthClientDeleteController',
	'edit/(?P<phid>[^/]+)/' => 'PhabricatorOAuthClientEditController',
	'view/(?P<phid>[^/]+)/' => 'PhabricatorOAuthClientViewController',
	),
	),

	'/~/' => array(
	'' => 'DarkConsoleController',
	'data/(?P<key>[^/]+)/' => 'DarkConsoleDataController',
	),

	'/status/' => 'PhabricatorStatusController',


	'/help/' => array(
	'keyboardshortcut/' => 'PhabricatorHelpKeyboardShortcutController',
	),

	'/notification/' => array(
	'(?:(?P<filter>all\|unread)/)?'
	=> 'PhabricatorNotificationListController',
	'panel/' => 'PhabricatorNotificationPanelController',
	'individual/' => 'PhabricatorNotificationIndividualController',
	'status/' => 'PhabricatorNotificationStatusController',
	'clear/' => 'PhabricatorNotificationClearController',
	),

	'/debug/' => 'PhabricatorDebugController',
	);
	}

	protected function getResourceURIMapRules() {
	return array(
	'/res/' => array(
	'(?:(?P<mtime>[0-9]+)T/)?'.
	'(?P<package>pkg/)?'.
	'(?P<hash>[a-f0-9]{8})/'.
	'(?P<path>.+\.(?:css\|js\|jpg\|png\|swf\|gif))'
	=> 'CelerityPhabricatorResourceController',
	),
	);
	}

	+ /**
	+ * @phutil-external-symbol class PhabricatorStartup
	+ */
	public function buildRequest() {
	+ $parser = new PhutilQueryStringParser();
	+ $data = array();
	+
	+ $raw_input = PhabricatorStartup::getRawInput();
	+ if (strlen($raw_input)) {
	+ $data += $parser->parseQueryString($raw_input);
	+ } else if ($_POST) {
	+ $data += $_POST;
	+ }
	+
	+ $data += $parser->parseQueryString(
	+ isset($_SERVER['QUERY_STRING']) ? $_SERVER['QUERY_STRING'] : "");
	+
	$request = new AphrontRequest($this->getHost(), $this->getPath());
	- $request->setRequestData($_POST + $_GET);
	+ $request->setRequestData($data);
	$request->setApplicationConfiguration($this);
	+
	return $request;
	}

	public function handleException(Exception $ex) {
	$request = $this->getRequest();

	// For Conduit requests, return a Conduit response.
	if ($request->isConduit()) {
	$response = new ConduitAPIResponse();
	$response->setErrorCode(get_class($ex));
	$response->setErrorInfo($ex->getMessage());

	return id(new AphrontJSONResponse())
	->setAddJSONShield(false)
	->setContent($response->toDictionary());
	}

	// For non-workflow requests, return a Ajax response.
	if ($request->isAjax() && !$request->isJavelinWorkflow()) {
	$response = new AphrontAjaxResponse();
	$response->setError(
	array(
	'code' => get_class($ex),
	'info' => $ex->getMessage(),
	));
	return $response;
	}

	$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');

	$user = $request->getUser();
	if (!$user) {
	// If we hit an exception very early, we won't have a user.
	$user = new PhabricatorUser();
	}

	if ($ex instanceof PhabricatorPolicyException) {

	if (!$user->isLoggedIn()) {
	// If the user isn't logged in, just give them a login form. This is
	// probably a generally more useful response than a policy dialog that
	// they have to click through to get a login form.
	//
	// Possibly we should add a header here like "you need to login to see
	// the thing you are trying to look at".
	$login_controller = new PhabricatorAuthStartController($request);
	return $login_controller->processRequest();
	}

	$content = hsprintf(
	'<div class="aphront-policy-exception">%s</div>',
	$ex->getMessage());

	$dialog = new AphrontDialogView();
	$dialog
	->setTitle(
	$is_serious
	? 'Access Denied'
	: "You Shall Not Pass")
	->setClass('aphront-access-dialog')
	->setUser($user)
	->appendChild($content);

	if ($this->getRequest()->isAjax()) {
	$dialog->addCancelButton('/', 'Close');
	} else {
	$dialog->addCancelButton('/', $is_serious ? 'OK' : 'Away With Thee');
	}

	$response = new AphrontDialogResponse();
	$response->setDialog($dialog);
	return $response;
	}

	if ($ex instanceof AphrontUsageException) {
	$error = new AphrontErrorView();
	$error->setTitle($ex->getTitle());
	$error->appendChild($ex->getMessage());

	$view = new PhabricatorStandardPageView();
	$view->setRequest($this->getRequest());
	$view->appendChild($error);

	$response = new AphrontWebpageResponse();
	$response->setContent($view->render());

	return $response;
	}


	// Always log the unhandled exception.
	phlog($ex);

	$class = get_class($ex);
	$message = $ex->getMessage();

	if ($ex instanceof AphrontQuerySchemaException) {
	$message .=
	"\n\n".
	"NOTE: This usually indicates that the MySQL schema has not been ".
	"properly upgraded. Run 'bin/storage upgrade' to ensure your ".
	"schema is up to date.";
	}

	if (PhabricatorEnv::getEnvConfig('phabricator.developer-mode')) {
	$trace = $this->renderStackTrace($ex->getTrace(), $user);
	} else {
	$trace = null;
	}

	$content = hsprintf(
	'<div class="aphront-unhandled-exception">'.
	'<div class="exception-message">%s</div>'.
	'%s'.
	'</div>',
	$message,
	$trace);

	$dialog = new AphrontDialogView();
	$dialog
	->setTitle('Unhandled Exception ("'.$class.'")')
	->setClass('aphront-exception-dialog')
	->setUser($user)
	->appendChild($content);

	if ($this->getRequest()->isAjax()) {
	$dialog->addCancelButton('/', 'Close');
	}

	$response = new AphrontDialogResponse();
	$response->setDialog($dialog);

	return $response;
	}

	public function willSendResponse(AphrontResponse $response) {
	return $response;
	}

	public function build404Controller() {
	return array(new Phabricator404Controller($this->getRequest()), array());
	}

	public function buildRedirectController($uri) {
	return array(
	new PhabricatorRedirectController($this->getRequest()),
	array(
	'uri' => $uri,
	));
	}

	private function renderStackTrace($trace, PhabricatorUser $user) {

	$libraries = PhutilBootloader::getInstance()->getAllLibraries();

	// TODO: Make this configurable?
	$path = 'https://secure.phabricator.com/diffusion/%s/browse/master/src/';

	$callsigns = array(
	'arcanist' => 'ARC',
	'phutil' => 'PHU',
	'phabricator' => 'P',
	);

	$rows = array();
	$depth = count($trace);
	foreach ($trace as $part) {
	$lib = null;
	$file = idx($part, 'file');
	$relative = $file;
	foreach ($libraries as $library) {
	$root = phutil_get_library_root($library);
	if (Filesystem::isDescendant($file, $root)) {
	$lib = $library;
	$relative = Filesystem::readablePath($file, $root);
	break;
	}
	}

	$where = '';
	if (isset($part['class'])) {
	$where .= $part['class'].'::';
	}
	if (isset($part['function'])) {
	$where .= $part['function'].'()';
	}

	if ($file) {
	if (isset($callsigns[$lib])) {
	$attrs = array('title' => $file);
	try {
	$attrs['href'] = $user->loadEditorLink(
	'/src/'.$relative,
	$part['line'],
	$callsigns[$lib]);
	} catch (Exception $ex) {
	// The database can be inaccessible.
	}
	if (empty($attrs['href'])) {
	$attrs['href'] = sprintf($path, $callsigns[$lib]).
	str_replace(DIRECTORY_SEPARATOR, '/', $relative).
	'$'.$part['line'];
	$attrs['target'] = '_blank';
	}
	$file_name = phutil_tag(
	'a',
	$attrs,
	$relative);
	} else {
	$file_name = phutil_tag(
	'span',
	array(
	'title' => $file,
	),
	$relative);
	}
	$file_name = hsprintf('%s : %d', $file_name, $part['line']);
	} else {
	$file_name = phutil_tag('em', array(), '(Internal)');
	}


	$rows[] = array(
	$depth--,
	$lib,
	$file_name,
	$where,
	);
	}
	$table = new AphrontTableView($rows);
	$table->setHeaders(
	array(
	'Depth',
	'Library',
	'File',
	'Where',
	));
	$table->setColumnClasses(
	array(
	'n',
	'',
	'',
	'wide',
	));

	return hsprintf(
	'<div class="exception-trace">'.
	'<div class="exception-trace-header">Stack Trace</div>'.
	'%s'.
	'</div>',
	$table->render());
	}

	}
	diff --git a/src/applications/files/controller/PhabricatorFileDropUploadController.php b/src/applications/files/controller/PhabricatorFileDropUploadController.php
	index d628e8ab8f..97e948936a 100644
	--- a/src/applications/files/controller/PhabricatorFileDropUploadController.php
	+++ b/src/applications/files/controller/PhabricatorFileDropUploadController.php
	@@ -1,36 +1,39 @@
	<?php

	final class PhabricatorFileDropUploadController
	extends PhabricatorFileController {

	+ /**
	+ * @phutil-external-symbol class PhabricatorStartup
	+ */
	public function processRequest() {
	$request = $this->getRequest();
	$user = $request->getUser();

	// NOTE: Throws if valid CSRF token is not present in the request.
	$request->validateCSRF();

	- $data = file_get_contents('php://input');
	+ $data = PhabricatorStartup::getRawInput();
	$name = $request->getStr('name');

	$file = PhabricatorFile::newFromXHRUpload(
	$data,
	array(
	'name' => $request->getStr('name'),
	'authorPHID' => $user->getPHID(),
	'isExplicitUpload' => true,
	));

	$view = new AphrontAttachedFileView();
	$view->setFile($file);

	return id(new AphrontAjaxResponse())->setContent(
	array(
	'id' => $file->getID(),
	'phid' => $file->getPHID(),
	'html' => $view->render(),
	'uri' => $file->getBestURI(),
	));
	}

	}
	diff --git a/support/PhabricatorStartup.php b/support/PhabricatorStartup.php
	index 374228570e..a4d241198d 100644
	--- a/support/PhabricatorStartup.php
	+++ b/support/PhabricatorStartup.php
	@@ -1,385 +1,395 @@
	<?php

	/**
	* Handle request startup, before loading the environment or libraries. This
	* class bootstraps the request state up to the point where we can enter
	* Phabricator code.
	*
	* NOTE: This class MUST NOT have any dependencies. It runs before libraries
	* load.
	*
	* @task info Accessing Request Information
	* @task hook Startup Hooks
	* @task apocalypse In Case Of Apocalypse
	* @task validation Validation
	*/
	final class PhabricatorStartup {

	private static $startTime;
	private static $globals = array();
	private static $capturingOutput;
	+ private static $rawInput;


	/* -( Accessing Request Information )-------------------------------------- */


	/**
	* @task info
	*/
	public static function getStartTime() {
	return self::$startTime;
	}


	/**
	* @task info
	*/
	public static function getMicrosecondsSinceStart() {
	return (int)(1000000 * (microtime(true) - self::getStartTime()));
	}


	/**
	* @task info
	*/
	public static function setGlobal($key, $value) {
	self::validateGlobal($key);

	self::$globals[$key] = $value;
	}


	/**
	* @task info
	*/
	public static function getGlobal($key, $default = null) {
	self::validateGlobal($key);

	if (!array_key_exists($key, self::$globals)) {
	return $default;
	}
	return self::$globals[$key];
	}

	+ /**
	+ * @task info
	+ */
	+ public static function getRawInput() {
	+ return self::$rawInput;
	+ }
	+

	/* -( Startup Hooks )------------------------------------------------------ */


	/**
	* @task hook
	*/
	public static function didStartup() {
	self::$startTime = microtime(true);
	self::$globals = array();

	static $registered;
	if (!$registered) {
	// NOTE: This protects us against multiple calls to didStartup() in the
	// same request, but also against repeated requests to the same
	// interpreter state, which we may implement in the future.
	register_shutdown_function(array(__CLASS__, 'didShutdown'));
	$registered = true;
	}

	self::setupPHP();
	self::verifyPHP();

	self::verifyRewriteRules();

	self::detectPostMaxSizeTriggered();

	self::beginOutputCapture();
	+
	+ self::$rawInput = (string)file_get_contents('php://input');
	}


	/**
	* @task hook
	*/
	public static function didShutdown() {
	$event = error_get_last();

	if (!$event) {
	return;
	}

	switch ($event['type']) {
	case E_ERROR:
	case E_PARSE:
	case E_COMPILE_ERROR:
	break;
	default:
	return;
	}

	$msg = ">>> UNRECOVERABLE FATAL ERROR <<<\n\n";
	if ($event) {
	// Even though we should be emitting this as text-plain, escape things
	// just to be sure since we can't really be sure what the program state
	// is when we get here.
	$msg .= htmlspecialchars(
	$event['message']."\n\n".$event['file'].':'.$event['line'],
	ENT_QUOTES,
	'UTF-8');
	}

	// flip dem tables
	$msg .= "\n\n\n";
	$msg .= "\xe2\x94\xbb\xe2\x94\x81\xe2\x94\xbb\x20\xef\xb8\xb5\x20\xc2\xaf".
	"\x5c\x5f\x28\xe3\x83\x84\x29\x5f\x2f\xc2\xaf\x20\xef\xb8\xb5\x20".
	"\xe2\x94\xbb\xe2\x94\x81\xe2\x94\xbb";

	self::didFatal($msg);
	}

	public static function loadCoreLibraries() {
	$phabricator_root = dirname(dirname(__FILE__));
	$libraries_root = dirname($phabricator_root);

	$root = null;
	if (!empty($_SERVER['PHUTIL_LIBRARY_ROOT'])) {
	$root = $_SERVER['PHUTIL_LIBRARY_ROOT'];
	}

	ini_set(
	'include_path',
	$libraries_root.PATH_SEPARATOR.ini_get('include_path'));

	@include_once $root.'libphutil/src/__phutil_library_init__.php';
	if (!@constant('__LIBPHUTIL__')) {
	self::didFatal(
	"Unable to load libphutil. Put libphutil/ next to phabricator/, or ".
	"update your PHP 'include_path' to include the parent directory of ".
	"libphutil/.");
	}

	phutil_load_library('arcanist/src');

	// Load Phabricator itself using the absolute path, so we never end up doing
	// anything surprising (loading index.php and libraries from different
	// directories).
	phutil_load_library($phabricator_root.'/src');
	}

	/* -( Output Capture )----------------------------------------------------- */


	public static function beginOutputCapture() {
	if (self::$capturingOutput) {
	self::didFatal("Already capturing output!");
	}
	self::$capturingOutput = true;
	ob_start();
	}


	public static function endOutputCapture() {
	if (!self::$capturingOutput) {
	return null;
	}
	self::$capturingOutput = false;
	return ob_get_clean();
	}


	/* -( In Case of Apocalypse )---------------------------------------------- */


	/**
	* @task apocalypse
	*/
	public static function didFatal($message) {
	self::endOutputCapture();
	$access_log = self::getGlobal('log.access');

	if ($access_log) {
	// We may end up here before the access log is initialized, e.g. from
	// verifyPHP().
	$access_log->setData(
	array(
	'c' => 500,
	));
	$access_log->write();
	}

	header(
	'Content-Type: text/plain; charset=utf-8',
	$replace = true,
	$http_error = 500);

	error_log($message);
	echo $message;

	exit(1);
	}


	/* -( Validation )--------------------------------------------------------- */


	/**
	* @task valiation
	*/
	private static function setupPHP() {
	error_reporting(E_ALL \| E_STRICT);
	ini_set('memory_limit', -1);
	}


	/**
	* @task valiation
	*/
	private static function verifyPHP() {
	$required_version = '5.2.3';
	if (version_compare(PHP_VERSION, $required_version) < 0) {
	self::didFatal(
	"You are running PHP version '".PHP_VERSION."', which is older than ".
	"the minimum version, '{$required_version}'. Update to at least ".
	"'{$required_version}'.");
	}

	if (get_magic_quotes_gpc()) {
	self::didFatal(
	"Your server is configured with PHP 'magic_quotes_gpc' enabled. This ".
	"feature is 'highly discouraged' by PHP's developers and you must ".
	"disable it to run Phabricator. Consult the PHP manual for ".
	"instructions.");
	}
	}


	/**
	* @task valiation
	*/
	private static function verifyRewriteRules() {
	if (isset($_REQUEST['__path__']) && strlen($_REQUEST['__path__'])) {
	return;
	}

	if (php_sapi_name() == 'cli-server') {
	// Compatibility with PHP 5.4+ built-in web server.
	$url = parse_url($_SERVER['REQUEST_URI']);
	$_REQUEST['__path__'] = $url['path'];
	return;
	}

	if (!isset($_REQUEST['__path__'])) {
	self::didFatal(
	"Request parameter '__path__' is not set. Your rewrite rules ".
	"are not configured correctly.");
	}

	if (!strlen($_REQUEST['__path__'])) {
	self::didFatal(
	"Request parameter '__path__' is set, but empty. Your rewrite rules ".
	"are not configured correctly. The '__path__' should always ".
	"begin with a '/'.");
	}
	}


	/**
	* @task valiation
	*/
	private static function validateGlobal($key) {
	static $globals = array(
	'log.access' => true,
	);

	if (empty($globals[$key])) {
	throw new Exception("Access to unknown startup global '{$key}'!");
	}
	}


	/**
	* Detect if this request has had its POST data stripped by exceeding the
	* 'post_max_size' PHP configuration limit.
	*
	* PHP has a setting called 'post_max_size'. If a POST request arrives with
	* a body larger than the limit, PHP doesn't generate $_POST but processes
	* the request anyway, and provides no formal way to detect that this
	* happened.
	*
	* We can still read the entire body out of `php://input`. However according
	* to the documentation the stream isn't available for "multipart/form-data"
	* (on nginx + php-fpm it appears that it is available, though, at least) so
	* any attempt to generate $_POST would be fragile.
	*
	* @task validation
	*/
	private static function detectPostMaxSizeTriggered() {
	// If this wasn't a POST, we're fine.
	if ($_SERVER['REQUEST_METHOD'] != 'POST') {
	return;
	}

	// If there's POST data, clearly we're in good shape.
	if ($_POST) {
	return;
	}

	// For HTML5 drag-and-drop file uploads, Safari submits the data as
	// "application/x-www-form-urlencoded". For most files this generates
	// something in POST because most files decode to some nonempty (albeit
	// meaningless) value. However, some files (particularly small images)
	// don't decode to anything. If we know this is a drag-and-drop upload,
	// we can skip this check.
	if (isset($_REQUEST['__upload__'])) {
	return;
	}

	// PHP generates $_POST only for two content types. This routing happens
	// in `main/php_content_types.c` in PHP. Normally, all forms use one of
	// these content types, but some requests may not -- for example, Firefox
	// submits files sent over HTML5 XMLHTTPRequest APIs with the Content-Type
	// of the file itself. If we don't have a recognized content type, we
	// don't need $_POST.
	//
	// NOTE: We use strncmp() because the actual content type may be something
	// like "multipart/form-data; boundary=...".
	//
	// NOTE: Chrome sometimes omits this header, see some discussion in T1762
	// and http://code.google.com/p/chromium/issues/detail?id=6800
	$content_type = isset($_SERVER['CONTENT_TYPE'])
	? $_SERVER['CONTENT_TYPE']
	: '';

	$parsed_types = array(
	'application/x-www-form-urlencoded',
	'multipart/form-data',
	);

	$is_parsed_type = false;
	foreach ($parsed_types as $parsed_type) {
	if (strncmp($content_type, $parsed_type, strlen($parsed_type)) === 0) {
	$is_parsed_type = true;
	break;
	}
	}

	if (!$is_parsed_type) {
	return;
	}

	// Check for 'Content-Length'. If there's no data, we don't expect $_POST
	// to exist.
	$length = (int)$_SERVER['CONTENT_LENGTH'];
	if (!$length) {
	return;
	}

	// Time to fatal: we know this was a POST with data that should have been
	// populated into $_POST, but it wasn't.

	$config = ini_get('post_max_size');
	PhabricatorStartup::didFatal(
	"As received by the server, this request had a nonzero content length ".
	"but no POST data.\n\n".
	"Normally, this indicates that it exceeds the 'post_max_size' setting ".
	"in the PHP configuration on the server. Increase the 'post_max_size' ".
	"setting or reduce the size of the request.\n\n".
	"Request size according to 'Content-Length' was '{$length}', ".
	"'post_max_size' is set to '{$config}'.");
	}

	}
	diff --git a/webroot/index.php b/webroot/index.php
	index 5db2067175..7ee22338cc 100644
	--- a/webroot/index.php
	+++ b/webroot/index.php
	@@ -1,147 +1,140 @@
	<?php

	require_once dirname(dirname(__FILE__)).'/support/PhabricatorStartup.php';
	PhabricatorStartup::didStartup();

	try {
	PhabricatorStartup::loadCoreLibraries();

	PhabricatorEnv::initializeWebEnvironment();

	// This is the earliest we can get away with this, we need env config first.
	PhabricatorAccessLog::init();
	$access_log = PhabricatorAccessLog::getLog();
	PhabricatorStartup::setGlobal('log.access', $access_log);
	$access_log->setData(
	array(
	'R' => AphrontRequest::getHTTPHeader('Referer', '-'),
	'r' => idx($_SERVER, 'REMOTE_ADDR', '-'),
	'M' => idx($_SERVER, 'REQUEST_METHOD', '-'),
	));

	DarkConsoleXHProfPluginAPI::hookProfiler();
	DarkConsoleErrorLogPluginAPI::registerErrorHandler();

	$sink = new AphrontPHPHTTPSink();

	$response = PhabricatorSetupCheck::willProcessRequest();
	if ($response) {
	PhabricatorStartup::endOutputCapture();
	$sink->writeResponse($response);
	return;
	}

	$host = AphrontRequest::getHTTPHeader('Host');
	$path = $_REQUEST['__path__'];

	- $parser = new PhutilQueryStringParser();
	- $_GET = $parser->parseQueryString(
	- isset($_SERVER['QUERY_STRING']) ? $_SERVER['QUERY_STRING'] : "");
	- $_POST = $parser->parseQueryString(
	- (string)file_get_contents('php://input'));
	- $_REQUEST = $_POST + $_GET;
	-
	switch ($host) {
	default:
	$config_key = 'aphront.default-application-configuration-class';
	$application = PhabricatorEnv::newObjectFromConfig($config_key);
	break;
	}

	$application->setHost($host);
	$application->setPath($path);
	$application->willBuildRequest();
	$request = $application->buildRequest();

	// Until an administrator sets "phabricator.base-uri", assume it is the same
	// as the request URI. This will work fine in most cases, it just breaks down
	// when daemons need to do things.
	$request_protocol = ($request->isHTTPS() ? 'https' : 'http');
	$request_base_uri = "{$request_protocol}://{$host}/";
	PhabricatorEnv::setRequestBaseURI($request_base_uri);

	$write_guard = new AphrontWriteGuard(array($request, 'validateCSRF'));

	$application->setRequest($request);
	list($controller, $uri_data) = $application->buildController();

	$access_log->setData(
	array(
	'U' => (string)$request->getRequestURI()->getPath(),
	'C' => get_class($controller),
	));

	// If execution throws an exception and then trying to render that exception
	// throws another exception, we want to show the original exception, as it is
	// likely the root cause of the rendering exception.
	$original_exception = null;
	try {
	$response = $controller->willBeginExecution();

	if ($request->getUser() && $request->getUser()->getPHID()) {
	$access_log->setData(
	array(
	'u' => $request->getUser()->getUserName(),
	'P' => $request->getUser()->getPHID(),
	));
	}

	if (!$response) {
	$controller->willProcessRequest($uri_data);
	$response = $controller->processRequest();
	}
	} catch (AphrontRedirectException $ex) {
	$response = id(new AphrontRedirectResponse())
	->setURI($ex->getURI());
	} catch (Exception $ex) {
	$original_exception = $ex;
	$response = $application->handleException($ex);
	}

	try {
	$response = $controller->didProcessRequest($response);
	$response = $application->willSendResponse($response, $controller);
	$response->setRequest($request);

	$unexpected_output = PhabricatorStartup::endOutputCapture();
	if ($unexpected_output) {
	$unexpected_output = "Unexpected output:\n\n{$unexpected_output}";
	phlog($unexpected_output);

	if ($response instanceof AphrontWebpageResponse) {
	echo hsprintf(
	'<div style="background: #eeddff; white-space: pre-wrap;
	z-index: 200000; position: relative; padding: 8px;
	font-family: monospace;">%s</div>',
	$unexpected_output);
	}
	}

	$sink->writeResponse($response);
	} catch (Exception $ex) {
	$write_guard->dispose();
	$access_log->write();
	if ($original_exception) {
	$ex = new PhutilAggregateException(
	"Multiple exceptions during processing and rendering.",
	array(
	$original_exception,
	$ex,
	));
	}
	PhabricatorStartup::didFatal('[Rendering Exception] '.$ex->getMessage());
	}

	$write_guard->dispose();

	$access_log->setData(
	array(
	'c' => $response->getHTTPResponseCode(),
	'T' => PhabricatorStartup::getMicrosecondsSinceStart(),
	));

	DarkConsoleXHProfPluginAPI::saveProfilerSample($access_log);
	} catch (Exception $ex) {
	PhabricatorStartup::didFatal("[Exception] ".$ex->getMessage());
	}

File Metadata

Mime Type: text/x-diff
Expires: Sat, Nov 15, 3:48 PM (18 h, 22 m)
Storage Engine: blob
Storage Format: Raw Data
Storage Handle: 338118
Default Alt Text: (28 KB)

No OneTemporaryActions

View Options

File Metadata

Event Timeline

No OneTemporary
Actions