Page MenuHomestyx hydra
Files F234428

No OneTemporary
Actions

View Options

diff --git a/src/infrastructure/storage/lisk/LiskMigrationIterator.php b/src/infrastructure/storage/lisk/LiskMigrationIterator.php
index 9243c7432d..1a8b46aa9b 100644
--- a/src/infrastructure/storage/lisk/LiskMigrationIterator.php
+++ b/src/infrastructure/storage/lisk/LiskMigrationIterator.php
@@ -1,77 +1,60 @@
<?php
/*
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/**
* Iterate over every object of a given type, without holding all of them in
* memory. This is useful for performing database migrations.
*
* $things = new LiskMigrationIterator(new LiskThing());
* foreach ($things as $thing) {
* // do something
* }
*
* NOTE: This only works on objects with a normal `id` column.
*
* @task storage
*/
-final class LiskMigrationIterator implements Iterator {
+final class LiskMigrationIterator extends PhutilBufferedIterator {
private $object;
private $cursor;
- private $data;
public function __construct(LiskDAO $object) {
$this->object = $object;
}
- public function rewind() {
+ protected function didRewind() {
$this->cursor = 0;
- $this->data = array();
- $this->next();
- }
-
- public function valid() {
- if (!$this->data) {
- $this->next();
- }
- return (bool)$this->data;
- }
-
- public function current() {
- return end($this->data);
}
public function key() {
return $this->current()->getID();
}
- public function next() {
- if ($this->data) {
- return array_pop($this->data);
- }
- $this->data = $this->object->loadAllWhere(
+ protected function loadPage() {
+ $results = $this->object->loadAllWhere(
'id > %d ORDER BY id ASC LIMIT %d',
$this->cursor,
- 100);
- if ($this->data) {
- $this->cursor = last($this->data)->getID();
- $this->data = array_reverse($this->data);
+ $this->getPageSize());
+ if ($results) {
+ $this->cursor = last($results)->getID();
}
+ return $results;
}
}

File Metadata

Mime Type
text/x-diff
Expires
Mon, Jul 28, 5:43 PM (1 w, 3 d ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
187237
Default Alt Text
(2 KB)

Event Timeline

styx copyright 2020 sirocyl / ellie (kymkdd) / ncommander / styx contributors
Use of other names and brands is not intended to reflect a claim of, or right to, use the name or brand.
styx is an operating system using the Linux kernel and components, and "styx Linux" as a phrase does not reflect the inclusion of the Linux brand or trademark in the styx project.
Linux® is the registered trademark of Linus Torvalds in the U.S. and other countries.
Terms and Conditions (TODO: fix this!)