Page MenuHomestyx hydra
Files F1235

No OneTemporary
Actions

View Options

diff --git a/src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php b/src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php
index ab13c6a571..418acf476e 100644
--- a/src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php
+++ b/src/applications/repository/xaction/PhabricatorRepositoryCallsignTransaction.php
@@ -1,90 +1,90 @@
<?php
final class PhabricatorRepositoryCallsignTransaction
extends PhabricatorRepositoryTransactionType {
const TRANSACTIONTYPE = 'repo:callsign';
public function generateOldValue($object) {
return $object->getCallsign();
}
public function generateNewValue($object, $value) {
if (strlen($value)) {
return $value;
}
return null;
}
public function applyInternalEffects($object, $value) {
$object->setCallsign($value);
}
public function getTitle() {
$old = $this->getOldValue();
$new = $this->getNewValue();
- if (!strlen($old)) {
+ if ($old === null) {
return pht(
'%s set the callsign for this repository to %s.',
$this->renderAuthor(),
$this->renderNewValue());
- } else if (!strlen($new)) {
+ } else if ($new === null) {
return pht(
'%s removed the callsign (%s) for this repository.',
$this->renderAuthor(),
$this->renderOldValue());
} else {
return pht(
'%s changed the callsign for this repository from %s to %s.',
$this->renderAuthor(),
$this->renderOldValue(),
$this->renderNewValue());
}
}
public function validateTransactions($object, array $xactions) {
$errors = array();
foreach ($xactions as $xaction) {
$old = $xaction->getOldValue();
$new = $xaction->getNewValue();
if (!strlen($new)) {
continue;
}
if ($new === $old) {
continue;
}
try {
PhabricatorRepository::assertValidCallsign($new);
} catch (Exception $ex) {
$errors[] = $this->newInvalidError(
$ex->getMessage(),
$xaction);
continue;
}
$other = id(new PhabricatorRepositoryQuery())
->setViewer(PhabricatorUser::getOmnipotentUser())
->withCallsigns(array($new))
->executeOne();
if ($other && ($other->getID() !== $object->getID())) {
$errors[] = $this->newError(
pht('Duplicate'),
pht(
'The selected callsign ("%s") is already in use by another '.
'repository. Choose a unique callsign.',
$new),
$xaction);
continue;
}
}
return $errors;
}
}

File Metadata

Mime Type
text/x-diff
Expires
Sun, Nov 24, 1:06 PM (1 d, 12 h)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
1019
Default Alt Text
(2 KB)

Event Timeline

styx copyright 2020 sirocyl / ellie (kymkdd) / ncommander / styx contributors
Use of other names and brands is not intended to reflect a claim of, or right to, use the name or brand.
styx is an operating system using the Linux kernel and components, and "styx Linux" as a phrase does not reflect the inclusion of the Linux brand or trademark in the styx project.
Linux® is the registered trademark of Linus Torvalds in the U.S. and other countries.
Terms and Conditions (TODO: fix this!)