Page MenuHomestyx hydra

No OneTemporary

diff --git a/src/applications/differential/mail/DifferentialCCWelcomeMail.php b/src/applications/differential/mail/DifferentialCCWelcomeMail.php
index 2dd66816de..004822177a 100644
--- a/src/applications/differential/mail/DifferentialCCWelcomeMail.php
+++ b/src/applications/differential/mail/DifferentialCCWelcomeMail.php
@@ -1,37 +1,38 @@
<?php
/*
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
final class DifferentialCCWelcomeMail extends DifferentialReviewRequestMail {
protected function renderVarySubject() {
return '[Added to CC] '.$this->renderSubject();
}
protected function renderBody() {
$actor = $this->getActorName();
$name = $this->getRevision()->getTitle();
$body = array();
$body[] = "{$actor} added you to the CC list for the revision \"{$name}\".";
+ $body[] = null;
$body[] = $this->renderReviewRequestBody();
return implode("\n", $body);
}
}
diff --git a/src/applications/differential/mail/DifferentialNewDiffMail.php b/src/applications/differential/mail/DifferentialNewDiffMail.php
index cee44b1ff2..06cd6e45b8 100644
--- a/src/applications/differential/mail/DifferentialNewDiffMail.php
+++ b/src/applications/differential/mail/DifferentialNewDiffMail.php
@@ -1,52 +1,53 @@
<?php
/*
* Copyright 2012 Facebook, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
final class DifferentialNewDiffMail extends DifferentialReviewRequestMail {
protected function renderVarySubject() {
$revision = $this->getRevision();
$line_count = $revision->getLineCount();
$lines = ($line_count == 1 ? "1 line" : "{$line_count} lines");
if ($this->isFirstMailToRecipients()) {
$verb = 'Request';
} else {
$verb = 'Updated';
}
return "[{$verb}, {$lines}] ".$this->renderSubject();
}
protected function renderBody() {
$actor = $this->getActorName();
$name = $this->getRevision()->getTitle();
$body = array();
if ($this->isFirstMailToRecipients()) {
$body[] = "{$actor} requested code review of \"{$name}\".";
} else {
$body[] = "{$actor} updated the revision \"{$name}\".";
}
+ $body[] = null;
$body[] = $this->renderReviewRequestBody();
return implode("\n", $body);
}
}

File Metadata

Mime Type
text/x-diff
Expires
Thu, Jul 24, 3:29 AM (1 d, 12 h)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
182502
Default Alt Text
(3 KB)

Event Timeline