Page MenuHomestyx hydra
Files F128713

No OneTemporary
Actions

View Options

diff --git a/support/startup/PhabricatorClientRateLimit.php b/support/startup/PhabricatorClientRateLimit.php
index 85a6def878..89a273e3bf 100644
--- a/support/startup/PhabricatorClientRateLimit.php
+++ b/support/startup/PhabricatorClientRateLimit.php
@@ -1,58 +1,66 @@
<?php
final class PhabricatorClientRateLimit
extends PhabricatorClientLimit {
protected function getBucketDuration() {
return 60;
}
protected function getBucketCount() {
return 5;
}
protected function shouldRejectConnection($score) {
$limit = $this->getLimit();
// Reject connections if the average score across all buckets exceeds the
// limit.
$average_score = $score / $this->getBucketCount();
return ($average_score > $limit);
}
protected function getConnectScore() {
return 0;
}
protected function getPenaltyScore() {
return 1;
}
protected function getDisconnectScore(array $request_state) {
$score = 1;
// If the user was logged in, let them make more requests.
if (isset($request_state['viewer'])) {
$viewer = $request_state['viewer'];
- if ($viewer->isLoggedIn()) {
+ if ($viewer->isOmnipotent()) {
+ // If the viewer was omnipotent, this was an intracluster request or
+ // some other kind of special request, so don't give it any points
+ // toward rate limiting.
+ $score = 0;
+ } else if ($viewer->isLoggedIn()) {
+ // If the viewer was logged in, give them fewer points than if they
+ // were logged out, since this traffic is much more likely to be
+ // legitimate.
$score = 0.25;
}
}
return $score;
}
protected function getRateLimitReason($score) {
$client_key = $this->getClientKey();
// NOTE: This happens before we load libraries, so we can not use pht()
// here.
return
"TOO MANY REQUESTS\n".
"You (\"{$client_key}\") are issuing too many requests ".
"too quickly.\n";
}
}

File Metadata

Mime Type
text/x-diff
Expires
Thu, May 1, 2:41 PM (1 d, 20 h)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
109016
Default Alt Text
(1 KB)

Event Timeline

styx copyright 2020 sirocyl / ellie (kymkdd) / ncommander / styx contributors
Use of other names and brands is not intended to reflect a claim of, or right to, use the name or brand.
styx is an operating system using the Linux kernel and components, and "styx Linux" as a phrase does not reflect the inclusion of the Linux brand or trademark in the styx project.
Linux® is the registered trademark of Linus Torvalds in the U.S. and other countries.
Terms and Conditions (TODO: fix this!)