Page MenuHomestyx hydra
Files F233474

No OneTemporary
Actions

View Options

diff --git a/src/applications/people/controller/PhabricatorPeopleRenameController.php b/src/applications/people/controller/PhabricatorPeopleRenameController.php
index 42eebfc8ae..9f0c2b21a8 100644
--- a/src/applications/people/controller/PhabricatorPeopleRenameController.php
+++ b/src/applications/people/controller/PhabricatorPeopleRenameController.php
@@ -1,97 +1,91 @@
<?php
final class PhabricatorPeopleRenameController
extends PhabricatorPeopleController {
public function handleRequest(AphrontRequest $request) {
$viewer = $this->getViewer();
$id = $request->getURIData('id');
$user = id(new PhabricatorPeopleQuery())
->setViewer($viewer)
->withIDs(array($id))
->executeOne();
if (!$user) {
return new Aphront404Response();
}
$done_uri = $this->getApplicationURI("manage/{$id}/");
$validation_exception = null;
$username = $user->getUsername();
if ($request->isFormOrHisecPost()) {
$username = $request->getStr('username');
$xactions = array();
$xactions[] = id(new PhabricatorUserTransaction())
->setTransactionType(
PhabricatorUserUsernameTransaction::TRANSACTIONTYPE)
->setNewValue($username);
$editor = id(new PhabricatorUserTransactionEditor())
->setActor($viewer)
->setContentSourceFromRequest($request)
->setCancelURI($done_uri)
->setContinueOnMissingFields(true);
try {
$editor->applyTransactions($user, $xactions);
return id(new AphrontRedirectResponse())->setURI($done_uri);
} catch (PhabricatorApplicationTransactionValidationException $ex) {
$validation_exception = $ex;
}
}
- $inst1 = pht(
- 'Be careful when renaming users!');
-
- $inst2 = pht(
- 'The old username will no longer be tied to the user, so anything '.
- 'which uses it (like old commit messages) will no longer associate '.
- 'correctly. (And, if you give a user a username which some other user '.
- 'used to have, username lookups will begin returning the wrong user.)');
-
- $inst3 = pht(
- 'It is generally safe to rename newly created users (and test users '.
- 'and so on), but less safe to rename established users and unsafe to '.
- 'reissue a username.');
-
- $inst4 = pht(
- 'Users who rely on password authentication will need to reset their '.
- 'password after their username is changed (their username is part of '.
- 'the salt in the password hash).');
-
- $inst5 = pht(
+ $instructions = array();
+
+ $instructions[] = pht(
+ 'If you rename this user, the old username will no longer be tied '.
+ 'to the user account. Anything which uses the old username in raw '.
+ 'text (like old commit messages) may no longer associate correctly.');
+
+ $instructions[] = pht(
+ 'It is generally safe to rename users, but changing usernames may '.
+ 'create occasional minor complications or confusion with text that '.
+ 'contains the old username.');
+
+ $instructions[] = pht(
'The user will receive an email notifying them that you changed their '.
- 'username, with instructions for logging in and resetting their '.
- 'password if necessary.');
+ 'username.');
+
+ $instructions[] = null;
$form = id(new AphrontFormView())
- ->setUser($viewer)
->appendChild(
id(new AphrontFormStaticControl())
->setLabel(pht('Old Username'))
->setValue($user->getUsername()))
->appendChild(
id(new AphrontFormTextControl())
->setLabel(pht('New Username'))
->setValue($username)
->setName('username'));
- return $this->newDialog()
- ->setWidth(AphrontDialogView::WIDTH_FORM)
+ $dialog = $this->newDialog()
->setTitle(pht('Change Username'))
- ->setValidationException($validation_exception)
- ->appendParagraph($inst1)
- ->appendParagraph($inst2)
- ->appendParagraph($inst3)
- ->appendParagraph($inst4)
- ->appendParagraph($inst5)
- ->appendParagraph(null)
+ ->setValidationException($validation_exception);
+
+ foreach ($instructions as $instruction) {
+ $dialog->appendParagraph($instruction);
+ }
+
+ $dialog
->appendForm($form)
->addSubmitButton(pht('Rename User'))
->addCancelButton($done_uri);
+
+ return $dialog;
}
}

File Metadata

Mime Type
text/x-diff
Expires
Mon, Jul 28, 6:42 AM (1 w, 20 h ago)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
186483
Default Alt Text
(4 KB)

Event Timeline

styx copyright 2020 sirocyl / ellie (kymkdd) / ncommander / styx contributors
Use of other names and brands is not intended to reflect a claim of, or right to, use the name or brand.
styx is an operating system using the Linux kernel and components, and "styx Linux" as a phrase does not reflect the inclusion of the Linux brand or trademark in the styx project.
Linux® is the registered trademark of Linus Torvalds in the U.S. and other countries.
Terms and Conditions (TODO: fix this!)