Page MenuHomestyx hydra
Files F1456142

No OneTemporary
Actions

View Options

diff --git a/src/applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php b/src/applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php
index af57c4a186..19a0a483c1 100644
--- a/src/applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php
+++ b/src/applications/differential/field/specification/DifferentialDependsOnFieldSpecification.php
@@ -1,57 +1,57 @@
<?php
final class DifferentialDependsOnFieldSpecification
extends DifferentialFieldSpecification {
public function shouldAppearOnRevisionView() {
return true;
}
public function getRequiredHandlePHIDsForRevisionView() {
return $this->getDependentRevisionPHIDs();
}
public function renderLabelForRevisionView() {
return 'Depends On:';
}
public function renderValueForRevisionView() {
$revision_phids = $this->getDependentRevisionPHIDs();
if (!$revision_phids) {
return null;
}
$links = array();
- foreach ($revision_phids as $revision_phids) {
- $links[] = $this->getHandle($revision_phids)->renderLink();
+ foreach ($revision_phids as $revision_phid) {
+ $links[] = $this->getHandle($revision_phid)->renderLink();
}
return phutil_implode_html(phutil_tag('br'), $links);
}
private function getDependentRevisionPHIDs() {
return PhabricatorEdgeQuery::loadDestinationPHIDs(
$this->getRevision()->getPHID(),
PhabricatorEdgeConfig::TYPE_DREV_DEPENDS_ON_DREV);
}
public function shouldAppearOnConduitView() {
return true;
}
public function getValueForConduit() {
return $this->getDependentRevisionPHIDs();
}
public function getKeyForConduit() {
return 'phabricator:depends-on';
}
public function getCommitMessageTips() {
return array(
'Use "Depends on D123" in your summary to mark '.
'a dependency between revisions.'
);
}
}

File Metadata

Mime Type
text/x-diff
Expires
Sat, Nov 15, 12:20 AM (16 h, 19 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
337369
Default Alt Text
(1 KB)

Event Timeline

styx copyright 2020 sirocyl / ellie (kymkdd) / ncommander / styx contributors
Use of other names and brands is not intended to reflect a claim of, or right to, use the name or brand.
styx is an operating system using the Linux kernel and components, and "styx Linux" as a phrase does not reflect the inclusion of the Linux brand or trademark in the styx project.
Linux® is the registered trademark of Linus Torvalds in the U.S. and other countries.
Terms and Conditions (TODO: fix this!)